114968 2013-04-22 10:48:57 -0700 [32-bit] JavaScriptCore JIT build is broken for 32-bit arch since r148893 2013-04-22 11:40:42 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance mark.lam ggaren mark.lam oliver oldest_to_newest 879246 0 jbriance 2013-04-22 10:48:57 -0700 JavaScriptCore JIT build is broken for sh4 arch since r148893 See: http://build.webkit.org/builders/Qt%20Linux%20SH4%20Release/builds/24734 sh4-linux-g++ --sysroot=/opt/STM/STLinux-2.4/devkit/sh4/target -Wl,-O1 -Wl,-rpath,/local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/WebKitBuild/Release/lib -Wl,-rpath,/lib -o ../../bin/jsc .obj/release-shared/jsc.o -Wl,-whole-archive -lJavaScriptCore -Wl,-no-whole-archive -L/local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/WebKitBuild/Release/Source/JavaScriptCore/release -Wl,-whole-archive -lWTF -Wl,-no-whole-archive -L/local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/WebKitBuild/Release/Source/WTF/release -licui18n -licuuc -licudata -L/local/wkit/build/qt5-5.0.0/qtbase/lib -lQt5Core -lpthread -lpthread /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/WebKitBuild/Release/Source/JavaScriptCore/release/libJavaScriptCore.a(JIT.o): In function `JSC::JIT::privateCompileSlowCases()': JIT.cpp:(.text+0x2100): undefined reference to `JSC::JIT::emitSlow_op_loop_hint(JSC::Instruction*, JSC::SlowCaseEntry*&)' /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/WebKitBuild/Release/Source/JavaScriptCore/release/libJavaScriptCore.a(JIT.o): In function `JSC::JIT::privateCompileMainPass()': JIT.cpp:(.text+0x2b74): undefined reference to `JSC::JIT::emit_op_loop_hint(JSC::Instruction*)' collect2: ld returned 1 exit status make[3]: *** [../../bin/jsc] Error 1 make[3]: Leaving directory `/local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/WebKitBuild/Release/Source/JavaScriptCore' make[2]: *** [sub-jsc-pro-make_first-ordered] Error 2 879257 1 jbriance 2013-04-22 10:59:48 -0700 The JIT::emit_op_loop_hint and JIT::emitSlow_op_loop_hint are implemented inside #if USE(JSVALUE64). Is this really needed ? Can I move them outside ? Once moved out, there is also one missing implementation in MacroAssemblerSH4.h of branchAdd32: Jump branchAdd32(ResultCondition cond, TrustedImm32 imm, AbsoluteAddress dest) I'll submit a patch soon, 879283 2 mark.lam 2013-04-22 11:30:54 -0700 From what I can tell, apart from the 32-bit build issue, the SH4 branchAdd32 is not missing an implementation. However, their asserts for acceptable ResultConditions need to be updated, which I will do with this patch as well. 879289 3 199054 mark.lam 2013-04-22 11:37:09 -0700 Created attachment 199054 the fix 879295 4 mark.lam 2013-04-22 11:40:42 -0700 Fix landed in r148899: <http://trac.webkit.org/changeset/148899>. 199054 2013-04-22 11:37:09 -0700 2013-04-22 11:37:09 -0700 the fix bug-114968.patch text/plain 6667 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ4ODk4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDEzLTA0LTIyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBG aXggYnJva2VuIDMyLWJpdCBidWlsZCB0byBncmVlbiB0aGUgYm90cy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDk2OC4KKworICAgICAgICBVbnJl dmlld2VkLgorCisgICAgICAgIEJhc2ljYWxseSwgSSBtb3ZlZCBhIEpJVDo6ZW1pdF9vcF9sb29w X2hpbnQoKSBhbmQgSklUOjplbWl0U2xvd19vcF9sb29wX2hpbnQoKQorICAgICAgICBpbnRvIGNv bW1vbiBjb2RlIHdoZXJlIHRoZXkgYmVsb25nLCBpbnN0ZWFkIG9mIHRoZSA2NC1iaXQgc3BlY2lm aWMgc2VjdGlvbi4KKworICAgICAgICBBbHNvIGZpeGVkIHNvbWUgU0g0IGFzc2VydGlvbnMgZmFp bHVyZXMgY2F1c2VkIGJ5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTQ5NjMuIFRoYW5rcyB0byBKdWxpZW4gQnJpYW5jZWF1CisgICAgICAgIGZvciBw b2ludGluZyB0aGlzIG91dC4KKworICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclNI NC5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlclNINDo6YnJhbmNoQWRkMzIpOgorICAg ICAgICAqIGppdC9KSVRPcGNvZGVzLmNwcDoKKyAgICAgICAgKEpTQyk6CisgICAgICAgIChKU0M6 OkpJVDo6ZW1pdF9vcF9sb29wX2hpbnQpOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRTbG93X29w X2xvb3BfaGludCk6CisKIDIwMTMtMDQtMjIgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNv bT4KIAogICAgICAgICBQZXJmb3JtIG51bGwgY2hlY2sgYmVmb3JlIHRyeWluZyB0byB1c2UgdGhl IHJlc3VsdCBvZiByZWFkbGluZSgpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1i bGVyL01hY3JvQXNzZW1ibGVyU0g0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclNINC5oCShyZXZpc2lvbiAxNDg4OTMpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyU0g0LmgJKHdvcmtp bmcgY29weSkKQEAgLTE5MDcsNyArMTkwNyw3IEBAIHZvaWQgb3IzMihUcnVzdGVkSW1tMzIgaW1t LCBSZWdpc3RlcklEIHMKIAogICAgIEp1bXAgYnJhbmNoQWRkMzIoUmVzdWx0Q29uZGl0aW9uIGNv bmQsIFJlZ2lzdGVySUQgc3JjLCBSZWdpc3RlcklEIGRlc3QpCiAgICAgewotICAgICAgICBBU1NF UlQoKGNvbmQgPT0gT3ZlcmZsb3cpIHx8IChjb25kID09IFNpZ25lZCkgfHwgKGNvbmQgPT0gWmVy bykgfHwgKGNvbmQgPT0gTm9uWmVybykpOworICAgICAgICBBU1NFUlQoKGNvbmQgPT0gT3ZlcmZs b3cpIHx8IChjb25kID09IFNpZ25lZCkgfHwgKGNvbmQgPT0gUG9zaXRpdmVPclplcm8pIHx8IChj b25kID09IFplcm8pIHx8IChjb25kID09IE5vblplcm8pKTsKIAogICAgICAgICBpZiAoY29uZCA9 PSBPdmVyZmxvdykgewogICAgICAgICAgICAgbV9hc3NlbWJsZXIuYWRkdmxSZWdSZWcoc3JjLCBk ZXN0KTsKQEAgLTE5MzcsNyArMTkzNyw3IEBAIHZvaWQgb3IzMihUcnVzdGVkSW1tMzIgaW1tLCBS ZWdpc3RlcklEIHMKIAogICAgIEp1bXAgYnJhbmNoQWRkMzIoUmVzdWx0Q29uZGl0aW9uIGNvbmQs IFRydXN0ZWRJbW0zMiBpbW0sIFJlZ2lzdGVySUQgZGVzdCkKICAgICB7Ci0gICAgICAgIEFTU0VS VCgoY29uZCA9PSBPdmVyZmxvdykgfHwgKGNvbmQgPT0gU2lnbmVkKSB8fCAoY29uZCA9PSBaZXJv KSB8fCAoY29uZCA9PSBOb25aZXJvKSk7CisgICAgICAgIEFTU0VSVCgoY29uZCA9PSBPdmVyZmxv dykgfHwgKGNvbmQgPT0gU2lnbmVkKSB8fCAoY29uZCA9PSBQb3NpdGl2ZU9yWmVybykgfHwgKGNv bmQgPT0gWmVybykgfHwgKGNvbmQgPT0gTm9uWmVybykpOwogCiAgICAgICAgIG1vdmUoaW1tLCBz Y3JhdGNoUmVnMyk7CiAgICAgICAgIHJldHVybiBicmFuY2hBZGQzMihjb25kLCBzY3JhdGNoUmVn MywgZGVzdCk7CkBAIC0xOTQ1LDcgKzE5NDUsNyBAQCB2b2lkIG9yMzIoVHJ1c3RlZEltbTMyIGlt bSwgUmVnaXN0ZXJJRCBzCiAKICAgICBKdW1wIGJyYW5jaEFkZDMyKFJlc3VsdENvbmRpdGlvbiBj b25kLCBSZWdpc3RlcklEIHNyYywgVHJ1c3RlZEltbTMyIGltbSwgUmVnaXN0ZXJJRCBkZXN0KQog ICAgIHsKLSAgICAgICAgQVNTRVJUKChjb25kID09IE92ZXJmbG93KSB8fCAoY29uZCA9PSBTaWdu ZWQpIHx8IChjb25kID09IFplcm8pIHx8IChjb25kID09IE5vblplcm8pKTsKKyAgICAgICAgQVNT RVJUKChjb25kID09IE92ZXJmbG93KSB8fCAoY29uZCA9PSBTaWduZWQpIHx8IChjb25kID09IFBv c2l0aXZlT3JaZXJvKSB8fCAoY29uZCA9PSBaZXJvKSB8fCAoY29uZCA9PSBOb25aZXJvKSk7CiAK ICAgICAgICAgaWYgKHNyYyAhPSBkZXN0KQogICAgICAgICAgICAgbW92ZShzcmMsIGRlc3QpOwpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGNvZGVzLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wY29kZXMuY3BwCShyZXZpc2lvbiAx NDg4OTMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wY29kZXMuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC00ODEsNTIgKzQ4MSw2IEBAIHZvaWQgSklUOjplbWl0X29wX2p0cnVlKElu c3RydWN0aW9uKiBjdXIKICAgICBpc1plcm8ubGluayh0aGlzKTsKIH0KIAotdm9pZCBKSVQ6OmVt aXRfb3BfbG9vcF9oaW50KEluc3RydWN0aW9uKikKLXsKLSAgICAvLyBFbWl0IHRoZSB3YXRjaGRv ZyB0aW1lciBjaGVjazoKLSAgICBpZiAobV92bS0+d2F0Y2hkb2cuaXNFbmFibGVkKCkpCi0gICAg ICAgIGFkZFNsb3dDYXNlKGJyYW5jaFRlc3Q4KE5vblplcm8sIEFic29sdXRlQWRkcmVzcyhtX3Zt LT53YXRjaGRvZy50aW1lckRpZEZpcmVBZGRyZXNzKCkpKSk7Ci0KLSAgICAvLyBFbWl0IHRoZSBK SVQgb3B0aW1pemF0aW9uIGNoZWNrOiAKLSAgICBpZiAoY2FuQmVPcHRpbWl6ZWQoKSkKLSAgICAg ICAgYWRkU2xvd0Nhc2UoYnJhbmNoQWRkMzIoUG9zaXRpdmVPclplcm8sIFRydXN0ZWRJbW0zMihP cHRpb25zOjpleGVjdXRpb25Db3VudGVySW5jcmVtZW50Rm9yTG9vcCgpKSwKLSAgICAgICAgICAg IEFic29sdXRlQWRkcmVzcyhtX2NvZGVCbG9jay0+YWRkcmVzc09mSklURXhlY3V0ZUNvdW50ZXIo KSkpKTsKLX0KLQotdm9pZCBKSVQ6OmVtaXRTbG93X29wX2xvb3BfaGludChJbnN0cnVjdGlvbios IFZlY3RvcjxTbG93Q2FzZUVudHJ5Pjo6aXRlcmF0b3ImIGl0ZXIpCi17Ci0gICAgLy8gRW1pdCB0 aGUgc2xvdyBwYXRoIG9mIHRoZSB3YXRjaGRvZyB0aW1lciBjaGVjazoKLSAgICBpZiAobV92bS0+ d2F0Y2hkb2cuaXNFbmFibGVkKCkpIHsKLSAgICAgICAgbGlua1Nsb3dDYXNlKGl0ZXIpOwotCi0g ICAgICAgIEpJVFN0dWJDYWxsIHN0dWJDYWxsKHRoaXMsIGN0aV9oYW5kbGVfd2F0Y2hkb2dfdGlt ZXIpOwotICAgICAgICBzdHViQ2FsbC5jYWxsKCk7Ci0KLSNpZiBFTkFCTEUoREZHX0pJVCkKLSAg ICAgICAgaWYgKGNhbkJlT3B0aW1pemVkKCkpIHsKLSAgICAgICAgICAgIEp1bXAgZG9PcHRpbWl6 ZSA9IGJyYW5jaEFkZDMyKFBvc2l0aXZlT3JaZXJvLCBUcnVzdGVkSW1tMzIoT3B0aW9uczo6ZXhl Y3V0aW9uQ291bnRlckluY3JlbWVudEZvckxvb3AoKSksCi0gICAgICAgICAgICAgICAgQWJzb2x1 dGVBZGRyZXNzKG1fY29kZUJsb2NrLT5hZGRyZXNzT2ZKSVRFeGVjdXRlQ291bnRlcigpKSk7Ci0g ICAgICAgICAgICBlbWl0SnVtcFNsb3dUb0hvdChqdW1wKCksIE9QQ09ERV9MRU5HVEgob3BfbG9v cF9oaW50KSk7Ci0gICAgICAgICAgICBkb09wdGltaXplLmxpbmsodGhpcyk7Ci0gICAgICAgIH0g ZWxzZQotI2VuZGlmCi0gICAgICAgICAgICBlbWl0SnVtcFNsb3dUb0hvdChqdW1wKCksIE9QQ09E RV9MRU5HVEgob3BfbG9vcF9oaW50KSk7Ci0gICAgfQotCi0jaWYgRU5BQkxFKERGR19KSVQpCi0g ICAgLy8gRW1pdCB0aGUgc2xvdyBwYXRoIGZvciB0aGUgSklUIG9wdGltaXphdGlvbiBjaGVjazoK LSAgICBpZiAoY2FuQmVPcHRpbWl6ZWQoKSkgewotICAgICAgICBsaW5rU2xvd0Nhc2UoaXRlcik7 Ci0KLSAgICAgICAgSklUU3R1YkNhbGwgc3R1YkNhbGwodGhpcywgY3RpX29wdGltaXplKTsKLSAg ICAgICAgc3R1YkNhbGwuYWRkQXJndW1lbnQoVHJ1c3RlZEltbTMyKG1fYnl0ZWNvZGVPZmZzZXQp KTsKLSAgICAgICAgc3R1YkNhbGwuY2FsbCgpOwotCi0gICAgICAgIGVtaXRKdW1wU2xvd1RvSG90 KGp1bXAoKSwgT1BDT0RFX0xFTkdUSChvcF9sb29wX2hpbnQpKTsKLSAgICB9Ci0jZW5kaWYKLX0K LQogdm9pZCBKSVQ6OmVtaXRfb3BfbmVxKEluc3RydWN0aW9uKiBjdXJyZW50SW5zdHJ1Y3Rpb24p CiB7CiAgICAgZW1pdEdldFZpcnR1YWxSZWdpc3RlcnMoY3VycmVudEluc3RydWN0aW9uWzJdLnUu b3BlcmFuZCwgcmVnVDAsIGN1cnJlbnRJbnN0cnVjdGlvblszXS51Lm9wZXJhbmQsIHJlZ1QxKTsK QEAgLTEzMjMsNiArMTI3Nyw1MiBAQCB2b2lkIEpJVDo6ZW1pdF9vcF9wdXRfdG9fYmFzZShJbnN0 cnVjdGlvCiAKICNlbmRpZiAvLyBVU0UoSlNWQUxVRTY0KQogCit2b2lkIEpJVDo6ZW1pdF9vcF9s b29wX2hpbnQoSW5zdHJ1Y3Rpb24qKQoreworICAgIC8vIEVtaXQgdGhlIHdhdGNoZG9nIHRpbWVy IGNoZWNrOgorICAgIGlmIChtX3ZtLT53YXRjaGRvZy5pc0VuYWJsZWQoKSkKKyAgICAgICAgYWRk U2xvd0Nhc2UoYnJhbmNoVGVzdDgoTm9uWmVybywgQWJzb2x1dGVBZGRyZXNzKG1fdm0tPndhdGNo ZG9nLnRpbWVyRGlkRmlyZUFkZHJlc3MoKSkpKTsKKworICAgIC8vIEVtaXQgdGhlIEpJVCBvcHRp bWl6YXRpb24gY2hlY2s6IAorICAgIGlmIChjYW5CZU9wdGltaXplZCgpKQorICAgICAgICBhZGRT bG93Q2FzZShicmFuY2hBZGQzMihQb3NpdGl2ZU9yWmVybywgVHJ1c3RlZEltbTMyKE9wdGlvbnM6 OmV4ZWN1dGlvbkNvdW50ZXJJbmNyZW1lbnRGb3JMb29wKCkpLAorICAgICAgICAgICAgQWJzb2x1 dGVBZGRyZXNzKG1fY29kZUJsb2NrLT5hZGRyZXNzT2ZKSVRFeGVjdXRlQ291bnRlcigpKSkpOwor fQorCit2b2lkIEpJVDo6ZW1pdFNsb3dfb3BfbG9vcF9oaW50KEluc3RydWN0aW9uKiwgVmVjdG9y PFNsb3dDYXNlRW50cnk+OjppdGVyYXRvciYgaXRlcikKK3sKKyAgICAvLyBFbWl0IHRoZSBzbG93 IHBhdGggb2YgdGhlIHdhdGNoZG9nIHRpbWVyIGNoZWNrOgorICAgIGlmIChtX3ZtLT53YXRjaGRv Zy5pc0VuYWJsZWQoKSkgeworICAgICAgICBsaW5rU2xvd0Nhc2UoaXRlcik7CisKKyAgICAgICAg SklUU3R1YkNhbGwgc3R1YkNhbGwodGhpcywgY3RpX2hhbmRsZV93YXRjaGRvZ190aW1lcik7Cisg ICAgICAgIHN0dWJDYWxsLmNhbGwoKTsKKworI2lmIEVOQUJMRShERkdfSklUKQorICAgICAgICBp ZiAoY2FuQmVPcHRpbWl6ZWQoKSkgeworICAgICAgICAgICAgSnVtcCBkb09wdGltaXplID0gYnJh bmNoQWRkMzIoUG9zaXRpdmVPclplcm8sIFRydXN0ZWRJbW0zMihPcHRpb25zOjpleGVjdXRpb25D b3VudGVySW5jcmVtZW50Rm9yTG9vcCgpKSwKKyAgICAgICAgICAgICAgICBBYnNvbHV0ZUFkZHJl c3MobV9jb2RlQmxvY2stPmFkZHJlc3NPZkpJVEV4ZWN1dGVDb3VudGVyKCkpKTsKKyAgICAgICAg ICAgIGVtaXRKdW1wU2xvd1RvSG90KGp1bXAoKSwgT1BDT0RFX0xFTkdUSChvcF9sb29wX2hpbnQp KTsKKyAgICAgICAgICAgIGRvT3B0aW1pemUubGluayh0aGlzKTsKKyAgICAgICAgfSBlbHNlCisj ZW5kaWYKKyAgICAgICAgICAgIGVtaXRKdW1wU2xvd1RvSG90KGp1bXAoKSwgT1BDT0RFX0xFTkdU SChvcF9sb29wX2hpbnQpKTsKKyAgICB9CisKKyNpZiBFTkFCTEUoREZHX0pJVCkKKyAgICAvLyBF bWl0IHRoZSBzbG93IHBhdGggZm9yIHRoZSBKSVQgb3B0aW1pemF0aW9uIGNoZWNrOgorICAgIGlm IChjYW5CZU9wdGltaXplZCgpKSB7CisgICAgICAgIGxpbmtTbG93Q2FzZShpdGVyKTsKKworICAg ICAgICBKSVRTdHViQ2FsbCBzdHViQ2FsbCh0aGlzLCBjdGlfb3B0aW1pemUpOworICAgICAgICBz dHViQ2FsbC5hZGRBcmd1bWVudChUcnVzdGVkSW1tMzIobV9ieXRlY29kZU9mZnNldCkpOworICAg ICAgICBzdHViQ2FsbC5jYWxsKCk7CisKKyAgICAgICAgZW1pdEp1bXBTbG93VG9Ib3QoanVtcCgp LCBPUENPREVfTEVOR1RIKG9wX2xvb3BfaGludCkpOworICAgIH0KKyNlbmRpZgorfQorCiB2b2lk IEpJVDo6ZW1pdF9yZXNvbHZlX29wZXJhdGlvbnMoUmVzb2x2ZU9wZXJhdGlvbnMqIHJlc29sdmVP cGVyYXRpb25zLCBjb25zdCBpbnQqIGJhc2VWUiwgY29uc3QgaW50KiB2YWx1ZVZSKQogewogCg==