114962 2013-04-22 09:06:05 -0700 Cancelling load may cause deadlock in -[AVPlayerItem release] 2013-04-22 13:02:06 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble eric.carlson oldest_to_newest 879194 0 jer.noble 2013-04-22 09:06:05 -0700 Cancelling load may cause deadlock in -[AVPlayerItem release] 879278 1 199051 jer.noble 2013-04-22 11:26:29 -0700 Created attachment 199051 Patch 879296 2 199051 eric.carlson 2013-04-22 11:42:11 -0700 Comment on attachment 199051 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199051&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1627 > + if (!m_callback->shouldWaitForLoadingOfResource(loadingRequest)) This should check to make sure m_callback is not NULL. 879379 3 jer.noble 2013-04-22 12:17:26 -0700 <rdar://problem/13706310> 879395 4 jer.noble 2013-04-22 13:02:06 -0700 Committed r148906: <http://trac.webkit.org/changeset/148906> 199051 2013-04-22 11:26:29 -0700 2013-04-22 11:42:11 -0700 Patch bug-114962-20130422112554.patch text/plain 3365 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NzgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmQ1ZjliMGYwZjg3ZTc1 ZmUwYjg5NTU0ZDgxODIxNWYwYTZmNzhlMy4uMjIwMWJhNjNkODdmMGQ4OGE2NWNlODhmMmQwZTNh NDgxNWVkOWIwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA0LTIyICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIENhbmNlbGxpbmcgbG9hZCBt YXkgY2F1c2UgZGVhZGxvY2sgaW4gLVtBVlBsYXllckl0ZW0gcmVsZWFzZV0KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDk2MgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdvcmsgYXJvdW5kIGEgYnVnIGlu IEFWQXNzZXRSZXNvdXJjZUxvYWRlciBieSB1c2luZyBhIGdlbmVyaWMsIG5vbi1tYWluIGRpc3Bh dGNoIHF1ZXVlCisgICAgICAgIHRvIHJlY2lldmUgQVZBc3NldFJlc291cmNlTG9hZGVyRGVsZWdh dGUgY2FsbGJhY2tzLCBhbmQgdGhlbiBtYXJzaGFsbGluZyB0aG9zZQorICAgICAgICBjYWxsYmFj a3MgdG8gdGhlIG1haW4gdGhyZWFkIGFzeW5jaHJvbm91c2x5LgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0 aW9uT2JqQy5tbToKKyAgICAgICAgKFdlYkNvcmU6Omdsb2JhbExvYWRlckRlbGVnYXRlUXVldWUp OiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlv bk9iakM6OmNyZWF0ZUFWQXNzZXRGb3JVUkwpOiBVc2UgdGhlIG5ldyBnbG9iYWwgcXVldWUuCisg ICAgICAgICgtW1dlYkNvcmVBVkZMb2FkZXJEZWxlZ2F0ZSByZXNvdXJjZUxvYWRlcjpzaG91bGRX YWl0Rm9yTG9hZGluZ09mUmVxdWVzdGVkUmVzb3VyY2U6XSk6CisgICAgICAgICAgICBNYXJzaGFs bCB0aGUgcmVxdWVzdCB0byB0aGUgbWFpbiBxdWV1ZSwgYW5kIHJldHVybiBZRVMgKHdhaXQpIGlt bWVkaWF0ZWx5LgorCiAyMDEzLTA0LTE5ICBCZWFyIFRyYXZpcyAgPGJldHJhdmlzQGFkb2JlLmNv bT4KIAogICAgICAgICBbQ1NTIEV4Y2x1c2lvbnNdIEltcGxlbWVudCBlbXB0eSBzZWdtZW50cyBm b3IgbXVsdGlwbGUtc2VnbWVudCBzaGFwZS1pbnNpZGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZh dGVBVkZvdW5kYXRpb25PYmpDLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv YXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbQpp bmRleCAwYzcwMmVlZmVkOWFkNzk4Y2M4ODQ0NWJjYjgwMGEyNWZmZmJjYTljLi44YTBhODYxZDVl NTE3NTgxNDBkMWM1YzA0NWYxMWQ4ZDQxMTJlZDcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVB VkZvdW5kYXRpb25PYmpDLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakMubW0K QEAgLTE5OSw2ICsxOTksMTcgQEAgc3RhdGljIFBsYXllclRvUHJpdmF0ZU1hcFR5cGUmIHBsYXll clRvUHJpdmF0ZU1hcCgpCiB9OwogI2VuZGlmCiAKKyNpZiBFTkFCTEUoRU5DUllQVEVEX01FRElB KSB8fCBFTkFCTEUoRU5DUllQVEVEX01FRElBX1YyKQorc3RhdGljIGRpc3BhdGNoX3F1ZXVlX3Qg Z2xvYmFsTG9hZGVyRGVsZWdhdGVRdWV1ZSgpCit7CisgICAgc3RhdGljIGRpc3BhdGNoX3F1ZXVl X3QgZ2xvYmFsUXVldWU7CisgICAgc3RhdGljIGRpc3BhdGNoX29uY2VfdCBvbmNlVG9rZW47Cisg ICAgZGlzcGF0Y2hfb25jZSgmb25jZVRva2VuLCBeeworICAgICAgICBnbG9iYWxRdWV1ZSA9IGRp c3BhdGNoX3F1ZXVlX2NyZWF0ZSgiV2ViQ29yZUFWRkxvYWRlckRlbGVnYXRlIHF1ZXVlIiwgRElT UEFUQ0hfUVVFVUVfU0VSSUFMKTsKKyAgICB9KTsKKyAgICByZXR1cm4gZ2xvYmFsUXVldWU7Cit9 CisjZW5kaWYKIAogUGFzc093blB0cjxNZWRpYVBsYXllclByaXZhdGVJbnRlcmZhY2U+IE1lZGlh UGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6OmNyZWF0ZShNZWRpYVBsYXllciogcGxheWVy KQogeyAKQEAgLTQxMSw3ICs0MjIsNyBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRh dGlvbk9iakM6OmNyZWF0ZUFWQXNzZXRGb3JVUkwoY29uc3QgU3RyaW5nJiB1cmwpCiAgICAgbV9h dkFzc2V0LmFkb3B0TlMoW1tBVlVSTEFzc2V0IGFsbG9jXSBpbml0V2l0aFVSTDpjb2NvYVVSTCBv cHRpb25zOm9wdGlvbnMuZ2V0KCldKTsKIAogI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVR VUlSRUQgPj0gMTA5MAotICAgIFtbbV9hdkFzc2V0LmdldCgpIHJlc291cmNlTG9hZGVyXSBzZXRE ZWxlZ2F0ZTptX2xvYWRlckRlbGVnYXRlLmdldCgpIHF1ZXVlOmRpc3BhdGNoX2dldF9tYWluX3F1 ZXVlKCldOworICAgIFtbbV9hdkFzc2V0LmdldCgpIHJlc291cmNlTG9hZGVyXSBzZXREZWxlZ2F0 ZTptX2xvYWRlckRlbGVnYXRlLmdldCgpIHF1ZXVlOmdsb2JhbExvYWRlckRlbGVnYXRlUXVldWUo KV07CiAjZW5kaWYKIAogICAgIG1faGF2ZUNoZWNrZWRQbGF5YWJpbGl0eSA9IGZhbHNlOwpAQCAt MTYxMiw3ICsxNjIzLDEyIEBAIE5TQXJyYXkqIGl0ZW1LVk9Qcm9wZXJ0aWVzKCkKICAgICBpZiAo IW1fY2FsbGJhY2spCiAgICAgICAgIHJldHVybiBOTzsKIAotICAgIHJldHVybiBtX2NhbGxiYWNr LT5zaG91bGRXYWl0Rm9yTG9hZGluZ09mUmVzb3VyY2UobG9hZGluZ1JlcXVlc3QpOworICAgIGRp c3BhdGNoX2FzeW5jKGRpc3BhdGNoX2dldF9tYWluX3F1ZXVlKCksIF57CisgICAgICAgIGlmICgh bV9jYWxsYmFjay0+c2hvdWxkV2FpdEZvckxvYWRpbmdPZlJlc291cmNlKGxvYWRpbmdSZXF1ZXN0 KSkKKyAgICAgICAgICAgIFtsb2FkaW5nUmVxdWVzdCBmaW5pc2hMb2FkaW5nV2l0aEVycm9yOm5p bF07CisgICAgfSk7CisKKyAgICByZXR1cm4gWUVTOwogfQogCiAtICh2b2lkKXJlc291cmNlTG9h ZGVyOihBVkFzc2V0UmVzb3VyY2VMb2FkZXIgKilyZXNvdXJjZUxvYWRlciBkaWRDYW5jZWxMb2Fk aW5nUmVxdWVzdDooQVZBc3NldFJlc291cmNlTG9hZGluZ1JlcXVlc3QgKilsb2FkaW5nUmVxdWVz dAo=