114958 2013-04-22 07:35:46 -0700 WTF::AtomicString::find() should take unsigned 'start' argument 2013-04-22 08:30:22 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 107093 1 ddkilzer ddkilzer barraclough benjamin cmarcelo commit-queue oldest_to_newest 879131 0 ddkilzer 2013-04-22 07:35:46 -0700 Fixes the following warnings with -Wshorten-64-to-32: AtomicString.h:113:76: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32] size_t find(UChar c, size_t start = 0) const { return m_string.find(c, start); } ~~~~~~~~ ^~~~~ AtomicString.h:115:35: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32] { return m_string.find(s, start, caseSentitive); } ~~~~~~~~ ^~~~~ AtomicString.h:117:35: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32] { return m_string.find(s, start, caseSentitive); } ~~~~~~~~ ^~~~~ 879133 1 199027 ddkilzer 2013-04-22 07:39:10 -0700 Created attachment 199027 Patch v1 879137 2 ddkilzer 2013-04-22 07:45:20 -0700 > WTF::AtomicString::find() should take unsigned 'start' argument Because WTF::String::find() takes an unsigned 'start' argument. 879169 3 199027 commit-queue 2013-04-22 08:30:19 -0700 Comment on attachment 199027 Patch v1 Clearing flags on attachment: 199027 Committed r148884: <http://trac.webkit.org/changeset/148884> 879170 4 commit-queue 2013-04-22 08:30:22 -0700 All reviewed patches have been landed. Closing bug. 199027 2013-04-22 07:39:10 -0700 2013-04-22 08:30:19 -0700 Patch v1 bug-114958-20130422073835.patch text/plain 2864 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGI3MjAyNGVlNGQzNjkwODdlOTYyNmE3 Mzk4YTg0ZDNmNWY5MDE2YTAuLjM4YzMzZGQ5NWM4NWVjMjRiOWU0ZmEzNTc0MDM4NjczZDExMTEx NzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTMtMDQtMjIgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KKworICAgICAgICBXVEY6OkF0b21pY1N0cmluZzo6ZmluZCgpIHNob3Vs ZCB0YWtlIHVuc2lnbmVkICdzdGFydCcgYXJndW1lbnQKKyAgICAgICAgPGh0dHA6Ly93ZWJraXQu b3JnL2IvMTE0OTU4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEZpeGVzIHRoZSBmb2xsb3dpbmcgd2FybmluZ3Mgd2l0aCAtV3Nob3J0ZW4tNjQtdG8t MzI6CisKKyAgICAgICAgICAgIEF0b21pY1N0cmluZy5oOjExMzo3NjogZXJyb3I6IGltcGxpY2l0 IGNvbnZlcnNpb24gbG9zZXMgaW50ZWdlciBwcmVjaXNpb246ICdzaXplX3QnIChha2EgJ3Vuc2ln bmVkIGxvbmcnKSB0byAndW5zaWduZWQgaW50JyBbLVdlcnJvciwtV3Nob3J0ZW4tNjQtdG8tMzJd CisgICAgICAgICAgICAgICAgc2l6ZV90IGZpbmQoVUNoYXIgYywgc2l6ZV90IHN0YXJ0ID0gMCkg Y29uc3QgeyByZXR1cm4gbV9zdHJpbmcuZmluZChjLCBzdGFydCk7IH0KKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB+ fn5+fn5+fiAgICAgICAgIF5+fn5+CisgICAgICAgICAgICBBdG9taWNTdHJpbmcuaDoxMTU6MzU6 IGVycm9yOiBpbXBsaWNpdCBjb252ZXJzaW9uIGxvc2VzIGludGVnZXIgcHJlY2lzaW9uOiAnc2l6 ZV90JyAoYWthICd1bnNpZ25lZCBsb25nJykgdG8gJ3Vuc2lnbmVkIGludCcgWy1XZXJyb3IsLVdz aG9ydGVuLTY0LXRvLTMyXQorICAgICAgICAgICAgICAgICAgICB7IHJldHVybiBtX3N0cmluZy5m aW5kKHMsIHN0YXJ0LCBjYXNlU2VudGl0aXZlKTsgfQorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB+fn5+fn5+fiAgICAgICAgIF5+fn5+CisgICAgICAgICAgICBBdG9taWNTdHJpbmcuaDox MTc6MzU6IGVycm9yOiBpbXBsaWNpdCBjb252ZXJzaW9uIGxvc2VzIGludGVnZXIgcHJlY2lzaW9u OiAnc2l6ZV90JyAoYWthICd1bnNpZ25lZCBsb25nJykgdG8gJ3Vuc2lnbmVkIGludCcgWy1XZXJy b3IsLVdzaG9ydGVuLTY0LXRvLTMyXQorICAgICAgICAgICAgICAgICAgICB7IHJldHVybiBtX3N0 cmluZy5maW5kKHMsIHN0YXJ0LCBjYXNlU2VudGl0aXZlKTsgfQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB+fn5+fn5+fiAgICAgICAgIF5+fn5+CisKKyAgICAgICAgKiB3dGYvdGV4dC9B dG9taWNTdHJpbmcuaDoKKyAgICAgICAgKFdURjo6QXRvbWljU3RyaW5nOjpmaW5kKTogQ2hhbmdl IHR5cGUgb2YgJ3N0YXJ0JyBhcmd1bWVudCBmcm9tCisgICAgICAgIHNpemVfdCB0byB1bnNpZ25l ZC4KKwogMjAxMy0wNC0xOSAgQWxiZXJ0byBHYXJjaWEgIDxhZ2FyY2lhQGlnYWxpYS5jb20+CiAK ICAgICAgICAgT1NBbGxvY2F0b3JQb3NpeDogZml4IGJ1aWxkIHdhcm5pbmdzIGFib3V0IHVudXNl ZCBwYXJhbWV0ZXJzIGluIFFOWApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvdGV4dC9BdG9t aWNTdHJpbmcuaCBiL1NvdXJjZS9XVEYvd3RmL3RleHQvQXRvbWljU3RyaW5nLmgKaW5kZXggMjY1 NzE5ZjI5NDMwN2U2MjkzZjA5NWNiOGU5YTY4MWZhYTNkNjUyMy4uMGY1NTIzYTc2N2QwNDg2N2Fh NDVlMDk3NjAwNDIzYWRiYjU5N2RlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4dC9B dG9taWNTdHJpbmcuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0F0b21pY1N0cmluZy5oCkBA IC0xMTAsMTAgKzExMCwxMCBAQCBwdWJsaWM6CiAgICAgYm9vbCBjb250YWlucyhjb25zdCBTdHJp bmcmIHMsIGJvb2wgY2FzZVNlbnNpdGl2ZSA9IHRydWUpIGNvbnN0CiAgICAgICAgIHsgcmV0dXJu IG1fc3RyaW5nLmNvbnRhaW5zKHMsIGNhc2VTZW5zaXRpdmUpOyB9CiAKLSAgICBzaXplX3QgZmlu ZChVQ2hhciBjLCBzaXplX3Qgc3RhcnQgPSAwKSBjb25zdCB7IHJldHVybiBtX3N0cmluZy5maW5k KGMsIHN0YXJ0KTsgfQotICAgIHNpemVfdCBmaW5kKGNvbnN0IExDaGFyKiBzLCBzaXplX3Qgc3Rh cnQgPSAwLCBib29sIGNhc2VTZW50aXRpdmUgPSB0cnVlKSBjb25zdAorICAgIHNpemVfdCBmaW5k KFVDaGFyIGMsIHVuc2lnbmVkIHN0YXJ0ID0gMCkgY29uc3QgeyByZXR1cm4gbV9zdHJpbmcuZmlu ZChjLCBzdGFydCk7IH0KKyAgICBzaXplX3QgZmluZChjb25zdCBMQ2hhciogcywgdW5zaWduZWQg c3RhcnQgPSAwLCBib29sIGNhc2VTZW50aXRpdmUgPSB0cnVlKSBjb25zdAogICAgICAgICB7IHJl dHVybiBtX3N0cmluZy5maW5kKHMsIHN0YXJ0LCBjYXNlU2VudGl0aXZlKTsgfQotICAgIHNpemVf dCBmaW5kKGNvbnN0IFN0cmluZyYgcywgc2l6ZV90IHN0YXJ0ID0gMCwgYm9vbCBjYXNlU2VudGl0 aXZlID0gdHJ1ZSkgY29uc3QKKyAgICBzaXplX3QgZmluZChjb25zdCBTdHJpbmcmIHMsIHVuc2ln bmVkIHN0YXJ0ID0gMCwgYm9vbCBjYXNlU2VudGl0aXZlID0gdHJ1ZSkgY29uc3QKICAgICAgICAg eyByZXR1cm4gbV9zdHJpbmcuZmluZChzLCBzdGFydCwgY2FzZVNlbnRpdGl2ZSk7IH0KICAgICAK ICAgICBib29sIHN0YXJ0c1dpdGgoY29uc3QgU3RyaW5nJiBzLCBib29sIGNhc2VTZW5zaXRpdmUg PSB0cnVlKSBjb25zdAo=