114954 2013-04-22 06:47:36 -0700 [Flakiness Dashboard] Remove the remaining traces of platform modifier unions 2013-05-06 10:43:27 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 114971 1 zan zan benjamin rniwa oldest_to_newest 879112 0 zan 2013-04-22 06:47:36 -0700 [Dashboard] Remove the remaining traces of platform modifier unions 879426 1 199104 zan 2013-04-22 13:58:23 -0700 Created attachment 199104 Patch 885075 2 199104 rniwa 2013-05-06 09:47:25 -0700 Comment on attachment 199104 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199104&action=review > Tools/ChangeLog:3 > + [Dashboard] Remove the remaining traces of platform modifier unions There is an application called Dashboard on Mac. Please change it to Flakiness Dashboard as I've done to the bug title. 885084 3 zan 2013-05-06 09:55:01 -0700 Noted. Thanks for the reviews. 885114 4 zan 2013-05-06 10:43:27 -0700 Committed r149605: <http://trac.webkit.org/changeset/149605> 199104 2013-04-22 13:58:23 -0700 2013-05-06 09:47:25 -0700 Patch bug-114954-20130422225747.patch text/plain 5050 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4OTExCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjNhOWI2NGIwM2ZkMjU2Yjg3ZGVlMjc0YWQ1ZDk4YTlm NmIwODZmOC4uYWU5N2RjNzc1Mjk2YzFiNTY5Yjc4ZmVlZGNlNWFmOTVjYWEwYTkwYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4 IEBACiAyMDEzLTA0LTIyICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAor ICAgICAgICBbRGFzaGJvYXJkXSBSZW1vdmUgdGhlIHJlbWFpbmluZyB0cmFjZXMgb2YgcGxhdGZv cm0gbW9kaWZpZXIgdW5pb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMTQ5NTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFRlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZmxha2luZXNz X2Rhc2hib2FyZC5qczoKKyAgICAgICAgKHByb2Nlc3NFeHBlY3RhdGlvbnNGb3JQbGF0Zm9ybSk6 IFJlbW92ZSB0aGUgcGxhdGZvcm0gdHJlZSB0cmF2ZXJzYWwgdGhhdCBjaGVja2VkIGZvciBwcmVz ZW5jZSBvZiB0aGUgcGxhdGZvcm0KKyAgICAgICAgbW9kaWZpZXIgdW5pb25zIGluIHRoZSBsaXN0 IG9mIG1vZGlmaWVycy4KKyAgICAgICAgKGdlbmVyYXRlUGFnZUZvckV4cGVjdGF0aW9uc1VwZGF0 ZSk6IE9ubHkgZmlsdGVyIHRocm91Z2ggdGhlIG1vZGlmaWVycyB0aGF0IGRvIG5vdCByZXByZXNl bnQgYnVpbGQgdHlwZXMgb3IgYnVnIHJlZmVyZW5jZXMuCisgICAgICAgICogVGVzdFJlc3VsdFNl cnZlci9zdGF0aWMtZGFzaGJvYXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkX3VuaXR0ZXN0cy5qczog QWRqdXN0IHRoZSB0ZXN0IGNhc2VzIGZvciB0aGUgcmVhbE1vZGlmaWVycyB1bml0IHRlc3QuCisK KzIwMTMtMDQtMjIgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgorCiAgICAg ICAgIFtHVEtdIFNldCB1cCBsaWJQbGF0Zm9ybS5sYQogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0MTY4CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RS ZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2FyZC5qcyBiL1Rv b2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2Fy ZC5qcwppbmRleCBkMDc3MTMyYWI5NTBhOWVmNzQ1OWYxNjA2MWJjYzYyM2I0ZmM5ODU3Li40NGMw MTlkOTU3MDVkNjNkYWE5MDU0YmE3YWY3ZDc4NDY3MjAzZGFjIDEwMDY0NAotLS0gYS9Ub29scy9U ZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2ZsYWtpbmVzc19kYXNoYm9hcmQuanMK KysrIGIvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9mbGFraW5lc3Nf ZGFzaGJvYXJkLmpzCkBAIC04NDYsMzMgKzg0Niw2IEBAIGZ1bmN0aW9uIHByb2Nlc3NFeHBlY3Rh dGlvbnNGb3JQbGF0Zm9ybShwbGF0Zm9ybU9iamVjdCwgcGxhdGZvcm1OYW1lLCBleHBlY3RhdGlv CiAgICAgICAgIHZhciBtb2RpZmllcnMgPSBleHBlY3RhdGlvbnNBcnJheVtpXS5tb2RpZmllcnM7 CiAgICAgICAgIHZhciBleHBlY3RhdGlvbnMgPSBleHBlY3RhdGlvbnNBcnJheVtpXS5leHBlY3Rh dGlvbnM7CiAKLSAgICAgICAgdmFyIHNob3VsZFByb2Nlc3NFeHBlY3RhdGlvbiA9IGZhbHNlOwot ICAgICAgICB2YXIgaGFzUGxhdGZvcm1Nb2RpZmllclVuaW9ucyA9IGZhbHNlOwotICAgICAgICBp ZiAocGxhdGZvcm1PYmplY3QuZmFsbGJhY2tQbGF0Zm9ybXMpIHsKLSAgICAgICAgICAgIHBsYXRm b3JtT2JqZWN0LmZhbGxiYWNrUGxhdGZvcm1zLmZvckVhY2goZnVuY3Rpb24oZmFsbGJhY2tQbGF0 Zm9ybSkgewotICAgICAgICAgICAgICAgIGlmIChzaG91bGRQcm9jZXNzRXhwZWN0YXRpb24pCi0g ICAgICAgICAgICAgICAgICAgIHJldHVybjsKLQotICAgICAgICAgICAgICAgIHZhciBmYWxsYmFj a1BsYXRmb3JtT2JqZWN0ID0gcGxhdGZvcm1PYmplY3RGb3JOYW1lKGZhbGxiYWNrUGxhdGZvcm0p OwotICAgICAgICAgICAgICAgIGlmICghZmFsbGJhY2tQbGF0Zm9ybU9iamVjdC5wbGF0Zm9ybU1v ZGlmaWVyVW5pb25zKQotICAgICAgICAgICAgICAgICAgICByZXR1cm47Ci0KLSAgICAgICAgICAg ICAgICBtb2RpZmllcnMuc3BsaXQoJyAnKS5mb3JFYWNoKGZ1bmN0aW9uKG1vZGlmaWVyKSB7Ci0g ICAgICAgICAgICAgICAgICAgIGlmIChtb2RpZmllciBpbiBmYWxsYmFja1BsYXRmb3JtT2JqZWN0 LnBsYXRmb3JtTW9kaWZpZXJVbmlvbnMpIHsKLSAgICAgICAgICAgICAgICAgICAgICAgIGhhc1Bs YXRmb3JtTW9kaWZpZXJVbmlvbnMgPSB0cnVlOwotICAgICAgICAgICAgICAgICAgICAgICAgaWYg KGZhbGxiYWNrUGxhdGZvcm1PYmplY3QucGxhdGZvcm1Nb2RpZmllclVuaW9uc1ttb2RpZmllcl0u aW5kZXhPZihwbGF0Zm9ybU5hbWUpICE9IC0xKQotICAgICAgICAgICAgICAgICAgICAgICAgICAg IHNob3VsZFByb2Nlc3NFeHBlY3RhdGlvbiA9IHRydWU7Ci0gICAgICAgICAgICAgICAgICAgIH0K LSAgICAgICAgICAgICAgICB9KTsKLSAgICAgICAgICAgIH0pOwotICAgICAgICB9Ci0KLSAgICAg ICAgaWYgKCFoYXNQbGF0Zm9ybU1vZGlmaWVyVW5pb25zKQotICAgICAgICAgICAgc2hvdWxkUHJv Y2Vzc0V4cGVjdGF0aW9uID0gdHJ1ZTsKLQotICAgICAgICBpZiAoIXNob3VsZFByb2Nlc3NFeHBl Y3RhdGlvbikKLSAgICAgICAgICAgIGNvbnRpbnVlOwotCiAgICAgICAgIGdldEFsbFRlc3RzVHJp ZSgpLmZvckVhY2goZnVuY3Rpb24odHJpZVBhdGgpIHsKICAgICAgICAgICAgIGFkZFRlc3RUb0Fs bEV4cGVjdGF0aW9uc0ZvclBsYXRmb3JtKHRyaWVQYXRoLCBwbGF0Zm9ybU5hbWUsIGV4cGVjdGF0 aW9ucywgbW9kaWZpZXJzKTsKICAgICAgICAgfSwgcGF0aCk7CkBAIC0xNTk1LDI5ICsxNTY4LDcg QEAgZnVuY3Rpb24gcmVhbE1vZGlmaWVycyhtb2RpZmllclN0cmluZykKIHsKICAgICB2YXIgbW9k aWZpZXJzID0gbW9kaWZpZXJTdHJpbmcuc3BsaXQoJyAnKTs7CiAgICAgcmV0dXJuIG1vZGlmaWVy cy5maWx0ZXIoZnVuY3Rpb24obW9kaWZpZXIpIHsKLSAgICAgICAgaWYgKG1vZGlmaWVyIGluIEJV SUxEX1RZUEVTIHx8IHN0cmluZy5zdGFydHNXaXRoKG1vZGlmaWVyLCAnQlVHJykpCi0gICAgICAg ICAgICByZXR1cm4gZmFsc2U7Ci0KLSAgICAgICAgdmFyIG1hdGNoZXNQbGF0Zm9ybU9yVW5pb24g PSBmYWxzZTsKLSAgICAgICAgdHJhdmVyc2VQbGF0Zm9ybXNUcmVlKGZ1bmN0aW9uKHBsYXRmb3Jt LCBwbGF0Zm9ybU5hbWUpIHsKLSAgICAgICAgICAgIGlmIChtYXRjaGVzUGxhdGZvcm1PclVuaW9u KQotICAgICAgICAgICAgICAgIHJldHVybjsKLQotICAgICAgICAgICAgaWYgKHBsYXRmb3JtLmZh bGxiYWNrUGxhdGZvcm1zKSB7Ci0gICAgICAgICAgICAgICAgcGxhdGZvcm0uZmFsbGJhY2tQbGF0 Zm9ybXMuZm9yRWFjaChmdW5jdGlvbihmYWxsYmFja1BsYXRmb3JtKSB7Ci0gICAgICAgICAgICAg ICAgICAgIGlmIChtYXRjaGVzUGxhdGZvcm1PclVuaW9uKQotICAgICAgICAgICAgICAgICAgICAg ICAgcmV0dXJuOwotCi0gICAgICAgICAgICAgICAgICAgIHZhciBmYWxsYmFja1BsYXRmb3JtT2Jq ZWN0ID0gcGxhdGZvcm1PYmplY3RGb3JOYW1lKGZhbGxiYWNrUGxhdGZvcm0pOwotICAgICAgICAg ICAgICAgICAgICBpZiAoIWZhbGxiYWNrUGxhdGZvcm1PYmplY3QucGxhdGZvcm1Nb2RpZmllclVu aW9ucykKLSAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybjsKLQotICAgICAgICAgICAgICAg ICAgICBtYXRjaGVzUGxhdGZvcm1PclVuaW9uID0gbW9kaWZpZXIgaW4gZmFsbGJhY2tQbGF0Zm9y bU9iamVjdC5zdWJQbGF0Zm9ybXMgfHwgbW9kaWZpZXIgaW4gZmFsbGJhY2tQbGF0Zm9ybU9iamVj dC5wbGF0Zm9ybU1vZGlmaWVyVW5pb25zOwotICAgICAgICAgICAgICAgIH0pOwotICAgICAgICAg ICAgfQotICAgICAgICB9KTsKLQotICAgICAgICByZXR1cm4gIW1hdGNoZXNQbGF0Zm9ybU9yVW5p b247CisgICAgICAgIHJldHVybiAhKG1vZGlmaWVyIGluIEJVSUxEX1RZUEVTIHx8IHN0cmluZy5z dGFydHNXaXRoKG1vZGlmaWVyLCAnQlVHJykpOwogICAgIH0pLmpvaW4oJyAnKTsKIH0KIApkaWZm IC0tZ2l0IGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9mbGFraW5l c3NfZGFzaGJvYXJkX3VuaXR0ZXN0cy5qcyBiL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGlj LWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2FyZF91bml0dGVzdHMuanMKaW5kZXggNWRjMzg0 NTliMmI0MTFhYmEzYWE3YmU5MmIzODMxMjAxZGM4YTM3NC4uZWMyNjkxYWM2NWExZmYxZTVjNjA1 ZWI1NWIzMjA3NWNlOGYxNjlhNCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9z dGF0aWMtZGFzaGJvYXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkX3VuaXR0ZXN0cy5qcworKysgYi9U b29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2ZsYWtpbmVzc19kYXNoYm9h cmRfdW5pdHRlc3RzLmpzCkBAIC0xOTksOCArMTk5LDggQEAgdGVzdCgncGxhdGZvcm1BbmRCdWls ZFR5cGUnLCA3OCwgZnVuY3Rpb24oKSB7CiB9KTsKIAogdGVzdCgncmVhbE1vZGlmaWVycycsIDMs IGZ1bmN0aW9uKCkgewotICAgIGVxdWFsKHJlYWxNb2RpZmllcnMoJ0JVRyhGb28pIExJTlVYIExJ T04gV0lOIERFQlVHIFNMT1cnKSwgJ1NMT1cnKTsKLSAgICBlcXVhbChyZWFsTW9kaWZpZXJzKCdC VUcoRm9vKSBMVUNJRCBNQUMgWFAgUkVMRUFTRSBTS0lQJyksICdTS0lQJyk7CisgICAgZXF1YWwo cmVhbE1vZGlmaWVycygnQlVHKEZvbykgREVCVUcgU0xPVycpLCAnU0xPVycpOworICAgIGVxdWFs KHJlYWxNb2RpZmllcnMoJ0JVRyhGb28pIFJFTEVBU0UnKSwgJycpOwogICAgIGVxdWFsKHJlYWxN b2RpZmllcnMoJ0JVRyhGb28pJyksICcnKTsKIH0pOwogCg==