114950 2013-04-22 05:17:51 -0700 DOMFileSystemBase: fix multiple definitions in the BlackBerry port 2013-04-29 13:03:56 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111729 0 berto webkit-unassigned benjamin cgarcia commit-queue xan.lopez oldest_to_newest 879089 0 berto 2013-04-22 05:17:51 -0700 The following methods are already defined in DOMFileSystemBlackBerry.cpp: crackFileSystemURL() createFileSystemURL() isValidType() supportsToURL() 879091 1 199017 berto 2013-04-22 05:21:12 -0700 Created attachment 199017 Patch 880533 2 199017 xan.lopez 2013-04-24 06:58:27 -0700 Comment on attachment 199017 Patch OK. 880538 3 199017 commit-queue 2013-04-24 07:26:05 -0700 Comment on attachment 199017 Patch Clearing flags on attachment: 199017 Committed r149034: <http://trac.webkit.org/changeset/149034> 880539 4 commit-queue 2013-04-24 07:26:07 -0700 All reviewed patches have been landed. Closing bug. 882448 5 benjamin 2013-04-28 21:04:15 -0700 What The Fuck? This should have: -Justification on why you did not make an abstraction instead. -Justification for using different implementation. Adding platform #ifdef anywhere at random places in WebCore is not okay, we are trying to remove them. Please explain. 882488 6 xan.lopez 2013-04-29 00:29:01 -0700 (In reply to comment #5) > What The Fuck? > > This should have: > -Justification on why you did not make an abstraction instead. > -Justification for using different implementation. > > Adding platform #ifdef anywhere at random places in WebCore is not okay, we are trying to remove them. Please explain. The file already had #ifdefs for Chromium, which were removed recently with the removal of the Chromium code. It just so happens that the BB port was also using this feature, but the #ifdefs were not upstreamed. So the justification is that in general adding an extra #ifdef when there's already one is not a big deal, but we can open another bug to improve the code. 882504 7 berto 2013-04-29 03:15:14 -0700 (In reply to comment #5) > -Justification for using different implementation. Apart from what Xan said, I'll try to see if we can merge both implementations now that there's no Chromium code around. 882730 8 benjamin 2013-04-29 13:03:56 -0700 This has landed last week, there is no chromium code anymore. Even when chromium was there, they were doing a ton more maintenance than (In reply to comment #7) > (In reply to comment #5) > > -Justification for using different implementation. > > Apart from what Xan said, I'll try to see if we can merge both > implementations now that there's no Chromium code around. Thanks. That is the right thing to do. 199017 2013-04-22 05:21:12 -0700 2013-04-24 07:26:05 -0700 Patch 114950.diff text/plain 1526 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhMTFhMDA2Li5mZmM0ZTBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTMtMDQtMjIgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIERPTUZpbGVTeXN0ZW1CYXNlOiBmaXggbXVsdGlwbGUgZGVmaW5pdGlvbnMgaW4gdGhl IEJsYWNrQmVycnkgcG9ydAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTE0OTUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhlIGZvbGxvd2luZyAgbWV0aG9kcyBhcmUgYWxyZWFkeSBkZWZpbmVkIGluIERP TUZpbGVTeXN0ZW1CbGFja0JlcnJ5LmNwcDoKKworICAgICAgICBjcmFja0ZpbGVTeXN0ZW1VUkwo KQorICAgICAgICBjcmVhdGVGaWxlU3lzdGVtVVJMKCkKKyAgICAgICAgaXNWYWxpZFR5cGUoKQor ICAgICAgICBzdXBwb3J0c1RvVVJMKCkKKworICAgICAgICAqIE1vZHVsZXMvZmlsZXN5c3RlbS9E T01GaWxlU3lzdGVtQmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlKToKKwogMjAxMy0wNC0yMSAg RGlyayBTY2h1bHplICA8a3JpdEB3ZWJraXQub3JnPgogCiAgICAgICAgIFtQYXJ0IDRdIFBhcnNl IHRoZSBjdXN0b20oKSBmdW5jdGlvbiBpbiAtd2Via2l0LWZpbHRlcjogcGFyc2UgdGhlIG1hdE4o KSBmdW5jdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZmlsZXN5c3Rl bS9ET01GaWxlU3lzdGVtQmFzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2ZpbGVzeXN0 ZW0vRE9NRmlsZVN5c3RlbUJhc2UuY3BwCmluZGV4IDU5ZjY0Y2EuLjdlZmFhY2UgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZmlsZXN5c3RlbS9ET01GaWxlU3lzdGVtQmFzZS5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9maWxlc3lzdGVtL0RPTUZpbGVTeXN0ZW1C YXNlLmNwcApAQCAtNzEsNiArNzEsNyBAQCBET01GaWxlU3lzdGVtQmFzZTo6fkRPTUZpbGVTeXN0 ZW1CYXNlKCkKIHsKIH0KIAorI2lmICFQTEFURk9STShCTEFDS0JFUlJZKQogLy8gc3RhdGljCiBi b29sIERPTUZpbGVTeXN0ZW1CYXNlOjppc1ZhbGlkVHlwZShGaWxlU3lzdGVtVHlwZSB0eXBlKQog ewpAQCAtMTEyLDYgKzExMyw3IEBAIEtVUkwgRE9NRmlsZVN5c3RlbUJhc2U6OmNyZWF0ZUZpbGVT eXN0ZW1VUkwoY29uc3QgU3RyaW5nJiBmdWxsUGF0aCkgY29uc3QKICAgICB1cmwuc2V0UGF0aCh1 cmwucGF0aCgpICsgZW5jb2RlV2l0aFVSTEVzY2FwZVNlcXVlbmNlcyhmdWxsUGF0aC5zdWJzdHJp bmcoMSkpKTsKICAgICByZXR1cm4gdXJsOwogfQorI2VuZGlmCiAKIFNlY3VyaXR5T3JpZ2luKiBE T01GaWxlU3lzdGVtQmFzZTo6c2VjdXJpdHlPcmlnaW4oKSBjb25zdAogewo=