114944 2013-04-22 02:27:57 -0700 [BlackBerry] Crash due to an assert running test editing/execCommand/indent-paragraphs.html 2013-05-16 17:30:25 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 116101 1 cgarcia webkit-unassigned commit-queue rwlbuis oldest_to_newest 879041 0 cgarcia 2013-04-22 02:27:57 -0700 It crashes in network platform code when trying to save an invalid URL in the disk cache. The test contains the following HTML code: <div id="test"> <div><span class="Apple-style-span" style="background-color: rgb(255, 0, 0);">Hello <img src="http://"> world</span></div> <div>Hello <img src="http://"> world</span></div> Hello <img src="http://"> world </div> Those empty URLs, are parsed as http:/ by KURL and considered valid. BlockBerry network platform uses GURL which considers those URLs invalid. We needed to check that the URLs are valid for our platform before starting the network operation. 879044 1 199009 cgarcia 2013-04-22 02:33:49 -0700 Created attachment 199009 Patch 888300 2 199009 rwlbuis 2013-05-13 08:54:57 -0700 Comment on attachment 199009 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199009&action=review Looks great, but the new early exit needs to be verified and at least an error/log has to be there. > Source/WebCore/platform/network/blackberry/ResourceHandleBlackBerry.cpp:160 > + if (!NetworkManager::instance()->startJob(playerId, handle, frame, defersLoading)) It would be nice to set the error param here. 888799 3 201706 cgarcia 2013-05-14 05:49:55 -0700 Created attachment 201706 Updated patch Updated to return a StatusErrorInvalidUrl error. It depends on bug #116101. 888857 4 201706 rwlbuis 2013-05-14 08:56:46 -0700 Comment on attachment 201706 Updated patch Looks good. 890078 5 201706 commit-queue 2013-05-16 17:30:23 -0700 Comment on attachment 201706 Updated patch Clearing flags on attachment: 201706 Committed r150224: <http://trac.webkit.org/changeset/150224> 890079 6 commit-queue 2013-05-16 17:30:25 -0700 All reviewed patches have been landed. Closing bug. 199009 2013-04-22 02:33:49 -0700 2013-05-14 05:49:55 -0700 Patch bb-url-invalid.diff text/plain 3575 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhZjUxM2Q5ZS4uZTQwZTUzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5 IEBACisyMDEzLTA0LTIyICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNv bT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gQ3Jhc2ggZHVlIHRvIGFuIGFzc2VydCBydW5uaW5n IHRlc3QgZWRpdGluZy9leGVjQ29tbWFuZC9pbmRlbnQtcGFyYWdyYXBocy5odG1sCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ5NDQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBjcmFzaGVzIGluIG5l dHdvcmsgcGxhdGZvcm0gY29kZSB3aGVuIHRyeWluZyB0byBzYXZlIGFuCisgICAgICAgIGludmFs aWQgVVJMIGluIHRoZSBkaXNrIGNhY2hlLiBUaGF0IHRlc3QgY29udGFpbnMgcmVmZXJlbmNlcyB0 bworICAgICAgICBlbXB0eSBVUkxzIGxpa2UgaHR0cDovLy4gVGhvc2UgZW1wdHkgVVJMcywgYXJl IHBhcnNlZCBhcyBodHRwOi8gYnkKKyAgICAgICAgS1VSTCBhbmQgY29uc2lkZXJlZCB2YWxpZC4g QmxhY2tCZXJyeSBuZXR3b3JrIHBsYXRmb3JtIHVzZXMgR1VSTAorICAgICAgICB3aGljaCBjb25z aWRlcnMgdGhvc2UgVVJMcyBpbnZhbGlkLiBXZSBuZWVkZWQgdG8gY2hlY2sgdGhhdCB0aGUKKyAg ICAgICAgVVJMcyBhcmUgdmFsaWQgZm9yIG91ciBwbGF0Zm9ybSBiZWZvcmUgc3RhcnRpbmcgdGhl IG5ldHdvcmsgb3BlcmF0aW9uLgorCisgICAgICAgIEZpeGVzIGEgY3Jhc2ggcnVubmluZyB0ZXN0 CisgICAgICAgIGVkaXRpbmcvZXhlY0NvbW1hbmQvaW5kZW50LXBhcmFncmFwaHMuaHRtbC4KKwor ICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrTWFuYWdlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpOZXR3b3JrTWFuYWdlcjo6c3RhcnRKb2IpOiBDaGVjayBpZiB0 aGUgcmVxdWVzdCBVUkwgaXMKKyAgICAgICAgdmFsaWQgZnJvbSB0aGUgcGxhdGZvcm0gcG9pbnQg b2YgdmlldyByaWdodCBhZnRlciBjcmVhdGluZyB0aGUKKyAgICAgICAgcGxhdGZvcm0gbmV0d29y ayByZXF1ZXN0IGFuZCByZXR1cm4gZWFybHkgaWYgdGhlIFVSTCBpcyBpbnZhbGlkLgorICAgICAg ICAqIHBsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9SZXNvdXJjZUhhbmRsZUJsYWNrQmVycnku Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OnBsYXRmb3JtTG9hZFJlc291 cmNlU3luY2hyb25vdXNseSk6CisgICAgICAgIE5ldHdvcmtNYW5hZ2VyOjpzdGFydEpvYiBjYW4g cmV0dXJuIGZhbHNlIGluIHNvbWUgY2FzZXMuIENoZWNrIHRoZQorICAgICAgICByZXR1cm4gdmFs dWUgYW5kIHJldHVybiBlYXJseSB3ZSBpdCBmYWlsZWQgdG8gc3RhcnQgYSBuZXR3b3JrIGpvYi4K KwogMjAxMy0wNC0xOCAgQWxiZXJ0byBHYXJjaWEgIDxhZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAg ICAgICAgUmVtb3ZlIG9ic29sZXRlIG1hY3JvcyBmcm9tIGxpYnBuZwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtNYW5hZ2VyLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrTWFu YWdlci5jcHAKaW5kZXggM2Q4ZmEwMy4uMDVjNWZlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtNYW5hZ2VyLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya01hbmFnZXIu Y3BwCkBAIC0xNTgsNiArMTU4LDExIEBAIGJvb2wgTmV0d29ya01hbmFnZXI6OnN0YXJ0Sm9iKGlu dCBwbGF5ZXJJZCwgY29uc3QgU3RyaW5nJiBwYWdlR3JvdXBOYW1lLCBQYXNzUmVmCiAgICAgQmxh Y2tCZXJyeTo6UGxhdGZvcm06Ok5ldHdvcmtSZXF1ZXN0IHBsYXRmb3JtUmVxdWVzdDsKICAgICBy ZXF1ZXN0LmluaXRpYWxpemVQbGF0Zm9ybVJlcXVlc3QocGxhdGZvcm1SZXF1ZXN0LCBmcmFtZS0+ bG9hZGVyKCkgJiYgZnJhbWUtPmxvYWRlcigpLT5jbGllbnQoKSAmJiBzdGF0aWNfY2FzdDxGcmFt ZUxvYWRlckNsaWVudEJsYWNrQmVycnkqPihmcmFtZS0+bG9hZGVyKCktPmNsaWVudCgpKS0+Y29v a2llc0VuYWJsZWQoKSwgaXNJbml0aWFsLCByZXJlYWRDb29raWVzKTsKIAorICAgIC8vIEdVUkwg YW5kIEtVUkwgY29uc2lkZXIgdmFsaWQgVVJMcyBkaWZmZXJlbnRseSwgZm9yIGV4YW1wbGUgaHR0 cDovLyBpcyBwYXJzZWQgYXMKKyAgICAvLyBodHRwOi8gYnkgS1VSTCBhbmQgY29uc2lkZXJlZCB2 YWxpZCwgd2hpbGUgR1VSTCBjb25zaWRlcnMgaXQgaW52YWxpZC4KKyAgICBpZiAoIXBsYXRmb3Jt UmVxdWVzdC51cmwoKS5pc192YWxpZCgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKICAgICBj b25zdCBTdHJpbmcmIGRvY3VtZW50VXJsID0gZnJhbWUtPmRvY3VtZW50KCktPnVybCgpLnN0cmlu ZygpOwogICAgIGlmICghZG9jdW1lbnRVcmwuaXNFbXB0eSgpKSB7CiAgICAgICAgIHBsYXRmb3Jt UmVxdWVzdC5zZXRSZWZlcnJlcihkb2N1bWVudFVybCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvUmVzb3VyY2VIYW5kbGVCbGFja0JlcnJ5 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9SZXNvdXJj ZUhhbmRsZUJsYWNrQmVycnkuY3BwCmluZGV4IDQwNTgyZTAuLjRkNzNiYzYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9SZXNvdXJjZUhhbmRs ZUJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxh Y2tiZXJyeS9SZXNvdXJjZUhhbmRsZUJsYWNrQmVycnkuY3BwCkBAIC0xNTcsNyArMTU3LDggQEAg dm9pZCBSZXNvdXJjZUhhbmRsZTo6cGxhdGZvcm1Mb2FkUmVzb3VyY2VTeW5jaHJvbm91c2x5KE5l dHdvcmtpbmdDb250ZXh0KiBjb250ZXgKICAgICBib29sIHNob3VsZENvbnRlbnRTbmlmZiA9IGZh bHNlOwogCiAgICAgUmVmUHRyPFJlc291cmNlSGFuZGxlPiBoYW5kbGUgPSBhZG9wdFJlZihuZXcg UmVzb3VyY2VIYW5kbGUoY29udGV4dCwgcmVxdWVzdCwgJnN5bmNMb2FkZXIsIGRlZmVyc0xvYWRp bmcsIHNob3VsZENvbnRlbnRTbmlmZikpOwotICAgIE5ldHdvcmtNYW5hZ2VyOjppbnN0YW5jZSgp LT5zdGFydEpvYihwbGF5ZXJJZCwgaGFuZGxlLCBmcmFtZSwgZGVmZXJzTG9hZGluZyk7CisgICAg aWYgKCFOZXR3b3JrTWFuYWdlcjo6aW5zdGFuY2UoKS0+c3RhcnRKb2IocGxheWVySWQsIGhhbmRs ZSwgZnJhbWUsIGRlZmVyc0xvYWRpbmcpKQorICAgICAgICByZXR1cm47CiAKICAgICBjb25zdCBk b3VibGUgc3luY0xvYWRUaW1lT3V0ID0gNjA7IC8vIHNlY29uZHMKIAo= 201706 2013-05-14 05:49:55 -0700 2013-05-16 17:30:23 -0700 Updated patch bb-invalid-url.diff text/plain 2593 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5M2U4NTdhLi5hY2VkYmFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjkg QEAKIDIwMTMtMDUtMTQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtCbGFja0JlcnJ5XSBDcmFzaCBkdWUgdG8gYW4gYXNzZXJ0IHJ1bm5pbmcg dGVzdCBlZGl0aW5nL2V4ZWNDb21tYW5kL2luZGVudC1wYXJhZ3JhcGhzLmh0bWwKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDk0NAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0IGNyYXNoZXMgaW4gbmV0 d29yayBwbGF0Zm9ybSBjb2RlIHdoZW4gdHJ5aW5nIHRvIHNhdmUgYW4KKyAgICAgICAgaW52YWxp ZCBVUkwgaW4gdGhlIGRpc2sgY2FjaGUuIFRoYXQgdGVzdCBjb250YWlucyByZWZlcmVuY2VzIHRv CisgICAgICAgIGVtcHR5IFVSTHMgbGlrZSBodHRwOi8vLiBUaG9zZSBlbXB0eSBVUkxzLCBhcmUg cGFyc2VkIGFzIGh0dHA6LyBieQorICAgICAgICBLVVJMIGFuZCBjb25zaWRlcmVkIHZhbGlkLiBC bGFja0JlcnJ5IG5ldHdvcmsgcGxhdGZvcm0gdXNlcyBHVVJMCisgICAgICAgIHdoaWNoIGNvbnNp ZGVycyB0aG9zZSBVUkxzIGludmFsaWQuIFdlIG5lZWRlZCB0byBjaGVjayB0aGF0IHRoZQorICAg ICAgICBVUkxzIGFyZSB2YWxpZCBmb3Igb3VyIHBsYXRmb3JtIGJlZm9yZSBzdGFydGluZyB0aGUg bmV0d29yaworICAgICAgICBvcGVyYXRpb24uCisKKyAgICAgICAgRml4ZXMgYSBjcmFzaCBydW5u aW5nIHRlc3QKKyAgICAgICAgZWRpdGluZy9leGVjQ29tbWFuZC9pbmRlbnQtcGFyYWdyYXBocy5o dG1sLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtNYW5h Z2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdvcmtNYW5hZ2VyOjpzdGFydEpvYik6IENo ZWNrIGlmIHRoZSByZXF1ZXN0IFVSTCBpcworICAgICAgICB2YWxpZCBmcm9tIHRoZSBwbGF0Zm9y bSBwb2ludCBvZiB2aWV3IHJpZ2h0IGFmdGVyIGNyZWF0aW5nIHRoZQorICAgICAgICBwbGF0Zm9y bSBuZXR3b3JrIHJlcXVlc3QgYW5kIHJldHVybiBlYXJseSBpZiB0aGUgVVJMIGlzIGludmFsaWQK KyAgICAgICAgd2l0aCBTdGF0dXNFcnJvckludmFsaWRVcmwgZXJyb3IuCisKKzIwMTMtMDUtMTQg IENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtC bGFja0JlcnJ5XSBJbXBsZW1lbnQgcGxhdGZvcm0gc3RyYXRlZ2llcwogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyMTYyCiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrTWFuYWdlci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya01h bmFnZXIuY3BwCmluZGV4IDZjNzU1N2QuLjQ0YTkwODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrTWFuYWdlci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtNYW5hZ2Vy LmNwcApAQCAtMTU2LDYgKzE1NiwxMSBAQCBpbnQgTmV0d29ya01hbmFnZXI6OnN0YXJ0Sm9iKGlu dCBwbGF5ZXJJZCwgY29uc3QgU3RyaW5nJiBwYWdlR3JvdXBOYW1lLCBQYXNzUmVmUAogICAgIEJs YWNrQmVycnk6OlBsYXRmb3JtOjpOZXR3b3JrUmVxdWVzdCBwbGF0Zm9ybVJlcXVlc3Q7CiAgICAg cmVxdWVzdC5pbml0aWFsaXplUGxhdGZvcm1SZXF1ZXN0KHBsYXRmb3JtUmVxdWVzdCwgZnJhbWUt PmxvYWRlcigpICYmIGZyYW1lLT5sb2FkZXIoKS0+Y2xpZW50KCkgJiYgc3RhdGljX2Nhc3Q8RnJh bWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5Kj4oZnJhbWUtPmxvYWRlcigpLT5jbGllbnQoKSktPmNv b2tpZXNFbmFibGVkKCksIGlzSW5pdGlhbCwgcmVyZWFkQ29va2llcyk7CiAKKyAgICAvLyBHVVJM IGFuZCBLVVJMIGNvbnNpZGVyIHZhbGlkIFVSTHMgZGlmZmVyZW50bHksIGZvciBleGFtcGxlIGh0 dHA6Ly8gaXMgcGFyc2VkIGFzCisgICAgLy8gaHR0cDovIGJ5IEtVUkwgYW5kIGNvbnNpZGVyZWQg dmFsaWQsIHdoaWxlIEdVUkwgY29uc2lkZXJzIGl0IGludmFsaWQuCisgICAgaWYgKCFwbGF0Zm9y bVJlcXVlc3QudXJsKCkuaXNfdmFsaWQoKSkKKyAgICAgICAgcmV0dXJuIEJsYWNrQmVycnk6OlBs YXRmb3JtOjpGaWx0ZXJTdHJlYW06OlN0YXR1c0Vycm9ySW52YWxpZFVybDsKKwogICAgIGNvbnN0 IFN0cmluZyYgZG9jdW1lbnRVcmwgPSBmcmFtZS0+ZG9jdW1lbnQoKS0+dXJsKCkuc3RyaW5nKCk7 CiAgICAgaWYgKCFkb2N1bWVudFVybC5pc0VtcHR5KCkpCiAgICAgICAgIHBsYXRmb3JtUmVxdWVz dC5zZXRSZWZlcnJlcihkb2N1bWVudFVybCk7Cg==