114942 2013-04-22 02:18:58 -0700 [BlackBerry] Need to send out change event for date/color picker 2013-04-23 04:57:12 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 charles.wei charles.wei alex cgarcia commit-queue mifenton rwlbuis staikos oldest_to_newest 879037 0 charles.wei 2013-04-22 02:18:58 -0700 For now the date/time/color are implemented with PagePopups, when the user finishes selection and closes the popup, we set the value to the element but there's no change event sent out. so the javascript can't get the change event to perform its work if the application registers change handler. We need to instruct the webkit to send out 'change' event when the user selection changes. Internal tracking No. : 326167 879049 1 199011 charles.wei 2013-04-22 02:46:58 -0700 Created attachment 199011 Patch 879144 2 mifenton 2013-04-22 07:56:48 -0700 Looks good, but do we need it for select as well? void InputHandler::setInputValue(const WTF::String& value) would be the place if it's required. 879548 3 charles.wei 2013-04-22 18:10:16 -0700 (In reply to comment #2) > Looks good, but do we need it for select as well? > > void InputHandler::setInputValue(const WTF::String& value) would be the place if it's required. No, we don't . Selection change is already taken care of in SelectPopupClient::notifySelectionChange() which in turn calls : m_element->dispatchFormControlChangeEvent(); to send out the change event. 879641 4 199011 cgarcia 2013-04-23 00:05:06 -0700 Comment on attachment 199011 Patch It makes sense. 879791 5 199011 commit-queue 2013-04-23 04:57:10 -0700 Comment on attachment 199011 Patch Clearing flags on attachment: 199011 Committed r148959: <http://trac.webkit.org/changeset/148959> 879792 6 commit-queue 2013-04-23 04:57:12 -0700 All reviewed patches have been landed. Closing bug. 199011 2013-04-22 02:46:58 -0700 2013-04-23 04:57:10 -0700 Patch bug-114942-20130422174623.patch text/plain 2406 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4ODYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBmYWIzNGU5ZWVkOWIxZmM4MzhjMGNmNThmYTVjZmFiYWE5MTQ5OWM5Li43ZjA2MDBjNzdh MGUwYjc5NmZmYmEyNmIzMzFjZTVkMGU0MzE1ZmJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMy0wNC0yMiAgQ2hhcmxlcyBXZWkgIDxjaGFybGVz LndlaUB0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNrQmVycnldIE5lZWQgdG8g c2VuZCBvdXQgY2hhbmdlIGV2ZW50IGZvciBkYXRlL2NvbG9yIHBpY2tlcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0OTQyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgbmVlZCB0byBpbnN0cnVjdCB0 aGUgRm9ybUNvbnRyb2xFbGVtZW50cyB0byBzZW5kIG91dCAnY2hhbmdlJyBldmVudAorICAgICAg ICB3aGVuIHRoZSB1c2VyIG1ha2VzIHRoZSBzZWxlY3Rpb24gYW5kIGNsb3NlcyB0aGUgUGFnZVBv cHVwIGZvciBkYXRlL2NvbG9yLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvQ29sb3JQaWNr ZXJDbGllbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29sb3JQaWNrZXJDbGllbnQ6OnNldFZh bHVlQW5kQ2xvc2VQb3B1cCk6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRGF0ZVBpY2tlckNs aWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEYXRlUGlja2VyQ2xpZW50OjpzZXRWYWx1ZUFu ZENsb3NlUG9wdXApOgorCiAyMDEzLTA0LTE5ICBBbmR5IENoZW4gIDxhbmRjaGVuQGJsYWNrYmVy cnkuY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBGaW5kLW9uLXBhZ2Ugc2hvdWxkIGRvIHRo ZSBzY29waW5nIGFnYWluIHdoZW4gaGlnaGxpZ2h0IHBvbGljeSBjaGFuZ2VkIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0NvbG9yUGlja2VyQ2xp ZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9Db2xvclBp Y2tlckNsaWVudC5jcHAKaW5kZXggZDMyOWVjZjcwN2FjMGJhZjU5ZmM4MjY1MDAxZjkyYWYzYzJj MGNhZC4uYzZiZTJhOTA0MWE5NGM1NWU2NDFkOGE4YmRjM2YzYjFkMWIwNDE5ZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0NvbG9yUGlja2VyQ2xp ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvQ29s b3JQaWNrZXJDbGllbnQuY3BwCkBAIC05NSw3ICs5NSw3IEBAIHZvaWQgQ29sb3JQaWNrZXJDbGll bnQ6OnNldFZhbHVlQW5kQ2xvc2VQb3B1cChpbnQsIGNvbnN0IFN0cmluZyYgdmFsdWUpCiAKICAg ICBzdGF0aWMgY29uc3QgY2hhciogY2FuY2VsVmFsdWUgPSAiLTEiOwogICAgIGlmICh2YWx1ZSAh PSBjYW5jZWxWYWx1ZSkKLSAgICAgICAgbV9lbGVtZW50LT5zZXRWYWx1ZSh2YWx1ZSk7CisgICAg ICAgIG1fZWxlbWVudC0+c2V0VmFsdWUodmFsdWUsIERpc3BhdGNoQ2hhbmdlRXZlbnQpOwogICAg IGNsb3NlUG9wdXAoKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L1dlYkNvcmVTdXBwb3J0L0RhdGVQaWNrZXJDbGllbnQuY3BwIGIvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0RhdGVQaWNrZXJDbGllbnQuY3BwCmluZGV4IGE2NTFiMTkw OThkN2IxODNmNWRhZWE5NTA2MjUxMDhiNGVmMDU1ZTIuLjRhOTdmZmQ3ODkyMjQ2ODAzYjVmNGY0 YWI4Njc0NjdmNmFkNTI5ODcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9X ZWJDb3JlU3VwcG9ydC9EYXRlUGlja2VyQ2xpZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvRGF0ZVBpY2tlckNsaWVudC5jcHAKQEAgLTEzNCw3ICsx MzQsNyBAQCB2b2lkIERhdGVQaWNrZXJDbGllbnQ6OnNldFZhbHVlQW5kQ2xvc2VQb3B1cChpbnQs IGNvbnN0IFN0cmluZyYgdmFsdWUpCiAgICAgbV9lbGVtZW50LT5kb2N1bWVudCgpLT5mcmFtZSgp LT5zZWxlY3Rpb24oKS0+c2V0Q2FyZXRWaXNpYmxlKHRydWUpOwogCiAgICAgaWYgKHZhbHVlICE9 ICItMSIpCi0gICAgICAgIG1fZWxlbWVudC0+c2V0VmFsdWUodmFsdWUpOworICAgICAgICBtX2Vs ZW1lbnQtPnNldFZhbHVlKHZhbHVlLCBEaXNwYXRjaENoYW5nZUV2ZW50KTsKICAgICBjbG9zZVBv cHVwKCk7CiB9CiAK