114941 2013-04-22 02:08:24 -0700 Scrollbar should not depend on EventHandler, Frame and FrameView 2013-04-22 10:01:28 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 21354 1 cgarcia webkit-unassigned sam oldest_to_newest 879027 0 cgarcia 2013-04-22 02:08:24 -0700 It's a layering violation. 879032 1 199006 cgarcia 2013-04-22 02:13:53 -0700 Created attachment 199006 Patch 879178 2 199006 darin 2013-04-22 08:43:04 -0700 Comment on attachment 199006 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199006&action=review > Source/WebCore/ChangeLog:14 > + It's a layering violation that Scrollbar uses EventHandler, Frame > + and FrameView. Frame is used to get the EvenHandler that is used > + to set mousePressed to false after a Scrollbar::mouseUp(). This is > + not really needed, since EvenHandler already sets m_mousePressed > + to false when calling Scrollbar::mouseUp(). The PopupMenu windows > + implementation also calls Scrollbar::mouseUp(), but that scrollbar > + is not inside a FrameView. Some EvenHandler typos here. 879183 3 cgarcia 2013-04-22 08:50:32 -0700 (In reply to comment #2) > (From update of attachment 199006 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=199006&action=review > > > Source/WebCore/ChangeLog:14 > > + It's a layering violation that Scrollbar uses EventHandler, Frame > > + and FrameView. Frame is used to get the EvenHandler that is used > > + to set mousePressed to false after a Scrollbar::mouseUp(). This is > > + not really needed, since EvenHandler already sets m_mousePressed > > + to false when calling Scrollbar::mouseUp(). The PopupMenu windows > > + implementation also calls Scrollbar::mouseUp(), but that scrollbar > > + is not inside a FrameView. > > Some EvenHandler typos here. Ooops, will fix them before landing, thanks for the review. 879221 4 cgarcia 2013-04-22 10:01:28 -0700 Committed r148892: <http://trac.webkit.org/changeset/148892> 199006 2013-04-22 02:13:53 -0700 2013-04-22 08:43:04 -0700 Patch wcore-scrollbar-violations.diff text/plain 2587 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2OTI0ZWRlLi43YTY0ZWFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTMtMDQtMjIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFNjcm9sbGJhciBzaG91bGQgbm90IGRlcGVuZCBvbiBFdmVudEhhbmRsZXIs IEZyYW1lIGFuZCBGcmFtZVZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExNDk0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEl0J3MgYSBsYXllcmluZyB2aW9sYXRpb24gdGhhdCBTY3JvbGxiYXIgdXNl cyBFdmVudEhhbmRsZXIsIEZyYW1lCisgICAgICAgIGFuZCBGcmFtZVZpZXcuIEZyYW1lIGlzIHVz ZWQgdG8gZ2V0IHRoZSBFdmVuSGFuZGxlciB0aGF0IGlzIHVzZWQKKyAgICAgICAgdG8gc2V0IG1v dXNlUHJlc3NlZCB0byBmYWxzZSBhZnRlciBhIFNjcm9sbGJhcjo6bW91c2VVcCgpLiBUaGlzIGlz CisgICAgICAgIG5vdCByZWFsbHkgbmVlZGVkLCBzaW5jZSBFdmVuSGFuZGxlciBhbHJlYWR5IHNl dHMgbV9tb3VzZVByZXNzZWQKKyAgICAgICAgdG8gZmFsc2Ugd2hlbiBjYWxsaW5nIFNjcm9sbGJh cjo6bW91c2VVcCgpLiBUaGUgUG9wdXBNZW51IHdpbmRvd3MKKyAgICAgICAgaW1wbGVtZW50YXRp b24gYWxzbyBjYWxscyBTY3JvbGxiYXI6Om1vdXNlVXAoKSwgYnV0IHRoYXQgc2Nyb2xsYmFyCisg ICAgICAgIGlzIG5vdCBpbnNpZGUgYSBGcmFtZVZpZXcuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9T Y3JvbGxiYXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyOjppc1Njcm9sbFZpZXdT Y3JvbGxiYXIpOgorICAgICAgICBpc1Njcm9sbFZpZXdTY3JvbGxiYXIoKSBpcyBhIG1ldGhvZCBv ZiBTY3JvbGxWaWV3IHNvIHdlIGRvbid0IG5lZWQKKyAgICAgICAgdG8gY2FzdCB0byBGcmFtZVZp ZXcuCisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxiYXI6Om1vdXNlVXApOiBSZW1vdmUgRXZlbnRI YW5kbGVyIHVzc2FnZS4KKwogMjAxMy0wNC0yMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2Fy Y2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgRGl2aXNpb24gYnkgemVybyBpbiBDU1NHcmFkaWVu dFZhbHVlOjphZGRTdG9wcygpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9T Y3JvbGxiYXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsYmFyLmNwcAppbmRl eCAwZTFiMmZiLi5kZDMzYThiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9T Y3JvbGxiYXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbGJhci5jcHAK QEAgLTI5LDYgKzI5LDcgQEAKICNpbmNsdWRlICJHcmFwaGljc0NvbnRleHQuaCIKICNpbmNsdWRl ICJQbGF0Zm9ybU1vdXNlRXZlbnQuaCIKICNpbmNsdWRlICJTY3JvbGxBbmltYXRvci5oIgorI2lu Y2x1ZGUgIlNjcm9sbFZpZXcuaCIKICNpbmNsdWRlICJTY3JvbGxhYmxlQXJlYS5oIgogI2luY2x1 ZGUgIlNjcm9sbGJhclRoZW1lLmgiCiAjaW5jbHVkZSA8YWxnb3JpdGhtPgpAQCAtMzcsMTEgKzM4 LDYgQEAKICNpbmNsdWRlICJQbGF0Zm9ybUdlc3R1cmVFdmVudC5oIgogI2VuZGlmCiAKLS8vIEZJ WE1FOiBUaGUgZm9sbG93aW5nICNpbmNsdWRlcyBhcmUgYSBsYXllcmluZyB2aW9sYXRpb24gYW5k IHNob3VsZCBiZSByZW1vdmVkLgotI2luY2x1ZGUgIkV2ZW50SGFuZGxlci5oIgotI2luY2x1ZGUg IkZyYW1lLmgiCi0jaW5jbHVkZSAiRnJhbWVWaWV3LmgiCi0KIHVzaW5nIG5hbWVzcGFjZSBzdGQ7 CiAKICNpZiBQTEFURk9STShHVEspCkBAIC0xMzAsNyArMTI2LDcgQEAgYm9vbCBTY3JvbGxiYXI6 OmlzU2Nyb2xsYWJsZUFyZWFBY3RpdmUoKSBjb25zdAogCiBib29sIFNjcm9sbGJhcjo6aXNTY3Jv bGxWaWV3U2Nyb2xsYmFyKCkgY29uc3QKIHsKLSAgICByZXR1cm4gcGFyZW50KCkgJiYgcGFyZW50 KCktPmlzRnJhbWVWaWV3KCkgJiYgdG9GcmFtZVZpZXcocGFyZW50KCkpLT5pc1Njcm9sbFZpZXdT Y3JvbGxiYXIodGhpcyk7CisgICAgcmV0dXJuIHBhcmVudCgpICYmIHBhcmVudCgpLT5pc1Njcm9s bFZpZXdTY3JvbGxiYXIodGhpcyk7CiB9CiAKIHZvaWQgU2Nyb2xsYmFyOjpvZmZzZXREaWRDaGFu Z2UoKQpAQCAtNDU4LDkgKzQ1NCw2IEBAIGJvb2wgU2Nyb2xsYmFyOjptb3VzZVVwKGNvbnN0IFBs YXRmb3JtTW91c2VFdmVudCYgbW91c2VFdmVudCkKICAgICAgICAgICAgIG1fc2Nyb2xsYWJsZUFy ZWEtPm1vdXNlRXhpdGVkU2Nyb2xsYmFyKHRoaXMpOwogICAgIH0KIAotICAgIGlmIChwYXJlbnQo KSAmJiBwYXJlbnQoKS0+aXNGcmFtZVZpZXcoKSkKLSAgICAgICAgdG9GcmFtZVZpZXcocGFyZW50 KCkpLT5mcmFtZSgpLT5ldmVudEhhbmRsZXIoKS0+c2V0TW91c2VQcmVzc2VkKGZhbHNlKTsKLQog ICAgIHJldHVybiB0cnVlOwogfQogCg==