114907 2013-04-20 19:13:49 -0700 Fix some minor bad use of strings in WebCore 2013-04-21 22:53:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 878814 0 benjamin 2013-04-20 19:13:49 -0700 Fix some minor bad use of strings in WebCore 878815 1 198950 benjamin 2013-04-20 19:22:00 -0700 Created attachment 198950 Patch 878827 2 198950 darin 2013-04-20 22:01:04 -0700 Comment on attachment 198950 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198950&action=review > Source/WebCore/ChangeLog:9 > + (WebCore::Editor::selectedText): This was implictely getting the emptyString(). Typo or spelling error: should be "implicitly". But also, I don’t understand what you mean. Do you mean that 0 was turning into the null string? 878830 3 benjamin 2013-04-21 00:03:58 -0700 > But also, I don’t understand what you mean. Do you mean that 0 was turning into the null string? This replace(0, "") Would turn into this (there is no replace for char*): replace((UChar)0, String("")) And the constructor of String return the empty string if the length is 0 :( 878970 4 benjamin 2013-04-21 22:53:15 -0700 Committed r148854: <http://trac.webkit.org/changeset/148854> 198950 2013-04-20 19:22:00 -0700 2013-04-20 22:01:03 -0700 Patch bug-114907-20130420192127.patch text/plain 2858 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4Nzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTVkMTIxZmMxMjhhZDIz NDFkNmU4MzIzZWQ5NjI2ZDZlZWRjOTZlNy4uOWUxYzNjZDhmMjlmMWNhY2JiYjA2MDlmNmE3MTQx NWJkYTdiOTRiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA0LTIwICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBGaXggc29tZSBt aW5vciBiYWQgdXNlIG9mIHN0cmluZ3MgaW4gV2ViQ29yZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0OTA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBlZGl0aW5nL0VkaXRvci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpFZGl0b3I6OnNlbGVjdGVkVGV4dCk6IFRoaXMgd2FzIGltcGxpY3RlbHkgZ2V0 dGluZyB0aGUgZW1wdHlTdHJpbmcoKS4KKyAgICAgICAgKiBlZGl0aW5nL21hcmt1cC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpTdHlsZWRNYXJrdXBBY2N1bXVsYXRvcjo6dGFrZVJlc3VsdHMpOiBk aXR0by4KKwogMjAxMy0wNC0xOSAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+ CiAKICAgICAgICAgW0VGTF0gQXJyb3cgb2YgY29tYm8gYm94IGFyZSBkcmF3biB0d2ljZQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwIGIvU291cmNlL1dlYkNv cmUvZWRpdGluZy9FZGl0b3IuY3BwCmluZGV4IGEwMTgwMmE0YzM2OGNhOGIzMDlmMzVlNzBiODBk ZGUxOTIyZWIzNmYuLmNmYjM3MjRhNGRiOWE4MTJlNWM5MjM4OWRjNTIzMDUxZTllMDg0ODQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJp Z2h0IChDKSAyMDA2LCAyMDA3LCAyMDA4LCAyMDExIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNl cnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAwNiwgMjAwNywgMjAwOCwgMjAxMSwgMjAxMyBBcHBs ZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKiBDb3B5cmlnaHQgKEMpIDIwMDggTm9raWEg Q29ycG9yYXRpb24gYW5kL29yIGl0cyBzdWJzaWRpYXJ5KC1pZXMpCiAgKgogICogUmVkaXN0cmli dXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0 CkBAIC0yNjQ3LDcgKzI2NDcsNyBAQCBTdHJpbmcgRWRpdG9yOjpzZWxlY3RlZFRleHRGb3JDbGlw Ym9hcmQoKSBjb25zdAogU3RyaW5nIEVkaXRvcjo6c2VsZWN0ZWRUZXh0KFRleHRJdGVyYXRvckJl aGF2aW9yIGJlaGF2aW9yKSBjb25zdAogewogICAgIC8vIFdlIHJlbW92ZSAnXDAnIGNoYXJhY3Rl cnMgYmVjYXVzZSB0aGV5IGFyZSBub3QgdmlzaWJseSByZW5kZXJlZCB0byB0aGUgdXNlci4KLSAg ICByZXR1cm4gcGxhaW5UZXh0KG1fZnJhbWUtPnNlbGVjdGlvbigpLT50b05vcm1hbGl6ZWRSYW5n ZSgpLmdldCgpLCBiZWhhdmlvcikucmVwbGFjZSgwLCAiIik7CisgICAgcmV0dXJuIHBsYWluVGV4 dChtX2ZyYW1lLT5zZWxlY3Rpb24oKS0+dG9Ob3JtYWxpemVkUmFuZ2UoKS5nZXQoKSwgYmVoYXZp b3IpLnJlcGxhY2VXaXRoTGl0ZXJhbCgnXDAnLCAiIik7CiB9CiAKIEludFJlY3QgRWRpdG9yOjpm aXJzdFJlY3RGb3JSYW5nZShSYW5nZSogcmFuZ2UpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9lZGl0aW5nL21hcmt1cC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hcmt1 cC5jcHAKaW5kZXggYTViMjVmNjgyNWUzZmIxMGYxZjUwOWY2NDA3YTUzOTk0ZGI5YmIxMi4uZmRh MjFkNWVlOTRkNTFiMzNjZDg4MTJkZTRhY2FkZmI1MDhlYWQ5MCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvZWRpdGluZy9tYXJrdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcv bWFya3VwLmNwcApAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMDQsIDIw MDUsIDIwMDYsIDIwMDcsIDIwMDgsIDIwMDkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVk LgorICogQ29weXJpZ2h0IChDKSAyMDA0LCAyMDA1LCAyMDA2LCAyMDA3LCAyMDA4LCAyMDA5LCAy MDEzIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqIENvcHlyaWdodCAoQykgMjAw OCwgMjAwOSwgMjAxMCwgMjAxMSBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICog Q29weXJpZ2h0IChDKSAyMDExIElnYWxpYSBTLkwuCiAgKiBDb3B5cmlnaHQgKEMpIDIwMTEgTW90 b3JvbGEgTW9iaWxpdHkuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCkBAIC0yMTgsNyArMjE4LDcgQEAg U3RyaW5nIFN0eWxlZE1hcmt1cEFjY3VtdWxhdG9yOjp0YWtlUmVzdWx0cygpCiAgICAgY29uY2F0 ZW5hdGVNYXJrdXAocmVzdWx0KTsKIAogICAgIC8vIFdlIHJlbW92ZSAnXDAnIGNoYXJhY3RlcnMg YmVjYXVzZSB0aGV5IGFyZSBub3QgdmlzaWJseSByZW5kZXJlZCB0byB0aGUgdXNlci4KLSAgICBy ZXR1cm4gcmVzdWx0LnRvU3RyaW5nKCkucmVwbGFjZSgwLCAiIik7CisgICAgcmV0dXJuIHJlc3Vs dC50b1N0cmluZygpLnJlcGxhY2VXaXRoTGl0ZXJhbCgnXDAnLCAiIik7CiB9CiAKIHZvaWQgU3R5 bGVkTWFya3VwQWNjdW11bGF0b3I6OmFwcGVuZFRleHQoU3RyaW5nQnVpbGRlciYgb3V0LCBUZXh0 KiB0ZXh0KQo=