114895 2013-04-19 19:04:46 -0700 SunSpider/string-tagcloud should be more lenient in validating its results, since they depend on Math.log, which isn't formally specified 2013-04-20 13:10:28 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo fpizlo barraclough commit-queue ggaren mark.lam mhahnenberg mjs msaboff oliver rniwa sam oldest_to_newest 878697 0 fpizlo 2013-04-19 19:04:46 -0700 Patch forthcoming. <rdar://13699853> 878698 1 198923 fpizlo 2013-04-19 19:09:24 -0700 Created attachment 198923 the patch 878764 2 198923 msaboff 2013-04-20 06:50:18 -0700 Comment on attachment 198923 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=198923&action=review r=me > PerformanceTests/SunSpider/tests/sunspider-1.0/string-tagcloud.js:266 > +var expectedMinLength = 315000; How did you come up with this being enough in all cases? 878792 3 fpizlo 2013-04-20 13:09:12 -0700 (In reply to comment #2) > (From update of attachment 198923 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=198923&action=review > > r=me > > > PerformanceTests/SunSpider/tests/sunspider-1.0/string-tagcloud.js:266 > > +var expectedMinLength = 315000; > > How did you come up with this being enough in all cases? The differences I observed on the various platforms and browsers I tested were never greater than ~20. So I think this is much a much bigger tolerance than we need, based on empirical data. But also, this is a comparison of string length. The string length will only if Math.log returns a result that is in a different order of magnitude. So I think that it would be hard for someone to have a Math.log function that is so wrong that you get 241 fewer digits in the string generated by tagcloud, than you would get in the systems I tested. Finally, I'd be happy to make this even more tolerant, if you or others think it's a good idea. The point of this string compare at this point is just to force the JS engine to actually run the benchmark and generate the string - since you can only prove that the string wasn't shorter by actually running the thing. (Well I guess the browser could still spoof the benchmark, in which case we can't really do anything; or the browser could solve the much harder combinatoric problem of proving that the string must be at least that big without actually running the code, but if the browser can solve that problem faster than running the code then I suppose such a browser deserves to be given an epic victory.) 878793 4 fpizlo 2013-04-20 13:10:28 -0700 Landed in http://trac.webkit.org/changeset/148796 198923 2013-04-19 19:09:24 -0700 2013-04-20 06:50:18 -0700 the patch blah.patch text/plain 1560 fpizlo SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvU3VuU3BpZGVyL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBQZXJmb3JtYW5jZVRlc3RzL1N1blNwaWRlci9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0ODc4NikK KysrIFBlcmZvcm1hbmNlVGVzdHMvU3VuU3BpZGVyL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEyIEBACisyMDEzLTA0LTE5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5j b20+CisKKyAgICAgICAgU3VuU3BpZGVyL3N0cmluZy10YWdjbG91ZCBzaG91bGQgYmUgbW9yZSBs ZW5pZW50IGluIHZhbGlkYXRpbmcgaXRzIHJlc3VsdHMsIHNpbmNlIHRoZXkgZGVwZW5kIG9uIE1h dGgubG9nLCB3aGljaCBpc24ndCBmb3JtYWxseSBzcGVjaWZpZWQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDg5NQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogdGVzdHMvc3Vuc3BpZGVyLTEuMC9zdHJp bmctdGFnY2xvdWQuanM6CisKIDIwMTMtMDQtMTggIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxl LmNvbT4KIAogICAgICAgICBXaGVuZXZlciBpdCBpcyBjaGVhcCBhbmQgbm9uLWludmFzaXZlLCBT dW5TcGlkZXIgdGVzdHMgc2hvdWxkIHZhbGlkYXRlIHRoZWlyIHJlc3VsdHMgdG8gZW5zdXJlIHRo YXQgdGhlIGJyb3dzZXIgcnVucyB0aGVtIGNvcnJlY3RseQpJbmRleDogUGVyZm9ybWFuY2VUZXN0 cy9TdW5TcGlkZXIvdGVzdHMvc3Vuc3BpZGVyLTEuMC9zdHJpbmctdGFnY2xvdWQuanMKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gUGVyZm9ybWFuY2VUZXN0cy9TdW5TcGlkZXIvdGVzdHMvc3Vuc3BpZGVyLTEuMC9z dHJpbmctdGFnY2xvdWQuanMJKHJldmlzaW9uIDE0ODc4NCkKKysrIFBlcmZvcm1hbmNlVGVzdHMv U3VuU3BpZGVyL3Rlc3RzL3N1bnNwaWRlci0xLjAvc3RyaW5nLXRhZ2Nsb3VkLmpzCSh3b3JraW5n IGNvcHkpCkBAIC0yNjMsOSArMjYzLDkgQEAgZnVuY3Rpb24gbWFrZVRhZ0Nsb3VkKHRhZ0luZm8p CiAKIHZhciB0YWdjbG91ZCA9IG1ha2VUYWdDbG91ZCh0YWdJbmZvKTsKIAotdmFyIGV4cGVjdGVk TGVuZ3RoID0gMzE1MjQxOwordmFyIGV4cGVjdGVkTWluTGVuZ3RoID0gMzE1MDAwOwogCi1pZiAo dGFnY2xvdWQubGVuZ3RoICE9IGV4cGVjdGVkTGVuZ3RoKQotICAgIHRocm93ICJFUlJPUjogYmFk IHJlc3VsdDogZXhwZWN0ZWQgbGVuZ3RoICIgKyBleHBlY3RlZExlbmd0aCArICIgYnV0IGdvdCAi ICsgdGFnY2xvdWQubGVuZ3RoOworaWYgKHRhZ2Nsb3VkLmxlbmd0aCA8IGV4cGVjdGVkTWluTGVu Z3RoKQorICAgIHRocm93ICJFUlJPUjogYmFkIHJlc3VsdDogZXhwZWN0ZWQgbGVuZ3RoIGF0IGxl YXN0ICIgKyBleHBlY3RlZE1pbkxlbmd0aCArICIgYnV0IGdvdCAiICsgdGFnY2xvdWQubGVuZ3Ro OwogCiB0YWdJbmZvID0gbnVsbDsK