11489 2006-11-01 14:19:37 -0800 REGRESSION (r13971): Incomplete repaint of flexbox with overflow 2013-07-23 11:31:30 -0700 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 RESOLVED FIXED Regression P2 Normal --- 1 adele webkit-unassigned hamaji mitz robert oldest_to_newest 47498 0 adele 2006-11-01 14:19:37 -0800 Incomplete repaint of flexbox with overflow See http://bugs.webkit.org/show_bug.cgi?id=11277 for more discussion. See attached test case 47499 1 11341 adele 2006-11-01 14:21:09 -0800 Created attachment 11341 test case 16069 2 mitz 2007-03-31 08:35:12 -0700 This seems to be a regression from Safari 2. 998 3 ddkilzer 2007-09-02 20:50:16 -0700 Autospade says: Works: r13968 Fails: r13972 125448 4 31195 hamaji 2009-06-12 01:03:50 -0700 Created attachment 31195 Patch v1 WebCore/ChangeLog | 19 +++++++++++++++++++ WebCore/rendering/RenderBlock.cpp | 10 ++++++++-- WebCore/rendering/bidi.cpp | 2 +- 3 files changed, 28 insertions(+), 3 deletions(-) 125449 5 hamaji 2009-06-12 01:09:48 -0700 This patch depends on the patch I uploaded in https://bugs.webkit.org/show_bug.cgi?id=15135 . So, I don't mark this patch as '?' for now. Once the previous patch is granted, I'll update this patch and ask review. Regarding the layout test for this patch, I couldn't see how to test this with the layout test framework. The test case Adele posted seems to work correctly with DumpRenderTree (maybe it repaints all area before it generates png file?). I'll upload the layout test I wrote. If someone tell me how to make the layout test fail without this patch, I'll fix and add the layout test for my patch. 125450 6 31196 hamaji 2009-06-12 01:12:49 -0700 Created attachment 31196 test case modified to be automated 911100 7 robert 2013-07-23 11:31:30 -0700 The test case works fine now. Please re-open if I'm wrong in thinking that. 11341 2006-11-01 14:21:09 -0800 2006-11-01 14:21:09 -0800 test case textarea-delete.html text/html 834 adele PGh0bWw+CjxoZWFkPgoJPHNjcmlwdCBzcmM9InJlcGFpbnQuanMiIHR5cGU9InRleHQvamF2YXNj cmlwdCI+PC9zY3JpcHQ+Cgk8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CiAgICAgICAg ICAgIGZ1bmN0aW9uIHJlcGFpbnRUZXN0KCkKICAgICAgICAgICAgewogICAgICAgICAgICAgICAg ZHYuZmlyc3RDaGlsZC5kYXRhPSdMb3JlbSBpcHN1JzsKICAgICAgICAgICAgfQoJPC9zY3JpcHQ+ CjwvaGVhZD4KPGJvZHkgb25sb2FkPSJydW5SZXBhaW50VGVzdCgpOyI+CiAgICA8cD4KICAgICAg ICBUaGlzIGlzIGEgcmVwYWludCB0ZXN0IGZvciA8aT48YSBocmVmPSJodHRwOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI3NyI+aHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTE0ODk8L2E+CiAgICAgICAgUkVHUkVTU0lPTjogSW5jb21wbGV0ZSByZXBh aW50IG9mIGZsZXhib3ggd2l0aCBvdmVyZmxvdzwvaT4uCiAgICA8L3A+CiAgICA8aHI+CiAgICA8 YnV0dG9uIG9uY2xpY2s9InJlcGFpbnRUZXN0KCkiPlRlc3QgcmVwYWludCBwcm9ibGVtPC9idXR0 b24+CiAgICA8ZGl2IHN0eWxlPSJkaXNwbGF5OiAtd2Via2l0LWJveDstd2Via2l0LWJveC1vcmll bnQ6IHZlcnRpY2FsOyBoZWlnaHQ6IDM2cHg7Ij4KICAgICAgICA8ZGl2IGNvbnRlbnRlZGl0YWJs ZSBpZD0iZHYiIHN0eWxlPSJvdmVyZmxvdzogaGlkZGVuOyBvdXRsaW5lOiBub25lOyB3aWR0aDog ODBweDsgLXdlYmtpdC1ib3gtZmxleDoxOyI+CiAgICAgICAgICAgIExvcmVtIGlwc3VtCiAgICAg ICAgPC9kaXY+CiAgICA8L2Rpdj4KPC9ib2R5Pgo8L2h0bWw+ 31195 2009-06-12 01:03:50 -0700 2010-06-10 17:35:05 -0700 Patch v1 Patch-v1.patch text/plain 2604 hamaji NTU1MDdiMzBjZjI0YThhMjAyOTc3M2I3OGY1Y2IzY2VjOGEzZTJhOQpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2MjNkZmI3Li5iODA1Y2Y5 IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDIyIEBACisyMDA5LTA2LTEyICBTaGluaWNoaXJvIEhhbWFqaSAgPGhhbWFqaUBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDg5CisgICAg ICAgIEtlZXAgcmVwYWludGluZyByZWN0YW5nbGVzIGR1cmluZyB0aGUgZmlyc3QgYXR0ZW1wdCBh bmQgdGhlIHNlY29uZAorICAgICAgICBhdHRlbXB0IG9mIGxheW91dCBmb3IgYmxvY2tzIGluIGZs ZXhpYmxlIGJveGVzLiAgSW4gdGhpcyB3YXkgd2UKKyAgICAgICAgY2FuIHJlcGFpbnQgdGhlIGJs b2NrcyBpbiBmbGV4aWJsZSBib3hlcyBjb3JyZWN0bHkgZXZlbiB3aGVuIHRoZQorICAgICAgICBz aXplIG9mIGJsb2NrcyBiZWNvbWUgc21hbGxlci4KKworICAgICAgICBOb3QgZWFzaWx5IHRlc3Rh YmxlIGJlY2F1c2UgdGhlIHVuLXVwZGF0ZWQgYXJlYSB3aWxsIGJlIHBhaW50ZWQKKyAgICAgICAg Y29ycmVjdGx5IHdpdGggbGF5b3V0IHRlc3QgZnJhbWV3b3JrLgorCisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlckJsb2NrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpyZXBh aW50QmxvY2tBZnRlckxheW91dCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6bGF5 b3V0QmxvY2spOgorICAgICAgICAqIHJlbmRlcmluZy9iaWRpLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlckJsb2NrOjpsYXlvdXRJbmxpbmVDaGlsZHJlbik6CisKIDIwMDktMDYtMTEgIFNo aW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJsb2NrLmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAppbmRleCA5Mzdj ZjdlLi43MTY3ODViIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5j cHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCkBAIC03NTEsNyArNzUx LDkgQEAgdm9pZCBSZW5kZXJCbG9jazo6cmVwYWludEJsb2NrQWZ0ZXJMYXlvdXQoKQogICAgIH0K ICAgICBzZXROZWVkc0xheW91dChmYWxzZSk7CiAKKyAgICAvLyBSZXNldCByZXBhaW50aW5nIGNv bnRleHRzLgogICAgIGRlbGV0ZSBtX3JlcGFpbnRlcjsKKyAgICBtX3JlcGFpbnRUb3AgPSBtX3Jl cGFpbnRCb3R0b20gPSAtMTsKIH0KIAogdm9pZCBSZW5kZXJCbG9jazo6bGF5b3V0QmxvY2soYm9v bCByZWxheW91dENoaWxkcmVuKQpAQCAtODE5LDggKzgyMSwxMiBAQCB2b2lkIFJlbmRlckJsb2Nr OjpsYXlvdXRCbG9jayhib29sIHJlbGF5b3V0Q2hpbGRyZW4pCiAgICAgICAgICAgICBsYXllcigp LT5zZXRIYXNWZXJ0aWNhbFNjcm9sbGJhcih0cnVlKTsKICAgICB9CiAKLSAgICBtX3JlcGFpbnRU b3AgPSAwOwotICAgIG1fcmVwYWludEJvdHRvbSA9IDA7CisgICAgLy8gRG9uJ3QgaW5pdGlhbGl6 ZSB0aGVzZSB2YWx1ZXMgaWYgdGhpcyBpcyB0aGUgc2Vjb25kIGF0dGVtcHQgb2YKKyAgICAvLyBs YXlvdXQgZm9yIHRoaXMgb2JqZWN0LgorICAgIGlmIChtX3JlcGFpbnRUb3AgPCAwKSB7CisgICAg ICAgIG1fcmVwYWludFRvcCA9IDA7CisgICAgICAgIG1fcmVwYWludEJvdHRvbSA9IDA7CisgICAg fQogICAgIGludCBtYXhGbG9hdEJvdHRvbSA9IDA7CiAgICAgaWYgKGNoaWxkcmVuSW5saW5lKCkp CiAgICAgICAgIGxheW91dElubGluZUNoaWxkcmVuKHJlbGF5b3V0Q2hpbGRyZW4sIG1fcmVwYWlu dFRvcCwgbV9yZXBhaW50Qm90dG9tKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL2Jp ZGkuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvYmlkaS5jcHAKaW5kZXggMzY1OTkxMi4uNDYxNDQ0 ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvYmlkaS5jcHAKKysrIGIvV2ViQ29yZS9y ZW5kZXJpbmcvYmlkaS5jcHAKQEAgLTkwOCw3ICs5MDgsNyBAQCB2b2lkIFJlbmRlckJsb2NrOjps YXlvdXRJbmxpbmVDaGlsZHJlbihib29sIHJlbGF5b3V0Q2hpbGRyZW4sIGludCYgcmVwYWludFRv cCwgaQogICAgICAgICBpZiAoc3RhcnRMaW5lKSB7CiAgICAgICAgICAgICB1c2VSZXBhaW50Qm91 bmRzID0gdHJ1ZTsKICAgICAgICAgICAgIHJlcGFpbnRUb3AgPSBoZWlnaHQoKTsKLSAgICAgICAg ICAgIHJlcGFpbnRCb3R0b20gPSBoZWlnaHQoKTsKKyAgICAgICAgICAgIHJlcGFpbnRCb3R0b20g PSBtYXgocmVwYWludEJvdHRvbSwgaGVpZ2h0KCkpOwogICAgICAgICAgICAgUmVuZGVyQXJlbmEq IGFyZW5hID0gcmVuZGVyQXJlbmEoKTsKICAgICAgICAgICAgIFJvb3RJbmxpbmVCb3gqIGJveCA9 IHN0YXJ0TGluZTsKICAgICAgICAgICAgIHdoaWxlIChib3gpIHsK 31196 2009-06-12 01:12:49 -0700 2009-06-12 01:12:49 -0700 test case modified to be automated repaint-clip.html text/html 656 hamaji PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgo8aHRtbD4KPGhl YWQ+CjxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KaWYgKHdpbmRvdy5sYXlvdXRUZXN0 Q29udHJvbGxlcikgewogIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKfQoK ZnVuY3Rpb24gcmVwYWludCgpIHsKICB2YXIgZWxlbWVudCA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJkaXYiKTsKICBlbGVtZW50Lmxhc3RDaGlsZC5kYXRhPSdMb3JlbSBpcHN1JzsKICBpZiAo d2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CiAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5u b3RpZnlEb25lKCk7CiAgfQp9Cjwvc2NyaXB0Pgo8L2hlYWQ+Cjxib2R5IG9ubG9hZD0ic2V0VGlt ZW91dCgncmVwYWludCgpJywgMCkiPgo8ZGl2IHN0eWxlPSJkaXNwbGF5OiAtd2Via2l0LWJveDst d2Via2l0LWJveC1vcmllbnQ6IHZlcnRpY2FsOyBoZWlnaHQ6IDM2cHg7Ij4KICA8ZGl2IGNvbnRl bnRlZGl0YWJsZSBpZD0iZGl2IiBzdHlsZT0ib3ZlcmZsb3c6IGhpZGRlbjsgb3V0bGluZTogbm9u ZTsgd2lkdGg6IDgwcHg7IC13ZWJraXQtYm94LWZsZXg6MTsiPgogICAgTG9yZW0gaXBzdW0KICA8 L2Rpdj4KPC9kaXY+CjwvYm9keT4KPC9odG1sPgo=