114888 2013-04-19 13:37:01 -0700 Web Inspector: Support the SourceMap header, X-SourceMap was deprecated 2013-04-19 16:00:51 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned graouts joepeck timothy oldest_to_newest 878632 0 joepeck 2013-04-19 13:37:01 -0700 The SourceMap spec mentions that X-SourceMap was deprecated, we should support the expected header: <https://docs.google.com/document/d/1U1RGAehQwRypUTovF1KRlpiOFze0b-_2gc6fAH0KY0k/edit> > The HTTP header should supply the source map URL reference as: > > SourceMap: <url> > > Note: previous revisions of this document recommended a header name of “X-SourceMap”. This is now deprecated; “SourceMap” is now expected. 878637 1 198914 joepeck 2013-04-19 13:53:04 -0700 Created attachment 198914 [PATCH] Proposed Fix 878665 2 joepeck 2013-04-19 16:00:51 -0700 Committed r148769: <http://trac.webkit.org/changeset/148769> 198914 2013-04-19 13:53:04 -0700 2013-04-19 13:57:09 -0700 [PATCH] Proposed Fix header-1.patch text/plain 3692 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjOTFkZTFmLi5kODRhNzhjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEg QEAKIDIwMTMtMDQtMTkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBTdXBwb3J0IHRoZSBTb3VyY2VNYXAgaGVhZGVyLCBYLVNv dXJjZU1hcCB3YXMgZGVwcmVjYXRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTE0ODg4CisKKyAgICAgICAgQ2hlY2sgZmlyc3QgZm9yIFNvdXJjZU1h cCwgdGhlbiBmYWxsYmFjayB0byBYLVNvdXJjZU1hcC4gTGVhdmluZyBpbgorICAgICAgICBzdXBw b3J0IGZvciB0aGUgZGVwcmVjYXRlZCBoZWFkZXIgYmVjYXVzZSBtb3N0IHRvb2xzIGFuZCBhcnRp Y2xlcworICAgICAgICBvbmxpbmUgbWVudGlvbiB0aGF0IHZlcnNpb24gYW5kIGhhdmUgbm90IHll dCB1cGRhdGVkLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogaW5zcGVjdG9yL0luc3BlY3RvckRlYnVnZ2VyQWdlbnQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SW5zcGVjdG9yRGVidWdnZXJBZ2VudDo6c291cmNlTWFwVVJMRm9yU2NyaXB0KToKKyAg ICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yUGFnZUFnZW50LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Okluc3BlY3RvclBhZ2VBZ2VudDo6c291cmNlTWFwVVJMRm9yUmVzb3VyY2UpOgorCisyMDEz LTA0LTE5ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAg V2ViIEluc3BlY3RvcjogQmFja2VuZCBzaG91bGQgZGV0ZWN0IHNvdXJjZU1hcHBpbmdVUkxzIGlu IENTUyBSZXNvdXJjZXMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExNDg1NAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yRGVidWdnZXJBZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yRGVidWdnZXJBZ2VudC5jcHAKaW5kZXggYWUwODMwNy4uNThlZWY3NSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRlYnVnZ2VyQWdlbnQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50LmNwcApAQCAt NjMyLDcgKzYzMiw4IEBAIFBhc3NSZWZQdHI8QXJyYXk8VHlwZUJ1aWxkZXI6OkRlYnVnZ2VyOjpD YWxsRnJhbWU+ID4gSW5zcGVjdG9yRGVidWdnZXJBZ2VudDo6Y3VyCiAKIFN0cmluZyBJbnNwZWN0 b3JEZWJ1Z2dlckFnZW50Ojpzb3VyY2VNYXBVUkxGb3JTY3JpcHQoY29uc3QgU2NyaXB0JiBzY3Jp cHQpCiB7Ci0gICAgREVGSU5FX1NUQVRJQ19MT0NBTChTdHJpbmcsIHNvdXJjZU1hcEhUVFBIZWFk ZXIsIChBU0NJSUxpdGVyYWwoIlgtU291cmNlTWFwIikpKTsKKyAgICBERUZJTkVfU1RBVElDX0xP Q0FMKFN0cmluZywgc291cmNlTWFwSFRUUEhlYWRlciwgKEFTQ0lJTGl0ZXJhbCgiU291cmNlTWFw IikpKTsKKyAgICBERUZJTkVfU1RBVElDX0xPQ0FMKFN0cmluZywgc291cmNlTWFwSFRUUEhlYWRl ckRlcHJlY2F0ZWQsIChBU0NJSUxpdGVyYWwoIlgtU291cmNlTWFwIikpKTsKIAogICAgIGlmICgh c2NyaXB0LnVybC5pc0VtcHR5KCkpIHsKICAgICAgICAgaWYgKEluc3BlY3RvclBhZ2VBZ2VudCog cGFnZUFnZW50ID0gbV9pbnN0cnVtZW50aW5nQWdlbnRzLT5pbnNwZWN0b3JQYWdlQWdlbnQoKSkg ewpAQCAtNjQxLDYgKzY0MiwxMCBAQCBTdHJpbmcgSW5zcGVjdG9yRGVidWdnZXJBZ2VudDo6c291 cmNlTWFwVVJMRm9yU2NyaXB0KGNvbnN0IFNjcmlwdCYgc2NyaXB0KQogICAgICAgICAgICAgICAg IFN0cmluZyBzb3VyY2VNYXBIZWFkZXIgPSByZXNvdXJjZS0+cmVzcG9uc2UoKS5odHRwSGVhZGVy RmllbGQoc291cmNlTWFwSFRUUEhlYWRlcik7CiAgICAgICAgICAgICAgICAgaWYgKCFzb3VyY2VN YXBIZWFkZXIuaXNFbXB0eSgpKQogICAgICAgICAgICAgICAgICAgICByZXR1cm4gc291cmNlTWFw SGVhZGVyOworCisgICAgICAgICAgICAgICAgc291cmNlTWFwSGVhZGVyID0gcmVzb3VyY2UtPnJl c3BvbnNlKCkuaHR0cEhlYWRlckZpZWxkKHNvdXJjZU1hcEhUVFBIZWFkZXJEZXByZWNhdGVkKTsK KyAgICAgICAgICAgICAgICBpZiAoIXNvdXJjZU1hcEhlYWRlci5pc0VtcHR5KCkpCisgICAgICAg ICAgICAgICAgICAgIHJldHVybiBzb3VyY2VNYXBIZWFkZXI7ICAgICAgICAgICAgICAgIAogICAg ICAgICAgICAgfQogICAgICAgICB9CiAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL0luc3BlY3RvclBhZ2VBZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvSW5zcGVjdG9yUGFnZUFnZW50LmNwcAppbmRleCAxYzdhOTgwLi4wZDgwNTkwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUGFnZUFnZW50LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUGFnZUFnZW50LmNwcApAQCAtMjcw LDcgKzI3MCw4IEBAIHZvaWQgSW5zcGVjdG9yUGFnZUFnZW50OjpyZXNvdXJjZUNvbnRlbnQoRXJy b3JTdHJpbmcqIGVycm9yU3RyaW5nLCBGcmFtZSogZnJhbWUsCiAvL3N0YXRpYwogU3RyaW5nIElu c3BlY3RvclBhZ2VBZ2VudDo6c291cmNlTWFwVVJMRm9yUmVzb3VyY2UoQ2FjaGVkUmVzb3VyY2Uq IGNhY2hlZFJlc291cmNlKQogewotICAgIERFRklORV9TVEFUSUNfTE9DQUwoU3RyaW5nLCBzb3Vy Y2VNYXBIVFRQSGVhZGVyLCAoQVNDSUlMaXRlcmFsKCJYLVNvdXJjZU1hcCIpKSk7CisgICAgREVG SU5FX1NUQVRJQ19MT0NBTChTdHJpbmcsIHNvdXJjZU1hcEhUVFBIZWFkZXIsIChBU0NJSUxpdGVy YWwoIlNvdXJjZU1hcCIpKSk7CisgICAgREVGSU5FX1NUQVRJQ19MT0NBTChTdHJpbmcsIHNvdXJj ZU1hcEhUVFBIZWFkZXJEZXByZWNhdGVkLCAoQVNDSUlMaXRlcmFsKCJYLVNvdXJjZU1hcCIpKSk7 CiAKICAgICBpZiAoIWNhY2hlZFJlc291cmNlKQogICAgICAgICByZXR1cm4gU3RyaW5nKCk7CkBA IC0yODMsNiArMjg0LDEwIEBAIFN0cmluZyBJbnNwZWN0b3JQYWdlQWdlbnQ6OnNvdXJjZU1hcFVS TEZvclJlc291cmNlKENhY2hlZFJlc291cmNlKiBjYWNoZWRSZXNvdXJjCiAgICAgaWYgKCFzb3Vy Y2VNYXBIZWFkZXIuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm4gc291cmNlTWFwSGVhZGVyOwog CisgICAgc291cmNlTWFwSGVhZGVyID0gY2FjaGVkUmVzb3VyY2UtPnJlc3BvbnNlKCkuaHR0cEhl YWRlckZpZWxkKHNvdXJjZU1hcEhUVFBIZWFkZXJEZXByZWNhdGVkKTsKKyAgICBpZiAoIXNvdXJj ZU1hcEhlYWRlci5pc0VtcHR5KCkpCisgICAgICAgIHJldHVybiBzb3VyY2VNYXBIZWFkZXI7CisK ICAgICBTdHJpbmcgY29udGVudDsKICAgICBib29sIGJhc2U2NEVuY29kZWQ7CiAgICAgaWYgKElu c3BlY3RvclBhZ2VBZ2VudDo6Y2FjaGVkUmVzb3VyY2VDb250ZW50KGNhY2hlZFJlc291cmNlLCAm Y29udGVudCwgJmJhc2U2NEVuY29kZWQpICYmICFiYXNlNjRFbmNvZGVkKQo=