114880 2013-04-19 10:35:27 -0700 [Qt4] QtWebKit 2.3.1 broke compilation on MSVC 2013-04-23 19:33:43 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Major --- 88186 1 b.brachaczek allan.jensen allan.jensen bobber.cheng oldest_to_newest 878562 0 b.brachaczek 2013-04-19 10:35:27 -0700 I compile QtWebKit 2.3 on MSVC 2012 32-bit. Commit 7349c1125423555d908d89a0fd1548cf5cee2de3 in QtWebKit 2.3.1 broke compilation for me, reverting it locally fixes the problem. Tail of compilation output: "C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\BIN\nmake.exe" -f Makefile.QtWebKit.api Microsoft (R) Program Maintenance Utility Version 11.00.60315.1 Copyright (C) Microsoft Corporation. All rights reserved. Project MESSAGE: Running perl C:\Users\beevvy\build\qtwebkit-23\Tools\qmake\syncqt-4.8 -windows -outdir C:\Users\beevvy\build\qtwebkit-23\WebKitBuild\Release -separate-module QtWebKit;C:\Users\beevvy\build\qtwebkit-23\Source;WebKit\qt\Api (set QMAKEPATH=C:\Users\beevvy\build\qtwebkit-23\Tools\qmake) && c:\Users\beevvy\build\qt\bin\qmake.exe CONFIG+=production_build CONFIG+=no_webkit2 CONFIG+=no_force_sse2 DEFINES+=ENABLE_3D_RENDERING=0 DEFINES+=ENABLE_ACCELERATED_2D_CANVAS=0 DEFINES+=ENABLE_ANIMATION_API=0 DEFINES+=ENABLE_BATTERY_STATUS=0 DEFINES+=ENABLE_BLOB=0 DEFINES+=ENABLE_CHANNEL_MESSAGING=0 DEFINES+=ENABLE_CSP_NEXT=0 DEFINES+=ENABLE_CSS_DEVICE_ADAPTATION=0 DEFINES+=ENABLE_CSS_EXCLUSIONS=0 DEFINES+=ENABLE_CSS_FILTERS=0 DEFINES+=ENABLE_CSS3_BACKGROUND=0 DEFINES+=ENABLE_CSS3_CONDITIONAL_RULES=0 DEFINES+=ENABLE_CSS3_TEXT=0 DEFINES+=ENABLE_CSS_BOX_DECORATION_BREAK=0 DEFINES+=ENABLE_CSS_IMAGE_ORIENTATION=0 DEFINES+=ENABLE_CSS_IMAGE_RESOLUTION=0 DEFINES+=ENABLE_CSS_REGIONS=0 DEFINES+=ENABLE_CSS_SHADERS=0 DEFINES+=ENABLE_CSS_COMPOSITING=0 DEFINES+=ENABLE_CSS_VARIABLES=0 DEFINES+=ENABLE_CUSTOM_SCHEME_HANDLER=0 DEFINES+=ENABLE_DATALIST_ELEMENT=0 DEFINES+=ENABLE_DATA_TRANSFER_ITEMS=0 DEFINES+=ENABLE_DETAILS_ELEMENT=0 DEFINES+=ENABLE_DEVICE_ORIENTATION=0 DEFINES+=ENABLE_DIALOG_ELEMENT=0 DEFINES+=ENABLE_DIRECTORY_UPLOAD=0 DEFINES+=ENABLE_DOWNLOAD_ATTRIBUTE=0 DEFINES+=ENABLE_FILE_SYSTEM=0 DEFINES+=ENABLE_FILTERS=0 DEFINES+=ENABLE_FTPDIR=0 DEFINES+=ENABLE_FULLSCREEN_API=0 DEFINES+=ENABLE_GAMEPAD=0 DEFINES+=ENABLE_GEOLOCATION=0 DEFINES+=ENABLE_HIGH_DPI_CANVAS=0 DEFINES+=ENABLE_ICONDATABASE=0 DEFINES+=ENABLE_IFRAME_SEAMLESS=0 DEFINES+=ENABLE_INDEXED_DATABASE=0 DEFINES+=ENABLE_INPUT_SPEECH=0 DEFINES+=ENABLE_INPUT_TYPE_COLOR=0 DEFINES+=ENABLE_INPUT_TYPE_DATE=0 DEFINES+=ENABLE_INPUT_TYPE_DATETIME=0 DEFINES+=ENABLE_INPUT_TYPE_DATETIMELOCAL=0 DEFINES+=ENABLE_INPUT_TYPE_MONTH=0 DEFINES+=ENABLE_INPUT_TYPE_TIME=0 DEFINES+=ENABLE_INPUT_TYPE_WEEK=0 DEFINES+=ENABLE_INSPECTOR=0 DEFINES+=ENABLE_JAVASCRIPT_DEBUGGER=0 DEFINES+=ENABLE_LEGACY_NOTIFICATIONS=0 DEFINES+=ENABLE_LEGACY_VENDOR_PREFIXES=0 DEFINES+=ENABLE_LEGACY_WEB_AUDIO=0 DEFINES+=ENABLE_LINK_PREFETCH=0 DEFINES+=ENABLE_LINK_PRERENDER=0 DEFINES+=ENABLE_MATHML=0 DEFINES+=ENABLE_MEDIA_CAPTURE=0 DEFINES+=ENABLE_MEDIA_SOURCE=0 DEFINES+=ENABLE_MEDIA_STATISTICS=0 DEFINES+=ENABLE_MEDIA_STREAM=0 DEFINES+=ENABLE_METER_ELEMENT=0 DEFINES+=ENABLE_MHTML=0 DEFINES+=ENABLE_MICRODATA=0 DEFINES+=ENABLE_MUTATION_OBSERVERS=0 DEFINES+=ENABLE_NAVIGATOR_CONTENT_UTILS=0 DEFINES+=ENABLE_NETSCAPE_PLUGIN_API=1 DEFINES+=ENABLE_NETWORK_INFO=0 DEFINES+=ENABLE_NOTIFICATIONS=0 DEFINES+=ENABLE_ORIENTATION_EVENTS=0 DEFINES+=ENABLE_PAGE_VISIBILITY_API=0 DEFINES+=ENABLE_PROGRESS_ELEMENT=0 DEFINES+=ENABLE_PROXIMITY_EVENTS=0 DEFINES+=ENABLE_QUOTA=0 DEFINES+=ENABLE_RESOLUTION_MEDIA_QUERY=0 DEFINES+=ENABLE_REQUEST_ANIMATION_FRAME=0 DEFINES+=ENABLE_SCRIPTED_SPEECH=0 DEFINES+=ENABLE_SHADOW_DOM=0 DEFINES+=ENABLE_SHARED_WORKERS=0 DEFINES+=ENABLE_SQL_DATABASE=0 DEFINES+=ENABLE_STYLE_SCOPED=0 DEFINES+=ENABLE_SVG=0 DEFINES+=ENABLE_SVG_DOM_OBJC_BINDINGS=0 DEFINES+=ENABLE_SVG_FONTS=0 DEFINES+=USE_SYSTEM_MALLOC=0 DEFINES+=ENABLE_TEMPLATE_ELEMENT=0 DEFINES+=ENABLE_TEXT_AUTOSIZING=0 DEFINES+=WTF_USE_TILED_BACKING_STORE=0 DEFINES+=ENABLE_TOUCH_EVENTS=0 DEFINES+=ENABLE_TOUCH_SLIDER=0 DEFINES+=ENABLE_TOUCH_ICON_LOADING=0 DEFINES+=ENABLE_VIBRATION=0 DEFINES+=ENABLE_VIDEO=0 DEFINES+=ENABLE_VIDEO_TRACK=0 DEFINES+=ENABLE_WEBGL=0 DEFINES+=ENABLE_WEB_AUDIO=0 DEFINES+=ENABLE_WEB_INTENTS=0 DEFINES+=ENABLE_WEB_INTENTS_TAG=0 DEFINES+=ENABLE_WEB_SOCKETS=0 DEFINES+=ENABLE_WEB_TIMING=0 DEFINES+=ENABLE_WORKERS=0 DEFINES+=ENABLE_XHR_RESPONSE_BLOB=0 DEFINES+=ENABLE_XHR_TIMEOUT=0 DEFINES+=ENABLE_XSLT=0 CONFIG+=release CONFIG-=debug CONFIG+=production_build -o Makefile.QtWebKit.api c:\Users\beevvy\build\qtwebkit-23\Source\api.pri WARNING: Failure to find: \InspectorBackendCommands.qrc WARNING: Failure to find: \InspectorBackendCommands.qrc c:\Users\beevvy\build\qt\bin\rcc.exe: File does not exist '\InspectorBackendCommands.qrc' c:\Users\beevvy\build\qt\bin\rcc.exe: File does not exist '\InspectorBackendCommands.qrc' "C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\BIN\nmake.exe" -f Makefile.QtWebKit.api.Release Microsoft (R) Program Maintenance Utility Version 11.00.60315.1 Copyright (C) Microsoft Corporation. All rights reserved. python C:/Users/beevvy/build/qtwebkit-23\Tools\Scripts\generate-win32-export-forwards C:\Users\beevvy\build\qtwebkit-23\WebKitBuild\Release/Source/WebKit/release\WebKit1.lib C:\Users\beevvy\build\qtwebkit-23\WebKitBuild\Release/Source/WebCore/release\WebCore.lib C:\Users\beevvy\build\qtwebkit-23\WebKitBuild\Release/Source/JavaScriptCore/release\JavaScriptCore.lib C:\Users\beevvy\build\qtwebkit-23\WebKitBuild\Release/Source/WTF/release\WTF.lib forwarded-exports.cpp Forwarding 812 symbols from C:\Users\beevvy\build\qtwebkit-23\WebKitBuild\Release/Source/WebKit/release\WebKit1.lib C:\Users\beevvy\build\qtwebkit-23\WebKitBuild\Release/Source/WebCore/release\WebCore.lib C:\Users\beevvy\build\qtwebkit-23\WebKitBuild\Release/Source/JavaScriptCore/release\JavaScriptCore.lib C:\Users\beevvy\build\qtwebkit-23\WebKitBuild\Release/Source/WTF/release\WTF.lib NMAKE : fatal error U1073: don't know how to make '\InspectorBackendCommands.qrc' Stop. NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\BIN\nmake.exe"' : return code '0x2' Stop. NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\BIN\nmake.exe"' : return code '0x2' Stop. NMAKE : fatal error U1077: 'cd' : return code '0x2' Stop. 879045 1 allan.jensen 2013-04-22 02:37:11 -0700 Looks like $${WEBCORE_GENERATED_SOURCES_DIR} is not defined in api.pri, so it probably need to include WebCore.pri somehow. 879156 2 199031 allan.jensen 2013-04-22 08:18:11 -0700 Created attachment 199031 Patch This should hopefully fix it. 879669 3 allan.jensen 2013-04-23 01:21:27 -0700 Pushed to qtwebkit-2.3-staging. If you confirm it solves the issue, I will push it to the release branch as well, in any case it should be part of 2.3.2. 879673 4 bobber.cheng 2013-04-23 01:28:32 -0700 Please use $${ROOT_BUILD_DIR}/Source/WebCore/$${GENERATED_SOURCES_DESTDIR}/InspectorBackendCommands.qrc in Source/api.pri here. WEBCORE_GENERATED_SOURCES_DIR is defined in WebCore.pri that's not included by Source/api.pri. 880297 5 b.brachaczek 2013-04-23 19:33:43 -0700 (In reply to comment #3) Yes, it fixes the issue. Thanks! 199031 2013-04-22 08:18:11 -0700 2013-04-22 08:18:11 -0700 Patch Patch text/plain 1308 allan.jensen ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzOTQzZjRkLi5jOTNhYTM3 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTMtMDQtMjIgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5j b20+CisKKyAgICAgICAgW1F0NF0gUXRXZWJLaXQgMi4zLjEgYnJva2UgY29tcGlsYXRpb24gb24g TVNWQworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0 ODgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2lu Y2Ugd2UgZG8gbm90IGxvYWQgd2Via2l0X21vZHVsZXMgdGhlIHNhbWUgd2F5IGFzIHRydW5rLCB3 ZSBuZWVkIHRvCisgICAgICAgIGRlZmluZSBXRUJDT1JFX0dFTkVSQVRFRF9TT1VSQ0VTX0RJUiBv dXJzZWx2ZXMKKworICAgICAgICAqIFNvdXJjZS9hcGkucHJpOgorCiAyMDEzLTAyLTA1ICBKb2Nl bHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBkaWdpYS5jb20+CiAKICAgICAgICAgW1F0 XSBSRUdSRVNTSU9OKHIxMzc0MzYpOiBJdCBtYWRlIGFsbCBpbnNwZWN0b3IgdGVzdHMgdGltZW91 dCBvbiBkZXZlbG9wZXIgYnVpbGRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvYXBpLnByaSBiL1NvdXJj ZS9hcGkucHJpCmluZGV4IDJjMzAyODMuLmY5ZDZmYmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9hcGku cHJpCisrKyBiL1NvdXJjZS9hcGkucHJpCkBAIC0xMDQsOCArMTA0LDcgQEAgUU1BS0VfRE9DUyA9 ICQkUFdEL3F0d2Via2l0LnFkb2Njb25mCiB3aW4qIHsKICAgICBSRVNPVVJDRVMgKz0gJCRQV0Qv V2ViQ29yZS9XZWJDb3JlLnFyYwogICAgIGluY2x1ZGVfd2ViaW5zcGVjdG9yIHsKLSAgICAgICAg IyBXRUJDT1JFX0dFTkVSQVRFRF9TT1VSQ0VTX0RJUiBpcyBkZWZpbmVkIGluIFdlYkNvcmUucHJp LCBpbmNsdWRlZCBieQotICAgICAgICAjIGxvYWQod2Via2l0X21vZHVsZXMpIGlmIFdFQktJVCBj b250YWlucyB3ZWJjb3JlLgorICAgICAgICBXRUJDT1JFX0dFTkVSQVRFRF9TT1VSQ0VTX0RJUiA9 ICQke1JPT1RfQlVJTERfRElSfS9Tb3VyY2UvV2ViQ29yZS8kJHtHRU5FUkFURURfU09VUkNFU19E RVNURElSfQogICAgICAgICBSRVNPVVJDRVMgKz0gXAogICAgICAgICAgICAgJCRQV0QvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1dlYktpdC5xcmMgXAogICAgICAgICAgICAgJCR7V0VCQ09S RV9HRU5FUkFURURfU09VUkNFU19ESVJ9L0luc3BlY3RvckJhY2tlbmRDb21tYW5kcy5xcmMK