114861 2013-04-19 02:24:30 -0700 [BlackBerry] Add dummy implementations of DragData::droppedFileSystemId() 2013-04-22 02:57:25 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111729 0 berto webkit-unassigned cgarcia commit-queue mifenton rwlbuis tonikitoo oldest_to_newest 878327 0 berto 2013-04-19 02:24:30 -0700 AccessibilityController::accessibleElementById() is needed since r129308, DragData::droppedFileSystemId() appeared in r120667 878329 1 198828 berto 2013-04-19 02:26:54 -0700 Created attachment 198828 Patch 878997 2 198828 cgarcia 2013-04-22 00:49:09 -0700 Comment on attachment 198828 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198828&action=review > Source/WebCore/platform/blackberry/DragDataBlackBerry.cpp:99 > +String DragData::droppedFileSystemId() const > +{ > + notImplemented(); > + return String(); > +} This should be inside a #if ENABLE(FILE_SYSTEM) block. 879008 3 berto 2013-04-22 01:30:11 -0700 Ok, I'll also split the patch in two. 879012 4 198999 berto 2013-04-22 01:35:54 -0700 Created attachment 198999 Patch 879050 5 198999 commit-queue 2013-04-22 02:57:23 -0700 Comment on attachment 198999 Patch Clearing flags on attachment: 198999 Committed r148870: <http://trac.webkit.org/changeset/148870> 879051 6 commit-queue 2013-04-22 02:57:25 -0700 All reviewed patches have been landed. Closing bug. 198828 2013-04-19 02:26:54 -0700 2013-04-22 01:35:54 -0700 Patch 114861.diff text/plain 2489 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1OGYxZDBiLi4xYzQ2NDg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDQtMTkgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtCbGFja0JlcnJ5XSBBZGQgZHVtbXkgaW1wbGVtZW50YXRpb25zIG9mIHNvbWUgbWV0 aG9kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0 ODYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRHJh Z0RhdGE6OmRyb3BwZWRGaWxlU3lzdGVtSWQoKSB3YXMgYWRkZWQgaW4gcjEyMDY2Ny4KKworICAg ICAgICAqIHBsYXRmb3JtL2JsYWNrYmVycnkvRHJhZ0RhdGFCbGFja0JlcnJ5LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkRyYWdEYXRhOjpkcm9wcGVkRmlsZVN5c3RlbUlkKToKKyAgICAgICAgKFdl YkNvcmUpOgorCiAyMDEzLTA0LTE5ICBEYW4gQmVhbSAgPGRiZWFtQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZW1vdmUgdW5tYWludGFpbmVkIGZlYXR1cmUgUkVRVUVTVF9BVVRPQ09NUExFVEUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvRHJhZ0RhdGFC bGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvRHJhZ0Rh dGFCbGFja0JlcnJ5LmNwcAppbmRleCBkYTUxMzkxLi41MzBhY2MzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L0RyYWdEYXRhQmxhY2tCZXJyeS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxhY2tiZXJyeS9EcmFnRGF0YUJsYWNrQmVycnku Y3BwCkBAIC05Miw0ICs5MiwxMCBAQCBQYXNzUmVmUHRyPERvY3VtZW50RnJhZ21lbnQ+IERyYWdE YXRhOjphc0ZyYWdtZW50KEZyYW1lKiwgUGFzc1JlZlB0cjxSYW5nZT4sIGJvbwogICAgIHJldHVy biAwOwogfQogCitTdHJpbmcgRHJhZ0RhdGE6OmRyb3BwZWRGaWxlU3lzdGVtSWQoKSBjb25zdAor eworICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgcmV0dXJuIFN0cmluZygpOworfQorCiB9IC8v IG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9D aGFuZ2VMb2cKaW5kZXggOTZiZmE2Yy4uNGNkY2IwZiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdl TG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA0LTE5ICBB bGJlcnRvIEdhcmNpYSAgPGFnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJy eV0gQWRkIGR1bW15IGltcGxlbWVudGF0aW9ucyBvZiBzb21lIG1ldGhvZHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDg2MQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFjY2Vzc2liaWxpdHlDb250cm9s bGVyOjphY2Nlc3NpYmxlRWxlbWVudEJ5SWQoKSB3YXMgYWRkZWQgaW4KKyAgICAgICAgcjEyOTMw OC4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2JsYWNrYmVycnkvQWNjZXNzaWJpbGl0eUNv bnRyb2xsZXJCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKEFjY2Vzc2liaWxpdHlDb250cm9sbGVy OjphY2Nlc3NpYmxlRWxlbWVudEJ5SWQpOgorCiAyMDEzLTA0LTE5ICBaYW4gRG9iZXJzZWsgIDx6 ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBbRGFzaGJvYXJkXSBSZW1vdmUgdGhlIGlz VG9UV2ViS2l0IG1lbWJlciB2YXJpYWJsZSBmcm9tIHRoZSBCdWlsZGVyR3JvdXAgaW50ZXJmYWNl CmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ibGFja2JlcnJ5L0FjY2Vzc2liaWxp dHlDb250cm9sbGVyQmxhY2tCZXJyeS5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ibGFja2Jl cnJ5L0FjY2Vzc2liaWxpdHlDb250cm9sbGVyQmxhY2tCZXJyeS5jcHAKaW5kZXggY2RhYzE0Zi4u NWI2YjY5OSAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvYmxhY2tiZXJyeS9BY2Nl c3NpYmlsaXR5Q29udHJvbGxlckJsYWNrQmVycnkuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL2JsYWNrYmVycnkvQWNjZXNzaWJpbGl0eUNvbnRyb2xsZXJCbGFja0JlcnJ5LmNwcApAQCAt NzcsMyArNzcsOCBAQCB2b2lkIEFjY2Vzc2liaWxpdHlDb250cm9sbGVyOjpyZW1vdmVOb3RpZmlj YXRpb25MaXN0ZW5lcigpCiB7CiB9CiAKK0FjY2Vzc2liaWxpdHlVSUVsZW1lbnQgQWNjZXNzaWJp bGl0eUNvbnRyb2xsZXI6OmFjY2Vzc2libGVFbGVtZW50QnlJZChKU1N0cmluZ1JlZikKK3sKKyAg ICBub3RJbXBsZW1lbnRlZCgpOworICAgIHJldHVybiAwOworfQo= 198999 2013-04-22 01:35:54 -0700 2013-04-22 02:57:22 -0700 Patch 114861.diff text/plain 1238 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhMTFhMDA2Li41YTYyYjVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTMtMDQtMjIgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtCbGFja0JlcnJ5XSBBZGQgZHVtbXkgaW1wbGVtZW50YXRpb25zIG9mIERyYWdEYXRh Ojpkcm9wcGVkRmlsZVN5c3RlbUlkKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExNDg2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogcGxhdGZvcm0vYmxhY2tiZXJyeS9EcmFnRGF0YUJsYWNrQmVycnku Y3BwOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpEcmFnRGF0YTo6ZHJv cHBlZEZpbGVTeXN0ZW1JZCk6CisKIDIwMTMtMDQtMjEgIERpcmsgU2NodWx6ZSAgPGtyaXRAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBbUGFydCA0XSBQYXJzZSB0aGUgY3VzdG9tKCkgZnVuY3Rpb24g aW4gLXdlYmtpdC1maWx0ZXI6IHBhcnNlIHRoZSBtYXROKCkgZnVuY3Rpb25zCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L0RyYWdEYXRhQmxhY2tCZXJyeS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L0RyYWdEYXRhQmxhY2tCZXJy eS5jcHAKaW5kZXggZGE1MTM5MS4uYmZlNmMyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vYmxhY2tiZXJyeS9EcmFnRGF0YUJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvRHJhZ0RhdGFCbGFja0JlcnJ5LmNwcApAQCAtOTIs NCArOTIsMTIgQEAgUGFzc1JlZlB0cjxEb2N1bWVudEZyYWdtZW50PiBEcmFnRGF0YTo6YXNGcmFn bWVudChGcmFtZSosIFBhc3NSZWZQdHI8UmFuZ2U+LCBib28KICAgICByZXR1cm4gMDsKIH0KIAor I2lmIEVOQUJMRShGSUxFX1NZU1RFTSkKK1N0cmluZyBEcmFnRGF0YTo6ZHJvcHBlZEZpbGVTeXN0 ZW1JZCgpIGNvbnN0Cit7CisgICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICByZXR1cm4gU3RyaW5n KCk7Cit9CisjZW5kaWYKKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=