<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>114845</bug_id>
          
          <creation_ts>2013-04-18 19:33:51 -0700</creation_ts>
          <short_desc>Rename JSStringJoiner::build() to join()</short_desc>
          <delta_ts>2013-04-19 14:01:05 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Benjamin Poulain">benjamin</reporter>
          <assigned_to name="Benjamin Poulain">benjamin</assigned_to>
          <cc>ggaren</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>878189</commentid>
    <comment_count>0</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2013-04-18 19:33:51 -0700</bug_when>
    <thetext>Rename JSStringJoiner::build() to join()</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>878190</commentid>
    <comment_count>1</comment_count>
      <attachid>198789</attachid>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2013-04-18 19:34:47 -0700</bug_when>
    <thetext>Created attachment 198789
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>878229</commentid>
    <comment_count>2</comment_count>
      <attachid>198789</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2013-04-18 22:15:37 -0700</bug_when>
    <thetext>Comment on attachment 198789
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>878641</commentid>
    <comment_count>3</comment_count>
      <attachid>198789</attachid>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2013-04-19 14:01:02 -0700</bug_when>
    <thetext>Comment on attachment 198789
Patch

Clearing flags on attachment: 198789

Committed r148767: &lt;http://trac.webkit.org/changeset/148767&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>878642</commentid>
    <comment_count>4</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2013-04-19 14:01:05 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>198789</attachid>
            <date>2013-04-18 19:34:47 -0700</date>
            <delta_ts>2013-04-19 14:01:02 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-114845-20130418193417.patch</filename>
            <type>text/plain</type>
            <size>4149</size>
            <attacher name="Benjamin Poulain">benjamin</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NzIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4
NWQ2NTJhMmQ0MjA2M2Y0NjFjMTIwOGYwN2RkZWU0ZDM2YTBhMWE3Li44MTk3ZDgxYWJmMDQwNzc4
YjRlZjhkNTY4ZTIxN2ExZGU1ZWVjOGQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
NSArMSwyNCBAQAogMjAxMy0wNC0xOCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl
LmNvbT4KIAorICAgICAgICBSZW5hbWUgSlNTdHJpbmdKb2luZXI6OmJ1aWxkKCkgdG8gam9pbigp
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ4NDUK
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgbWV0
aG9kIG5hbWUgYnVpbGQoKSBjYW1lIGZyb20gU3RyaW5nQnVpbGRlciBoaXN0b3J5LiBJdCBkb2Vz
IG5vdCBtYWtlIG11Y2gKKyAgICAgICAgc2Vuc2Ugb24gdGhlIFN0cmluZ0pvaW5lci4KKworICAg
ICAgICAqIHJ1bnRpbWUvQXJyYXlQcm90b3R5cGUuY3BwOgorICAgICAgICAoSlNDOjphcnJheVBy
b3RvRnVuY1RvU3RyaW5nKToKKyAgICAgICAgKEpTQzo6YXJyYXlQcm90b0Z1bmNUb0xvY2FsZVN0
cmluZyk6CisgICAgICAgIChKU0M6OmFycmF5UHJvdG9GdW5jSm9pbik6CisgICAgICAgICogcnVu
dGltZS9KU1N0cmluZ0pvaW5lci5jcHA6CisgICAgICAgIChKU0M6OkpTU3RyaW5nSm9pbmVyOjpq
b2luKToKKyAgICAgICAgKiBydW50aW1lL0pTU3RyaW5nSm9pbmVyLmg6CisgICAgICAgIChKU1N0
cmluZ0pvaW5lcik6CisKKzIwMTMtMDQtMTggIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBh
cHBsZS5jb20+CisKICAgICAgICAgVXNlIFN0cmluZ0pvaW5lciB0byBjcmVhdGUgdGhlIEpTU3Ry
aW5nIG9mIGFycmF5UHJvdG9GdW5jVG9TdHJpbmcKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDc3OQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj
cmlwdENvcmUvcnVudGltZS9BcnJheVByb3RvdHlwZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvcnVudGltZS9BcnJheVByb3RvdHlwZS5jcHAKaW5kZXggNDFiNjAzNGVmZWE0NjFmZDRiOGI1
NWVmNTNiMDk3N2RmNWNhZmQ0ZS4uYmExYzdiNzI1YTY3MzNmNjE4MGVlY2E4YzY4YTcxMTI2ZmJi
MmU5ZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQXJyYXlQcm90
b3R5cGUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0FycmF5UHJvdG90
eXBlLmNwcApAQCAtMzI0LDcgKzMyNCw3IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwg
YXJyYXlQcm90b0Z1bmNUb1N0cmluZyhFeGVjU3RhdGUqIGV4ZWMpCiAgICAgICAgIGlmIChleGVj
LT5oYWRFeGNlcHRpb24oKSkKICAgICAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNV
bmRlZmluZWQoKSk7CiAgICAgfQotICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoc3RyaW5nSm9p
bmVyLmJ1aWxkKGV4ZWMpKTsKKyAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKHN0cmluZ0pvaW5l
ci5qb2luKGV4ZWMpKTsKIH0KIAogRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBhcnJheVBy
b3RvRnVuY1RvTG9jYWxlU3RyaW5nKEV4ZWNTdGF0ZSogZXhlYykKQEAgLTM2Nyw3ICszNjcsNyBA
QCBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGFycmF5UHJvdG9GdW5jVG9Mb2NhbGVTdHJp
bmcoRXhlY1N0YXRlKiBleGVjKQogICAgICAgICB9CiAgICAgfQogCi0gICAgcmV0dXJuIEpTVmFs
dWU6OmVuY29kZShzdHJpbmdKb2luZXIuYnVpbGQoZXhlYykpOworICAgIHJldHVybiBKU1ZhbHVl
OjplbmNvZGUoc3RyaW5nSm9pbmVyLmpvaW4oZXhlYykpOwogfQogCiBFbmNvZGVkSlNWYWx1ZSBK
U0NfSE9TVF9DQUxMIGFycmF5UHJvdG9GdW5jSm9pbihFeGVjU3RhdGUqIGV4ZWMpCkBAIC00MTMs
NyArNDEzLDcgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBhcnJheVByb3RvRnVuY0pv
aW4oRXhlY1N0YXRlKiBleGVjKQogICAgICAgICAgICAgc3RyaW5nSm9pbmVyLmFwcGVuZChTdHJp
bmcoKSk7CiAgICAgfQogCi0gICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShzdHJpbmdKb2luZXIu
YnVpbGQoZXhlYykpOworICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoc3RyaW5nSm9pbmVyLmpv
aW4oZXhlYykpOwogfQogCiBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGFycmF5UHJvdG9G
dW5jQ29uY2F0KEV4ZWNTdGF0ZSogZXhlYykKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9ydW50aW1lL0pTU3RyaW5nSm9pbmVyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y
dW50aW1lL0pTU3RyaW5nSm9pbmVyLmNwcAppbmRleCA4YjRjNTVmM2JiNDEwOWUzYTljNzQwN2Iy
Y2JjYTEzZTgyMDE3ZTQxLi43ZTIwZDIxOTU5NjA0YjY2ZmEzN2Y4NWUwN2VjM2QwMTNkMGZkYWZh
IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1N0cmluZ0pvaW5l
ci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNTdHJpbmdKb2luZXIu
Y3BwCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAxMiBBcHBsZSBJbmMu
IEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTIsIDIwMTMgQXBwbGUg
SW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2Ug
aW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0
aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25z
CkBAIC05NCw3ICs5NCw3IEBAIHN0YXRpYyBpbmxpbmUgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBq
b2luU3RyaW5ncyhjb25zdCBWZWN0b3I8U3RyaW5nPiYgc3RyaW5ncywKICAgICByZXR1cm4gb3V0
cHV0U3RyaW5nSW1wbC5yZWxlYXNlKCk7CiB9CiAKLUpTVmFsdWUgSlNTdHJpbmdKb2luZXI6OmJ1
aWxkKEV4ZWNTdGF0ZSogZXhlYykKK0pTVmFsdWUgSlNTdHJpbmdKb2luZXI6OmpvaW4oRXhlY1N0
YXRlKiBleGVjKQogewogICAgIGlmICghbV9pc1ZhbGlkKQogICAgICAgICByZXR1cm4gdGhyb3dP
dXRPZk1lbW9yeUVycm9yKGV4ZWMpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl
L3J1bnRpbWUvSlNTdHJpbmdKb2luZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l
L0pTU3RyaW5nSm9pbmVyLmgKaW5kZXggNDA3NDg4OGJmODNmZmJlNTk4ODNkMzZkMzg5M2IwMDAz
NTdmODYwMy4uNzM5NTBjNmQ3NDVhMGFjOGNhZjNlY2EzMjI1Mjc3Zjc2NzNlZjI1NCAxMDA2NDQK
LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNTdHJpbmdKb2luZXIuaAorKysg
Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1N0cmluZ0pvaW5lci5oCkBAIC0xLDUg
KzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAxMiBBcHBsZSBJbmMuIEFsbCByaWdodHMg
cmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTIsIDIwMTMgQXBwbGUgSW5jLiBBbGwgcmln
aHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFu
ZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVy
bWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC00MCw3ICs0
MCw3IEBAIHB1YmxpYzoKICAgICBKU1N0cmluZ0pvaW5lcihjb25zdCBTdHJpbmcmIHNlcGFyYXRv
ciwgc2l6ZV90IHN0cmluZ0NvdW50KTsKIAogICAgIHZvaWQgYXBwZW5kKGNvbnN0IFN0cmluZyYp
OwotICAgIEpTVmFsdWUgYnVpbGQoRXhlY1N0YXRlKik7CisgICAgSlNWYWx1ZSBqb2luKEV4ZWNT
dGF0ZSopOwogCiBwcml2YXRlOgogICAgIFN0cmluZyBtX3NlcGFyYXRvcjsK
</data>

          </attachment>
      

    </bug>

</bugzilla>