114841 2013-04-18 18:02:02 -0700 Objective-C API: Update public header documentation 2013-04-23 10:59:29 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg oldest_to_newest 878162 0 mhahnenberg 2013-04-18 18:02:02 -0700 There has been a lot of changes/additions to the Objective-C API during development, so we need to make sure all of the public headers have sufficient and correct documentation prior to final release. 878163 1 mhahnenberg 2013-04-18 18:02:12 -0700 <rdar://problem/13351539> 878164 2 198783 mhahnenberg 2013-04-18 18:03:39 -0700 Created attachment 198783 Patch 878250 3 198783 ggaren 2013-04-18 23:02:42 -0700 Comment on attachment 198783 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198783&action=review > Source/JavaScriptCore/API/JSManagedValue.h:36 > +// JSManagedValue represents a "conditionally strong" JSValue. "Conditionally strong" means that Maybe we should say "conditionally retained" to match typical ObjC language. > Source/JavaScriptCore/API/JSManagedValue.h:38 > +// as long as the JSManagedValue object is reachable either through the JavaScript object graph > +// or through the external Objective-C object graph as reported to the JSVirtualMachine using We should be a little clearer here: The JSManagedValue's JSValue can be reachable through the JS object graph; the JSManageValue itself can be reachable through addManagedReference:withOwner:. > Source/JavaScriptCore/API/JSManagedValue.h:40 > +// addManagedReference:withOwner:, the corresponding JavaScript value will remain alive inside > +// of the JSVirtualMachine. However, if none of these conditions are true, the corresponding Let's say "be retained" here as well. > Source/JavaScriptCore/API/JSManagedValue.h:42 > +// JavaScript value becomes a weak value, meaning it can be collected by the JavaScript garbage > +// collector at any time. Let's say "be release" here. > Source/JavaScriptCore/API/JSVirtualMachine.h:41 > +// addManagedReference:withOwner and removeManagedReference:withOwner allow clients of to make the Typo: "clients of the JSVirtualMachine". > Source/JavaScriptCore/API/JSVirtualMachine.h:49 > +// There is one caveat to this API: the root of any particular Objective-C object graph must be reachable from > +// within the JavaScript runtime. For example, a client could install a wrapped Objective-C object > +// as a property on the global object within the JSContext. If the external object graph is not > +// reachable from within the JSContext then that object graph will not be scanned during garbage > +// collection, which will cause objects referenced from Objective-C to be prematurely collected. I think this would read more clearly if you phrased it in terms of what's required to get correct behavior: If an Objective-C object is reachable from within the JavaScript runtime, all managed references transitively reachable from it will be scanned by the garbage collector.... 878561 4 198896 mhahnenberg 2013-04-19 10:25:19 -0700 Created attachment 198896 Patch 879406 5 198896 ggaren 2013-04-22 13:27:14 -0700 Comment on attachment 198896 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198896&action=review r=me > Source/JavaScriptCore/API/JSManagedValue.h:42 > +// be retained inside of the JSVirtualMachine. However, if neither of these Let's drop "inside the JSVirtualMachine" here and say, "the corresponding JSValue will be retained". That puts things more in terms of classical Cocoa programming. > Source/JavaScriptCore/API/JSManagedValue.h:44 > +// conditions are true, the corresponding JavaScript value becomes a weak value, > +// meaning it can be released by the JavaScript garbage collector at any time. Here, let's say, "the corresponding JSValue will be released and set to nil". We can hide the detail that it only becomes nil after the GC notices. 879979 6 mhahnenberg 2013-04-23 10:59:29 -0700 Committed r148974: <http://trac.webkit.org/changeset/148974> 198783 2013-04-18 18:03:39 -0700 2013-04-19 10:25:17 -0700 Patch bug-114841-20130418180309.patch text/plain 3705 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ4NzE4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTA0LTE4ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgT2JqZWN0aXZlLUMgQVBJOiBVcGRhdGUgcHVibGljIGhlYWRlciBkb2N1bWVudGF0 aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ4 NDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRl ZCBkb2N1bWVudGF0aW9uIGZvciB0aGUgbmV3bHkgYWRkZWQgb2JqZWN0IGxpZmV0aW1lLXJlbGF0 ZWQgc3R1ZmYuCisKKyAgICAgICAgKiBBUEkvSlNNYW5hZ2VkVmFsdWUuaDoKKyAgICAgICAgKiBB UEkvSlNWaXJ0dWFsTWFjaGluZS5oOgorCiAyMDEzLTA0LTE4ICBNYXJrIEhhaG5lbmJlcmcgIDxt aGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgQ3Jhc2ggYmVuZWF0aCBKU0M6OkpJVDo6 cHJpdmF0ZUNvbXBpbGVTbG93Q2FzZXMgQCBzdGVwaGVucmRvbmFsZHNvbi5jb20KSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNNYW5hZ2VkVmFsdWUuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTTWFuYWdlZFZhbHVlLmgJKHJldmlzaW9uIDE0ODcx MykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNNYW5hZ2VkVmFsdWUuaAkod29ya2lu ZyBjb3B5KQpAQCAtMzMsMTMgKzMzLDI4IEBACiBAY2xhc3MgSlNWYWx1ZTsKIEBjbGFzcyBKU0Nv bnRleHQ7CiAKKy8vIEpTTWFuYWdlZFZhbHVlIHJlcHJlc2VudHMgYSAiY29uZGl0aW9uYWxseSBz dHJvbmciIEpTVmFsdWUuICJDb25kaXRpb25hbGx5IHN0cm9uZyIgbWVhbnMgdGhhdCAKKy8vIGFz IGxvbmcgYXMgdGhlIEpTTWFuYWdlZFZhbHVlIG9iamVjdCBpcyByZWFjaGFibGUgZWl0aGVyIHRo cm91Z2ggdGhlIEphdmFTY3JpcHQgb2JqZWN0IGdyYXBoCisvLyBvciB0aHJvdWdoIHRoZSBleHRl cm5hbCBPYmplY3RpdmUtQyBvYmplY3QgZ3JhcGggYXMgcmVwb3J0ZWQgdG8gdGhlIEpTVmlydHVh bE1hY2hpbmUgdXNpbmcgCisvLyBhZGRNYW5hZ2VkUmVmZXJlbmNlOndpdGhPd25lcjosIHRoZSBj b3JyZXNwb25kaW5nIEphdmFTY3JpcHQgdmFsdWUgd2lsbCByZW1haW4gYWxpdmUgaW5zaWRlIAor Ly8gb2YgdGhlIEpTVmlydHVhbE1hY2hpbmUuIEhvd2V2ZXIsIGlmIG5vbmUgb2YgdGhlc2UgY29u ZGl0aW9ucyBhcmUgdHJ1ZSwgdGhlIGNvcnJlc3BvbmRpbmcgCisvLyBKYXZhU2NyaXB0IHZhbHVl IGJlY29tZXMgYSB3ZWFrIHZhbHVlLCBtZWFuaW5nIGl0IGNhbiBiZSBjb2xsZWN0ZWQgYnkgdGhl IEphdmFTY3JpcHQgZ2FyYmFnZSAKKy8vIGNvbGxlY3RvciBhdCBhbnkgdGltZS4KKy8vCisvLyBU aGUgcHJpbWFyeSB1c2UgY2FzZSBpcyBmb3IgSlNNYW5hZ2VkVmFsdWUgaXMgZm9yIHNhZmVseSBy ZWZlcmVuY2luZyBKU1ZhbHVlcyBmcm9tIHRoZSBPYmplY3RpdmUtQyBoZWFwLiAKKy8vIEl0IGlz IGluY29ycmVjdCB0byBzdG9yZSBhIEpTVmFsdWUgaW50byBhbiBPYmplY3RpdmUtQyBoZWFwIG9i amVjdCwgYXMgdGhpcyBjYW4gdmVyeSBlYXNpbHkgY3JlYXRlIAorLy8gYSByZWZlcmVuY2UgY3lj bGUsIGtlZXBpbmcgdGhlIGVudGlyZSBKU0NvbnRleHQgYWxpdmUuIAogTlNfQ0xBU1NfQVZBSUxB QkxFKDEwXzksIE5BKQogQGludGVyZmFjZSBKU01hbmFnZWRWYWx1ZSA6IE5TT2JqZWN0CiAKKy8v IENvbnZlbmllbmNlIG1ldGhvZCBmb3IgY3JlYXRpbmcgSlNNYW5hZ2VkVmFsdWVzIGZyb20gSlNW YWx1ZXMuCiArIChKU01hbmFnZWRWYWx1ZSAqKW1hbmFnZWRWYWx1ZVdpdGhWYWx1ZTooSlNWYWx1 ZSAqKXZhbHVlOwogCisvLyBDcmVhdGUgYSBKU01hbmFnZWRWYWx1ZS4KIC0gKGlkKWluaXRXaXRo VmFsdWU6KEpTVmFsdWUgKil2YWx1ZTsKIAorLy8gR2V0IHRoZSBKU1ZhbHVlIHRvIHdoaWNoIHRo aXMgSlNNYW5hZ2VkVmFsdWUgcmVmZXJzLiBJZiB0aGUgSmF2YVNjcmlwdCB2YWx1ZSBoYXMgYmVl biBjb2xsZWN0ZWQsCisvLyB0aGlzIG1ldGhvZCByZXR1cm5zIG5pbC4KIC0gKEpTVmFsdWUgKil2 YWx1ZTsKIAogQGVuZApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1ZpcnR1YWxN YWNoaW5lLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1ZpcnR1 YWxNYWNoaW5lLmgJKHJldmlzaW9uIDE0ODcxMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9B UEkvSlNWaXJ0dWFsTWFjaGluZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNSw4ICszNSwxOSBAQAog TlNfQ0xBU1NfQVZBSUxBQkxFKDEwXzksIE5BKQogQGludGVyZmFjZSBKU1ZpcnR1YWxNYWNoaW5l IDogTlNPYmplY3QKIAorLy8gQ3JlYXRlIGEgbmV3IEpTVmlydHVhbE1hY2hpbmUuCiAtIChpZClp bml0OwogCisvLyBhZGRNYW5hZ2VkUmVmZXJlbmNlOndpdGhPd25lciBhbmQgcmVtb3ZlTWFuYWdl ZFJlZmVyZW5jZTp3aXRoT3duZXIgYWxsb3cgY2xpZW50cyBvZiB0byBtYWtlIHRoZSAKKy8vIEph dmFTY3JpcHQgcnVudGltZSBhd2FyZSBvZiBhcmJpdHJhcnkgZXh0ZXJuYWwgT2JqZWN0aXZlLUMg b2JqZWN0IGdyYXBocy4gVGhlIHJ1bnRpbWUgY2FuIHRoZW4gdXNlIAorLy8gdGhpcyBpbmZvcm1h dGlvbiB0byBrZWVwIGFsaXZlIGFueSBKYXZhU2NyaXB0IHZhbHVlcyB0aGF0IGFyZSByZWZlcmVu Y2VkIGZyb20gc29tZXdoZXJlIGluIHNhaWQgb2JqZWN0IGdyYXBoLgorLy8gCisvLyBUaGVyZSBp cyBvbmUgY2F2ZWF0IHRvIHRoaXMgQVBJOiB0aGUgcm9vdCBvZiBhbnkgcGFydGljdWxhciBPYmpl Y3RpdmUtQyBvYmplY3QgZ3JhcGggbXVzdCBiZSByZWFjaGFibGUgZnJvbQorLy8gd2l0aGluIHRo ZSBKYXZhU2NyaXB0IHJ1bnRpbWUuIEZvciBleGFtcGxlLCBhIGNsaWVudCBjb3VsZCBpbnN0YWxs IGEgd3JhcHBlZCBPYmplY3RpdmUtQyBvYmplY3QgCisvLyBhcyBhIHByb3BlcnR5IG9uIHRoZSBn bG9iYWwgb2JqZWN0IHdpdGhpbiB0aGUgSlNDb250ZXh0LiBJZiB0aGUgZXh0ZXJuYWwgb2JqZWN0 IGdyYXBoIGlzIG5vdCAKKy8vIHJlYWNoYWJsZSBmcm9tIHdpdGhpbiB0aGUgSlNDb250ZXh0IHRo ZW4gdGhhdCBvYmplY3QgZ3JhcGggd2lsbCBub3QgYmUgc2Nhbm5lZCBkdXJpbmcgZ2FyYmFnZQor Ly8gY29sbGVjdGlvbiwgd2hpY2ggd2lsbCBjYXVzZSBvYmplY3RzIHJlZmVyZW5jZWQgZnJvbSBP YmplY3RpdmUtQyB0byBiZSBwcmVtYXR1cmVseSBjb2xsZWN0ZWQuCisvLwogLSAodm9pZClhZGRN YW5hZ2VkUmVmZXJlbmNlOihpZClvYmplY3Qgd2l0aE93bmVyOihpZClvd25lcjsKIC0gKHZvaWQp cmVtb3ZlTWFuYWdlZFJlZmVyZW5jZTooaWQpb2JqZWN0IHdpdGhPd25lcjooaWQpb3duZXI7CiAK 198896 2013-04-19 10:25:19 -0700 2013-04-22 13:27:14 -0700 Patch bug-114841-20130419102448.patch text/plain 3643 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ4NzE4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTA0LTE4ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgT2JqZWN0aXZlLUMgQVBJOiBVcGRhdGUgcHVibGljIGhlYWRlciBkb2N1bWVudGF0 aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ4 NDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRl ZCBkb2N1bWVudGF0aW9uIGZvciB0aGUgbmV3bHkgYWRkZWQgb2JqZWN0IGxpZmV0aW1lLXJlbGF0 ZWQgc3R1ZmYuCisKKyAgICAgICAgKiBBUEkvSlNNYW5hZ2VkVmFsdWUuaDoKKyAgICAgICAgKiBB UEkvSlNWaXJ0dWFsTWFjaGluZS5oOgorCiAyMDEzLTA0LTE4ICBNYXJrIEhhaG5lbmJlcmcgIDxt aGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgQ3Jhc2ggYmVuZWF0aCBKU0M6OkpJVDo6 cHJpdmF0ZUNvbXBpbGVTbG93Q2FzZXMgQCBzdGVwaGVucmRvbmFsZHNvbi5jb20KSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNNYW5hZ2VkVmFsdWUuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTTWFuYWdlZFZhbHVlLmgJKHJldmlzaW9uIDE0ODcx MykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNNYW5hZ2VkVmFsdWUuaAkod29ya2lu ZyBjb3B5KQpAQCAtMzMsMTMgKzMzLDMxIEBACiBAY2xhc3MgSlNWYWx1ZTsKIEBjbGFzcyBKU0Nv bnRleHQ7CiAKKy8vIEpTTWFuYWdlZFZhbHVlIHJlcHJlc2VudHMgYSAiY29uZGl0aW9uYWxseSBy ZXRhaW5lZCIgSlNWYWx1ZS4gCisvLyAiQ29uZGl0aW9uYWxseSByZXRhaW5lZCIgbWVhbnMgdGhh dCBhcyBsb25nIGFzIGVpdGhlciB0aGUgSlNNYW5hZ2VkVmFsdWUgCisvLyBKYXZhU2NyaXB0IHZh bHVlIGlzIHJlYWNoYWJsZSB0aHJvdWdoIHRoZSBKYXZhU2NyaXB0IG9iamVjdCBncmFwaAorLy8g b3IgdGhlIEpTTWFuYWdlZFZhbHVlIG9iamVjdCBpcyByZWFjaGFibGUgdGhyb3VnaCB0aGUgZXh0 ZXJuYWwgT2JqZWN0aXZlLUMgCisvLyBvYmplY3QgZ3JhcGggYXMgcmVwb3J0ZWQgdG8gdGhlIEpT VmlydHVhbE1hY2hpbmUgdXNpbmcgCisvLyBhZGRNYW5hZ2VkUmVmZXJlbmNlOndpdGhPd25lcjos IHRoZSBjb3JyZXNwb25kaW5nIEphdmFTY3JpcHQgdmFsdWUgd2lsbCAKKy8vIGJlIHJldGFpbmVk IGluc2lkZSBvZiB0aGUgSlNWaXJ0dWFsTWFjaGluZS4gSG93ZXZlciwgaWYgbmVpdGhlciBvZiB0 aGVzZSAKKy8vIGNvbmRpdGlvbnMgYXJlIHRydWUsIHRoZSBjb3JyZXNwb25kaW5nIEphdmFTY3Jp cHQgdmFsdWUgYmVjb21lcyBhIHdlYWsgdmFsdWUsCisvLyBtZWFuaW5nIGl0IGNhbiBiZSByZWxl YXNlZCBieSB0aGUgSmF2YVNjcmlwdCBnYXJiYWdlIGNvbGxlY3RvciBhdCBhbnkgdGltZS4KKy8v CisvLyBUaGUgcHJpbWFyeSB1c2UgY2FzZSBmb3IgSlNNYW5hZ2VkVmFsdWUgaXMgZm9yIHNhZmVs eSByZWZlcmVuY2luZyBKU1ZhbHVlcyAKKy8vIGZyb20gdGhlIE9iamVjdGl2ZS1DIGhlYXAuIEl0 IGlzIGluY29ycmVjdCB0byBzdG9yZSBhIEpTVmFsdWUgaW50byBhbiAKKy8vIE9iamVjdGl2ZS1D IGhlYXAgb2JqZWN0LCBhcyB0aGlzIGNhbiB2ZXJ5IGVhc2lseSBjcmVhdGUgYSByZWZlcmVuY2Ug Y3ljbGUsIAorLy8ga2VlcGluZyB0aGUgZW50aXJlIEpTQ29udGV4dCBhbGl2ZS4gCiBOU19DTEFT U19BVkFJTEFCTEUoMTBfOSwgTkEpCiBAaW50ZXJmYWNlIEpTTWFuYWdlZFZhbHVlIDogTlNPYmpl Y3QKIAorLy8gQ29udmVuaWVuY2UgbWV0aG9kIGZvciBjcmVhdGluZyBKU01hbmFnZWRWYWx1ZXMg ZnJvbSBKU1ZhbHVlcy4KICsgKEpTTWFuYWdlZFZhbHVlICopbWFuYWdlZFZhbHVlV2l0aFZhbHVl OihKU1ZhbHVlICopdmFsdWU7CiAKKy8vIENyZWF0ZSBhIEpTTWFuYWdlZFZhbHVlLgogLSAoaWQp aW5pdFdpdGhWYWx1ZTooSlNWYWx1ZSAqKXZhbHVlOwogCisvLyBHZXQgdGhlIEpTVmFsdWUgdG8g d2hpY2ggdGhpcyBKU01hbmFnZWRWYWx1ZSByZWZlcnMuIElmIHRoZSBKYXZhU2NyaXB0IHZhbHVl IGhhcyBiZWVuIGNvbGxlY3RlZCwKKy8vIHRoaXMgbWV0aG9kIHJldHVybnMgbmlsLgogLSAoSlNW YWx1ZSAqKXZhbHVlOwogCiBAZW5kCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pT VmlydHVhbE1hY2hpbmUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJ L0pTVmlydHVhbE1hY2hpbmUuaAkocmV2aXNpb24gMTQ4NzEzKQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL0FQSS9KU1ZpcnR1YWxNYWNoaW5lLmgJKHdvcmtpbmcgY29weSkKQEAgLTM1LDggKzM1 LDIxIEBACiBOU19DTEFTU19BVkFJTEFCTEUoMTBfOSwgTkEpCiBAaW50ZXJmYWNlIEpTVmlydHVh bE1hY2hpbmUgOiBOU09iamVjdAogCisvLyBDcmVhdGUgYSBuZXcgSlNWaXJ0dWFsTWFjaGluZS4K IC0gKGlkKWluaXQ7CiAKKy8vIGFkZE1hbmFnZWRSZWZlcmVuY2U6d2l0aE93bmVyIGFuZCByZW1v dmVNYW5hZ2VkUmVmZXJlbmNlOndpdGhPd25lciBhbGxvdyAKKy8vIGNsaWVudHMgb2YgSlNWaXJ0 dWFsTWFjaGluZSB0byBtYWtlIHRoZSBKYXZhU2NyaXB0IHJ1bnRpbWUgYXdhcmUgb2YgCisvLyBh cmJpdHJhcnkgZXh0ZXJuYWwgT2JqZWN0aXZlLUMgb2JqZWN0IGdyYXBocy4gVGhlIHJ1bnRpbWUg Y2FuIHRoZW4gdXNlIAorLy8gdGhpcyBpbmZvcm1hdGlvbiB0byByZXRhaW4gYW55IEphdmFTY3Jp cHQgdmFsdWVzIHRoYXQgYXJlIHJlZmVyZW5jZWQgCisvLyBmcm9tIHNvbWV3aGVyZSBpbiBzYWlk IG9iamVjdCBncmFwaC4KKy8vIAorLy8gRm9yIGNvcnJlY3QgYmVoYXZpb3IgY2xpZW50cyBtdXN0 IG1ha2UgdGhlaXIgZXh0ZXJuYWwgb2JqZWN0IGdyYXBocyAKKy8vIHJlYWNoYWJsZSBmcm9tIHdp dGhpbiB0aGUgSmF2YVNjcmlwdCBydW50aW1lLiBJZiBhbiBPYmplY3RpdmUtQyBvYmplY3QgaXMg CisvLyByZWFjaGFibGUgZnJvbSB3aXRoaW4gdGhlIEphdmFTY3JpcHQgcnVudGltZSwgYWxsIG1h bmFnZWQgcmVmZXJlbmNlcyAKKy8vIHRyYW5zaXRpdmVseSByZWFjaGFibGUgZnJvbSBpdCBhcyBy ZWNvcmRlZCB3aXRoIAorLy8gYWRkTWFuYWdlZFJlZmVyZW5jZTp3aXRoT3duZXI6IHdpbGwgYmUg c2Nhbm5lZCBieSB0aGUgZ2FyYmFnZSBjb2xsZWN0b3IuCisvLyAKIC0gKHZvaWQpYWRkTWFuYWdl ZFJlZmVyZW5jZTooaWQpb2JqZWN0IHdpdGhPd25lcjooaWQpb3duZXI7CiAtICh2b2lkKXJlbW92 ZU1hbmFnZWRSZWZlcmVuY2U6KGlkKW9iamVjdCB3aXRoT3duZXI6KGlkKW93bmVyOwogCg==