114825 2013-04-18 13:16:28 -0700 Garbage at the top of http://www.technologyreview.com after scrolling 2013-04-24 18:26:50 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://www.technologyreview.com InRadar P2 Normal --- 1 simon.fraser simon.fraser alokp bdakin commit-queue esprehn+autocc shawnsingh simon.fraser webkit-bug-importer oldest_to_newest 878040 0 simon.fraser 2013-04-18 13:16:28 -0700 http://www.technologyreview.com shows garbage at the top on Mac if you scroll down then back up. Regression from r146531 878041 1 simon.fraser 2013-04-18 13:16:52 -0700 <rdar://problem/13684286> 880961 2 simon.fraser 2013-04-24 17:55:07 -0700 The element showing the garbage pixels has visibility:hidden, which is not considered by RenderLayer::backgroundIsKnownToBeOpaqueInRect(). Another change I notice that affects this is https://bugs.webkit.org/show_bug.cgi?id=108118. Before that revision, we'd compute that the fixed position element is a simple container layer (yellow border). After that change, it became something that draws content. I haven't been able to make a useful reduction. Most of the time, visibility:hidden just causes us to not parent the compositing layer. 880973 3 199573 simon.fraser 2013-04-24 18:18:27 -0700 Created attachment 199573 Patch 880975 4 199573 thorton 2013-04-24 18:22:39 -0700 Comment on attachment 199573 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199573&action=review > LayoutTests/compositing/contents-opaque/visibility-hidden.html:49 > + <nav> > + <ul> > + <li>Some text here</li> > + </ul> > + </nav> TABS 880978 5 simon.fraser 2013-04-24 18:26:50 -0700 https://trac.webkit.org/r149084 199573 2013-04-24 18:18:27 -0700 2013-04-24 18:22:39 -0700 Patch bug-114825-20130424181753.patch text/plain 5517 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5MDUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGIyMjJiMTYwN2IxMDZh NDIyZmM2YWRmMGJhNjc3YmRlYzQ1ZTRmOC4uZDI1MWIyNTE0ODZlZmE2ZTg0ZDQ3NThkOWE1OGVm YjkzMjlkZTAxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEzLTA0LTI0ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIEdhcmJhZ2UgYXQg dGhlIHRvcCBvZiBodHRwOi8vd3d3LnRlY2hub2xvZ3lyZXZpZXcuY29tIGFmdGVyIHNjcm9sbGlu ZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0ODI1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR2FyYmFn ZSBwaXhlbHMgYXJlIGNhdXNlZCBieSBHcmFwaGljc0xheWVyQ0Egc2V0dGluZyBhIGxheWVyIHRv IGJlIG9wYXF1ZSwKKyAgICAgICAgYnV0IHRoZW4gbm90IHBhaW50aW5nIGFueXRoaW5nIGludG8g aXQuIE9uIHRoaXMgcGFnZSwgdGhlIGVsZW1lbnQgaXMKKyAgICAgICAgdG9nZ2xlZCB0byBiZSB2 aXNpYmlsaXR5OmhpZGRlbiBvbiBzY3JvbGxpbmcsIGJ1dCBSZW5kZXJMYXllcjo6YmFja2dyb3Vu ZElzS25vd25Ub0JlT3BhcXVlSW5SZWN0KCkKKyAgICAgICAgZmFpbGVkIHRvIGNvbnNpZGVyIHRo YXQgYXMgc29tZXRoaW5nIHRoYXQgY2FuIGNhdXNlIGJhY2tncm91bmRzIG5vdCB0byBiZSBvcGFx dWUuCisgICAgICAgIAorICAgICAgICBGb3IgdGhlIGJ1ZyB0byBoYXBwZW4sIHNvbWUgc3VidGxl IGludGVyYWN0aW9ucyB3aXRoIHIxNDIwMTIgY29tZSBpbnRvIHBsYXkKKyAgICAgICAgZm9yIHRo ZSBsYXllciB0byByZW1haW4gdmlzaWJsZSwgaGVuY2UgdGhlIHNsaWdodGx5IGNvbXBsZXggdGVz dGNhc2UuCisgICAgICAgIAorICAgICAgICBUZXN0OiBjb21wb3NpdGluZy9jb250ZW50cy1vcGFx dWUvdmlzaWJpbGl0eS1oaWRkZW4uaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxh eWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpiYWNrZ3JvdW5kSXNLbm93 blRvQmVPcGFxdWVJblJlY3QpOgorCisyMDEzLTA0LTI0ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5m cmFzZXJAYXBwbGUuY29tPgorCiAgICAgICAgIER1bXAgbGF5ZXIgb3BhcXVlbmVzcyBpbiB0aGUg Q29tcG9zaXRpbmcgbG9nIG91dHB1dAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTE1MTMyCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXIuY3BwCmluZGV4IDZkNWEwYWY2YWY4MjMyNGI0MGY5YzMzZjhkZTg4YTZiMGMwZGI1ODIuLjRi N2ExMTRjYjU1YWIyNGZjOTYxMzhjM2QwOTU5N2Q5MmY5NzI1MzggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcApAQCAtNTU1OSw2ICs1NTU5LDEwIEBAIGJvb2wgUmVu ZGVyTGF5ZXI6OmJhY2tncm91bmRJc0tub3duVG9CZU9wYXF1ZUluUmVjdChjb25zdCBMYXlvdXRS ZWN0JiBsb2NhbFJlY3QpCiAgICAgaWYgKHBhaW50c1dpdGhUcmFuc3BhcmVuY3koUGFpbnRCZWhh dmlvck5vcm1hbCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAorICAgIEFTU0VSVCghbV92aXNp YmxlQ29udGVudFN0YXR1c0RpcnR5KTsKKyAgICBpZiAoIWhhc1Zpc2libGVDb250ZW50KCkpCisg ICAgICAgIHJldHVybiBmYWxzZTsKKwogI2lmIEVOQUJMRShDU1NfRklMVEVSUykKICAgICBpZiAo cGFpbnRzV2l0aEZpbHRlcnMoKSAmJiByZW5kZXJlcigpLT5zdHlsZSgpLT5maWx0ZXIoKS5oYXNG aWx0ZXJUaGF0QWZmZWN0c09wYWNpdHkoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4 IDdmYTUyYjIyZDI0MzAwM2U0NTA0NzEwMGY2NzNjMTg2MTA0NDYxZjEuLjM0ZTMxOGFjZTQ3NmNh MWJjMmMzMzU2ZDQxYzMyNDVhYzczMzhkMTYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMy0w NC0yNCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBH YXJiYWdlIGF0IHRoZSB0b3Agb2YgaHR0cDovL3d3dy50ZWNobm9sb2d5cmV2aWV3LmNvbSBhZnRl ciBzY3JvbGxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExNDgyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAg ICAKKyAgICAgICAgVGVzdCB0aGF0IHNldHMgdmlzaWJpbGl0eTpoaWRkZW4gb24gYW4gZWxlbWVu dCB3aXRoIHNvbWUgY29tcGxleAorICAgICAgICBjb25maWd1cmF0aW9uIG9mIGxheWVyIGNoaWxk cmVuLCBhbmQgZHVtcHMgdGhlIGxheWVyIHRyZWUgdG8gY2hlY2sKKyAgICAgICAgdGhhdCB0aGUg Y29udGVudHMgYXJlIG5vdCBtYXJrZWQgYXMgb3BhcXVlLgorCisgICAgICAgICogY29tcG9zaXRp bmcvY29udGVudHMtb3BhcXVlL3Zpc2liaWxpdHktaGlkZGVuLWV4cGVjdGVkLnR4dDogQWRkZWQu CisgICAgICAgICogY29tcG9zaXRpbmcvY29udGVudHMtb3BhcXVlL3Zpc2liaWxpdHktaGlkZGVu Lmh0bWw6IEFkZGVkLgorCiAyMDEzLTA0LTI0ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBh cHBsZS5jb20+CiAKICAgICAgICAgQVg6IFdBSS1BUklBIGxhbmRtYXJrcyBubyBsb25nZXIgc3Bl YWsgdHlwZSBvZiBsYW5kbWFyayBvbiBpT1MKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NvbXBv c2l0aW5nL2NvbnRlbnRzLW9wYXF1ZS92aXNpYmlsaXR5LWhpZGRlbi1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy9jb21wb3NpdGluZy9jb250ZW50cy1vcGFxdWUvdmlzaWJpbGl0eS1oaWRkZW4t ZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjEwMGQ3ZDAzZTkwYmZhMjhhZjQ1ZmIzOWQ1ZDc1MTM3 Y2ZiOTQ5NDQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9jb250 ZW50cy1vcGFxdWUvdmlzaWJpbGl0eS1oaWRkZW4tZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTcg QEAKKyhHcmFwaGljc0xheWVyCisgIChib3VuZHMgODAwLjAwIDYwMC4wMCkKKyAgKGNoaWxkcmVu IDEKKyAgICAoR3JhcGhpY3NMYXllcgorICAgICAgKGJvdW5kcyA4MDAuMDAgNjAwLjAwKQorICAg ICAgKGNvbnRlbnRzT3BhcXVlIDEpCisgICAgICAoY2hpbGRyZW4gMQorICAgICAgICAoR3JhcGhp Y3NMYXllcgorICAgICAgICAgIChwb3NpdGlvbiA4LjAwIDIwLjAwKQorICAgICAgICAgIChib3Vu ZHMgMjAwLjAwIDUwLjAwKQorICAgICAgICAgIChkcmF3c0NvbnRlbnQgMSkKKyAgICAgICAgKQor ICAgICAgKQorICAgICkKKyAgKQorKQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jb21wb3Np dGluZy9jb250ZW50cy1vcGFxdWUvdmlzaWJpbGl0eS1oaWRkZW4uaHRtbCBiL0xheW91dFRlc3Rz L2NvbXBvc2l0aW5nL2NvbnRlbnRzLW9wYXF1ZS92aXNpYmlsaXR5LWhpZGRlbi5odG1sCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLjNmYzVlZjE2MGY4YzgxNjUwMDcyMGQyZmI4MzA3OTQzNmM3ZWVmOGIKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9jb250ZW50cy1vcGFxdWUvdmlzaWJp bGl0eS1oaWRkZW4uaHRtbApAQCAtMCwwICsxLDU0IEBACis8aHRtbD4KKyAgICA8aGVhZD4KKyAg ICAgICAgPHN0eWxlIHR5cGU9InRleHQvY3NzIj4KKyAgICAgICAgICAgIGhlYWRlciB7CisgICAg ICAgICAgICAgICAgcG9zaXRpb246IGFic29sdXRlOworICAgICAgICAgICAgICAgIHRvcDogMjBw eDsKKyAgICAgICAgICAgICAgICB3aWR0aDogMjAwcHg7CisgICAgICAgICAgICAgICAgaGVpZ2h0 OiA1MHB4OworICAgICAgICAgICAgICAgIGJhY2tncm91bmQtY29sb3I6IHNpbHZlcjsKKyAgICAg ICAgICAgICAgICAtd2Via2l0LXRyYW5zZm9ybTogdHJhbnNsYXRlWigwKTsKKyAgICAgICAgICAg IH0KKyAgICAgICAgICAgIAorICAgICAgICAgICAgaGVhZGVyLmhpZGRlbiB7CisgICAgICAgICAg ICAgICAgdmlzaWJpbGl0eTogaGlkZGVuOworICAgICAgICAgICAgfQorICAgICAgICAgICAgCisg ICAgICAgICAgICBuYXYgeworICAgICAgICAgICAgICAgIGhlaWdodDogMzdweDsKKyAgICAgICAg ICAgICAgICBvdmVyZmxvdzogaGlkZGVuOworICAgICAgICAgICAgfQorICAgICAgICAgICAgCisg ICAgICAgICAgICBuYXYgdWwgbGkgeworICAgICAgICAgICAgICAgIGhlaWdodDogNTBweDsKKyAg ICAgICAgICAgICAgICBmbG9hdDogbGVmdDsKKyAgICAgICAgICAgICAgICBvdmVyZmxvdzogaGlk ZGVuOworICAgICAgICAgICAgfQorICAgICAgICAgICAgCisgICAgICAgIDwvc3R5bGU+CisgICAg ICAgIDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KKyAgICAgICAgICAgIGlmICh3aW5k b3cudGVzdFJ1bm5lcikKKyAgICAgICAgICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsK KworICAgICAgICAgICAgZnVuY3Rpb24gZG9UZXN0KCkgeworICAgICAgICAgICAgICAgIHZhciBo ZWFkZXIgPSBkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgnaGVhZGVyJylbMF07CisgICAg ICAgICAgICAgICAgaGVhZGVyLmNsYXNzTGlzdC50b2dnbGUoJ2hpZGRlbicpOworICAgICAgICAg ICAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lciAmJiB3aW5kb3cuaW50ZXJuYWxzKQorICAgICAg ICAgICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnbGF5ZXJ0cmVlJykuaW5uZXJU ZXh0ID0gd2luZG93LmludGVybmFscy5sYXllclRyZWVBc1RleHQoZG9jdW1lbnQpOworICAgICAg ICAgICAgfQorICAgICAgICAgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBkb1Rl c3QsIGZhbHNlKTsKKyAgICAgICAgPC9zY3JpcHQ+CisgICAgPC9oZWFkPgorCis8Ym9keT4KKyAg ICA8aGVhZGVyPiAKKyAgICAJPG5hdj4gCisJCQk8dWw+CisJCQkJPGxpPlNvbWUgdGV4dCBoZXJl PC9saT4KKwkJCTwvdWw+CisgICAgCTwvbmF2PiAKKyAgICA8L2hlYWRlcj4KKyAgICAKKyAgICA8 cHJlIGlkPSJsYXllcnRyZWUiPjwvcHJlPiAKKzwvYm9keT4KKzwvaHRtbD4K