114818 2013-04-18 09:16:36 -0700 Forced subtitles never rendered 2013-10-28 11:41:42 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson dino jer.noble simon.fraser webkit-bug-importer oldest_to_newest 877927 0 eric.carlson 2013-04-18 09:16:36 -0700 Although forced subtitle tracks are enabled correctly when appropriate, forced cues are never rendered. 877928 1 webkit-bug-importer 2013-04-18 09:16:50 -0700 <rdar://problem/13684478> 877932 2 198744 eric.carlson 2013-04-18 09:20:01 -0700 Created attachment 198744 Proposed patch 877996 3 eric.carlson 2013-04-18 11:02:36 -0700 https://trac.webkit.org/r148688 944173 4 simon.fraser 2013-10-28 11:41:42 -0700 The added test times out every time: http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20(Tests)/r158114%20(121)/media/track/track-forced-subtitles-in-band-pretty-diff.html Skipping it (bug 123412). 198744 2013-04-18 09:20:01 -0700 2013-04-18 11:02:44 -0700 Proposed patch fix_patch_1.txt text/plain 3792 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0ODY4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA0LTE4ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIEZvcmNlZCBzdWJ0aXRs ZXMgbmV2ZXIgcmVuZGVyZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExNDgxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cywgbWVkaWEvdHJhY2svdHJhY2stZm9yY2VkLXN1YnRpdGxl cy1pbi1iYW5kLmh0bWwgd2FzIHVwZGF0ZWQgdG8gdGVzdCB0aGlzIGNoYW5nZS4KKworICAgICAg ICAqIGh0bWwvdHJhY2svVGV4dFRyYWNrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHRUcmFj azo6aXNSZW5kZXJlZCk6ICJmb3JjZWQiIHRyYWNrcyBhcmUgcmVuZGVyZWQuCisKIDIwMTMtMDQt MTggIEpvbmF0aGFuIEZlbGRzdGVpbiAgPGpmZWxkc3RlaW5AYmxhY2tiZXJyeS5jb20+CiAKICAg ICAgICAgW0JsYWNrQmVycnldIEltcHJvcGVyIGluaXRpYWxpemF0aW9uIG9mIEFOR0xFUmVzb3Vy Y2VzIChyZXN1Ym1pc3Npb24pCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1RleHRU cmFjay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9UZXh0VHJh Y2suY3BwCShyZXZpc2lvbiAxNDg1NDApCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1Rl eHRUcmFjay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQzOSw3ICs0MzksNyBAQCB2b2lkIFRleHRU cmFjazo6aW52YWxpZGF0ZVRyYWNrSW5kZXgoKQogCiBib29sIFRleHRUcmFjazo6aXNSZW5kZXJl ZCgpCiB7Ci0gICAgaWYgKGtpbmQoKSAhPSBjYXB0aW9uc0tleXdvcmQoKSAmJiBraW5kKCkgIT0g c3VidGl0bGVzS2V5d29yZCgpKQorICAgIGlmIChraW5kKCkgIT0gY2FwdGlvbnNLZXl3b3JkKCkg JiYga2luZCgpICE9IHN1YnRpdGxlc0tleXdvcmQoKSAmJiBraW5kKCkgIT0gZm9yY2VkS2V5d29y ZCgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBpZiAobV9tb2RlICE9IHNob3dpbmdL ZXl3b3JkKCkpCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDg2ODApCisrKyBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0wNC0xOCAgRXJpYyBD YXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KKworICAgICAgICBGb3JjZWQgc3VidGl0 bGVzIG5ldmVyIHJlbmRlcmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMTQ4MTgKKworICAgICAgICBVcGRhdGUgdGVzdCB0byBjaGVjayB0aGF0IGEg Zm9yY2VkIGN1ZSBpcyByZW5kZXJlZC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIG1lZGlhL3RyYWNrL3RyYWNrLWZvcmNlZC1zdWJ0aXRsZXMtaW4t YmFuZC1leHBlY3RlZC50eHQ6CisgICAgICAgICogbWVkaWEvdHJhY2svdHJhY2stZm9yY2VkLXN1 YnRpdGxlcy1pbi1iYW5kLmh0bWw6CisKIDIwMTMtMDQtMTggIEVyaWMgQ2FybHNvbiAgPGVyaWMu Y2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgRmxha3kgVGVzdDogbWVkaWEvdHJhY2svdHJh Y2stbW9kZS5odG1sCkluZGV4OiBMYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1mb3JjZWQt c3VidGl0bGVzLWluLWJhbmQtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L21lZGlhL3RyYWNrL3RyYWNrLWZvcmNlZC1zdWJ0aXRsZXMtaW4tYmFuZC1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDE0ODQ1NCkKKysrIExheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLWZvcmNl ZC1zdWJ0aXRsZXMtaW4tYmFuZC1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTQ4LDUg KzQ4LDEwIEBAIEVYUEVDVEVEICh2aWRlby50ZXh0VHJhY2tzWzhdLmxhbmd1YWdlID0KIEVYUEVD VEVEICh2aWRlby50ZXh0VHJhY2tzWzhdLmtpbmQgPT0gJ2NhcHRpb25zJykgT0sKIEVYUEVDVEVE ICh2aWRlby50ZXh0VHJhY2tzWzhdLm1vZGUgPT0gJ2Rpc2FibGVkJykgT0sKIAorUlVOKHZpZGVv LmN1cnJlbnRUaW1lID0gOS41KQorRVZFTlQoc2Vla2VkKQorRVhQRUNURUQgKHZpZGVvLnRleHRU cmFja3NbM10uYWN0aXZlQ3Vlcy5sZW5ndGggPT0gJzEnKSBPSworRVhQRUNURUQgKHRleHRUcmFj a0Rpc3BsYXlFbGVtZW50KHZpZGVvLCAnY3VlJykgIT0gJ251bGwnKSBPSworCiBFTkQgT0YgVEVT VAogCkluZGV4OiBMYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1mb3JjZWQtc3VidGl0bGVz LWluLWJhbmQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFj ay1mb3JjZWQtc3VidGl0bGVzLWluLWJhbmQuaHRtbAkocmV2aXNpb24gMTQ4NDU0KQorKysgTGF5 b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2stZm9yY2VkLXN1YnRpdGxlcy1pbi1iYW5kLmh0bWwJ KHdvcmtpbmcgY29weSkKQEAgLTksNiArOSwxNSBAQAogICAgICAgICA8c2NyaXB0PgogICAgICAg ICAgICAgdmFyIHRlc3QgPSAwOwogCisgICAgICAgICAgICBmdW5jdGlvbiBzZWVrZWQoKQorICAg ICAgICAgICAgeworICAgICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgidmlkZW8udGV4dFRyYWNr c1szXS5hY3RpdmVDdWVzLmxlbmd0aCIsIDEpOworICAgICAgICAgICAgICAgIHRlc3RFeHBlY3Rl ZCgidGV4dFRyYWNrRGlzcGxheUVsZW1lbnQodmlkZW8sICdjdWUnKSIsIG51bGwsICIhPSIpOwor ICAgICAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiIik7CisKKyAgICAgICAgICAgICAgICBlbmRU ZXN0KCk7CisgICAgICAgICAgICB9CisKICAgICAgICAgICAgIGZ1bmN0aW9uIHRlc3RGb3JjZWQo KQogICAgICAgICAgICAgewogICAgICAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiPGJyPjxpPioq IEZvcmNlZCB0cmFja3Mgc2hvdWxkIGJlIGluIC50ZXh0VHJhY2tzLCBidXQgbm90IGluIHRoZSBt ZW51PCIgKyAiL2k+Iik7CkBAIC02OCw3ICs3Nyw4IEBACiAgICAgICAgICAgICAgICAgdGVzdEV4 cGVjdGVkKCJ2aWRlby50ZXh0VHJhY2tzWzhdLm1vZGUiLCAiZGlzYWJsZWQiKTsKICAgICAgICAg ICAgICAgICBjb25zb2xlV3JpdGUoIiIpOwogCi0gICAgICAgICAgICAgICAgZW5kVGVzdCgpOwor ICAgICAgICAgICAgICAgIHdhaXRGb3JFdmVudCgnc2Vla2VkJywgc2Vla2VkKTsKKyAgICAgICAg ICAgICAgICBydW4oInZpZGVvLmN1cnJlbnRUaW1lID0gOS41Iik7CiAgICAgICAgICAgICB9CiAK ICAgICAgICAgICAgIGZ1bmN0aW9uIHNldHVwKCkK