114817 2013-04-18 09:04:41 -0700 Remove obsolete macros from libpng 2013-04-18 14:00:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 berto webkit-unassigned commit-queue mrobinson oldest_to_newest 877920 0 berto 2013-04-18 09:04:41 -0700 PNGImageEncoder.cpp uses png_voidp_NULL and png_error_ptr_NULL, which no longer exist in libpng 1.4. From the changelog: b. We removed the typecasted NULL definitions such as #define png_voidp_NULL (png_voidp)NULL If you used these in your application, just use NULL instead. http://www.libpng.org/pub/png/src/libpng-1.2.x-to-1.4.x-summary.txt 877922 1 198741 berto 2013-04-18 09:07:14 -0700 Created attachment 198741 Patch 877926 2 198742 berto 2013-04-18 09:14:22 -0700 Created attachment 198742 Patch There was a typo in the changelog message. 878070 3 198742 commit-queue 2013-04-18 14:00:11 -0700 Comment on attachment 198742 Patch Clearing flags on attachment: 198742 Committed r148701: <http://trac.webkit.org/changeset/148701> 878071 4 commit-queue 2013-04-18 14:00:13 -0700 All reviewed patches have been landed. Closing bug. 198741 2013-04-18 09:07:14 -0700 2013-04-18 09:14:22 -0700 Patch 114817.diff text/plain 1396 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NGM5N2YyLi41NDU5YmEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDQtMTggIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFJlbW92ZSBvYnNvbGV0ZSBtYWNyb3MgZnJvbSBsaWJwbmcKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDgxNworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGxpYnBuIGcxLjQgcmVtb3ZlcyB0aGUg cG5nX3ZvaWRwX05VTEwgYW5kIHBuZ19lcnJvcl9wdHJfTlVMTAorICAgICAgICBtYWNyb3MuIE51 bGwgcG9pbnRlcnMgbXVzdCBiZSB1c2VkIGRpcmVjdGx5IGluc3RlYWQuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9QTkdJbWFnZUVuY29kZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Y29tcHJlc3NSR0JBQmlnRW5kaWFuVG9QTkcpOgorCiAyMDEzLTA0LTE4ICBYdWVmZWkg UmVuICA8eHJlbkBibGFja2JlcnJ5LmNvbT4KIAogICAgICAgICByZW1vdmUgYnVpbGQgd2Fybmlu Zyh1bnVzZWQgcGFyYW1ldGVyKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v aW1hZ2UtZW5jb2RlcnMvUE5HSW1hZ2VFbmNvZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2ltYWdlLWVuY29kZXJzL1BOR0ltYWdlRW5jb2Rlci5jcHAKaW5kZXggMzU4ZDM1MS4uMzAx YWNiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZW5jb2RlcnMv UE5HSW1hZ2VFbmNvZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1l bmNvZGVycy9QTkdJbWFnZUVuY29kZXIuY3BwCkBAIC04NSw3ICs4NSw3IEBAIHByaXZhdGU6CiAK IGJvb2wgY29tcHJlc3NSR0JBQmlnRW5kaWFuVG9QTkcodW5zaWduZWQgY2hhciogcmdiYUJpZ0Vu ZGlhbkRhdGEsIGNvbnN0IEludFNpemUmIHNpemUsIFZlY3RvcjxjaGFyPiYgcG5nRGF0YSkKIHsK LSAgICBwbmdfc3RydWN0KiBwbmdQdHIgPSBwbmdfY3JlYXRlX3dyaXRlX3N0cnVjdChQTkdfTElC UE5HX1ZFUl9TVFJJTkcsIHBuZ192b2lkcF9OVUxMLCBwbmdfZXJyb3JfcHRyX05VTEwsIHBuZ19l cnJvcl9wdHJfTlVMTCk7CisgICAgcG5nX3N0cnVjdCogcG5nUHRyID0gcG5nX2NyZWF0ZV93cml0 ZV9zdHJ1Y3QoUE5HX0xJQlBOR19WRVJfU1RSSU5HLCAwLCAwLCAwKTsKICAgICBpZiAoIXBuZ1B0 cikKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCg== 198742 2013-04-18 09:14:22 -0700 2013-04-18 14:00:10 -0700 Patch 114817.diff text/plain 1396 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NGM5N2YyLi41NDU5YmEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDQtMTggIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFJlbW92ZSBvYnNvbGV0ZSBtYWNyb3MgZnJvbSBsaWJwbmcKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDgxNworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGxpYnBuZyAxLjQgcmVtb3ZlcyB0aGUg cG5nX3ZvaWRwX05VTEwgYW5kIHBuZ19lcnJvcl9wdHJfTlVMTAorICAgICAgICBtYWNyb3MuIE51 bGwgcG9pbnRlcnMgbXVzdCBiZSB1c2VkIGRpcmVjdGx5IGluc3RlYWQuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9QTkdJbWFnZUVuY29kZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Y29tcHJlc3NSR0JBQmlnRW5kaWFuVG9QTkcpOgorCiAyMDEzLTA0LTE4ICBYdWVmZWkg UmVuICA8eHJlbkBibGFja2JlcnJ5LmNvbT4KIAogICAgICAgICByZW1vdmUgYnVpbGQgd2Fybmlu Zyh1bnVzZWQgcGFyYW1ldGVyKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v aW1hZ2UtZW5jb2RlcnMvUE5HSW1hZ2VFbmNvZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2ltYWdlLWVuY29kZXJzL1BOR0ltYWdlRW5jb2Rlci5jcHAKaW5kZXggMzU4ZDM1MS4uMzAx YWNiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZW5jb2RlcnMv UE5HSW1hZ2VFbmNvZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1l bmNvZGVycy9QTkdJbWFnZUVuY29kZXIuY3BwCkBAIC04NSw3ICs4NSw3IEBAIHByaXZhdGU6CiAK IGJvb2wgY29tcHJlc3NSR0JBQmlnRW5kaWFuVG9QTkcodW5zaWduZWQgY2hhciogcmdiYUJpZ0Vu ZGlhbkRhdGEsIGNvbnN0IEludFNpemUmIHNpemUsIFZlY3RvcjxjaGFyPiYgcG5nRGF0YSkKIHsK LSAgICBwbmdfc3RydWN0KiBwbmdQdHIgPSBwbmdfY3JlYXRlX3dyaXRlX3N0cnVjdChQTkdfTElC UE5HX1ZFUl9TVFJJTkcsIHBuZ192b2lkcF9OVUxMLCBwbmdfZXJyb3JfcHRyX05VTEwsIHBuZ19l cnJvcl9wdHJfTlVMTCk7CisgICAgcG5nX3N0cnVjdCogcG5nUHRyID0gcG5nX2NyZWF0ZV93cml0 ZV9zdHJ1Y3QoUE5HX0xJQlBOR19WRVJfU1RSSU5HLCAwLCAwLCAwKTsKICAgICBpZiAoIXBuZ1B0 cikKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCg==