114815 2013-04-18 08:31:56 -0700 FrameLoaderClientBlackBerry.cpp should pass through an actual error code when calling notifyLoadFinished 2013-04-18 10:54:08 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 edbaker webkit-unassigned commit-queue oldest_to_newest 877909 0 edbaker 2013-04-18 08:31:56 -0700 It's just 0 or -1 depending on if an error occurred. Passing through the actual error code will be more useful. 877930 1 198743 edbaker 2013-04-18 09:18:53 -0700 Created attachment 198743 Patch 877955 2 198743 rwlbuis 2013-04-18 10:27:42 -0700 Comment on attachment 198743 Patch Makes sense. 877977 3 198743 commit-queue 2013-04-18 10:54:07 -0700 Comment on attachment 198743 Patch Clearing flags on attachment: 198743 Committed r148685: <http://trac.webkit.org/changeset/148685> 877978 4 commit-queue 2013-04-18 10:54:08 -0700 All reviewed patches have been landed. Closing bug. 198743 2013-04-18 09:18:53 -0700 2013-04-18 10:54:07 -0700 Patch bug-114815-20130418121808.patch text/plain 1743 edbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4Njc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA1Y2NhNTllNWY0NjZjZDZjNWFkNDQ1N2E1NWRmNzU2MWYyZjE5M2VkLi4wMzM4MmYwMWY4 ODI4MjUwMmRiMDBlMTdiMWFmMTljZjY5OTdkZDgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0wNC0xOCAgRWQgQmFrZXIgIDxlZGJha2VyQGJs YWNrYmVycnkuY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBTaG91bGQgcGFzcyB0aHJvdWdo IGFuIGFjdHVhbCBlcnJvciBjb2RlIHdoZW4gY2FsbGluZyBub3RpZnlMb2FkRmluaXNoZWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDgxNQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBSICMzMTgwNzkK KworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnk6OnBvc3RQ cm9ncmVzc0ZpbmlzaGVkTm90aWZpY2F0aW9uKToKKwogMjAxMy0wNC0xOCAgWHVlZmVpIFJlbiAg PHhyZW5AYmxhY2tiZXJyeS5jb20+CiAKICAgICAgICAgcmVtb3ZlIGJ1aWxkIHdhcm5pbmcodW51 c2VkIHBhcmFtZXRlcikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJD b3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5j cHAKaW5kZXggN2E1YTliMzI3NzQwMzUyMzlhYWY0Zjk0ZGFhMWNmYjcyMDc2NTM5NC4uYTFhYWM1 MDdhMmNjNTI2M2M3YjY3M2ZmNDU1ZTg0NTdhOThkNGYwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJy eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1l TG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAKQEAgLTkwMSw4ICs5MDEsNyBAQCB2b2lkIEZyYW1l TG9hZGVyQ2xpZW50QmxhY2tCZXJyeTo6cG9zdFByb2dyZXNzRmluaXNoZWROb3RpZmljYXRpb24o KQogICAgIC8vIHdlIG1heSBuZWVkIHRvIGNhbGwgcmVhZHlUb1JlbmRlciBub3cuCiAgICAgcmVh ZHlUb1JlbmRlcihmYWxzZSk7CiAKLSAgICAvLyBGSVhNRTogU2VuZCB1cCBhIHJlYWwgc3RhdHVz IGNvZGUuCi0gICAgbV93ZWJQYWdlUHJpdmF0ZS0+bV9jbGllbnQtPm5vdGlmeUxvYWRGaW5pc2hl ZChtX2xvYWRFcnJvci5pc051bGwoKSA/IDAgOiAtMSk7CisgICAgbV93ZWJQYWdlUHJpdmF0ZS0+ bV9jbGllbnQtPm5vdGlmeUxvYWRGaW5pc2hlZChtX2xvYWRFcnJvci5pc051bGwoKSA/IDAgOiBt X2xvYWRFcnJvci5lcnJvckNvZGUoKSk7CiAKICAgICAvLyBOb3RpZnkgcGx1Z2lucyB0aGF0IGFy ZSB3YWl0aW5nIGZvciB0aGUgcGFnZSB0byBmdWxseSBsb2FkIGJlZm9yZSBzdGFydGluZyB0aGF0 CiAgICAgLy8gdGhlIGxvYWQgaGFzIGNvbXBsZXRlZC4K