114814 2013-04-18 07:38:59 -0700 [BlackBerry] Improper initialization of ANGLEResources (resubmission) 2013-04-18 09:13:43 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jfeldstein webkit-unassigned commit-queue oldest_to_newest 877890 0 jfeldstein 2013-04-18 07:38:59 -0700 This is a resubmission of Bug 101489 which was accidentally reverted by Bug 111072. oes_standard_derivatives extension is being enabled by default, without getExtension having been called. This should not be allowed according to Khronos WebGL specs, section 5.14.14. 877894 1 198736 jfeldstein 2013-04-18 07:58:24 -0700 Created attachment 198736 Patch 877903 2 198739 jfeldstein 2013-04-18 08:20:56 -0700 Created attachment 198739 Patch 877908 3 198739 rwlbuis 2013-04-18 08:31:15 -0700 Comment on attachment 198739 Patch LGTM. 877924 4 198739 commit-queue 2013-04-18 09:13:41 -0700 Comment on attachment 198739 Patch Clearing flags on attachment: 198739 Committed r148680: <http://trac.webkit.org/changeset/148680> 877925 5 commit-queue 2013-04-18 09:13:43 -0700 All reviewed patches have been landed. Closing bug. 198736 2013-04-18 07:58:24 -0700 2013-04-18 08:20:56 -0700 Patch ANGLEResources.patch text/plain 3640 jfeldstein Y29tbWl0IDE5ZDA0OWI4MTQxZjk5NDQ2YmNjYzliOTk2ZTY1OWMzNjcyYjllYjAKQXV0aG9yOiBK b25hdGhhbiBGZWxkc3RlaW4gPGpmZWxkc3RlaW5AYmxhY2tiZXJyeS5jb20+CkRhdGU6ICAgVGh1 IEFwciAxOCAxMDo1MjowNSAyMDEzIC0wNDAwCgogICAgW0JsYWNrQmVycnldIEltcHJvcGVyIGlu aXRpYWxpemF0aW9uIG9mIEFOR0xFUmVzb3VyY2VzIChyZXN1Ym1pc3Npb24pCiAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0ODE0CiAgICAKICAgIFJldmlld2Vk IGJ5IFlvbmcgTGksIFJvYiBCdWlzCiAgICBJbnRlcm5hbGx5IHJldmlld2VkIGJ5IE1heGltIE1v Z2lsbml0c2t5CiAgICAKICAgIE1heERyYXdCdWZmZXJzLCBPRVNfc3RhbmRhcmRfZGVyaXZhdGl2 ZXMsIE9FU19FR0xfaW1hZ2VfZXh0ZXJuYWwgYW5kIEFSQl90ZXh0dXJlX3JlY3RhbmdsZQogICAg YXJlIGluaXRpYWxpemVkIHRocm91Z2ggdGhlIFNoQnVpbHRJblJlc291cmNlcyBmdW5jdGlvbiBz byB0aGVzZSBmaWVsZHMgZG8gbm90IG5lZWQgdG8gYmUKICAgIHNldCBhZ2FpbiBpbiBHcmFwaGlj c0NvbnRleHQzREJsYWNrQmVycnkuY3BwLiBJbiBhZGRpdGlvbiwgdGhlIGV4dGVuc2lvbiBmbGFn cyBzaG91bGQgbm90CiAgICBiZSBzZXQgdG8gdHJ1ZSB3aXRob3V0IGdldEV4dGVuc2lvbiBiZWlu ZyBjYWxsZWQgKEtocm9ub3MgV2ViR0wgc3BlY3MsIHNlY3Rpb24gNS4xNC4xNC4pLgogICAgSW4g ZmFjdCwgYXMgYSBkaXJlY3QgcmVzdWx0IG9mIHRoZXNlIGV4dGVuc2lvbnMgYmVpbmcgZW5hYmxl ZCBwcmlvciB0byBjYWxsaW5nCiAgICBnZXRFeHRlbnNpb24sIGEgV2ViR0wgY29uZm9ybWFuY2Ug c3VpdGUgdGVzdCBmb3IgR0xfT0VTX3N0YW5kYXJkX2Rlcml2YXRpdmVzIHdhcyBmYWlsaW5nLgog ICAgCiAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvR3JhcGhpY3NDb250ZXh0M0RC bGFja0JlcnJ5LmNwcDoKICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6R3JhcGhpY3ND b250ZXh0M0QpOgoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxMGU4YmE4Li4yNDVjZjMyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTMtMDQtMTggIEpvbmF0aGFuIEZlbGRzdGVpbiAgPGpmZWxkc3Rl aW5AYmxhY2tiZXJyeS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEltcHJvcGVyIGluaXRp YWxpemF0aW9uIG9mIEFOR0xFUmVzb3VyY2VzIChyZXN1Ym1pc3Npb24pCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ4MTQKKworICAgICAgICBSZXZp ZXdlZCBieSBZb25nIExpLCBSb2IgQnVpcworICAgICAgICBJbnRlcm5hbGx5IHJldmlld2VkIGJ5 IE1heGltIE1vZ2lsbml0c2t5CisKKyAgICAgICAgTWF4RHJhd0J1ZmZlcnMsIE9FU19zdGFuZGFy ZF9kZXJpdmF0aXZlcywgT0VTX0VHTF9pbWFnZV9leHRlcm5hbCBhbmQgQVJCX3RleHR1cmVfcmVj dGFuZ2xlCisgICAgICAgIGFyZSBpbml0aWFsaXplZCB0aHJvdWdoIHRoZSBTaEJ1aWx0SW5SZXNv dXJjZXMgZnVuY3Rpb24gc28gdGhlc2UgZmllbGRzIGRvIG5vdCBuZWVkIHRvIGJlCisgICAgICAg IHNldCBhZ2FpbiBpbiBHcmFwaGljc0NvbnRleHQzREJsYWNrQmVycnkuY3BwLiBJbiBhZGRpdGlv biwgdGhlIGV4dGVuc2lvbiBmbGFncyBzaG91bGQgbm90CisgICAgICAgIGJlIHNldCB0byB0cnVl IHdpdGhvdXQgZ2V0RXh0ZW5zaW9uIGJlaW5nIGNhbGxlZCAoS2hyb25vcyBXZWJHTCBzcGVjcywg c2VjdGlvbiA1LjE0LjE0LikuCisgICAgICAgIEluIGZhY3QsIGFzIGEgZGlyZWN0IHJlc3VsdCBv ZiB0aGVzZSBleHRlbnNpb25zIGJlaW5nIGVuYWJsZWQgcHJpb3IgdG8gY2FsbGluZworICAgICAg ICBnZXRFeHRlbnNpb24sIGEgV2ViR0wgY29uZm9ybWFuY2Ugc3VpdGUgdGVzdCBmb3IgR0xfT0VT X3N0YW5kYXJkX2Rlcml2YXRpdmVzIHdhcyBmYWlsaW5nLgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvYmxhY2tiZXJyeS9HcmFwaGljc0NvbnRleHQzREJsYWNrQmVycnkuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0Q6OkdyYXBoaWNzQ29udGV4dDNEKToKKwog MjAxMy0wNC0wOCAgVGlhbmNoZW5nIEppYW5nICA8dGlqaWFuZ0ByaW0uY29tPgogCiAgICAgICAg IFtCbGFja0JlcnJ5XSBDbGVhbiB1cCByZW5kZXIgdGhlbWUgY29kZS4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvR3JhcGhpY3NDb250ZXh0 M0RCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNr YmVycnkvR3JhcGhpY3NDb250ZXh0M0RCbGFja0JlcnJ5LmNwcAppbmRleCBlMmY3YmI4Li4yN2Uw YTIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2Jl cnJ5L0dyYXBoaWNzQ29udGV4dDNEQmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9HcmFwaGljc0NvbnRleHQzREJsYWNrQmVycnku Y3BwCkBAIC0xMDgsMTIgKzEwOCw2IEBAIEdyYXBoaWNzQ29udGV4dDNEOjpHcmFwaGljc0NvbnRl eHQzRChHcmFwaGljc0NvbnRleHQzRDo6QXR0cmlidXRlcyBhdHRycywgSG9zdFdpCiAgICAgZ2V0 SW50ZWdlcnYoR3JhcGhpY3NDb250ZXh0M0Q6Ok1BWF9URVhUVVJFX0lNQUdFX1VOSVRTLCAmQU5H TEVSZXNvdXJjZXMuTWF4VGV4dHVyZUltYWdlVW5pdHMpOwogICAgIGdldEludGVnZXJ2KEdyYXBo aWNzQ29udGV4dDNEOjpNQVhfRlJBR01FTlRfVU5JRk9STV9WRUNUT1JTLCAmQU5HTEVSZXNvdXJj ZXMuTWF4RnJhZ21lbnRVbmlmb3JtVmVjdG9ycyk7CiAKLSAgICBFeHRlbnNpb25zM0QqIGV4dGVu c2lvbnMgPSBnZXRFeHRlbnNpb25zKCk7Ci0gICAgQU5HTEVSZXNvdXJjZXMuTWF4RHJhd0J1ZmZl cnMgPSAxOyAvLyBBbHdheXMgc2V0IHRvIDEgZm9yIE9wZW5HTCBFUy4KLSAgICBBTkdMRVJlc291 cmNlcy5PRVNfc3RhbmRhcmRfZGVyaXZhdGl2ZXMgPSBleHRlbnNpb25zLT5zdXBwb3J0cygiR0xf T0VTX3N0YW5kYXJkX2Rlcml2YXRpdmVzIik7Ci0gICAgQU5HTEVSZXNvdXJjZXMuT0VTX0VHTF9p bWFnZV9leHRlcm5hbCA9IGV4dGVuc2lvbnMtPnN1cHBvcnRzKCJHTF9FR0xfaW1hZ2VfZXh0ZXJu YWwiKTsKLSAgICBBTkdMRVJlc291cmNlcy5BUkJfdGV4dHVyZV9yZWN0YW5nbGUgPSBleHRlbnNp b25zLT5zdXBwb3J0cygiR0xfQVJCX3RleHR1cmVfcmVjdGFuZ2xlIik7Ci0KICAgICBHQzNEaW50 IHJhbmdlWzJdLCBwcmVjaXNpb247CiAgICAgZ2V0U2hhZGVyUHJlY2lzaW9uRm9ybWF0KEdyYXBo aWNzQ29udGV4dDNEOjpGUkFHTUVOVF9TSEFERVIsIEdyYXBoaWNzQ29udGV4dDNEOjpISUdIX0ZM T0FULCByYW5nZSwgJnByZWNpc2lvbik7CiAgICAgQU5HTEVSZXNvdXJjZXMuRnJhZ21lbnRQcmVj aXNpb25IaWdoID0gKHJhbmdlWzBdIHx8IHJhbmdlWzFdIHx8IHByZWNpc2lvbik7Cg== 198739 2013-04-18 08:20:56 -0700 2013-04-18 09:13:41 -0700 Patch ANGLEResources.patch text/plain 3637 jfeldstein Y29tbWl0IDM0ZjE0MzY3NWVmMjk0NTE5Mzk5YmQ0NWQ1NmU3ZTY4MTZiMTM2NGYKQXV0aG9yOiBK b25hdGhhbiBGZWxkc3RlaW4gPGpmZWxkc3RlaW5AYmxhY2tiZXJyeS5jb20+CkRhdGU6ICAgVGh1 IEFwciAxOCAxMToxODo1NiAyMDEzIC0wNDAwCgogICAgW0JsYWNrQmVycnldIEltcHJvcGVyIGlu aXRpYWxpemF0aW9uIG9mIEFOR0xFUmVzb3VyY2VzIChyZXN1Ym1pc3Npb24pCiAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0ODE0CiAgICAKICAgIFJldmlld2Vk IGJ5IFlvbmcgTGksIFJvYiBCdWlzCiAgICBJbnRlcm5hbGx5IHJldmlld2VkIGJ5IE1heGltIE1v Z2lsbml0c2t5CiAgICAKICAgIE1heERyYXdCdWZmZXJzLCBPRVNfc3RhbmRhcmRfZGVyaXZhdGl2 ZXMsIE9FU19FR0xfaW1hZ2VfZXh0ZXJuYWwgYW5kIEFSQl90ZXh0dXJlX3JlY3RhbmdsZQogICAg YXJlIGluaXRpYWxpemVkIHRocm91Z2ggdGhlIFNoQnVpbHRJblJlc291cmNlcyBmdW5jdGlvbiBz byB0aGVzZSBmaWVsZHMgZG8gbm90IG5lZWQgdG8gYmUKICAgIHNldCBhZ2FpbiBpbiBHcmFwaGlj c0NvbnRleHQzREJsYWNrQmVycnkuY3BwLiBJbiBhZGRpdGlvbiwgdGhlIGV4dGVuc2lvbiBmbGFn cyBzaG91bGQgbm90CiAgICBiZSBzZXQgdG8gdHJ1ZSB3aXRob3V0IGdldEV4dGVuc2lvbiBiZWlu ZyBjYWxsZWQgKEtocm9ub3MgV2ViR0wgc3BlY3MsIHNlY3Rpb24gNS4xNC4xNC4pLgogICAgSW4g ZmFjdCwgYXMgYSBkaXJlY3QgcmVzdWx0IG9mIHRoZXNlIGV4dGVuc2lvbnMgYmVpbmcgZW5hYmxl ZCBwcmlvciB0byBjYWxsaW5nCiAgICBnZXRFeHRlbnNpb24sIGEgV2ViR0wgY29uZm9ybWFuY2Ug c3VpdGUgdGVzdCBmb3IgR0xfT0VTX3N0YW5kYXJkX2Rlcml2YXRpdmVzIHdhcyBmYWlsaW5nLgog ICAgCiAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvR3JhcGhpY3NDb250ZXh0M0RC bGFja0JlcnJ5LmNwcDoKICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6R3JhcGhpY3ND b250ZXh0M0QpOgoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3NGM5N2YyLi42ODk5ZGU0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTMtMDQtMTggIEpvbmF0aGFuIEZlbGRzdGVpbiAgPGpmZWxkc3Rl aW5AYmxhY2tiZXJyeS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEltcHJvcGVyIGluaXRp YWxpemF0aW9uIG9mIEFOR0xFUmVzb3VyY2VzIChyZXN1Ym1pc3Npb24pCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ4MTQKKworICAgICAgICBSZXZp ZXdlZCBieSBZb25nIExpLCBSb2IgQnVpcworICAgICAgICBJbnRlcm5hbGx5IHJldmlld2VkIGJ5 IE1heGltIE1vZ2lsbml0c2t5CisKKyAgICAgICAgTWF4RHJhd0J1ZmZlcnMsIE9FU19zdGFuZGFy ZF9kZXJpdmF0aXZlcywgT0VTX0VHTF9pbWFnZV9leHRlcm5hbCBhbmQgQVJCX3RleHR1cmVfcmVj dGFuZ2xlCisgICAgICAgIGFyZSBpbml0aWFsaXplZCB0aHJvdWdoIHRoZSBTaEJ1aWx0SW5SZXNv dXJjZXMgZnVuY3Rpb24gc28gdGhlc2UgZmllbGRzIGRvIG5vdCBuZWVkIHRvIGJlCisgICAgICAg IHNldCBhZ2FpbiBpbiBHcmFwaGljc0NvbnRleHQzREJsYWNrQmVycnkuY3BwLiBJbiBhZGRpdGlv biwgdGhlIGV4dGVuc2lvbiBmbGFncyBzaG91bGQgbm90CisgICAgICAgIGJlIHNldCB0byB0cnVl IHdpdGhvdXQgZ2V0RXh0ZW5zaW9uIGJlaW5nIGNhbGxlZCAoS2hyb25vcyBXZWJHTCBzcGVjcywg c2VjdGlvbiA1LjE0LjE0LikuCisgICAgICAgIEluIGZhY3QsIGFzIGEgZGlyZWN0IHJlc3VsdCBv ZiB0aGVzZSBleHRlbnNpb25zIGJlaW5nIGVuYWJsZWQgcHJpb3IgdG8gY2FsbGluZworICAgICAg ICBnZXRFeHRlbnNpb24sIGEgV2ViR0wgY29uZm9ybWFuY2Ugc3VpdGUgdGVzdCBmb3IgR0xfT0VT X3N0YW5kYXJkX2Rlcml2YXRpdmVzIHdhcyBmYWlsaW5nLgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvYmxhY2tiZXJyeS9HcmFwaGljc0NvbnRleHQzREJsYWNrQmVycnkuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0Q6OkdyYXBoaWNzQ29udGV4dDNEKToKKwog MjAxMy0wNC0xOCAgWHVlZmVpIFJlbiAgPHhyZW5AYmxhY2tiZXJyeS5jb20+CiAKICAgICAgICAg cmVtb3ZlIGJ1aWxkIHdhcm5pbmcodW51c2VkIHBhcmFtZXRlcikKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvR3JhcGhpY3NDb250ZXh0M0RC bGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVy cnkvR3JhcGhpY3NDb250ZXh0M0RCbGFja0JlcnJ5LmNwcAppbmRleCBlMmY3YmI4Li4yN2UwYTIw IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5 L0dyYXBoaWNzQ29udGV4dDNEQmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9HcmFwaGljc0NvbnRleHQzREJsYWNrQmVycnkuY3Bw CkBAIC0xMDgsMTIgKzEwOCw2IEBAIEdyYXBoaWNzQ29udGV4dDNEOjpHcmFwaGljc0NvbnRleHQz RChHcmFwaGljc0NvbnRleHQzRDo6QXR0cmlidXRlcyBhdHRycywgSG9zdFdpCiAgICAgZ2V0SW50 ZWdlcnYoR3JhcGhpY3NDb250ZXh0M0Q6Ok1BWF9URVhUVVJFX0lNQUdFX1VOSVRTLCAmQU5HTEVS ZXNvdXJjZXMuTWF4VGV4dHVyZUltYWdlVW5pdHMpOwogICAgIGdldEludGVnZXJ2KEdyYXBoaWNz Q29udGV4dDNEOjpNQVhfRlJBR01FTlRfVU5JRk9STV9WRUNUT1JTLCAmQU5HTEVSZXNvdXJjZXMu TWF4RnJhZ21lbnRVbmlmb3JtVmVjdG9ycyk7CiAKLSAgICBFeHRlbnNpb25zM0QqIGV4dGVuc2lv bnMgPSBnZXRFeHRlbnNpb25zKCk7Ci0gICAgQU5HTEVSZXNvdXJjZXMuTWF4RHJhd0J1ZmZlcnMg PSAxOyAvLyBBbHdheXMgc2V0IHRvIDEgZm9yIE9wZW5HTCBFUy4KLSAgICBBTkdMRVJlc291cmNl cy5PRVNfc3RhbmRhcmRfZGVyaXZhdGl2ZXMgPSBleHRlbnNpb25zLT5zdXBwb3J0cygiR0xfT0VT X3N0YW5kYXJkX2Rlcml2YXRpdmVzIik7Ci0gICAgQU5HTEVSZXNvdXJjZXMuT0VTX0VHTF9pbWFn ZV9leHRlcm5hbCA9IGV4dGVuc2lvbnMtPnN1cHBvcnRzKCJHTF9FR0xfaW1hZ2VfZXh0ZXJuYWwi KTsKLSAgICBBTkdMRVJlc291cmNlcy5BUkJfdGV4dHVyZV9yZWN0YW5nbGUgPSBleHRlbnNpb25z LT5zdXBwb3J0cygiR0xfQVJCX3RleHR1cmVfcmVjdGFuZ2xlIik7Ci0KICAgICBHQzNEaW50IHJh bmdlWzJdLCBwcmVjaXNpb247CiAgICAgZ2V0U2hhZGVyUHJlY2lzaW9uRm9ybWF0KEdyYXBoaWNz Q29udGV4dDNEOjpGUkFHTUVOVF9TSEFERVIsIEdyYXBoaWNzQ29udGV4dDNEOjpISUdIX0ZMT0FU LCByYW5nZSwgJnByZWNpc2lvbik7CiAgICAgQU5HTEVSZXNvdXJjZXMuRnJhZ21lbnRQcmVjaXNp b25IaWdoID0gKHJhbmdlWzBdIHx8IHJhbmdlWzFdIHx8IHByZWNpc2lvbik7Cg==