114808 2013-04-18 05:24:40 -0700 [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5 2013-05-07 04:01:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P3 Normal --- 114171 1 abecsi abecsi jturcotte ossy zarvai oldest_to_newest 877827 0 abecsi 2013-04-18 05:24:40 -0700 http://trac.webkit.org/changeset/131727 introduced a workaround to speed up layout tests on buildbots running in Xvfb. This workaround depended on QQuickWindowPrivate::setRenderWithoutShowing which has been removed from QtDeclarative in https://codereview.qt-project.org/53880, thus we have to find a new solution for this problem. 877831 1 jturcotte 2013-04-18 05:34:10 -0700 What? Maybe they didn't know we used it, it's not really dead code. 885036 2 200704 abecsi 2013-05-06 08:52:20 -0700 Created attachment 200704 Patch 885037 3 abecsi 2013-05-06 08:53:23 -0700 (In reply to comment #2) > Created an attachment (id=200704) [details] > Patch This probably needs a Qt version update on the bots. 885042 4 200704 jturcotte 2013-05-06 09:09:00 -0700 Comment on attachment 200704 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200704&action=review > Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp:69 > + // Remove this as soon as we depend on Qt 5.1 I think you can omit the comment, it won't be necessary to remove it before we completely stop supporting Qt 5.0 in trunk. 885061 5 200708 abecsi 2013-05-06 09:37:10 -0700 Created attachment 200708 Patch 885064 6 200708 abecsi 2013-05-06 09:39:31 -0700 Comment on attachment 200708 Patch Ossy, feel free to land this if it is not causing issues for the pixel testing bot, since I'm not sure what version of Qt 5 is used there. 885668 7 200708 abecsi 2013-05-07 04:01:11 -0700 Comment on attachment 200708 Patch Clearing flags on attachment: 200708 Committed r149667: <http://trac.webkit.org/changeset/149667> 885669 8 abecsi 2013-05-07 04:01:18 -0700 All reviewed patches have been landed. Closing bug. 200704 2013-05-06 08:52:20 -0700 2013-05-06 09:37:05 -0700 Patch bug-114808-20130506174811.patch text/plain 1588 abecsi U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5NTk5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDcwYzA0OTNiYmRiMTIzZGM4MDRkOWI0ODIwZTQ5YzAy YjZhNWI5YS4uNjkyNzAzY2E5MTM3ZTI3OWU5NjQ3Y2YyMGNjNzBhNmFlMjFmNjA3NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEzLTA1LTA2ICBBbmRyYXMgQmVjc2kgIDxhbmRyYXMuYmVjc2lAZGlnaWEuY29tPgor CisgICAgICAgIFtRdF1bV1RSXSBRUXVpY2tXaW5kb3dQcml2YXRlOjpzZXRSZW5kZXJXaXRob3V0 U2hvd2luZyBoYXMgYmVlbiByZW1vdmVkIGZyb20gUXQgNQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0ODA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUVF1aWNrV2luZG93OjpncmFiV2luZG93KCkgaGFz IGJlZW4gaW1wbGVtZW50ZWQgZm9yIGlzVmlzaWJsZT1mYWxzZSBmb3IgUXQgNS4xLgorICAgICAg ICAoaHR0cHM6Ly9jb2RlcmV2aWV3LnF0LXByb2plY3Qub3JnLyNjaGFuZ2UsNTQyMzQpCisKKyAg ICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL3F0L1BsYXRmb3JtV2ViVmlld1F0LmNwcDoKKyAgICAg ICAgKFdUUjo6V3JhcHBlcldpbmRvdzo6aGFuZGxlU3RhdHVzQ2hhbmdlZCk6CisKIDIwMTMtMDUt MDYgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZGVkIHR3byBm aWxlcyBJIG5lZ2xlY3RlZCB0byBjb21taXQgaW4gcjE0OTU4OS4KZGlmZiAtLWdpdCBhL1Rvb2xz L1dlYktpdFRlc3RSdW5uZXIvcXQvUGxhdGZvcm1XZWJWaWV3UXQuY3BwIGIvVG9vbHMvV2ViS2l0 VGVzdFJ1bm5lci9xdC9QbGF0Zm9ybVdlYlZpZXdRdC5jcHAKaW5kZXggN2ZjNjRhYWFkZmRjNmZh OGM0NDA0OGU4MWNkYjE5YzE3ODM0ZGJkMS4uMjBkYTAxZjkxN2UyZGQ5MjNhMmM2OWY2MThjN2Nh MjkzYWZjZDk0MiAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9QbGF0Zm9y bVdlYlZpZXdRdC5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9QbGF0Zm9ybVdl YlZpZXdRdC5jcHAKQEAgLTY1LDcgKzY1LDEwIEBAIHByaXZhdGUgUV9TTE9UUzoKICAgICAgICAg aWYgKFBsYXRmb3JtV2ViVmlldzo6d2luZG93U2hhcHNob3RFbmFibGVkKCkpIHsKICAgICAgICAg ICAgIHNldFN1cmZhY2VUeXBlKE9wZW5HTFN1cmZhY2UpOwogICAgICAgICAgICAgY3JlYXRlKCk7 CisjaWYgUVRfVkVSU0lPTiA8IFFUX1ZFUlNJT05fQ0hFQ0soNSwgMSwgMCkKKyAgICAgICAgICAg IC8vIFJlbW92ZSB0aGlzIGFzIHNvb24gYXMgd2UgZGVwZW5kIG9uIFF0IDUuMQogICAgICAgICAg ICAgUVF1aWNrV2luZG93UHJpdmF0ZTo6Z2V0KHRoaXMpLT5zZXRSZW5kZXJXaXRob3V0U2hvd2lu Zyh0cnVlKTsKKyNlbmRpZgogICAgICAgICB9IGVsc2UKICAgICAgICAgICAgIG1fdmlldy0+ZXhw ZXJpbWVudGFsKCktPnNldFJlbmRlclRvT2Zmc2NyZWVuQnVmZmVyKHRydWUpOwogCg== 200708 2013-05-06 09:37:10 -0700 2013-05-07 04:01:11 -0700 Patch bug-114808-20130506183301.patch text/plain 1530 abecsi U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5NjAwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDcwYzA0OTNiYmRiMTIzZGM4MDRkOWI0ODIwZTQ5YzAy YjZhNWI5YS4uYTA2ZTIzOTVlOTU0MmYwYzgwODMwNWRmMTM2ODc1NDUxMjM2MmE4OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEzLTA1LTA2ICBBbmRyYXMgQmVjc2kgIDxhbmRyYXMuYmVjc2lAZGlnaWEuY29tPgor CisgICAgICAgIFtRdF1bV1RSXSBRUXVpY2tXaW5kb3dQcml2YXRlOjpzZXRSZW5kZXJXaXRob3V0 U2hvd2luZyBoYXMgYmVlbiByZW1vdmVkIGZyb20gUXQgNQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0ODA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Sm9jZWx5biBUdXJjb3R0ZS4KKworICAgICAgICBRUXVpY2tXaW5kb3c6OmdyYWJXaW5kb3coKSBo YXMgYmVlbiBpbXBsZW1lbnRlZCBmb3IgaXNWaXNpYmxlPWZhbHNlIGZvciBRdCA1LjEuCisgICAg ICAgIChodHRwczovL2NvZGVyZXZpZXcucXQtcHJvamVjdC5vcmcvI2NoYW5nZSw1NDIzNCkKKwor ICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvcXQvUGxhdGZvcm1XZWJWaWV3UXQuY3BwOgorICAg ICAgICAoV1RSOjpXcmFwcGVyV2luZG93OjpoYW5kbGVTdGF0dXNDaGFuZ2VkKToKKwogMjAxMy0w NS0wNiAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgQWRkZWQgdHdv IGZpbGVzIEkgbmVnbGVjdGVkIHRvIGNvbW1pdCBpbiByMTQ5NTg5LgpkaWZmIC0tZ2l0IGEvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9QbGF0Zm9ybVdlYlZpZXdRdC5jcHAgYi9Ub29scy9XZWJL aXRUZXN0UnVubmVyL3F0L1BsYXRmb3JtV2ViVmlld1F0LmNwcAppbmRleCA3ZmM2NGFhYWRmZGM2 ZmE4YzQ0MDQ4ZTgxY2RiMTljMTc4MzRkYmQxLi5kN2FiM2M0YjU4NDdhMjMwNzBmZDE2ZGM5MGZk OTBjNmU4YjRmODkwIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL3F0L1BsYXRm b3JtV2ViVmlld1F0LmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL3F0L1BsYXRmb3Jt V2ViVmlld1F0LmNwcApAQCAtNjUsNyArNjUsOSBAQCBwcml2YXRlIFFfU0xPVFM6CiAgICAgICAg IGlmIChQbGF0Zm9ybVdlYlZpZXc6OndpbmRvd1NoYXBzaG90RW5hYmxlZCgpKSB7CiAgICAgICAg ICAgICBzZXRTdXJmYWNlVHlwZShPcGVuR0xTdXJmYWNlKTsKICAgICAgICAgICAgIGNyZWF0ZSgp OworI2lmIFFUX1ZFUlNJT04gPCBRVF9WRVJTSU9OX0NIRUNLKDUsIDEsIDApCiAgICAgICAgICAg ICBRUXVpY2tXaW5kb3dQcml2YXRlOjpnZXQodGhpcyktPnNldFJlbmRlcldpdGhvdXRTaG93aW5n KHRydWUpOworI2VuZGlmCiAgICAgICAgIH0gZWxzZQogICAgICAgICAgICAgbV92aWV3LT5leHBl cmltZW50YWwoKS0+c2V0UmVuZGVyVG9PZmZzY3JlZW5CdWZmZXIodHJ1ZSk7CiAK