114806 2013-04-18 03:54:41 -0700 [EFL][WK2] Change inadequate return value in method setDone(). 2013-04-18 06:07:09 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 k.wolanski webkit-unassigned cdumez commit-queue lucas.de.marchi oldest_to_newest 877804 0 k.wolanski 2013-04-18 03:54:41 -0700 Fix possible warning in EFL port: no return statement in function returning non-void. Change return value from bool to void in method setDone(). 877816 1 198721 k.wolanski 2013-04-18 04:50:08 -0700 Created attachment 198721 proposed patch 877819 2 198721 cdumez 2013-04-18 05:01:26 -0700 Comment on attachment 198721 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=198721&action=review > Source/WebKit2/ChangeLog:3 > + [EFL] Change inadequate return value in method setDone(). LGTM but you should add [WK2] tag. 877825 3 198723 k.wolanski 2013-04-18 05:21:01 -0700 Created attachment 198723 proposed patch 877828 4 198724 k.wolanski 2013-04-18 05:26:27 -0700 Created attachment 198724 added [WK2] tag 877833 5 198724 kling 2013-04-18 05:38:30 -0700 Comment on attachment 198724 added [WK2] tag rs=me 877853 6 198724 commit-queue 2013-04-18 06:07:06 -0700 Comment on attachment 198724 added [WK2] tag Clearing flags on attachment: 198724 Committed r148671: <http://trac.webkit.org/changeset/148671> 877854 7 commit-queue 2013-04-18 06:07:09 -0700 All reviewed patches have been landed. Closing bug. 198721 2013-04-18 04:50:08 -0700 2013-04-18 05:21:01 -0700 proposed patch fix_setDone_warning.patch text/plain 1322 k.wolanski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkNjU5YTNmLi4xYjc4MGVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDQtMTggIEtyenlzenRvZiBXb2xhbnNraSAgPGsud29sYW5za2lAc2Ftc3VuZy5j b20+OgorCisgICAgICAgIFtFRkxdIENoYW5nZSBpbmFkZXF1YXRlIHJldHVybiB2YWx1ZSBpbiBt ZXRob2Qgc2V0RG9uZSgpLgorICAgICAgICBOZWVkIHRoZSBidWcgVVJMIChPT1BTISkuCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHBvc3NpYmxl IHdhcm5pbmcgaW4gRUZMIHBvcnQ6IG5vIHJldHVybiBzdGF0ZW1lbnQgaW4gZnVuY3Rpb24gcmV0 dXJuaW5nIG5vbi12b2lkLgorICAgICAgICBDaGFuZ2UgcmV0dXJuIHZhbHVlIGZyb20gYm9vbCB0 byB2b2lkIGluIG1ldGhvZCBzZXREb25lKCkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2Vm bC90ZXN0cy9Vbml0VGVzdFV0aWxzL0VXSzJVbml0VGVzdEJhc2UuY3BwOgorICAgICAgICAoRVdL MlVuaXRUZXN0OjpDYWxsYmFja0RhdGFUaW1lcjo6c2V0RG9uZSk6CisKIDIwMTMtMDQtMTggIFhh biBMb3BleiAgPHhhbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFdoZW4gdGhlIFdlYlBy b2Nlc3MgY3Jhc2hlcywgYSBzaWduYWwgc2hvdWxkIGJlIGVtaXR0ZWQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdLMlVu aXRUZXN0QmFzZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy9V bml0VGVzdFV0aWxzL0VXSzJVbml0VGVzdEJhc2UuY3BwCmluZGV4IDZlOGJhZTIuLmM4ZjRjZmQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL1VuaXRU ZXN0VXRpbHMvRVdLMlVuaXRUZXN0QmFzZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9FV0syVW5pdFRlc3RCYXNlLmNwcApAQCAt MTA2LDcgKzEwNiw3IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgaXNEb25lKCkgY29uc3QgeyByZXR1 cm4gbV9kb25lOyB9CiAKLSAgICBib29sIHNldERvbmUoKQorICAgIHZvaWQgc2V0RG9uZSgpCiAg ICAgewogICAgICAgICBpZiAobV90aW1lcikgewogICAgICAgICAgICAgZWNvcmVfdGltZXJfZGVs KG1fdGltZXIpOwo= 198723 2013-04-18 05:21:01 -0700 2013-04-18 05:26:27 -0700 proposed patch fix_setDone_warning.patch text/plain 1343 k.wolanski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkNjU5YTNmLi4xYjc4MGVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDQtMTggIEtyenlzenRvZiBXb2xhbnNraSAgPGsud29sYW5za2lAc2Ftc3VuZy5j b20+OgorCisgICAgICAgIFtFRkxdIENoYW5nZSBpbmFkZXF1YXRlIHJldHVybiB2YWx1ZSBpbiBt ZXRob2Qgc2V0RG9uZSgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTE0ODA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRml4IHBvc3NpYmxlIHdhcm5pbmcgaW4gRUZMIHBvcnQ6IG5vIHJldHVybiBzdGF0 ZW1lbnQgaW4gZnVuY3Rpb24gcmV0dXJuaW5nIG5vbi12b2lkLgorICAgICAgICBDaGFuZ2UgcmV0 dXJuIHZhbHVlIGZyb20gYm9vbCB0byB2b2lkIGluIG1ldGhvZCBzZXREb25lKCkuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy9Vbml0VGVzdFV0aWxzL0VXSzJVbml0VGVzdEJh c2UuY3BwOgorICAgICAgICAoRVdLMlVuaXRUZXN0OjpDYWxsYmFja0RhdGFUaW1lcjo6c2V0RG9u ZSk6CisKIDIwMTMtMDQtMTggIFhhbiBMb3BleiAgPHhhbkBpZ2FsaWEuY29tPgogCiAgICAgICAg IFtHVEtdIFdoZW4gdGhlIFdlYlByb2Nlc3MgY3Jhc2hlcywgYSBzaWduYWwgc2hvdWxkIGJlIGVt aXR0ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3Rz L1VuaXRUZXN0VXRpbHMvRVdLMlVuaXRUZXN0QmFzZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2VmbC90ZXN0cy9Vbml0VGVzdFV0aWxzL0VXSzJVbml0VGVzdEJhc2UuY3BwCmlu ZGV4IDZlOGJhZTIuLmM4ZjRjZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdLMlVuaXRUZXN0QmFzZS5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9FV0sy VW5pdFRlc3RCYXNlLmNwcApAQCAtMTA2LDcgKzEwNiw3IEBAIHB1YmxpYzoKIAogICAgIGJvb2wg aXNEb25lKCkgY29uc3QgeyByZXR1cm4gbV9kb25lOyB9CiAKLSAgICBib29sIHNldERvbmUoKQor ICAgIHZvaWQgc2V0RG9uZSgpCiAgICAgewogICAgICAgICBpZiAobV90aW1lcikgewogICAgICAg ICAgICAgZWNvcmVfdGltZXJfZGVsKG1fdGltZXIpOwo= 198724 2013-04-18 05:26:27 -0700 2013-04-18 06:07:06 -0700 added [WK2] tag fix_setDone_warning.patch text/plain 1348 k.wolanski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkNjU5YTNmLi4xYjc4MGVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDQtMTggIEtyenlzenRvZiBXb2xhbnNraSAgPGsud29sYW5za2lAc2Ftc3VuZy5j b20+OgorCisgICAgICAgIFtFRkxdW1dLMl0gQ2hhbmdlIGluYWRlcXVhdGUgcmV0dXJuIHZhbHVl IGluIG1ldGhvZCBzZXREb25lKCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTQ4MDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBGaXggcG9zc2libGUgd2FybmluZyBpbiBFRkwgcG9ydDogbm8gcmV0dXJu IHN0YXRlbWVudCBpbiBmdW5jdGlvbiByZXR1cm5pbmcgbm9uLXZvaWQuCisgICAgICAgIENoYW5n ZSByZXR1cm4gdmFsdWUgZnJvbSBib29sIHRvIHZvaWQgaW4gbWV0aG9kIHNldERvbmUoKS4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdLMlVuaXRU ZXN0QmFzZS5jcHA6CisgICAgICAgIChFV0syVW5pdFRlc3Q6OkNhbGxiYWNrRGF0YVRpbWVyOjpz ZXREb25lKToKKwogMjAxMy0wNC0xOCAgWGFuIExvcGV6ICA8eGFuQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW0dUS10gV2hlbiB0aGUgV2ViUHJvY2VzcyBjcmFzaGVzLCBhIHNpZ25hbCBzaG91bGQg YmUgZW1pdHRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv dGVzdHMvVW5pdFRlc3RVdGlscy9FV0syVW5pdFRlc3RCYXNlLmNwcCBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdLMlVuaXRUZXN0QmFzZS5j cHAKaW5kZXggNmU4YmFlMi4uYzhmNGNmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9FV0syVW5pdFRlc3RCYXNlLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy9Vbml0VGVzdFV0aWxz L0VXSzJVbml0VGVzdEJhc2UuY3BwCkBAIC0xMDYsNyArMTA2LDcgQEAgcHVibGljOgogCiAgICAg Ym9vbCBpc0RvbmUoKSBjb25zdCB7IHJldHVybiBtX2RvbmU7IH0KIAotICAgIGJvb2wgc2V0RG9u ZSgpCisgICAgdm9pZCBzZXREb25lKCkKICAgICB7CiAgICAgICAgIGlmIChtX3RpbWVyKSB7CiAg ICAgICAgICAgICBlY29yZV90aW1lcl9kZWwobV90aW1lcik7Cg==