114803 2013-04-18 03:43:18 -0700 [Dashboard] Remove Chromium-specific helper functions that were used in the builder-loading code 2013-04-19 01:41:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 114607 1 zan zan oldest_to_newest 877798 0 zan 2013-04-18 03:43:18 -0700 [Dashboard] Remove Chromium-specific helper functions that were used in the builder-loading code 877799 1 198712 zan 2013-04-18 03:45:54 -0700 Created attachment 198712 Patch 878309 2 198712 zan 2013-04-19 01:41:06 -0700 Comment on attachment 198712 Patch Clearing flags on attachment: 198712 Committed r148733: <http://trac.webkit.org/changeset/148733> 878310 3 zan 2013-04-19 01:41:10 -0700 All reviewed patches have been landed. Closing bug. 198712 2013-04-18 03:45:54 -0700 2013-04-19 01:41:06 -0700 Patch bug-114803-20130418124524.patch text/plain 4630 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NjYwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGE2N2M4ZjEwOGIyMmI4NWIzZjU5YzhkMTZhODIyMWUw YjI4OTQyMC4uNTE1NzQ0Yzg1ZTBjMWFjMDMwNDU3ODhkODM1ZDdiZWRmZmIxMzU2YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5 IEBACiAyMDEzLTA0LTE4ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAor ICAgICAgICBbRGFzaGJvYXJkXSBSZW1vdmUgQ2hyb21pdW0tc3BlY2lmaWMgaGVscGVyIGZ1bmN0 aW9ucyB0aGF0IHdlcmUgdXNlZCBpbiB0aGUgYnVpbGRlci1sb2FkaW5nIGNvZGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDgwMworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSB0aHJlZSBDaHJv bWl1bS1zcGVjaWZpYyBoZWxwZXIgZnVuY3Rpb25zIHRoYXQgd2VyZSB1c2VkIHRvIGRldGVybWlu ZSBDaHJvbWl1bSBERVBTLCBDb250ZW50IFNoZWxsIGFuZCBXZWJLaXQgVG9UCisgICAgICAgIHRl c3QgcnVubmVycy4gVGhlc2UgYXJlIG5vdCByZXF1aXJlZCBhbnltb3JlIGFuZCB0aHVzIHJlbW92 ZWQgYWxvbmcgd2l0aCBhIGNvdXBsZSBvZiB1bml0IHRlc3RzIHRoYXQgd2VyZSB0ZXN0aW5nIHRo ZXNlCisgICAgICAgIG1ldGhvZHMnIGNvcnJlY3QgYmVoYXZpb3IuCisKKyAgICAgICAgKiBUZXN0 UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2J1aWxkZXJzLmpzOgorICAgICAgICAqIFRl c3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2FyZF91bml0 dGVzdHMuanM6CisKKzIwMTMtMDQtMTggIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEu Y29tPgorCiAgICAgICAgIFtEYXNoYm9hcmRdIFJlbW92ZSB0aGUgQ2hyb21pdW0tc3BlY2lmaWMg YnVpbGRlciBtYXN0ZXJzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTQ4MDIKIApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0 aWMtZGFzaGJvYXJkcy9idWlsZGVycy5qcyBiL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGlj LWRhc2hib2FyZHMvYnVpbGRlcnMuanMKaW5kZXggODdkZTA0YzA0MzVlNWUxY2U3ZmQ5ZDU5NWFi Y2U0YWZhYzJkODI3NS4uYzRiYWQ2NjczMWZlNWFiNWZlZWYzM2JjNzkwYjUxZGFjMmM0ZGMwYiAx MDA2NDQKLS0tIGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9idWls ZGVycy5qcworKysgYi9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2J1 aWxkZXJzLmpzCkBAIC0xNDAsMjIgKzE0MCw2IEBAIGZ1bmN0aW9uIHJlcXVlc3RCdWlsZGVyTGlz dChidWlsZGVyR3JvdXBzLCBtYXN0ZXJOYW1lLCBncm91cE5hbWUsIGJ1aWxkZXJHcm91cCwKICAg ICBidWlsZGVyR3JvdXBzW2dyb3VwTmFtZV0uYXBwZW5kKGJ1aWxkZXJMaXN0KTsKIH0KIAotZnVu Y3Rpb24gaXNDaHJvbWl1bUNvbnRlbnRTaGVsbFRlc3RSdW5uZXIoYnVpbGRlcikKLXsKLSAgICBy ZXR1cm4gYnVpbGRlci5pbmRleE9mKCcoQ29udGVudCBTaGVsbCknKSAhPSAtMTsKLX0KLQotZnVu Y3Rpb24gaXNDaHJvbWl1bVdlYmtpdFRpcE9mVHJlZVRlc3RSdW5uZXIoYnVpbGRlcikKLXsKLSAg ICAvLyBGSVhNRTogUmVtb3ZlIHRoZSBBbmRyb2lkIGNoZWNrIG9uY2UgdGhlIGFuZHJvaWQgdGVz dHMgYm90IGlzIGFjdHVhbGx5IHVwbG9hZGluZyByZXN1bHRzLgotICAgIHJldHVybiBidWlsZGVy LmluZGV4T2YoJ0FTQU4nKSA9PSAtMSAmJiAhaXNDaHJvbWl1bUNvbnRlbnRTaGVsbFRlc3RSdW5u ZXIoYnVpbGRlcikgJiYgYnVpbGRlci5pbmRleE9mKCdBbmRyb2lkJykgPT0gLTEgJiYgIWlzQ2hy b21pdW1XZWJraXREZXBzVGVzdFJ1bm5lcihidWlsZGVyKTsKLX0KLQotZnVuY3Rpb24gaXNDaHJv bWl1bVdlYmtpdERlcHNUZXN0UnVubmVyKGJ1aWxkZXIpCi17Ci0gICAgcmV0dXJuIGJ1aWxkZXIu aW5kZXhPZignKGRlcHMpJykgIT0gLTE7Ci19Ci0KIC8vIEZJWE1FOiBMb29rIGludG8gd2hldGhl ciB3ZSBjYW4gbW92ZSB0aGUgZ3JvdXBpbmcgbG9naWMgaW50byBidWlsZGVycy5qc29ucCBhbmQg Z2V0IHJpZCBvZiB0aGlzIGNvZGUuCiBmdW5jdGlvbiBsb2FkQnVpbGRlcnNMaXN0KGdyb3VwTmFt ZSwgdGVzdFR5cGUpIHsKICAgICBzd2l0Y2ggKHRlc3RUeXBlKSB7CmRpZmYgLS1naXQgYS9Ub29s cy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2ZsYWtpbmVzc19kYXNoYm9hcmRf dW5pdHRlc3RzLmpzIGIvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9m bGFraW5lc3NfZGFzaGJvYXJkX3VuaXR0ZXN0cy5qcwppbmRleCBkZjA3NjhjZGNkMWE0OWU3Njg0 ZDExZTdkNjA1ZDcxMGJiMThkZjVhLi4yOWE4MTcyYTVlZTJjZGExMTU0NjE3MzE3MTMxNjNkOTkz YmNiZjBjIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9h cmRzL2ZsYWtpbmVzc19kYXNoYm9hcmRfdW5pdHRlc3RzLmpzCisrKyBiL1Rvb2xzL1Rlc3RSZXN1 bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2FyZF91bml0dGVzdHMu anMKQEAgLTUwMSwyNCArNTAxLDYgQEAgdGVzdCgnYmFzZVRlc3QnLCAyLCBmdW5jdGlvbigpIHsK IAogLy8gRklYTUU6IENyZWF0ZSBidWlsZGVyc190ZXN0cy5qcyBhbmQgbW92ZSB0aGlzIHRoZXJl LgogCi10ZXN0KCdpc0Nocm9taXVtV2Via2l0VGlwT2ZUcmVlVGVzdFJ1bm5lcicsIDEsIGZ1bmN0 aW9uKCkgewotICAgIHZhciBidWlsZGVyTGlzdCA9IFsiV2ViS2l0IExpbnV4IiwgIldlYktpdCBM aW51eCAoZGJnKSIsICJXZWJLaXQgTGludXggMzIiLCAiV2ViS2l0IE1hYzEwLjYiLCAiV2ViS2l0 IE1hYzEwLjYgKGRiZykiLAotICAgICAgICAiV2ViS2l0IE1hYzEwLjYgKGRlcHMpIiwgIldlYktp dCBNYWMxMC43IiwgIldlYktpdCBXaW4iLCAiV2ViS2l0IFdpbiAoZGJnKSgxKSIsICJXZWJLaXQg V2luIChkYmcpKDIpIiwgIldlYktpdCBXaW4gKGRlcHMpIiwKLSAgICAgICAgIldlYktpdCBXaW43 IiwgIkxpbnV4IChDb250ZW50IFNoZWxsKSJdOwotICAgIHZhciBleHBlY3RlZEJ1aWxkZXJzID0g WyJXZWJLaXQgTGludXgiLCAiV2ViS2l0IExpbnV4IChkYmcpIiwgIldlYktpdCBMaW51eCAzMiIs ICJXZWJLaXQgTWFjMTAuNiIsCi0gICAgICAgICJXZWJLaXQgTWFjMTAuNiAoZGJnKSIsICJXZWJL aXQgTWFjMTAuNyIsICJXZWJLaXQgV2luIiwgIldlYktpdCBXaW4gKGRiZykoMSkiLCAiV2ViS2l0 IFdpbiAoZGJnKSgyKSIsICJXZWJLaXQgV2luNyJdOwotICAgIGRlZXBFcXVhbChidWlsZGVyTGlz dC5maWx0ZXIoaXNDaHJvbWl1bVdlYmtpdFRpcE9mVHJlZVRlc3RSdW5uZXIpLCBleHBlY3RlZEJ1 aWxkZXJzKTsKLX0pOwotCi10ZXN0KCdpc0Nocm9taXVtV2Via2l0RGVwc1Rlc3RSdW5uZXInLCAx LCBmdW5jdGlvbigpIHsKLSAgICB2YXIgYnVpbGRlckxpc3QgPSBbIkNocm9tZSBGcmFtZSBUZXN0 cyIsICJHUFUgTGludXggKE5WSURJQSkiLCAiR1BVIExpbnV4IChkYmcpIChOVklESUEpIiwgIkdQ VSBNYWMiLCAiR1BVIE1hYyAoZGJnKSIsICJHUFUgV2luNyAoTlZJRElBKSIsICJHUFUgV2luNyAo ZGJnKSAoTlZJRElBKSIsICJMaW51eCBQZXJmIiwgIkxpbnV4IFRlc3RzIiwKLSAgICAgICAgIkxp bnV4IFZhbGdyaW5kIiwgIk1hYyBCdWlsZGVyIChkYmcpIiwgIk1hYzEwLjYgUGVyZiIsICJNYWMx MC42IFRlc3RzIiwgIlZpc3RhIFBlcmYiLCAiVmlzdGEgVGVzdHMiLCAiV2ViS2l0IExpbnV4Iiwg IldlYktpdCBMaW51eCBBU0FOIiwgICJXZWJLaXQgTGludXggKGRiZykiLCAiV2ViS2l0IExpbnV4 IChkZXBzKSIsICJXZWJLaXQgTGludXggMzIiLAotICAgICAgICAiV2ViS2l0IE1hYzEwLjYiLCAi V2ViS2l0IE1hYzEwLjYgKGRiZykiLCAiV2ViS2l0IE1hYzEwLjYgKGRlcHMpIiwgIldlYktpdCBN YWMxMC43IiwgIldlYktpdCBXaW4iLCAiV2ViS2l0IFdpbiAoZGJnKSgxKSIsICJXZWJLaXQgV2lu IChkYmcpKDIpIiwgIldlYktpdCBXaW4gKGRlcHMpIiwKLSAgICAgICAgIldlYktpdCBXaW43Iiwg IldpbiAoZGJnKSIsICJXaW4gQnVpbGRlciJdOwotICAgIHZhciBleHBlY3RlZEJ1aWxkZXJzID0g WyJXZWJLaXQgTGludXggKGRlcHMpIiwgIldlYktpdCBNYWMxMC42IChkZXBzKSIsICJXZWJLaXQg V2luIChkZXBzKSJdOwotICAgIGRlZXBFcXVhbChidWlsZGVyTGlzdC5maWx0ZXIoaXNDaHJvbWl1 bVdlYmtpdERlcHNUZXN0UnVubmVyKSwgZXhwZWN0ZWRCdWlsZGVycyk7Ci19KTsKLQogdGVzdCgn cmVxdWVzdEJ1aWxkZXJMaXN0QWRkc0J1aWxkZXJHcm91cEVudHJ5JywgMSwgZnVuY3Rpb24oKSB7 CiAgICAgdmFyIHRlc3RCdWlsZGVyR3JvdXBzID0geyAnQFRvVCAtIGR1bW15Lm9yZyc6IG51bGwg fTsKICAgICB2YXIgYnVpbGRlckdyb3VwID0gbmV3IEJ1aWxkZXJHcm91cChCdWlsZGVyR3JvdXAu VE9UX1dFQktJVCk7Cg==