114793 2013-04-18 01:25:37 -0700 REGRESSION(r148639): It broke Qt Mountain Lion Release 2013-04-18 10:49:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P2 Normal --- 114577 1 zarvai webkit-unassigned commit-queue ggaren kadam mark.lam ossy zeno oldest_to_newest 877737 0 zarvai 2013-04-18 01:25:37 -0700 /Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/WTF/wtf/CurrentTime.cpp:339:5: error: unknown type name 'mach_msg_type_number_t' mach_msg_type_number_t infoCount = THREAD_BASIC_INFO_COUNT; ^ /Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/WTF/wtf/CurrentTime.cpp:339:40: error: use of undeclared identifier 'THREAD_BASIC_INFO_COUNT' mach_msg_type_number_t infoCount = THREAD_BASIC_INFO_COUNT; ^ /Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/WTF/wtf/CurrentTime.cpp:340:5: error: unknown type name 'thread_basic_info_data_t' thread_basic_info_data_t info; ^ /Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/WTF/wtf/CurrentTime.cpp:343:30: error: use of undeclared identifier 'mach_thread_self'; did you mean 'pthread_self'? mach_port_t threadPort = mach_thread_self(); ^~~~~~~~~~~~~~~~ pthread_self /usr/include/pthread.h:349:11: note: 'pthread_self' declared here pthread_t pthread_self(void); ^ /Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/WTF/wtf/CurrentTime.cpp:343:17: error: cannot initialize a variable of type 'mach_port_t' (aka 'unsigned int') with an rvalue of type 'pthread_t' (aka '_opaque_pthread_t *') mach_port_t threadPort = mach_thread_self(); ^ ~~~~~~~~~~~~~~~~~~ /Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/WTF/wtf/CurrentTime.cpp:345:26: error: use of undeclared identifier 'mach_task_self' mach_port_deallocate(mach_task_self(), threadPort); ^ 6 errors generated. 877741 1 zarvai 2013-04-18 01:30:23 -0700 Maybe in http://trac.webkit.org/changeset/148639/trunk/Source/WTF/wtf/CurrentTime.cpp #if PLATFORM(MAC) #include <mach/mach.h> should be #if OS(DARWIN) ... 877813 2 198719 zarvai 2013-04-18 04:25:26 -0700 Created attachment 198719 Speculative fix. 877947 3 198719 mark.lam 2013-04-18 09:55:59 -0700 Comment on attachment 198719 Speculative fix. LGTM, but need someone else to r+. 877970 4 198719 commit-queue 2013-04-18 10:49:42 -0700 Comment on attachment 198719 Speculative fix. Clearing flags on attachment: 198719 Committed r148684: <http://trac.webkit.org/changeset/148684> 877971 5 commit-queue 2013-04-18 10:49:45 -0700 All reviewed patches have been landed. Closing bug. 198719 2013-04-18 04:25:26 -0700 2013-04-18 10:49:42 -0700 Speculative fix. fix.patch text/plain 879 zarvai ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggOTFjMTIwNi4uNGZiMjg0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMy0wNC0xOCAg Wm9sdGFuIEFydmFpICA8emFydmFpQGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBTcGVjdWxh dGl2ZSBidWlsZCBmaXggZm9yIFF0IE1vdW50YWluIExpb24gUmVsZWFzZSBhZnRlciByMTQ4NjM5 LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0Nzkz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYv Q3VycmVudFRpbWUuY3BwOgorCiAyMDEzLTA0LTE3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxl LmNvbT4KIAogICAgICAgICBBZGRlZCBjdXJyZW50Q1BVVGltZSgpIGFuZCBjdXJyZW50Q1BVVGlt ZU1TKCkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9DdXJyZW50VGltZS5jcHAgYi9Tb3Vy Y2UvV1RGL3d0Zi9DdXJyZW50VGltZS5jcHAKaW5kZXggNTM3MzE1MS4uYjFjMDk1ZSAxMDA2NDQK LS0tIGEvU291cmNlL1dURi93dGYvQ3VycmVudFRpbWUuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3Rm L0N1cnJlbnRUaW1lLmNwcApAQCAtMzQsNyArMzQsNyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgog I2luY2x1ZGUgIkN1cnJlbnRUaW1lLmgiCiAKLSNpZiBQTEFURk9STShNQUMpCisjaWYgT1MoREFS V0lOKQogI2luY2x1ZGUgPG1hY2gvbWFjaC5oPgogI2luY2x1ZGUgPG1hY2gvbWFjaF90aW1lLmg+ CiAjaW5jbHVkZSA8c3lzL3RpbWUuaD4K