114784 2013-04-17 21:55:04 -0700 CodeGeneratorJS.pm should generate "isFiringEventListeners()" check in isReachableFromOpaqueRoots() 2013-04-18 16:09:08 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble commit-queue ggaren jberlin kling oldest_to_newest 877694 0 jer.noble 2013-04-17 21:55:04 -0700 For classes which inherit from EventTarget, the generator should add an isFiringEventListeners() check to the generated isReachableFromOpaqueRoots() function. 877700 1 198679 jer.noble 2013-04-17 22:05:10 -0700 Created attachment 198679 Patch 877841 2 kling 2013-04-18 05:53:52 -0700 Can we remove the isFiringEventListeners() checks from the custom bindings for Node, TextTrack, TextTrackCue and TextTrackList with this change? 877901 3 jer.noble 2013-04-18 08:18:16 -0700 (In reply to comment #2) > Can we remove the isFiringEventListeners() checks from the custom bindings for Node, TextTrack, TextTrackCue and TextTrackList with this change? I was going to do it in a follow-up patch, but yes, we totally could. 877969 4 198679 ggaren 2013-04-18 10:48:18 -0700 Comment on attachment 198679 Patch r=me 878058 5 198679 commit-queue 2013-04-18 13:38:16 -0700 Comment on attachment 198679 Patch Clearing flags on attachment: 198679 Committed r148700: <http://trac.webkit.org/changeset/148700> 878059 6 commit-queue 2013-04-18 13:38:18 -0700 All reviewed patches have been landed. Closing bug. 878131 7 jberlin 2013-04-18 16:09:08 -0700 This patch broke the bindings-generation tests: http://build.webkit.org/builders/Apple%20Lion%20Debug%20WK1%20%28Tests%29/builds/8189/steps/bindings-generation-tests/logs/stdio PASS: (JS) JSTestCallback.cpp PASS: (JS) JSTestCallback.h PASS: (JS) JSTestCustomNamedGetter.cpp PASS: (JS) JSTestCustomNamedGetter.h PASS: (JS) JSTestActiveDOMObject.cpp PASS: (JS) JSTestActiveDOMObject.h PASS: (JS) JSTestEventConstructor.cpp PASS: (JS) JSTestEventConstructor.h FAIL: (JS) JSTestEventTarget.cpp --- WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp 2013-04-18 13:26:25.000000000 -0700 +++ /var/folders/_c/vr7s8m291vz90n5ffhf72nnw0000gn/T/tmp7N_ZlU/JSTestEventTarget.cpp 2013-04-18 15:31:34.000000000 -0700 @@ -326,6 +326,8 @@ bool JSTestEventTargetOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown> handle, void*, SlotVisitor& visitor) { JSTestEventTarget* jsTestEventTarget = jsCast<JSTestEventTarget*>(handle.get().asCell()); + if (jsTestEventTarget->impl()->isFiringEventListeners()) + return true; if (!isObservable(jsTestEventTarget)) return false; UNUSED_PARAM(visitor); I notified Jer and he is going to fix them. 198679 2013-04-17 22:05:10 -0700 2013-04-18 13:38:16 -0700 Patch bug-114784-20130417220441.patch text/plain 1957 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NjE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGI5NTQ2ZDkwYjAzMzdk YTc0YTYzYjEzOTA5NDUwZDkyMzkyYTlmMC4uMjM0MWNkZGU2ZTI4MTg4ZWZlZDZlNjUxOWZhMWUy MzcwMjEzOTRmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA0LTE3ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIENvZGVHZW5lcmF0b3JKUy5w bSBzaG91bGQgZ2VuZXJhdGUgImlzRmlyaW5nRXZlbnRMaXN0ZW5lcnMoKSIgY2hlY2sgaW4gaXNS ZWFjaGFibGVGcm9tT3BhcXVlUm9vdHMoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTE0Nzg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRXZlbnRUYXJnZXQgc3ViY2xhc3NlcyBzaG91bGRuJ3QgaGF2ZSB0 byB1c2UgQ3VzdG9tSXNSZWFjaGFibGUgZGlyZWN0aXZlcworICAgICAgICBpbiBvcmRlciB0byBr ZWVwIHRoZWlyIHdyYXBwZXJzIGFsaXZlIHdoaWxlIGZpcmluZyBldmVudCBsaXN0ZW5lcnMuCisK KyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbToKKyAgICAgICAg KEdlbmVyYXRlSW1wbGVtZW50YXRpb24pOgorCiAyMDEzLTA0LTE3ICBDaHJpcyBGbGVpemFjaCAg PGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgQVg6IFdoZW4gaW1nQGFsdCBpcyB1bmRl ZmluZWQsIFdlYktpdCBzaG91bGQgdXNlIEB0aXRsZSBhcyBhY2Nlc3NpYmlsaXR5IGxhYmVsIGlm IGF2YWlsYWJsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9D b2RlR2VuZXJhdG9ySlMucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVH ZW5lcmF0b3JKUy5wbQppbmRleCA2MDUwOGIwNTdlMWU2OGEzNDdlOTdlNmE4ZTNjN2MxODRiZjk1 NTU1Li44NzJjOWYwZjM0NzBjY2Q4Mjc1MGQ1ZjdmMjRmYjE4ZDcyYmRhMzA3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQorKysg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQpAQCAt MjYzOSw2ICsyNjM5LDEwIEBAIHN1YiBHZW5lcmF0ZUltcGxlbWVudGF0aW9uCiAgICAgICAgICAg ICBwdXNoKEBpbXBsQ29udGVudCwgIiAgICBpZiAoanMke2ludGVyZmFjZU5hbWV9LT5pbXBsKCkt Pmhhc1BlbmRpbmdBY3Rpdml0eSgpKVxuIik7CiAgICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVu dCwgIiAgICAgICAgcmV0dXJuIHRydWU7XG4iKTsKICAgICAgICAgfQorICAgICAgICBpZiAoJGNv ZGVHZW5lcmF0b3ItPkluaGVyaXRzRXh0ZW5kZWRBdHRyaWJ1dGUoJGludGVyZmFjZSwgIkV2ZW50 VGFyZ2V0IikpIHsKKyAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgIGlmIChqcyR7 aW50ZXJmYWNlTmFtZX0tPmltcGwoKS0+aXNGaXJpbmdFdmVudExpc3RlbmVycygpKVxuIik7Cisg ICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIiAgICAgICAgcmV0dXJuIHRydWU7XG4iKTsK KyAgICAgICAgfQogICAgICAgICBpZiAoJGNvZGVHZW5lcmF0b3ItPkluaGVyaXRzSW50ZXJmYWNl KCRpbnRlcmZhY2UsICJOb2RlIikpIHsKICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAi ICAgIGlmIChKU05vZGVPd25lcjo6aXNSZWFjaGFibGVGcm9tT3BhcXVlUm9vdHMoaGFuZGxlLCAw LCB2aXNpdG9yKSlcbiIpOwogICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAgICAg IHJldHVybiB0cnVlO1xuIik7Cg==