114775 2013-04-17 16:48:31 -0700 Fix GraphicsLayerCA::recursiveVisibleRectChangeRequiresFlush() to do predictive visible rect expansion 2013-04-17 17:08:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser simon.fraser oldest_to_newest 877572 0 simon.fraser 2013-04-17 16:48:31 -0700 Fix GraphicsLayerCA::recursiveVisibleRectChangeRequiresFlush() to do predictive visible rect expansion 877575 1 198630 simon.fraser 2013-04-17 16:53:25 -0700 Created attachment 198630 Patch 877576 2 198630 thorton 2013-04-17 16:56:50 -0700 Comment on attachment 198630 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198630&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1000 > + FloatPoint boundsOrigin = m_boundsOrigin; Is there a reason you're doing this? (the local) 877579 3 simon.fraser 2013-04-17 17:08:45 -0700 https://trac.webkit.org/r148651 198630 2013-04-17 16:53:25 -0700 2013-04-17 16:56:50 -0700 Patch bug-114775-20130417165259.patch text/plain 7229 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NjM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTNkNDhkYWUzYmJkNWNj ZWQwYzVjY2VlZDllNWVlZDU4YWUyNzE4YS4uYWNjNzA2ZmMxOWU3ZjJkYzdhYjE2OTFhMDA3OWRm ZDZjZTYyM2U5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDEzLTA0LTE3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBHcmFwaGlj c0xheWVyQ0E6OnJlY3Vyc2l2ZVZpc2libGVSZWN0Q2hhbmdlUmVxdWlyZXNGbHVzaCgpIHRvIGRv IHByZWRpY3RpdmUgdmlzaWJsZSByZWN0IGV4cGFuc2lvbgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0Nzc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR3JhcGhpY3NMYXllckNBOjpyZWN1cnNpdmVWaXNp YmxlUmVjdENoYW5nZVJlcXVpcmVzRmx1c2goKSBpcyBpbnRlbmRlZCB0byBhbnN3ZXIgdGhlIHF1 ZXN0aW9uCisgICAgICAgICJpZiB5b3VyIHZpc2libGUgcmVjdCBpcyBjaGFuZ2UgdG8gWCwgd291 bGQgYW55IHRpbGVzIGJlIGNyZWF0ZWQgb3IgZGVzdHJveWVkPyIuCisgICAgICAgIAorICAgICAg ICBIb3dldmVyLCBmb3IgY29tcG9zaXRpbmcgbGF5ZXIgdGlsZWQgbGF5ZXJzLCB3ZSBkbyBzb21l IHByZWRpY3RpdmUgdmlzaWJsZSByZWN0IGV4cGFuc2lvbiBiYXNlZCBvbiBob3cKKyAgICAgICAg dGhlIHZpc2libGUgcmVjdCBpcyBjaGFuZ2luZyB3aGVuIHdlIGFjdHVhbGx5IGNvbW1pdCB2aXNp YmxlIHJlY3QgY2hhbmdlcy4gcmVjdXJzaXZlVmlzaWJsZVJlY3RDaGFuZ2VSZXF1aXJlc0ZsdXNo KCkKKyAgICAgICAgd2FzIG5vdCBkb2luZyB0aGF0LCBjYXVzaW5nIGl0IHRvIGdpdmUgY29uZnVz aW5nIGFuc3dlcnMsIHNvIGZpeCBpdCB0byBkbyBzby4KKyAgICAgICAgCisgICAgICAgIEJvdGgg bm93IGNhbGwgYWRqdXN0VGlsZWRMYXllclZpc2libGVSZWN0KCksIGFuZCBpdCdzIGNsZWFuZXIg dG8gbWFrZSB0aGlzIGEgc3RhdGljIGZ1bmN0aW9uLgorICAgICAgICAKKyAgICAgICAgQSBzb21l d2hhdCB1bnJlbGF0ZWQgY2hhbmdlIGlzIHRvIHRha2UgdGhlIGxheWVyIGJvdW5kcyBvcmlnaW4g aW50byBhY2NvdW50CisgICAgICAgIGluIEdyYXBoaWNzTGF5ZXJDQTo6Y29tcHV0ZVZpc2libGVS ZWN0KCkuIERlc2t0b3AgV2ViS2l0IG5ldmVyIHNldHMgdGhpcywgYnV0IGl0J3MgdXNlZAorICAg ICAgICBvbiBvdGhlciBwbGF0Zm9ybXMgZm9yIGNvbXBvc2l0ZWQgc2Nyb2xsaW5nLCBzbyBuZWVk cyB0byBiZSB0YWtlbiBpbnRvIGFjY291bnQKKyAgICAgICAgd2hlbiBjb21wdXRpbmcgdmlzaWJs ZSByZWN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJD QS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyQ0E6OnJlY3Vyc2l2ZVZpc2li bGVSZWN0Q2hhbmdlUmVxdWlyZXNGbHVzaCk6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xh eWVyQ0E6OmNvbXB1dGVWaXNpYmxlUmVjdCk6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xh eWVyQ0E6OmFkanVzdFRpbGVkTGF5ZXJWaXNpYmxlUmVjdCk6CisgICAgICAgIChXZWJDb3JlOjpH cmFwaGljc0xheWVyQ0E6OnVwZGF0ZVZpc2libGVSZWN0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuaDoKKyAgICAgICAgKEdyYXBoaWNzTGF5ZXJDQSk6 CisKIDIwMTMtMDQtMTYgIEplciBOb2JsZSA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAg ICBDcmFzaCBpbiBXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50Ojp+SFRNTE1lZGlhRWxlbWVudC4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNz TGF5ZXJDQS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGlj c0xheWVyQ0EuY3BwCmluZGV4IGIxZTg0NjM4Yzg0ZTdmZmU1MDVkMjFmNDkxOGM5Y2EzY2JhNDRi MTMuLjBjZDc1N2NhMjE3MWMxOWYwOTlmYmRlZGEyZGMxMWNlODY1NTcwYmQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNB LmNwcApAQCAtOTEzLDEwICs5MTMsMTMgQEAgYm9vbCBHcmFwaGljc0xheWVyQ0E6OnJlY3Vyc2l2 ZVZpc2libGVSZWN0Q2hhbmdlUmVxdWlyZXNGbHVzaChjb25zdCBUcmFuc2Zvcm1TdGEKICAgICAK ICAgICAvLyBUaGlzIG1heSBiZSBjYWxsZWQgYXQgdGltZXMgd2hlbiBsYXlvdXQgaGFzIG5vdCBi ZWVuIHVwZGF0ZWQsIHNvIHdlIHdhbnQgdG8gYXZvaWQgY2FsbGluZyBvdXQgdG8gdGhlIGNsaWVu dAogICAgIC8vIGZvciBhbmltYXRpbmcgdHJhbnNmb3Jtcy4KLSAgICBGbG9hdFJlY3QgdmlzaWJs ZVJlY3QgPSBjb21wdXRlVmlzaWJsZVJlY3QobG9jYWxTdGF0ZSwgMCk7Ci0gICAgaWYgKHZpc2li bGVSZWN0ICE9IG1fdmlzaWJsZVJlY3QpIHsKKyAgICBGbG9hdFJlY3QgbmV3VmlzaWJsZVJlY3Qg PSBjb21wdXRlVmlzaWJsZVJlY3QobG9jYWxTdGF0ZSwgMCk7CisgICAgaWYgKG1fbGF5ZXItPmxh eWVyVHlwZSgpID09IFBsYXRmb3JtQ0FMYXllcjo6TGF5ZXJUeXBlVGlsZWRCYWNraW5nTGF5ZXIp CisgICAgICAgIG5ld1Zpc2libGVSZWN0ID0gYWRqdXN0VGlsZWRMYXllclZpc2libGVSZWN0KHRp bGVkQmFja2luZygpLCBtX3Zpc2libGVSZWN0LCBuZXdWaXNpYmxlUmVjdCwgbV9zaXplQXRMYXN0 VmlzaWJsZVJlY3RVcGRhdGUsIG1fc2l6ZSk7CisKKyAgICBpZiAobmV3VmlzaWJsZVJlY3QgIT0g bV92aXNpYmxlUmVjdCkgewogICAgICAgICBpZiAoVGlsZWRCYWNraW5nKiB0aWxlZEJhY2tpbmcg PSB0aGlzLT50aWxlZEJhY2tpbmcoKSkgewotICAgICAgICAgICAgaWYgKHRpbGVkQmFja2luZy0+ dGlsZXNXb3VsZENoYW5nZUZvclZpc2libGVSZWN0KHZpc2libGVSZWN0KSkKKyAgICAgICAgICAg IGlmICh0aWxlZEJhY2tpbmctPnRpbGVzV291bGRDaGFuZ2VGb3JWaXNpYmxlUmVjdChuZXdWaXNp YmxlUmVjdCkpCiAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgIH0KICAgICB9 CkBAIC05OTQsNyArOTk3LDEwIEBAIEZsb2F0UmVjdCBHcmFwaGljc0xheWVyQ0E6OmNvbXB1dGVW aXNpYmxlUmVjdChUcmFuc2Zvcm1TdGF0ZSYgc3RhdGUsIENvbXB1dGVWaXNpCiAgICAgCiAgICAg Ym9vbCBtYXBXYXNDbGFtcGVkOwogICAgIEZsb2F0UmVjdCBjbGlwUmVjdEZvckNoaWxkcmVuID0g c3RhdGUubWFwcGVkUXVhZCgmbWFwV2FzQ2xhbXBlZCkuYm91bmRpbmdCb3goKTsKLSAgICBGbG9h dFJlY3QgY2xpcFJlY3RGb3JTZWxmKDAsIDAsIG1fc2l6ZS53aWR0aCgpLCBtX3NpemUuaGVpZ2h0 KCkpOworICAgIEZsb2F0UG9pbnQgYm91bmRzT3JpZ2luID0gbV9ib3VuZHNPcmlnaW47CisgICAg Y2xpcFJlY3RGb3JDaGlsZHJlbi5tb3ZlKGJvdW5kc09yaWdpbi54KCksIGJvdW5kc09yaWdpbi55 KCkpOworICAgIAorICAgIEZsb2F0UmVjdCBjbGlwUmVjdEZvclNlbGYoYm91bmRzT3JpZ2luLCBt X3NpemUpOwogICAgIGlmICghYXBwbHlXYXNDbGFtcGVkICYmICFtYXBXYXNDbGFtcGVkKQogICAg ICAgICBjbGlwUmVjdEZvclNlbGYuaW50ZXJzZWN0KGNsaXBSZWN0Rm9yQ2hpbGRyZW4pOwogICAg IApAQCAtMTU5MiwyNCArMTU5OCwyNCBAQCB2b2lkIEdyYXBoaWNzTGF5ZXJDQTo6dXBkYXRlRGVi dWdCb3JkZXIoKQogICAgICAgICBtX2xheWVyLT5zZXRCb3JkZXJXaWR0aCgwKTsKIH0KIAotRmxv YXRSZWN0IEdyYXBoaWNzTGF5ZXJDQTo6YWRqdXN0VGlsZWRMYXllclZpc2libGVSZWN0KFRpbGVk QmFja2luZyogdGlsZWRCYWNraW5nLCBjb25zdCBGbG9hdFJlY3QmIG9sZFZpc2libGVSZWN0LCBj b25zdCBGbG9hdFNpemUmIG9sZFNpemUpIGNvbnN0CitGbG9hdFJlY3QgR3JhcGhpY3NMYXllckNB OjphZGp1c3RUaWxlZExheWVyVmlzaWJsZVJlY3QoVGlsZWRCYWNraW5nKiB0aWxlZEJhY2tpbmcs IGNvbnN0IEZsb2F0UmVjdCYgb2xkVmlzaWJsZVJlY3QsIGNvbnN0IEZsb2F0UmVjdCYgbmV3Vmlz aWJsZVJlY3QsIGNvbnN0IEZsb2F0U2l6ZSYgb2xkU2l6ZSwgY29uc3QgRmxvYXRTaXplJiBuZXdT aXplKQogewogICAgIC8vIElmIHRoZSBvbGQgdmlzaWJsZSByZWN0IGlzIGVtcHR5LCB3ZSBoYXZl IG5vIGluZm9ybWF0aW9uIGFib3V0IGhvdyB0aGUgdmlzaWJsZSBhcmVhIGlzIGNoYW5naW5nCiAg ICAgLy8gKG1heWJlIHRoZSBsYXllciB3YXMganVzdCBjcmVhdGVkKSwgc28gZG9uJ3QgYXR0ZW1w dCB0byBleHBhbmQuIEFsc28gZG9uJ3QgYXR0ZW1wdCB0byBleHBhbmQKICAgICAvLyBpZiB0aGUg c2l6ZSBjaGFuZ2VkLgotICAgIGlmIChvbGRWaXNpYmxlUmVjdC5pc0VtcHR5KCkgfHwgbV9zaXpl ICE9IG9sZFNpemUpCi0gICAgICAgIHJldHVybiBtX3Zpc2libGVSZWN0OworICAgIGlmIChvbGRW aXNpYmxlUmVjdC5pc0VtcHR5KCkgfHwgbmV3U2l6ZSAhPSBvbGRTaXplKQorICAgICAgICByZXR1 cm4gbmV3VmlzaWJsZVJlY3Q7CiAKICAgICBjb25zdCBmbG9hdCBwYWRkaW5nTXVsdGlwbGllciA9 IDI7CiAKLSAgICBmbG9hdCBsZWZ0RWRnZURlbHRhID0gcGFkZGluZ011bHRpcGxpZXIgKiAobV92 aXNpYmxlUmVjdC54KCkgLSBvbGRWaXNpYmxlUmVjdC54KCkpOwotICAgIGZsb2F0IHJpZ2h0RWRn ZURlbHRhID0gcGFkZGluZ011bHRpcGxpZXIgKiAobV92aXNpYmxlUmVjdC5tYXhYKCkgLSBvbGRW aXNpYmxlUmVjdC5tYXhYKCkpOworICAgIGZsb2F0IGxlZnRFZGdlRGVsdGEgPSBwYWRkaW5nTXVs dGlwbGllciAqIChuZXdWaXNpYmxlUmVjdC54KCkgLSBvbGRWaXNpYmxlUmVjdC54KCkpOworICAg IGZsb2F0IHJpZ2h0RWRnZURlbHRhID0gcGFkZGluZ011bHRpcGxpZXIgKiAobmV3VmlzaWJsZVJl Y3QubWF4WCgpIC0gb2xkVmlzaWJsZVJlY3QubWF4WCgpKTsKIAotICAgIGZsb2F0IHRvcEVkZ2VE ZWx0YSA9IHBhZGRpbmdNdWx0aXBsaWVyICogKG1fdmlzaWJsZVJlY3QueSgpIC0gb2xkVmlzaWJs ZVJlY3QueSgpKTsKLSAgICBmbG9hdCBib3R0b21FZGdlRGVsdGEgPSBwYWRkaW5nTXVsdGlwbGll ciAqIChtX3Zpc2libGVSZWN0Lm1heFkoKSAtIG9sZFZpc2libGVSZWN0Lm1heFkoKSk7CisgICAg ZmxvYXQgdG9wRWRnZURlbHRhID0gcGFkZGluZ011bHRpcGxpZXIgKiAobmV3VmlzaWJsZVJlY3Qu eSgpIC0gb2xkVmlzaWJsZVJlY3QueSgpKTsKKyAgICBmbG9hdCBib3R0b21FZGdlRGVsdGEgPSBw YWRkaW5nTXVsdGlwbGllciAqIChuZXdWaXNpYmxlUmVjdC5tYXhZKCkgLSBvbGRWaXNpYmxlUmVj dC5tYXhZKCkpOwogICAgIAogICAgIEZsb2F0UmVjdCBleGlzdGluZ1RpbGVCYWNraW5nUmVjdCA9 IHRpbGVkQmFja2luZy0+dmlzaWJsZVJlY3QoKTsKLSAgICBGbG9hdFJlY3QgZXhwYW5kZWRSZWN0 ID0gbV92aXNpYmxlUmVjdDsKKyAgICBGbG9hdFJlY3QgZXhwYW5kZWRSZWN0ID0gbmV3VmlzaWJs ZVJlY3Q7CiAKICAgICAvLyBNb3JlIGV4cG9zZWQgb24gbGVmdCBzaWRlLgogICAgIGlmIChsZWZ0 RWRnZURlbHRhIDwgMCkgewpAQCAtMTY1OSw3ICsxNjY1LDcgQEAgdm9pZCBHcmFwaGljc0xheWVy Q0E6OnVwZGF0ZVZpc2libGVSZWN0KGNvbnN0IEZsb2F0UmVjdCYgb2xkVmlzaWJsZVJlY3QpCiAK ICAgICBGbG9hdFJlY3QgdGlsZUFyZWEgPSBtX3Zpc2libGVSZWN0OwogICAgIGlmIChtX2xheWVy LT5sYXllclR5cGUoKSA9PSBQbGF0Zm9ybUNBTGF5ZXI6OkxheWVyVHlwZVRpbGVkQmFja2luZ0xh eWVyKQotICAgICAgICB0aWxlQXJlYSA9IGFkanVzdFRpbGVkTGF5ZXJWaXNpYmxlUmVjdCh0aWxl ZEJhY2tpbmcoKSwgb2xkVmlzaWJsZVJlY3QsIG1fc2l6ZUF0TGFzdFZpc2libGVSZWN0VXBkYXRl KTsKKyAgICAgICAgdGlsZUFyZWEgPSBhZGp1c3RUaWxlZExheWVyVmlzaWJsZVJlY3QodGlsZWRC YWNraW5nKCksIG9sZFZpc2libGVSZWN0LCB0aWxlQXJlYSwgbV9zaXplQXRMYXN0VmlzaWJsZVJl Y3RVcGRhdGUsIG1fc2l6ZSk7CiAKICAgICB0aWxlZEJhY2tpbmcoKS0+c2V0VmlzaWJsZVJlY3Qo dGlsZUFyZWEpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jYS9HcmFwaGljc0xheWVyQ0EuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2NhL0dyYXBoaWNzTGF5ZXJDQS5oCmluZGV4IDdiMzVjYWNiMDE4MGViMDQ5MzM1ZjgwOGZiZjJi YmFiODhlYmU4NzUuLjA4NzMyYTdmZWJjNzVkOTU3NTNiMDJiMzA0MDQ2YTNkODA2OTg4MGUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5 ZXJDQS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNz TGF5ZXJDQS5oCkBAIC0yNTAsNyArMjUwLDcgQEAgcHJpdmF0ZToKICAgICBGbG9hdFJlY3QgY29t cHV0ZVZpc2libGVSZWN0KFRyYW5zZm9ybVN0YXRlJiwgQ29tcHV0ZVZpc2libGVSZWN0RmxhZ3Mg PSBSZXNwZWN0QW5pbWF0aW5nVHJhbnNmb3JtcykgY29uc3Q7CiAgICAgY29uc3QgRmxvYXRSZWN0 JiB2aXNpYmxlUmVjdCgpIGNvbnN0IHsgcmV0dXJuIG1fdmlzaWJsZVJlY3Q7IH0KICAgICAKLSAg ICBGbG9hdFJlY3QgYWRqdXN0VGlsZWRMYXllclZpc2libGVSZWN0KFRpbGVkQmFja2luZyosIGNv bnN0IEZsb2F0UmVjdCYgb2xkVmlzaWJsZVJlY3QsIGNvbnN0IEZsb2F0U2l6ZSYgb2xkU2l6ZSkg Y29uc3Q7CisgICAgc3RhdGljIEZsb2F0UmVjdCBhZGp1c3RUaWxlZExheWVyVmlzaWJsZVJlY3Qo VGlsZWRCYWNraW5nKiwgY29uc3QgRmxvYXRSZWN0JiBvbGRWaXNpYmxlUmVjdCwgY29uc3QgRmxv YXRSZWN0JiBuZXdWaXNpYmxlUmVjdCwgY29uc3QgRmxvYXRTaXplJiBvbGRTaXplLCBjb25zdCBG bG9hdFNpemUmIG5ld1NpemUpOwogCiAgICAgYm9vbCByZWN1cnNpdmVWaXNpYmxlUmVjdENoYW5n ZVJlcXVpcmVzRmx1c2goY29uc3QgVHJhbnNmb3JtU3RhdGUmKSBjb25zdDsKIAo=