114774 2013-04-17 16:45:19 -0700 Crash beneath JSC::JIT::privateCompileSlowCases @ stephenrdonaldson.com 2013-04-18 15:50:57 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg oldest_to_newest 877570 0 mhahnenberg 2013-04-17 16:45:19 -0700 Looks like we're not linking up all of the slow cases in the baseline JIT. put_to_base is the culprit due to some weird mismatch in the switch statement logic of the normal case and the slow case. 877571 1 mhahnenberg 2013-04-17 16:45:29 -0700 <rdar://problem/13445011> 878025 2 198752 mhahnenberg 2013-04-18 12:17:28 -0700 Created attachment 198752 Patch 878028 3 198752 ggaren 2013-04-18 12:23:56 -0700 Comment on attachment 198752 Patch Patch looks good, but it needs a regression test. 878122 4 198776 mhahnenberg 2013-04-18 15:42:24 -0700 Created attachment 198776 Patch 878123 5 198776 ggaren 2013-04-18 15:43:52 -0700 Comment on attachment 198776 Patch r=me 878127 6 mhahnenberg 2013-04-18 15:50:57 -0700 Committed r148711: <http://trac.webkit.org/changeset/148711> 198752 2013-04-18 12:17:28 -0700 2013-04-18 15:42:23 -0700 Patch bug-114774-20130418121659.patch text/plain 1578 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ4NjkzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTA0LTE4ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgQ3Jhc2ggYmVuZWF0aCBKU0M6OkpJVDo6cHJpdmF0ZUNvbXBpbGVTbG93Q2FzZXMg QCBzdGVwaGVucmRvbmFsZHNvbi5jb20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExNDc3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdlJ3JlIG5vdCBsaW5raW5nIHVwIGFsbCBvZiB0aGUgc2xvdyBjYXNl cyBpbiB0aGUgYmFzZWxpbmUgSklUIHdoZW4gY29tcGlsaW5nIHB1dF90b19iYXNlLgorCisgICAg ICAgICogaml0L0pJVE9wY29kZXMuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRTbG93X29w X3B1dF90b19iYXNlKToKKwogMjAxMy0wNC0xOCAgWHVlZmVpIFJlbiAgPHhyZW5AYmxhY2tiZXJy eS5jb20+CiAKICAgICAgICAgcmVtb3ZlIGJ1aWxkIHdhcm5pbmcodW51c2VkIHBhcmFtZXRlcikK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3Bjb2Rlcy5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGNvZGVzLmNwcAkocmV2aXNpb24g MTQ4NjQxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGNvZGVzLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTU5Nyw2ICsxNTk3LDggQEAgdm9pZCBKSVQ6OmVtaXRTbG93X29wX3B1 dF90b19iYXNlKEluc3RydQogICAgIGNhc2UgUHV0VG9CYXNlT3BlcmF0aW9uOjpWYXJpYWJsZVB1 dDoKICAgICAgICAgcmV0dXJuOwogCisgICAgY2FzZSBQdXRUb0Jhc2VPcGVyYXRpb246Okdsb2Jh bFZhcmlhYmxlUHV0Q2hlY2tlZDoKKyAgICAgICAgbGlua1Nsb3dDYXNlKGl0ZXIpOwogICAgIGNh c2UgUHV0VG9CYXNlT3BlcmF0aW9uOjpHbG9iYWxWYXJpYWJsZVB1dDoKICAgICAgICAgaWYgKCFw dXRUb0Jhc2VPcGVyYXRpb24tPm1faXNEeW5hbWljKQogICAgICAgICAgICAgcmV0dXJuOwpAQCAt MTYwOCw3ICsxNjEwLDYgQEAgdm9pZCBKSVQ6OmVtaXRTbG93X29wX3B1dF90b19iYXNlKEluc3Ry dQogICAgIGNhc2UgUHV0VG9CYXNlT3BlcmF0aW9uOjpHZW5lcmljOgogICAgICAgICByZXR1cm47 CiAKLSAgICBjYXNlIFB1dFRvQmFzZU9wZXJhdGlvbjo6R2xvYmFsVmFyaWFibGVQdXRDaGVja2Vk OgogICAgIGNhc2UgUHV0VG9CYXNlT3BlcmF0aW9uOjpHbG9iYWxQcm9wZXJ0eVB1dDoKICAgICAg ICAgbGlua1Nsb3dDYXNlKGl0ZXIpOwogICAgICAgICBicmVhazsK 198776 2013-04-18 15:42:24 -0700 2013-04-18 15:43:52 -0700 Patch bug-114774-20130418154154.patch text/plain 4462 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ4NzA4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTA0LTE4ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgQ3Jhc2ggYmVuZWF0aCBKU0M6OkpJVDo6cHJpdmF0ZUNvbXBpbGVTbG93Q2FzZXMg QCBzdGVwaGVucmRvbmFsZHNvbi5jb20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExNDc3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdlJ3JlIG5vdCBsaW5raW5nIHVwIGFsbCBvZiB0aGUgc2xvdyBjYXNl cyBpbiB0aGUgYmFzZWxpbmUgSklUIHdoZW4gY29tcGlsaW5nIHB1dF90b19iYXNlLgorCisgICAg ICAgICogaml0L0pJVE9wY29kZXMuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRTbG93X29w X3B1dF90b19iYXNlKToKKwogMjAxMy0wNC0xOCAgR2Fib3IgUmFwY3NhbnlpICA8cmdhYm9yQHdl YmtpdC5vcmc+CiAKICAgICAgICAgTExJbnQgQVJNIGJhY2tlbmQgc2hvdWxkIG5vdCB1c2UgdGhl IGQ4IHJlZ2lzdGVyIGFzIHNjcmF0Y2ggcmVnaXN0ZXIKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9qaXQvSklUT3Bjb2Rlcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2ppdC9KSVRPcGNvZGVzLmNwcAkocmV2aXNpb24gMTQ4NjQxKQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2ppdC9KSVRPcGNvZGVzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU5Nyw2ICsx NTk3LDggQEAgdm9pZCBKSVQ6OmVtaXRTbG93X29wX3B1dF90b19iYXNlKEluc3RydQogICAgIGNh c2UgUHV0VG9CYXNlT3BlcmF0aW9uOjpWYXJpYWJsZVB1dDoKICAgICAgICAgcmV0dXJuOwogCisg ICAgY2FzZSBQdXRUb0Jhc2VPcGVyYXRpb246Okdsb2JhbFZhcmlhYmxlUHV0Q2hlY2tlZDoKKyAg ICAgICAgbGlua1Nsb3dDYXNlKGl0ZXIpOwogICAgIGNhc2UgUHV0VG9CYXNlT3BlcmF0aW9uOjpH bG9iYWxWYXJpYWJsZVB1dDoKICAgICAgICAgaWYgKCFwdXRUb0Jhc2VPcGVyYXRpb24tPm1faXNE eW5hbWljKQogICAgICAgICAgICAgcmV0dXJuOwpAQCAtMTYwOCw3ICsxNjEwLDYgQEAgdm9pZCBK SVQ6OmVtaXRTbG93X29wX3B1dF90b19iYXNlKEluc3RydQogICAgIGNhc2UgUHV0VG9CYXNlT3Bl cmF0aW9uOjpHZW5lcmljOgogICAgICAgICByZXR1cm47CiAKLSAgICBjYXNlIFB1dFRvQmFzZU9w ZXJhdGlvbjo6R2xvYmFsVmFyaWFibGVQdXRDaGVja2VkOgogICAgIGNhc2UgUHV0VG9CYXNlT3Bl cmF0aW9uOjpHbG9iYWxQcm9wZXJ0eVB1dDoKICAgICAgICAgbGlua1Nsb3dDYXNlKGl0ZXIpOwog ICAgICAgICBicmVhazsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0ODcwOCkKKysrIExheW91dFRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA0LTE4ICBN YXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2gg YmVuZWF0aCBKU0M6OkpJVDo6cHJpdmF0ZUNvbXBpbGVTbG93Q2FzZXMgQCBzdGVwaGVucmRvbmFs ZHNvbi5jb20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNDc3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdlJ3JlIG5vdCBsaW5raW5nIHVwIGFsbCBvZiB0aGUgc2xvdyBjYXNlcyBpbiB0aGUgYmFzZWxp bmUgSklUIHdoZW4gY29tcGlsaW5nIHB1dF90b19iYXNlLgorCisgICAgICAgICogZmFzdC9qcy9w dXQtdG8tYmFzZS1nbG9iYWwtY2hlY2tlZC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IGZhc3QvanMvcHV0LXRvLWJhc2UtZ2xvYmFsLWNoZWNrZWQuaHRtbDogQWRkZWQuCisgICAgICAg ICogZmFzdC9qcy9zY3JpcHQtdGVzdHMvcHV0LXRvLWJhc2UtZ2xvYmFsLWNoZWNrZWQuanM6IEFk ZGVkLgorICAgICAgICAoZ2xvYmFsRik6CisgICAgICAgICh3YXJtdXApOgorICAgICAgICAoZm9v KToKKwogMjAxMy0wNC0xOCAgSmVzc2llIEJlcmxpbiAgPGpiZXJsaW5AYXBwbGUuY29tPgogCiAg ICAgICAgIE1vcmUgY2xlYW5pbmcgdXAgb2Ygc2tpcHBlZCBXSzIgdGVzdHMuCkluZGV4OiBMYXlv dXRUZXN0cy9mYXN0L2pzL3B1dC10by1iYXNlLWdsb2JhbC1jaGVja2VkLWV4cGVjdGVkLnR4dAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL3B1dC10by1iYXNlLWdsb2JhbC1jaGVj a2VkLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvanMvcHV0 LXRvLWJhc2UtZ2xvYmFsLWNoZWNrZWQtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0w LDAgKzEsMTAgQEAKK01ha2Ugc3VyZSB3ZSBkb24ndCBjcmFzaCB3aGVuIGNvbXBpbGluZyBwdXRf dG9fYmFzZSBpbiB0aGUgYmFzZWxpbmUgSklULgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUg YSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIu CisKKworUEFTUyBzdW0gaXMgNDY2MgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQor CitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvanMvcHV0LXRvLWJhc2Ut Z2xvYmFsLWNoZWNrZWQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL3B1 dC10by1iYXNlLWdsb2JhbC1jaGVja2VkLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0 cy9mYXN0L2pzL3B1dC10by1iYXNlLWdsb2JhbC1jaGVja2VkLmh0bWwJKHdvcmtpbmcgY29weSkK QEAgLTAsMCArMSwxMCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlw dCBzcmM9InJlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9k eT4KKzxzY3JpcHQgc3JjPSJzY3JpcHQtdGVzdHMvcHV0LXRvLWJhc2UtZ2xvYmFsLWNoZWNrZWQu anMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9InJlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwv c2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9qcy9zY3Jp cHQtdGVzdHMvcHV0LXRvLWJhc2UtZ2xvYmFsLWNoZWNrZWQuanMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvcHV0LXRvLWJhc2UtZ2xvYmFsLWNoZWNrZWQu anMJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9wdXQt dG8tYmFzZS1nbG9iYWwtY2hlY2tlZC5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDM0IEBA CitkZXNjcmlwdGlvbigKKyJNYWtlIHN1cmUgd2UgZG9uJ3QgY3Jhc2ggd2hlbiBjb21waWxpbmcg cHV0X3RvX2Jhc2UgaW4gdGhlIGJhc2VsaW5lIEpJVC4iCispOworCit2YXIgc3VtID0gMDsKK2Z1 bmN0aW9uIGdsb2JhbEYoKSB7CisgICAgcmV0dXJuIDQyOyAKK30KKworLy8gQ3JlYXRlIGEgd2F0 Y2hwb2ludCBvbiBnbG9iYWxGLgordmFyIHdhcm11cCA9IGZ1bmN0aW9uKCkgeworICAgIHN1bSAr PSBnbG9iYWxGKCk7Cit9CisKK2ZvciAodmFyIGkgPSAwOyBpIDwgMTAwOyBpKyspIHsKKyAgICB3 YXJtdXAoKTsKK30KKwordmFyIGZvbyA9IGZ1bmN0aW9uKG8pIHsKKyAgICBpZiAoby54ID4gMTAp IAorICAgICAgICBldmFsKCJnbG9iYWxGID0gZnVuY3Rpb24oKSB7IHJldHVybiA0MzsgfSIpOwor ICAgIGVsc2UKKyAgICAgICAgc3VtICs9IGdsb2JhbEYoKTsKK307CisKK3ZhciBvID0ge307IAor CisvLyBUaWVyIHVwIHRvIEpJVCBmb3IgY3Jhc2h5IGNyYXNoLgorZm9yICh2YXIgaSA9IDA7IGkg PCAxMDA7IGkrKykgeworICAgIG8ueCA9IGk7CisgICAgZm9vKG8pOworfQorCitzaG91bGRCZSgi c3VtIiwgIjQ2NjIiKTsgCg==