114756 2013-04-17 12:55:28 -0700 [Dashboard] Clean up the timeline updating code, removing Chromium-specific cases 2013-04-17 13:38:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 114755 114605 1 zan zan oldest_to_newest 877439 0 zan 2013-04-17 12:55:28 -0700 [Dashboard] Clean up the timeline updating code, removing Chromium-specific cases 877440 1 198598 zan 2013-04-17 12:58:14 -0700 Created attachment 198598 Patch 877444 2 198598 rniwa 2013-04-17 13:04:02 -0700 Comment on attachment 198598 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198598&action=review > Tools/TestResultServer/static-dashboards/timeline_explorer.js:-114 > -function shouldShowWebKitRevisionsOnly() This function is also called in updateTimelineForBuilder so this patch depends on https://bugs.webkit.org/show_bug.cgi?id=114755. 877464 3 198598 zan 2013-04-17 13:38:01 -0700 Comment on attachment 198598 Patch Clearing flags on attachment: 198598 Committed r148631: <http://trac.webkit.org/changeset/148631> 877465 4 zan 2013-04-17 13:38:05 -0700 All reviewed patches have been landed. Closing bug. 198598 2013-04-17 12:58:14 -0700 2013-04-17 13:38:00 -0700 Patch bug-114756-20130417215745.patch text/plain 3074 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NjI3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzJmNzc5YzcyOWM3NDI1MGQwZGVmMTM4MzE3NDdhODUy NDQ1NDUyYi4uODhkMmI4NDQyNGE2OWMxZWQ0N2QxMDNjMjNiNjNhMDEzMDg0Mjc5NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEzLTA0LTE3ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisK KyAgICAgICAgW0Rhc2hib2FyZF0gQ2xlYW4gdXAgdGhlIHRpbWVsaW5lIHVwZGF0aW5nIGNvZGUs IHJlbW92aW5nIENocm9taXVtLXNwZWNpZmljIGNhc2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ3NTYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDbGVhbiB1cCB0aGUgdXBkYXRpbmcgb2YgdGhlIHRp bWVsaW5lIGluIHRoZSB0aW1lbGluZSBleHBsb3JlciwgZGVmYXVsdGluZyB0byB0aGUgd2Via2l0 Lm9yZyBidWlsZCBtYXN0ZXIgd2hlbgorICAgICAgICBjb25zdHJ1Y3RpbmcgdGhlIHJlc3VsdHMg VVJMIGFuZCByZW1vdmluZyB0aGUgcG9zc2libGUgcm93IGFkZGl0aW9uIGNvbnRhaW5pbmcgdGhl IENocm9taXVtIGNvbW1pdCByYW5nZSB0aGF0CisgICAgICAgIG9ubHkgYXBwbGllZCB0byBDaHJv bWl1bSBidWlsZGVycyBpbiB0aGUgZmlyc3QgcGxhY2UuIEFsc28gcmVtb3ZlcyB0aGUgbm93LXJl ZHVuZGFudCBzaG91bGRTaG93V2ViS2l0UmV2aXNpb25zT25seQorICAgICAgICBtZXRob2QuCisK KyAgICAgICAgKiBUZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL3RpbWVsaW5lX2V4 cGxvcmVyLmpzOgorCiAyMDEzLTA0LTE3ICBBbGJlcnRvIEdhcmNpYSAgPGFnYXJjaWFAaWdhbGlh LmNvbT4KIAogICAgICAgICBtZWRpYS1zdHJlYW0gYW5kIHhzbHQgYXJlIG5vIGxvbmdlciBjb25m aWd1cmFibGUgb3B0aW9ucyBpbiB0aGUgR1RLKyBwb3J0CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0 UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL3RpbWVsaW5lX2V4cGxvcmVyLmpzIGIvVG9v bHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy90aW1lbGluZV9leHBsb3Jlci5q cwppbmRleCBiODg1ZDYzMDg0YjQ1YWViMjI5MjMyOWEyOWQxNmYyNzI0ZWQ1MWUxLi5iNGM3OTc3 MzJhM2Y0NjM1MGJmMGQ4YTNmYWExMjkzM2IzMGQwNGQwIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0 UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL3RpbWVsaW5lX2V4cGxvcmVyLmpzCisrKyBi L1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvdGltZWxpbmVfZXhwbG9y ZXIuanMKQEAgLTExMSwxMSArMTExLDYgQEAgZnVuY3Rpb24gaW5pdEN1cnJlbnRCdWlsZGVyVGVz dFJlc3VsdHMoKQogICAgIGNvbnNvbGUubG9nKCAnVGltZSB0byBnZXQgdGVzdCByZXN1bHRzIGJ5 IGJ1aWxkOiAnICsgKERhdGUubm93KCkgLSBzdGFydFRpbWUpKTsKIH0KIAotZnVuY3Rpb24gc2hv dWxkU2hvd1dlYktpdFJldmlzaW9uc09ubHkoKQotewotICAgIHJldHVybiBpc1RpcE9mVHJlZVdl YktpdEJ1aWxkZXIoKTsKLX0KLQogZnVuY3Rpb24gdXBkYXRlVGltZWxpbmVGb3JCdWlsZGVyKCkK IHsKICAgICB2YXIgYnVpbGRlciA9IGdfaGlzdG9yeS5kYXNoYm9hcmRTcGVjaWZpY1N0YXRlLmJ1 aWxkZXIgfHwgY3VycmVudEJ1aWxkZXJHcm91cCgpLmRlZmF1bHRCdWlsZGVyKCk7CkBAIC0yMjks MTkgKzIyNCwxMiBAQCBmdW5jdGlvbiB1cGRhdGVCdWlsZEluc3BlY3RvcihyZXN1bHRzLCBidWls ZGVyLCBkeWdyYXBoLCBpbmRleCkKICAgICBhZGRSb3coJycsICcnKTsKICAgICB2YXIgbWFzdGVy ID0gYnVpbGRlck1hc3RlcihidWlsZGVyKTsKICAgICB2YXIgYnVpbGRVcmwgPSBtYXN0ZXIubG9n UGF0aChidWlsZGVyLCByZXN1bHRzW0JVSUxEX05VTUJFUlNfS0VZXVtpbmRleF0pOwotICAgIGlm IChtYXN0ZXIubmFtZSA9PSBXRUJLSVRfQlVJTERFUl9NQVNURVIpIHsKLSAgICAgICAgdmFyIHJl c3VsdHNVcmwgPSAnaHR0cDovL2J1aWxkLndlYmtpdC5vcmcvcmVzdWx0cy8nICsgYnVpbGRlciAr ICcvcicgKyByZXN1bHRzW1dFQktJVF9SRVZJU0lPTlNfS0VZXVtpbmRleF0gKwotICAgICAgICAg ICAgJyAoJyArIHJlc3VsdHNbQlVJTERfTlVNQkVSU19LRVldW2luZGV4XSArICcpJzsKLSAgICB9 IGVsc2UgewotICAgICAgICB2YXIgcmVzdWx0c1VybCA9ICdodHRwOi8vYnVpbGQuY2hyb21pdW0u b3JnL2YvY2hyb21pdW0vbGF5b3V0X3Rlc3RfcmVzdWx0cy8nICsKLSAgICAgICAgICAgIGN1cnJl bnRCdWlsZGVycygpW2J1aWxkZXJdICsgJy8nICsgcmVzdWx0c1tDSFJPTUVfUkVWSVNJT05TX0tF WV1baW5kZXhdOwotICAgIH0KKyAgICB2YXIgcmVzdWx0c1VybCA9ICdodHRwOi8vYnVpbGQud2Vi a2l0Lm9yZy9yZXN1bHRzLycgKyBidWlsZGVyICsgJy9yJyArIHJlc3VsdHNbV0VCS0lUX1JFVklT SU9OU19LRVldW2luZGV4XSArCisgICAgICAgICcgKCcgKyByZXN1bHRzW0JVSUxEX05VTUJFUlNf S0VZXVtpbmRleF0gKyAnKSc7CiAKICAgICBhZGRSb3coJ0J1aWxkOicsICc8YSBocmVmPSInICsg YnVpbGRVcmwgKyAnIiB0YXJnZXQ9Il9ibGFuayI+JyArIGJ1aWxkTnVtYmVyICsgJzwvYT4gKDxh IGhyZWY9IicgKyByZXN1bHRzVXJsICsgJyIgdGFyZ2V0PSJfYmxhbmsiPnJlc3VsdHM8L2E+KScp OwogCi0gICAgLy8gUmV2aXNpb24gbGluayhzKQotICAgIGlmICghc2hvdWxkU2hvd1dlYktpdFJl dmlzaW9uc09ubHkoKSkKLSAgICAgICAgYWRkUm93KCdDaHJvbWl1bSBjaGFuZ2U6JywgdWkuaHRt bC5jaHJvbWl1bVJldmlzaW9uTGluayhyZXN1bHRzLCBpbmRleCkpOworICAgIC8vIFJldmlzaW9u IGxpbmsKICAgICBhZGRSb3coJ1dlYktpdCBjaGFuZ2U6JywgdWkuaHRtbC53ZWJLaXRSZXZpc2lv bkxpbmsocmVzdWx0cywgaW5kZXgpKTsKIAogICAgIC8vIFRlc3Qgc3RhdHVzL2NvdW50cwo=