114740 2013-04-17 06:46:20 -0700 Add checking whether the compiler allows to use #pragma directive. 2013-04-18 05:54:46 -0700 1 1 1 Unclassified WebKit ANGLE 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 k.wolanski webkit-unassigned achicu commit-queue dino kling oldest_to_newest 877146 0 k.wolanski 2013-04-17 06:46:20 -0700 Some compilers may complain that #pragma warning is an undefined macro. 877148 1 198504 k.wolanski 2013-04-17 06:51:02 -0700 Created attachment 198504 proposed patch 877834 2 198504 kling 2013-04-18 05:41:38 -0700 Comment on attachment 198504 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=198504&action=review > Source/ThirdParty/ANGLE/src/compiler/depgraph/DependencyGraph.cpp:7 > +#if defined(_MSC_VER) This should be #if COMPILER(MSVC) Otherwise, it looks fine. 877836 3 kling 2013-04-18 05:42:36 -0700 (In reply to comment #2) > (From update of attachment 198504 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=198504&action=review > > > Source/ThirdParty/ANGLE/src/compiler/depgraph/DependencyGraph.cpp:7 > > +#if defined(_MSC_VER) > > This should be #if COMPILER(MSVC) > Otherwise, it looks fine. Actually, since this is in ANGLE.. I guess we don't have config.h / wtf/Platform.h included. 877838 4 198504 kling 2013-04-18 05:44:37 -0700 Comment on attachment 198504 proposed patch Okay, I got that wrong. Checking MSC_VER directly is fine in ANGLE. r=me! 877843 5 198504 commit-queue 2013-04-18 05:54:43 -0700 Comment on attachment 198504 proposed patch Clearing flags on attachment: 198504 Committed r148669: <http://trac.webkit.org/changeset/148669> 877844 6 commit-queue 2013-04-18 05:54:46 -0700 All reviewed patches have been landed. Closing bug. 198504 2013-04-17 06:51:02 -0700 2013-04-18 05:54:43 -0700 proposed patch fix_pragma_warning.patch text/plain 1223 k.wolanski ZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZyBiL1NvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZwppbmRleCAyMzUzYzcwLi4wNGM4Yjc4IDEwMDY0NAot LS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1RoaXJk UGFydHkvQU5HTEUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDQtMTYgIEtyenlz enRvZiBXb2xhbnNraSAgPGsud29sYW5za2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgQWRkIGNo ZWNraW5nIHdoZXRoZXIgdGhlIGNvbXBpbGVyIGFsbG93cyB0byB1c2UgI3ByYWdtYSBkaXJlY3Rp dmUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ3 NDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTb21l IGNvbXBpbGVycyBtYXkgY29tcGxhaW4gdGhhdCAjcHJhZ21hIHdhcm5pbmcgaXMgYW4gdW5kZWZp bmVkIG1hY3JvLgorCisgICAgICAgICogc3JjL2NvbXBpbGVyL2RlcGdyYXBoL0RlcGVuZGVuY3lH cmFwaC5jcHA6CisKIDIwMTMtMDQtMTEgIEFuZHJhcyBCZWNzaSAgPGFuZHJhcy5iZWNzaUBkaWdp YS5jb20+CiAKICAgICAgICAgW1F0XVtNYWNdIExpbmtpbmcgZmFpbHMgd2l0aCBRdCA1LjEKZGlm ZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9kZXBncmFwaC9E ZXBlbmRlbmN5R3JhcGguY3BwIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVy L2RlcGdyYXBoL0RlcGVuZGVuY3lHcmFwaC5jcHAKaW5kZXggY2E2NjFkNi4uOTQwOGYyOCAxMDA2 NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL2RlcGdyYXBoL0Rl cGVuZGVuY3lHcmFwaC5jcHAKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBp bGVyL2RlcGdyYXBoL0RlcGVuZGVuY3lHcmFwaC5jcHAKQEAgLTQsNyArNCw5IEBACiAvLyBmb3Vu ZCBpbiB0aGUgTElDRU5TRSBmaWxlLgogLy8KIAorI2lmIGRlZmluZWQoX01TQ19WRVIpCiAjcHJh Z21hIHdhcm5pbmcoZGlzYWJsZTogNDcxOCkKKyNlbmRpZgogCiAjaW5jbHVkZSAiY29tcGlsZXIv ZGVwZ3JhcGgvRGVwZW5kZW5jeUdyYXBoLmgiCiAjaW5jbHVkZSAiY29tcGlsZXIvZGVwZ3JhcGgv RGVwZW5kZW5jeUdyYXBoQnVpbGRlci5oIgo=