114737 2013-04-17 06:28:51 -0700 REGRESSION(r148588): It broke the Qt WK2 EWS 2013-04-18 01:22:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 114558 1 ossy ossy benjamin commit-queue dpranke hausmann jturcotte kadam ossy rniwa zarvai oldest_to_newest 877140 0 ossy 2013-04-17 06:28:51 -0700 Fix is coming soon. 877147 1 198503 ossy 2013-04-17 06:48:51 -0700 Created attachment 198503 Patch 877151 2 198503 jturcotte 2013-04-17 07:00:28 -0700 Comment on attachment 198503 Patch I can't say that this all makes sense to me but I don't see anything obviously wrong, rs=me. 877152 3 198503 ossy 2013-04-17 07:03:53 -0700 Comment on attachment 198503 Patch Clearing flags on attachment: 198503 Committed r148608: <http://trac.webkit.org/changeset/148608> 877153 4 ossy 2013-04-17 07:03:59 -0700 All reviewed patches have been landed. Closing bug. 877351 5 rniwa 2013-04-17 09:55:00 -0700 The patch makes sense. What doesn't make sense is that r148588 broke this. How did Qt WK2 EWS work before r148588 without qt-wk2 being defined there? 877352 6 ossy 2013-04-17 09:58:04 -0700 (In reply to comment #5) > The patch makes sense. What doesn't make sense is that r148588 broke this. How did Qt WK2 EWS work before r148588 without qt-wk2 being defined there? qt-wk2 didn't exist as platform before. Qt EWS and Qt WK2 EWS used qt platform, and only the local BUILD_WEBKIT_ARGS=--no-webkit2 on Qt EWS ensured that it built only WebKit1. 877354 7 rniwa 2013-04-17 10:00:26 -0700 (In reply to comment #6) > (In reply to comment #5) > > The patch makes sense. What doesn't make sense is that r148588 broke this. How did Qt WK2 EWS work before r148588 without qt-wk2 being defined there? > > qt-wk2 didn't exist as platform before. Qt EWS and Qt WK2 EWS > used qt platform, and only the local BUILD_WEBKIT_ARGS=--no-webkit2 > on Qt EWS ensured that it built only WebKit1. Interesting. How did that break with r148588? 877355 8 198503 ossy 2013-04-17 10:08:02 -0700 Comment on attachment 198503 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198503&action=review > Tools/Scripts/webkitpy/common/config/ews.json:33 > "Qt WK2 EWS": { > - "port": "qt", > + "port": "qt-wk2", (In reply to comment #7) > Interesting. How did that break with r148588? Before r148588 port and name was different: Qt EWS: port=qt and name=qt-ews Qt WK2 EWS: port=qt and name=qt-wk2-ews after r148588: name=port+"-ews" r148588 revealed that the previous implementation was misleading, and I thought it is high time to have a qt-wk2 platform and fix it properly and get rid one more local hack on the EWS bot. :) And additionally the change landed from this bug is necessary if once Qt want to run tests on the WK1 and/or the WK2 EWS bots. 877358 9 rniwa 2013-04-17 10:15:07 -0700 Makes sense. Thanks for the clarification & the fix. We should really merge deprecated ports & new ports :( 877735 10 zarvai 2013-04-18 01:22:26 -0700 Bad window, sorry for the noise. 198503 2013-04-17 06:48:51 -0700 2013-04-17 10:08:02 -0700 Patch bug-114737-20130417154831.patch text/plain 5384 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NjA1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTBiNmRlOTI0Y2NmMWQwMWFlYzU3NDUwNzg2NGE5NmEz MTk5NzdmZC4uMjgzMjZkYjE2OTBkYzQ0YTQwMDFlYzQ3NDFlMGIzZGJhY2I4NDhhMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDEzLTA0LTE3ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgUkVHUkVTU0lPTihyMTQ4NTg4KTogSXQgYnJva2UgdGhlIFF0IFdLMiBFV1MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDczNworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS9jb21tb24vY29uZmlnL2V3cy5qc29uOiAiUXQgV0syIEVXUyIgc2hvdWxkIHVzZSBx dC13azIgcG9ydC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvcG9y dHMucHk6CisgICAgICAgIChEZXByZWNhdGVkUG9ydC5wb3J0KToKKyAgICAgICAgKFF0UG9ydC5i dWlsZF93ZWJraXRfY29tbWFuZCk6IHF0IHBvcnQgc2hvdWxkbid0IGJ1aWxkIFdlYktpdDIuCisg ICAgICAgIChRdFBvcnQucnVuX3dlYmtpdF90ZXN0c19jb21tYW5kKTogcXQgcG9ydCBydW5zIFdL MSB0ZXN0cy4KKyAgICAgICAgKFF0V0syUG9ydCk6IEFkZGVkLgorICAgICAgICAoUXRXSzJQb3J0 LmJ1aWxkX3dlYmtpdF9jb21tYW5kKTogcXQtd2syIHBvcnQgYnVpbGRzIFdLMSBhbmQgV0syIHRv by4KKyAgICAgICAgKFF0V0syUG9ydC5ydW5fd2Via2l0X3Rlc3RzX2NvbW1hbmQpOiBxdC13azIg cG9ydCBydW5zIFdLMiB0ZXN0cy4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9j b25maWcvcG9ydHNfdW5pdHRlc3QucHk6CisgICAgICAgIChEZXByZWNhdGVkUG9ydFRlc3QudGVz dF9xdF9wb3J0KToKKyAgICAgICAgKERlcHJlY2F0ZWRQb3J0VGVzdCk6CisgICAgICAgIChEZXBy ZWNhdGVkUG9ydFRlc3QudGVzdF9xdF93azJfcG9ydCk6CisKIDIwMTMtMDQtMTcgIFphbiBEb2Jl cnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvZXdzLmpzb24gYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvZXdzLmpzb24KaW5kZXggYjUwZTBm YzAxNTA0N2U3OGMwYWUzMGEzYThmNzU4NmJhODJkYTMwNi4uYzgyYWE5OTY4MjEyMmZmMzIwMWIx YmE3NDQ2YmQxODllYjc3MzU3ZiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9j b21tb24vY29uZmlnL2V3cy5qc29uCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9u L2NvbmZpZy9ld3MuanNvbgpAQCAtMzAsNyArMzAsNyBAQAogICAgICAgICBdCiAgICAgfSwKICAg ICAiUXQgV0syIEVXUyI6IHsKLSAgICAgICAgInBvcnQiOiAicXQiLAorICAgICAgICAicG9ydCI6 ICJxdC13azIiLAogICAgICAgICAid2F0Y2hlcnMiOiBbCiAgICAgICAgICAgICAid2Via2l0LWV3 c0BzZWQuaW5mLnUtc3plZ2VkLmh1IgogICAgICAgICBdCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvcG9ydHMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9jb25maWcvcG9ydHMucHkKaW5kZXggMWQ0ZWY1MjI1OWUyYzRhYWI4M2NhYWFl N2E3MzAzNTA3Y2YyNjUwNy4uMGMyMGRhZTUxMjRhMjdkNTdiODZlN2RhYzUyZjczNGNjNTY2NGY5 NyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL3BvcnRz LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9wb3J0cy5weQpA QCAtNjcsNiArNjcsNyBAQCBjbGFzcyBEZXByZWNhdGVkUG9ydChvYmplY3QpOgogICAgICAgICAg ICAgIm1hYy13azIiOiBNYWNXSzJQb3J0LAogICAgICAgICAgICAgIndpbiI6IFdpblBvcnQsCiAg ICAgICAgICAgICAicXQiOiBRdFBvcnQsCisgICAgICAgICAgICAicXQtd2syIjogUXRXSzJQb3J0 LAogICAgICAgICAgICAgImVmbCI6IEVmbFBvcnQsCiAgICAgICAgICAgICAiZWZsLXdrMiI6IEVm bFdLMlBvcnQsCiAgICAgICAgIH0KQEAgLTE4MSw5ICsxODIsMzEgQEAgY2xhc3MgUXRQb3J0KERl cHJlY2F0ZWRQb3J0KToKICAgICBkZWYgYnVpbGRfd2Via2l0X2NvbW1hbmQoc2VsZiwgYnVpbGRf c3R5bGU9Tm9uZSk6CiAgICAgICAgIGNvbW1hbmQgPSBzdXBlcihRdFBvcnQsIHNlbGYpLmJ1aWxk X3dlYmtpdF9jb21tYW5kKGJ1aWxkX3N0eWxlPWJ1aWxkX3N0eWxlKQogICAgICAgICBjb21tYW5k LmFwcGVuZCgiLS1xdCIpCisgICAgICAgIGNvbW1hbmQuYXBwZW5kKCItLW5vLXdlYmtpdDIiKQog ICAgICAgICBjb21tYW5kLmFwcGVuZChzdXBlcihRdFBvcnQsIHNlbGYpLm1ha2VBcmdzKCkpCiAg ICAgICAgIHJldHVybiBjb21tYW5kCiAKKyAgICBkZWYgcnVuX3dlYmtpdF90ZXN0c19jb21tYW5k KHNlbGYpOgorICAgICAgICBjb21tYW5kID0gc3VwZXIoUXRQb3J0LCBzZWxmKS5ydW5fd2Via2l0 X3Rlc3RzX2NvbW1hbmQoKQorICAgICAgICBjb21tYW5kLmFwcGVuZCgiLS1xdCIpCisgICAgICAg IHJldHVybiBjb21tYW5kCisKKworY2xhc3MgUXRXSzJQb3J0KERlcHJlY2F0ZWRQb3J0KToKKyAg ICBwb3J0X2ZsYWdfbmFtZSA9ICJxdC13azIiCisKKyAgICBkZWYgYnVpbGRfd2Via2l0X2NvbW1h bmQoc2VsZiwgYnVpbGRfc3R5bGU9Tm9uZSk6CisgICAgICAgIGNvbW1hbmQgPSBzdXBlcihRdFdL MlBvcnQsIHNlbGYpLmJ1aWxkX3dlYmtpdF9jb21tYW5kKGJ1aWxkX3N0eWxlPWJ1aWxkX3N0eWxl KQorICAgICAgICBjb21tYW5kLmFwcGVuZCgiLS1xdCIpCisgICAgICAgIGNvbW1hbmQuYXBwZW5k KHN1cGVyKFF0V0syUG9ydCwgc2VsZikubWFrZUFyZ3MoKSkKKyAgICAgICAgcmV0dXJuIGNvbW1h bmQKKworICAgIGRlZiBydW5fd2Via2l0X3Rlc3RzX2NvbW1hbmQoc2VsZik6CisgICAgICAgIGNv bW1hbmQgPSBzdXBlcihRdFdLMlBvcnQsIHNlbGYpLnJ1bl93ZWJraXRfdGVzdHNfY29tbWFuZCgp CisgICAgICAgIGNvbW1hbmQuYXBwZW5kKCItLXF0IikKKyAgICAgICAgY29tbWFuZC5hcHBlbmQo Ii0yIikKKyAgICAgICAgcmV0dXJuIGNvbW1hbmQKKwogCiBjbGFzcyBFZmxQb3J0KERlcHJlY2F0 ZWRQb3J0KToKICAgICBwb3J0X2ZsYWdfbmFtZSA9ICJlZmwiCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvcG9ydHNfdW5pdHRlc3QucHkgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvcG9ydHNfdW5pdHRlc3QucHkKaW5kZXggY2Nl NjQ4NDY5MjExYzVjNzE3Y2NmMDAzNjdhM2Q1ODc3ODM5ZjI0OC4uZGFjYTU0YTY4YTRkYzE5MDVi OTA3NzFiOTRhZGE0NGYwNTNkMTQzOCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9jb21tb24vY29uZmlnL3BvcnRzX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL2NvbmZpZy9wb3J0c191bml0dGVzdC5weQpAQCAtNTgsNiArNTgsMTIgQEAg Y2xhc3MgRGVwcmVjYXRlZFBvcnRUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKIAogICAgIGRlZiB0 ZXN0X3F0X3BvcnQoc2VsZik6CiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoUXRQb3J0KCkuZmxh ZygpLCAiLS1wb3J0PXF0IikKLSAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChRdFBvcnQoKS5ydW5f d2Via2l0X3Rlc3RzX2NvbW1hbmQoKSwgRGVwcmVjYXRlZFBvcnQoKS5zY3JpcHRfc2hlbGxfY29t bWFuZCgicnVuLXdlYmtpdC10ZXN0cyIpKQotICAgICAgICBzZWxmLmFzc2VydEVxdWFsKFF0UG9y dCgpLmJ1aWxkX3dlYmtpdF9jb21tYW5kKCksIERlcHJlY2F0ZWRQb3J0KCkuc2NyaXB0X3NoZWxs X2NvbW1hbmQoImJ1aWxkLXdlYmtpdCIpICsgWyItLXF0IiwgRGVwcmVjYXRlZFBvcnQoKS5tYWtl QXJncygpXSkKLSAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChRdFBvcnQoKS5idWlsZF93ZWJraXRf Y29tbWFuZChidWlsZF9zdHlsZT0iZGVidWciKSwgRGVwcmVjYXRlZFBvcnQoKS5zY3JpcHRfc2hl bGxfY29tbWFuZCgiYnVpbGQtd2Via2l0IikgKyBbIi0tZGVidWciLCAiLS1xdCIsIERlcHJlY2F0 ZWRQb3J0KCkubWFrZUFyZ3MoKV0pCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoUXRQb3J0KCku cnVuX3dlYmtpdF90ZXN0c19jb21tYW5kKCksIERlcHJlY2F0ZWRQb3J0KCkuc2NyaXB0X3NoZWxs X2NvbW1hbmQoInJ1bi13ZWJraXQtdGVzdHMiKSArIFsiLS1xdCJdKQorICAgICAgICBzZWxmLmFz c2VydEVxdWFsKFF0UG9ydCgpLmJ1aWxkX3dlYmtpdF9jb21tYW5kKCksIERlcHJlY2F0ZWRQb3J0 KCkuc2NyaXB0X3NoZWxsX2NvbW1hbmQoImJ1aWxkLXdlYmtpdCIpICsgWyItLXF0IiwgIi0tbm8t d2Via2l0MiIsIERlcHJlY2F0ZWRQb3J0KCkubWFrZUFyZ3MoKV0pCisgICAgICAgIHNlbGYuYXNz ZXJ0RXF1YWwoUXRQb3J0KCkuYnVpbGRfd2Via2l0X2NvbW1hbmQoYnVpbGRfc3R5bGU9ImRlYnVn IiksIERlcHJlY2F0ZWRQb3J0KCkuc2NyaXB0X3NoZWxsX2NvbW1hbmQoImJ1aWxkLXdlYmtpdCIp ICsgWyItLWRlYnVnIiwgIi0tcXQiLCAiLS1uby13ZWJraXQyIiwgRGVwcmVjYXRlZFBvcnQoKS5t YWtlQXJncygpXSkKKworICAgIGRlZiB0ZXN0X3F0X3drMl9wb3J0KHNlbGYpOgorICAgICAgICBz ZWxmLmFzc2VydEVxdWFsKFF0V0syUG9ydCgpLmZsYWcoKSwgIi0tcG9ydD1xdC13azIiKQorICAg ICAgICBzZWxmLmFzc2VydEVxdWFsKFF0V0syUG9ydCgpLnJ1bl93ZWJraXRfdGVzdHNfY29tbWFu ZCgpLCBEZXByZWNhdGVkUG9ydCgpLnNjcmlwdF9zaGVsbF9jb21tYW5kKCJydW4td2Via2l0LXRl c3RzIikgKyBbIi0tcXQiLCAiLTIiXSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChRdFdLMlBv cnQoKS5idWlsZF93ZWJraXRfY29tbWFuZCgpLCBEZXByZWNhdGVkUG9ydCgpLnNjcmlwdF9zaGVs bF9jb21tYW5kKCJidWlsZC13ZWJraXQiKSArIFsiLS1xdCIsIERlcHJlY2F0ZWRQb3J0KCkubWFr ZUFyZ3MoKV0pCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoUXRXSzJQb3J0KCkuYnVpbGRfd2Vi a2l0X2NvbW1hbmQoYnVpbGRfc3R5bGU9ImRlYnVnIiksIERlcHJlY2F0ZWRQb3J0KCkuc2NyaXB0 X3NoZWxsX2NvbW1hbmQoImJ1aWxkLXdlYmtpdCIpICsgWyItLWRlYnVnIiwgIi0tcXQiLCBEZXBy ZWNhdGVkUG9ydCgpLm1ha2VBcmdzKCldKQo=