114727 2013-04-17 02:16:24 -0700 Gradient: add PlatformGradient definition for BlackBerry 2013-04-22 01:58:11 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111729 0 berto webkit-unassigned commit-queue oldest_to_newest 877083 0 berto 2013-04-17 02:16:24 -0700 PlatformGradient is not defined for BlackBerry in Gradient.h 877087 1 198486 berto 2013-04-17 02:17:34 -0700 Created attachment 198486 Patch 878999 2 198486 cgarcia 2013-04-22 00:55:51 -0700 Comment on attachment 198486 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198486&action=review > Source/WebCore/platform/graphics/Gradient.h:62 > + class Gradient; This should not be indented, I wonder why the the style checker hasn't caught this, maybe because of the multiple namespaces in the same line which is not common in WebKit code either. 879003 3 198997 berto 2013-04-22 01:11:05 -0700 Created attachment 198997 Patch Here's the updated patch. 879019 4 198997 commit-queue 2013-04-22 01:58:09 -0700 Comment on attachment 198997 Patch Clearing flags on attachment: 198997 Committed r148864: <http://trac.webkit.org/changeset/148864> 879020 5 commit-queue 2013-04-22 01:58:11 -0700 All reviewed patches have been landed. Closing bug. 198486 2013-04-17 02:17:34 -0700 2013-04-22 01:11:05 -0700 Patch 114727.diff text/plain 1173 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmNzJjZWZhLi4xY2Q1YzRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTMtMDQtMTcgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIEdyYWRpZW50OiBhZGQgUGxhdGZvcm1HcmFkaWVudCBkZWZpbml0aW9uIGZvciBCbGFj a0JlcnJ5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTQ3MjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50Lmg6CisgICAgICAgIChHcmFwaGljcyk6CisKIDIw MTMtMDQtMTUgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAg IFtCbGFja0JlcnJ5XSBVcHN0cmVhbSB0aGUgaW5wdXQgcG9wdXBzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFkaWVudC5oIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvR3JhZGllbnQuaAppbmRleCBhN2I1NDg4Li44OGJlZTNhIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFkaWVudC5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50LmgKQEAgLTU3LDYgKzU3 LDExIEBAIHR5cGVkZWYgY2xhc3MgU2tTaGFkZXIqIFBsYXRmb3JtUGF0dGVybjsKICNlbGlmIFBM QVRGT1JNKFdYKQogY2xhc3Mgd3hHcmFwaGljc0JydXNoOwogdHlwZWRlZiB3eEdyYXBoaWNzQnJ1 c2gqIFBsYXRmb3JtR3JhZGllbnQ7CisjZWxpZiBQTEFURk9STShCTEFDS0JFUlJZKQorbmFtZXNw YWNlIEJsYWNrQmVycnkgeyBuYW1lc3BhY2UgUGxhdGZvcm0geyBuYW1lc3BhY2UgR3JhcGhpY3Mg eworICAgIGNsYXNzIEdyYWRpZW50OworfSB9IH0KK3R5cGVkZWYgQmxhY2tCZXJyeTo6UGxhdGZv cm06OkdyYXBoaWNzOjpHcmFkaWVudCogUGxhdGZvcm1HcmFkaWVudDsKICNlbHNlCiB0eXBlZGVm IHZvaWQqIFBsYXRmb3JtR3JhZGllbnQ7CiAjZW5kaWYK 198997 2013-04-22 01:11:05 -0700 2013-04-22 01:58:09 -0700 Patch 114727.diff text/plain 1212 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhMTFhMDA2Li5iNmRhMjk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTMtMDQtMjIgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIEdyYWRpZW50OiBhZGQgUGxhdGZvcm1HcmFkaWVudCBkZWZpbml0aW9uIGZvciBCbGFj a0JlcnJ5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTQ3MjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50Lmg6CisgICAgICAgIChHcmFwaGljcyk6CisKIDIw MTMtMDQtMjEgIERpcmsgU2NodWx6ZSAgPGtyaXRAd2Via2l0Lm9yZz4KIAogICAgICAgICBbUGFy dCA0XSBQYXJzZSB0aGUgY3VzdG9tKCkgZnVuY3Rpb24gaW4gLXdlYmtpdC1maWx0ZXI6IHBhcnNl IHRoZSBtYXROKCkgZnVuY3Rpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9HcmFkaWVudC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv R3JhZGllbnQuaAppbmRleCBhN2I1NDg4Li41MDA2YzQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFkaWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50LmgKQEAgLTU3LDYgKzU3LDE1IEBAIHR5cGVkZWYgY2xh c3MgU2tTaGFkZXIqIFBsYXRmb3JtUGF0dGVybjsKICNlbGlmIFBMQVRGT1JNKFdYKQogY2xhc3Mg d3hHcmFwaGljc0JydXNoOwogdHlwZWRlZiB3eEdyYXBoaWNzQnJ1c2gqIFBsYXRmb3JtR3JhZGll bnQ7CisjZWxpZiBQTEFURk9STShCTEFDS0JFUlJZKQorbmFtZXNwYWNlIEJsYWNrQmVycnkgewor bmFtZXNwYWNlIFBsYXRmb3JtIHsKK25hbWVzcGFjZSBHcmFwaGljcyB7CitjbGFzcyBHcmFkaWVu dDsKK30KK30KK30KK3R5cGVkZWYgQmxhY2tCZXJyeTo6UGxhdGZvcm06OkdyYXBoaWNzOjpHcmFk aWVudCogUGxhdGZvcm1HcmFkaWVudDsKICNlbHNlCiB0eXBlZGVmIHZvaWQqIFBsYXRmb3JtR3Jh ZGllbnQ7CiAjZW5kaWYK