114726 2013-04-17 01:36:36 -0700 [BlackBerry] GraphicsContext3D: don't initialize m_extensions in the constructor 2013-04-17 02:17:11 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 berto webkit-unassigned cgarcia commit-queue dino mifenton rwlbuis tonikitoo oldest_to_newest 877074 0 berto 2013-04-17 01:36:36 -0700 m_extensions is now initialized on demand by GraphicsContext3D::getExtensions(). Doing it in the constructor produces a crash, because Extensions3DOpenGLES() calls glGetString before the WebGL context is current. 877075 1 198482 berto 2013-04-17 01:37:46 -0700 Created attachment 198482 Patch 877084 2 198482 commit-queue 2013-04-17 02:17:08 -0700 Comment on attachment 198482 Patch Clearing flags on attachment: 198482 Committed r148595: <http://trac.webkit.org/changeset/148595> 877085 3 commit-queue 2013-04-17 02:17:11 -0700 All reviewed patches have been landed. Closing bug. 198482 2013-04-17 01:37:46 -0700 2013-04-17 02:17:08 -0700 Patch 114726.diff text/plain 2788 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5YTI0NjEyLi45NDY4ODQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTMtMDQtMTcgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtCbGFja0JlcnJ5XSBHcmFwaGljc0NvbnRleHQzRDogZG9uJ3QgaW5pdGlhbGl6ZSBt X2V4dGVuc2lvbnMgaW4gdGhlIGNvbnN0cnVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ3MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBtX2V4dGVuc2lvbnMgaXMgbm93IGluaXRpYWxpemVkIG9u IGRlbWFuZCBieQorICAgICAgICBHcmFwaGljc0NvbnRleHQzRDo6Z2V0RXh0ZW5zaW9ucygpLgor CisgICAgICAgIERvaW5nIGl0IGluIHRoZSBjb25zdHJ1Y3RvciBwcm9kdWNlcyBhIGNyYXNoLCBi ZWNhdXNlCisgICAgICAgIEV4dGVuc2lvbnMzRE9wZW5HTEVTKCkgY2FsbHMgZ2xHZXRTdHJpbmcg YmVmb3JlIHRoZSBXZWJHTCBjb250ZXh0CisgICAgICAgIGlzIGN1cnJlbnQuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0dyYXBoaWNzQ29udGV4dDNEQmxhY2tCZXJy eS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6R3JhcGhpY3NDb250 ZXh0M0QpOgorCiAyMDEzLTA0LTE1ICBBbGJlcnRvIEdhcmNpYSAgPGFnYXJjaWFAaWdhbGlhLmNv bT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gVXBzdHJlYW0gdGhlIGlucHV0IHBvcHVwcwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9HcmFw aGljc0NvbnRleHQzREJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvYmxhY2tiZXJyeS9HcmFwaGljc0NvbnRleHQzREJsYWNrQmVycnkuY3BwCmluZGV4IDVl YjdiYWUuLmUyZjdiYjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2JsYWNrYmVycnkvR3JhcGhpY3NDb250ZXh0M0RCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0dyYXBoaWNzQ29udGV4dDNE QmxhY2tCZXJyeS5jcHAKQEAgLTU2LDcgKzU2LDYgQEAgR3JhcGhpY3NDb250ZXh0M0Q6OkdyYXBo aWNzQ29udGV4dDNEKEdyYXBoaWNzQ29udGV4dDNEOjpBdHRyaWJ1dGVzIGF0dHJzLCBIb3N0V2kK ICAgICAsIG1fY3VycmVudEhlaWdodCgwKQogICAgICwgbV9jb250ZXh0KEJsYWNrQmVycnk6OlBs YXRmb3JtOjpHcmFwaGljczo6Y3JlYXRlV2ViR0xDb250ZXh0KCkpCiAgICAgLCBtX2NvbXBpbGVy KFNIX0VTU0xfT1VUUFVUKQotICAgICwgbV9leHRlbnNpb25zKGFkb3B0UHRyKG5ldyBFeHRlbnNp b25zM0RPcGVuR0xFUyh0aGlzKSkpCiAgICAgLCBtX2F0dHJzKGF0dHJzKQogICAgICwgbV90ZXh0 dXJlKDApCiAgICAgLCBtX2ZibygwKQpAQCAtMTA5LDEwICsxMDgsMTEgQEAgR3JhcGhpY3NDb250 ZXh0M0Q6OkdyYXBoaWNzQ29udGV4dDNEKEdyYXBoaWNzQ29udGV4dDNEOjpBdHRyaWJ1dGVzIGF0 dHJzLCBIb3N0V2kKICAgICBnZXRJbnRlZ2VydihHcmFwaGljc0NvbnRleHQzRDo6TUFYX1RFWFRV UkVfSU1BR0VfVU5JVFMsICZBTkdMRVJlc291cmNlcy5NYXhUZXh0dXJlSW1hZ2VVbml0cyk7CiAg ICAgZ2V0SW50ZWdlcnYoR3JhcGhpY3NDb250ZXh0M0Q6Ok1BWF9GUkFHTUVOVF9VTklGT1JNX1ZF Q1RPUlMsICZBTkdMRVJlc291cmNlcy5NYXhGcmFnbWVudFVuaWZvcm1WZWN0b3JzKTsKIAorICAg IEV4dGVuc2lvbnMzRCogZXh0ZW5zaW9ucyA9IGdldEV4dGVuc2lvbnMoKTsKICAgICBBTkdMRVJl c291cmNlcy5NYXhEcmF3QnVmZmVycyA9IDE7IC8vIEFsd2F5cyBzZXQgdG8gMSBmb3IgT3BlbkdM IEVTLgotICAgIEFOR0xFUmVzb3VyY2VzLk9FU19zdGFuZGFyZF9kZXJpdmF0aXZlcyA9IG1fZXh0 ZW5zaW9ucy0+c3VwcG9ydHMoIkdMX09FU19zdGFuZGFyZF9kZXJpdmF0aXZlcyIpOwotICAgIEFO R0xFUmVzb3VyY2VzLk9FU19FR0xfaW1hZ2VfZXh0ZXJuYWwgPSBtX2V4dGVuc2lvbnMtPnN1cHBv cnRzKCJHTF9FR0xfaW1hZ2VfZXh0ZXJuYWwiKTsKLSAgICBBTkdMRVJlc291cmNlcy5BUkJfdGV4 dHVyZV9yZWN0YW5nbGUgPSBtX2V4dGVuc2lvbnMtPnN1cHBvcnRzKCJHTF9BUkJfdGV4dHVyZV9y ZWN0YW5nbGUiKTsKKyAgICBBTkdMRVJlc291cmNlcy5PRVNfc3RhbmRhcmRfZGVyaXZhdGl2ZXMg PSBleHRlbnNpb25zLT5zdXBwb3J0cygiR0xfT0VTX3N0YW5kYXJkX2Rlcml2YXRpdmVzIik7Cisg ICAgQU5HTEVSZXNvdXJjZXMuT0VTX0VHTF9pbWFnZV9leHRlcm5hbCA9IGV4dGVuc2lvbnMtPnN1 cHBvcnRzKCJHTF9FR0xfaW1hZ2VfZXh0ZXJuYWwiKTsKKyAgICBBTkdMRVJlc291cmNlcy5BUkJf dGV4dHVyZV9yZWN0YW5nbGUgPSBleHRlbnNpb25zLT5zdXBwb3J0cygiR0xfQVJCX3RleHR1cmVf cmVjdGFuZ2xlIik7CiAKICAgICBHQzNEaW50IHJhbmdlWzJdLCBwcmVjaXNpb247CiAgICAgZ2V0 U2hhZGVyUHJlY2lzaW9uRm9ybWF0KEdyYXBoaWNzQ29udGV4dDNEOjpGUkFHTUVOVF9TSEFERVIs IEdyYXBoaWNzQ29udGV4dDNEOjpISUdIX0ZMT0FULCByYW5nZSwgJnByZWNpc2lvbik7Cg==