114717 2013-04-16 18:14:02 -0700 Web Inspector: make generate-inspector-protocol-version work with python3 2013-04-17 13:13:17 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 sergio webkit-unassigned commit-queue graouts joepeck timothy oldest_to_newest 876985 0 sergio 2013-04-16 18:14:02 -0700 Web Inspector: make generate-inspector-protocol-version work with python3 876986 1 198456 sergio 2013-04-16 18:15:28 -0700 Created attachment 198456 Patch Proposed patch 876994 2 198456 joepeck 2013-04-16 18:54:54 -0700 Comment on attachment 198456 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198456&action=review Looks good. Just get that typo in the ChangeLog fixed if possible! > Source/WebCore/ChangeLog:10 > + to the sys.stderr.write() ones already used througout the file. Typo: "througout" => "throughout" 876999 3 198459 sergio 2013-04-16 19:29:59 -0700 Created attachment 198459 Patch Typo fixed in changelog and commit message. 877429 4 198459 timothy 2013-04-17 12:34:25 -0700 Comment on attachment 198459 Patch I assume this works with older python versions still? 877432 5 sergio 2013-04-17 12:42:17 -0700 (In reply to comment #4) > (From update of attachment 198459 [details]) > I assume this works with older python versions still? Yup, it keeps working with python2 as expected, since that is what is officially supported. I had some odd setup in here when it crashed on me, and since I saw revision https://bugs.webkit.org/show_bug.cgi?id=106194, I thought to keep it working with python3, assuming someone uses it somehow. All in all, this patch merely makes the file more consistent, since we already have sys.stderr.write, and now sys.stdout.write too. 877433 6 198459 timothy 2013-04-17 12:43:25 -0700 Comment on attachment 198459 Patch Thanks! 877449 7 198459 commit-queue 2013-04-17 13:13:15 -0700 Comment on attachment 198459 Patch Clearing flags on attachment: 198459 Committed r148630: <http://trac.webkit.org/changeset/148630> 877450 8 commit-queue 2013-04-17 13:13:17 -0700 All reviewed patches have been landed. Closing bug. 198456 2013-04-16 18:15:28 -0700 2013-04-16 19:29:54 -0700 Patch bug-114717-20130416210950.patch text/plain 1926 sergio U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDk3N2NkYTA5NzBmNWIz NmQ1NDdjOGY2N2NiMWEyMmI4YTg4YzlkNS4uNzU0NmM4NjIwZWM4NTAyYzFiNWFkNmM3ZGExMjIy ZTlmZWE1NDRmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA0LTE2ICBTZXJn aW8gQ29ycmVpYSAgPHNlcmdpby5jb3JyZWlhQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgV2Vi IEluc3BlY3RvcjogbWFrZSBnZW5lcmF0ZS1pbnNwZWN0b3ItcHJvdG9jb2wtdmVyc2lvbiB3b3Jr IHdpdGggcHl0aG9uMyAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExNDcxNworCisgICAgICAgIFJldmlzaW9uIHIxNDY3NjUgYWRkZWQgcHJpbnQoKSBj YWxscyB0aGF0IG1hZGUgdGhlIHNjcmlwdCBjb21wbGFpbiBhYm91dCAKKyAgICAgICAgaW52YWxp ZCBzeW50YXggd2hlbiB1c2luZyBweXRob24zLgorCisgICAgICAgIFRoaXMgY29tbWl0IHJlcGxh Y2VzIHN1Y2ggY2FsbHMgd2l0aCBjYWxscyB0byBzeXMuc3Rkb3V0LndyaXRlKCksIGFuYWxvZ291 cworICAgICAgICB0byB0aGUgc3lzLnN0ZGVyci53cml0ZSgpIG9uZXMgYWxyZWFkeSB1c2VkIHRo cm91Z291dCB0aGUgZmlsZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBObyBuZXcgdGVzdHMuIE5vIHVzZXIgdmlzaWJsZSBiZWhhdmlvciBjaGFuZ2Vk LgorCisgICAgICAgICogaW5zcGVjdG9yL2dlbmVyYXRlLWluc3BlY3Rvci1wcm90b2NvbC12ZXJz aW9uOgorICAgICAgICAobWFpbik6CisKIDIwMTMtMDQtMTYgIEhhbnMgTXVsbGVyICA8aG11bGxl ckBhZG9iZS5jb20+CiAKICAgICAgICAgW0NTUyBFeGNsdXNpb25zXSBwb2x5Z29uIHNoYXBlLWlu c2lkZSBsYXlvdXQgZmFpbHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9n ZW5lcmF0ZS1pbnNwZWN0b3ItcHJvdG9jb2wtdmVyc2lvbiBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9nZW5lcmF0ZS1pbnNwZWN0b3ItcHJvdG9jb2wtdmVyc2lvbgppbmRleCAxMmY0Mjk4ODVk NGY5MThkZWIzZjNkY2Q4YmY4YTVmZDdjNjU1YTBhLi41NTUyYTFiYzdlMmU2MTIzMjRhNjI1NGNi ZmU2OWY5NTc5MGRjZjdjIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZ2Vu ZXJhdGUtaW5zcGVjdG9yLXByb3RvY29sLXZlcnNpb24KKysrIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2dlbmVyYXRlLWluc3BlY3Rvci1wcm90b2NvbC12ZXJzaW9uCkBAIC00MjcsOSArNDI3 LDkgQEAgZGVmIG1haW4oKToKICAgICAgICAgY2hhbmdlcyA9IGNvbXBhcmVfc2NoZW1hcygKICAg ICAgICAgICAgIGxvYWRfanNvbihpbnB1dF9wYXRoKVsiZG9tYWlucyJdLCBsb2FkX2pzb24oYmFz ZWxpbmVfcGF0aClbImRvbWFpbnMiXSwgVHJ1ZSkKICAgICAgICAgaWYgbGVuKGNoYW5nZXMpID4g MDoKLSAgICAgICAgICAgIHByaW50ICIgIFB1YmxpYyBjaGFuZ2VzIHNpbmNlICVzOiIgJSB2ZXJz aW9uCisgICAgICAgICAgICBzeXMuc3Rkb3V0LndyaXRlKCIgIFB1YmxpYyBjaGFuZ2VzIHNpbmNl ICVzOlxuIiAlIHZlcnNpb24pCiAgICAgICAgICAgICBmb3IgY2hhbmdlIGluIGNoYW5nZXM6Ci0g ICAgICAgICAgICAgICAgcHJpbnQgIiAgICAlcyIgJSBjaGFuZ2UKKyAgICAgICAgICAgICAgICBz eXMuc3Rkb3V0LndyaXRlKCIgICAgJXNcbiIgJSBjaGFuZ2UpCiAKICAgICBvdXRwdXRfZmlsZS53 cml0ZSgiIiIKICNpZm5kZWYgSW5zcGVjdG9yUHJvdG9jb2xWZXJzaW9uX2gK 198459 2013-04-16 19:29:59 -0700 2013-04-17 13:13:15 -0700 Patch bug-114717-20130416222422.patch text/plain 1927 sergio U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDk3N2NkYTA5NzBmNWIz NmQ1NDdjOGY2N2NiMWEyMmI4YTg4YzlkNS4uMjgyZGUzMThhZDg3NWNjNTFhOTQ0ODkzNDkwZDU4 MTkxODkyYTM2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA0LTE2ICBTZXJn aW8gQ29ycmVpYSAgPHNlcmdpby5jb3JyZWlhQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgV2Vi IEluc3BlY3RvcjogbWFrZSBnZW5lcmF0ZS1pbnNwZWN0b3ItcHJvdG9jb2wtdmVyc2lvbiB3b3Jr IHdpdGggcHl0aG9uMyAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExNDcxNworCisgICAgICAgIFJldmlzaW9uIHIxNDY3NjUgYWRkZWQgcHJpbnQoKSBj YWxscyB0aGF0IG1hZGUgdGhlIHNjcmlwdCBjb21wbGFpbiBhYm91dCAKKyAgICAgICAgaW52YWxp ZCBzeW50YXggd2hlbiB1c2luZyBweXRob24zLgorCisgICAgICAgIFRoaXMgY29tbWl0IHJlcGxh Y2VzIHN1Y2ggY2FsbHMgd2l0aCBjYWxscyB0byBzeXMuc3Rkb3V0LndyaXRlKCksIGFuYWxvZ291 cworICAgICAgICB0byB0aGUgc3lzLnN0ZGVyci53cml0ZSgpIG9uZXMgYWxyZWFkeSB1c2VkIHRo cm91Z2hvdXQgdGhlIGZpbGUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyB1c2VyIHZpc2libGUgYmVoYXZpb3IgY2hhbmdl ZC4KKworICAgICAgICAqIGluc3BlY3Rvci9nZW5lcmF0ZS1pbnNwZWN0b3ItcHJvdG9jb2wtdmVy c2lvbjoKKyAgICAgICAgKG1haW4pOgorCiAyMDEzLTA0LTE2ICBIYW5zIE11bGxlciAgPGhtdWxs ZXJAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1MgRXhjbHVzaW9uc10gcG9seWdvbiBzaGFwZS1p bnNpZGUgbGF5b3V0IGZhaWxzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv Z2VuZXJhdGUtaW5zcGVjdG9yLXByb3RvY29sLXZlcnNpb24gYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZ2VuZXJhdGUtaW5zcGVjdG9yLXByb3RvY29sLXZlcnNpb24KaW5kZXggMTJmNDI5ODg1 ZDRmOTE4ZGViM2YzZGNkOGJmOGE1ZmQ3YzY1NWEwYS4uNTU1MmExYmM3ZTJlNjEyMzI0YTYyNTRj YmZlNjlmOTU3OTBkY2Y3YyAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2dl bmVyYXRlLWluc3BlY3Rvci1wcm90b2NvbC12ZXJzaW9uCisrKyBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9nZW5lcmF0ZS1pbnNwZWN0b3ItcHJvdG9jb2wtdmVyc2lvbgpAQCAtNDI3LDkgKzQy Nyw5IEBAIGRlZiBtYWluKCk6CiAgICAgICAgIGNoYW5nZXMgPSBjb21wYXJlX3NjaGVtYXMoCiAg ICAgICAgICAgICBsb2FkX2pzb24oaW5wdXRfcGF0aClbImRvbWFpbnMiXSwgbG9hZF9qc29uKGJh c2VsaW5lX3BhdGgpWyJkb21haW5zIl0sIFRydWUpCiAgICAgICAgIGlmIGxlbihjaGFuZ2VzKSA+ IDA6Ci0gICAgICAgICAgICBwcmludCAiICBQdWJsaWMgY2hhbmdlcyBzaW5jZSAlczoiICUgdmVy c2lvbgorICAgICAgICAgICAgc3lzLnN0ZG91dC53cml0ZSgiICBQdWJsaWMgY2hhbmdlcyBzaW5j ZSAlczpcbiIgJSB2ZXJzaW9uKQogICAgICAgICAgICAgZm9yIGNoYW5nZSBpbiBjaGFuZ2VzOgot ICAgICAgICAgICAgICAgIHByaW50ICIgICAgJXMiICUgY2hhbmdlCisgICAgICAgICAgICAgICAg c3lzLnN0ZG91dC53cml0ZSgiICAgICVzXG4iICUgY2hhbmdlKQogCiAgICAgb3V0cHV0X2ZpbGUu d3JpdGUoIiIiCiAjaWZuZGVmIEluc3BlY3RvclByb3RvY29sVmVyc2lvbl9oCg==