114716 2013-04-16 17:39:14 -0700 Harden FastMalloc against partial pointer overflows 2013-04-16 18:11:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver benjamin cmarcelo commit-queue oldest_to_newest 876970 0 oliver 2013-04-16 17:39:14 -0700 Harden FastMalloc against partial pointer overflows 876972 1 198455 oliver 2013-04-16 17:42:53 -0700 Created attachment 198455 Patch 876974 2 commit-queue 2013-04-16 17:43:56 -0700 Attachment 198455 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/FastMalloc.cpp']" exit_code: 1 Source/WTF/wtf/FastMalloc.cpp:3993: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3994: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3995: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3997: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:4010: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 5 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 876976 3 198455 barraclough 2013-04-16 17:46:36 -0700 Comment on attachment 198455 Patch preemptive RS=me for a patch the renames the random characters to proper variable names. 876982 4 oliver 2013-04-16 18:11:42 -0700 Committed r148587: <http://trac.webkit.org/changeset/148587> 198455 2013-04-16 17:42:53 -0700 2013-04-16 17:46:36 -0700 Patch bug-114716-20130416174226.patch text/plain 2933 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDk5YWIzNTU4ZDliZjNmMTA0ZWMxOGM2 YTViN2U5NTdhMjQxMGFkMGMuLjE2NTYwMzE0NjI0MTY2OWRhYWU0YWI0ODU3YjQxYmJkZjhiYzAz NjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTMtMDQtMTYgIE9saXZlciBIdW50ICA8b2xpdmVy QGFwcGxlLmNvbT4KKworICAgICAgICBIYXJkZW4gRmFzdE1hbGxvYyBhZ2FpbnN0IHBhcnRpYWwg cG9pbnRlciBvdmVyZmxvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExNDcxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEJpdGUgdGhlIGJ1bGxldCBhbmQgcGVyZm9ybSBvYmplY3QgYWxpZ25tZW50IGNo ZWNrcyBvbiBmcmVlLgorICAgICAgICBtYWxsb2MvZnJlZSBtaWNybyBiZW5jaG1hcmsgc2hvd3Mg YSByZWdyZXNzaW9uLCBidXQgcmVhbAorICAgICAgICBiZW5jaG1hcmtzIGRvbid0LiAgVGhlcmUn cyBhIGxpdHRsZSBjb2RlIG1vdGlvbiBpbiB0aGlzIGF2b2lkCisgICAgICAgIHRha2luZyB0b28g bXVjaCBvZiBhIHBlcmZvcm1hbmNlIGhpdC4gIEluIGFkZGl0aW9uIHRvIHRoZQorICAgICAgICBh bGlnbm1lbnQgY2hlY2sgd2UgYWxzbyB2YWxpZGF0ZSB0aGUgY29udGFpbmluZyBzcGFuIGFzCisg ICAgICAgIHdlJ3ZlIGFscmVhZHkgdGFrZW4gdGhlIGhpdCBvZiBmaW5kaW5nIGl0LgorCisgICAg ICAgICogd3RmL0Zhc3RNYWxsb2MuY3BwOgorICAgICAgICAoV1RGOjpUQ01hbGxvY19UaHJlYWRD YWNoZTo6Q3JlYXRlQ2FjaGVJZk5lY2Vzc2FyeSk6CisKIDIwMTMtMDQtMTYgIFNhbSBXZWluaWcg IDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBGaXggZmFsbG91dCBhZnRlciByMTQ4NTQ1Lgpk aWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvRmFzdE1hbGxvYy5jcHAgYi9Tb3VyY2UvV1RGL3d0 Zi9GYXN0TWFsbG9jLmNwcAppbmRleCA0NTdmNTkxZTcxNmEwODA0OTIwMzdhMGQ1YWJlYWIyNGVj NGU1MzJmLi5jYTg2ZjA3MDUyZWZiM2E5NDVkZDlmOWE4YTk2ZDAwN2RhOTI2ODdkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV1RGL3d0Zi9GYXN0TWFsbG9jLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9G YXN0TWFsbG9jLmNwcApAQCAtMzk5MCwxNiArMzk5MCwxNSBAQCBzdGF0aWMgQUxXQVlTX0lOTElO RSB2b2lkIGRvX2ZyZWUodm9pZCogcHRyKSB7CiAgIGlmIChwdHIgPT0gTlVMTCkgcmV0dXJuOwog ICBBU1NFUlQocGFnZWhlYXAgIT0gTlVMTCk7ICAvLyBTaG91bGQgbm90IGNhbGwgZnJlZSgpIGJl Zm9yZSBtYWxsb2MoKQogICBjb25zdCBQYWdlSUQgcCA9IHJlaW50ZXJwcmV0X2Nhc3Q8dWludHB0 cl90PihwdHIpID4+IGtQYWdlU2hpZnQ7Ci0gIFNwYW4qIHNwYW4gPSBOVUxMOwotICBzaXplX3Qg Y2wgPSBwYWdlaGVhcC0+R2V0U2l6ZUNsYXNzSWZDYWNoZWQocCk7CisgIFNwYW4qIHNwYW4gPSBw YWdlaGVhcC0+R2V0RGVzY3JpcHRvcihwKTsKKyAgUkVMRUFTRV9BU1NFUlQoc3Bhbi0+aXNWYWxp ZCgpKTsKKyAgc2l6ZV90IGNsID0gc3Bhbi0+c2l6ZWNsYXNzOwogCi0gIGlmIChjbCA9PSAwKSB7 Ci0gICAgc3BhbiA9IHBhZ2VoZWFwLT5HZXREZXNjcmlwdG9yKHApOwotICAgIFJFTEVBU0VfQVNT RVJUKHNwYW4tPmlzVmFsaWQoKSk7Ci0gICAgY2wgPSBzcGFuLT5zaXplY2xhc3M7CisgIGlmIChj bCkgeworICAgIHNpemVfdCBieXRlU2l6ZUZvckNsYXNzID0gQnl0ZVNpemVGb3JDbGFzcyhjbCk7 CisgICAgUkVMRUFTRV9BU1NFUlQoISgocmVpbnRlcnByZXRfY2FzdDxjaGFyKj4ocHRyKSAtIHJl aW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KHNwYW4tPnN0YXJ0IDw8IGtQYWdlU2hpZnQpKSAlIGJ5dGVT aXplRm9yQ2xhc3MpKTsKICAgICBwYWdlaGVhcC0+Q2FjaGVTaXplQ2xhc3MocCwgY2wpOwotICB9 Ci0gIGlmIChjbCAhPSAwKSB7CisKICNpZm5kZWYgTk9fVENNQUxMT0NfU0FNUExFUwogICAgIEFT U0VSVCghcGFnZWhlYXAtPkdldERlc2NyaXB0b3IocCktPnNhbXBsZSk7CiAjZW5kaWYKQEAgLTQw MDgsNyArNDAwNyw3IEBAIHN0YXRpYyBBTFdBWVNfSU5MSU5FIHZvaWQgZG9fZnJlZSh2b2lkKiBw dHIpIHsKICAgICAgIGhlYXAtPkRlYWxsb2NhdGUoSGFyZGVuZWRTTEw6OmNyZWF0ZShwdHIpLCBj bCk7CiAgICAgfSBlbHNlIHsKICAgICAgIC8vIERlbGV0ZSBkaXJlY3RseSBpbnRvIGNlbnRyYWwg Y2FjaGUKLSAgICAgIFBPSVNPTl9ERUFMTE9DQVRJT04ocHRyLCBCeXRlU2l6ZUZvckNsYXNzKGNs KSk7CisgICAgICBQT0lTT05fREVBTExPQ0FUSU9OKHB0ciwgYnl0ZVNpemVGb3JDbGFzcyk7CiAg ICAgICBTTExfU2V0TmV4dChIYXJkZW5lZFNMTDo6Y3JlYXRlKHB0ciksIEhhcmRlbmVkU0xMOjpu dWxsKCksIGNlbnRyYWxfY2FjaGVbY2xdLmVudHJvcHkoKSk7CiAgICAgICBjZW50cmFsX2NhY2hl W2NsXS5JbnNlcnRSYW5nZShIYXJkZW5lZFNMTDo6Y3JlYXRlKHB0ciksIEhhcmRlbmVkU0xMOjpj cmVhdGUocHRyKSwgMSk7CiAgICAgfQpAQCAtNDAyMyw3ICs0MDIyLDcgQEAgc3RhdGljIEFMV0FZ U19JTkxJTkUgdm9pZCBkb19mcmVlKHZvaWQqIHB0cikgewogICAgICAgc3Bhbi0+b2JqZWN0cyA9 IE5VTEw7CiAgICAgfQogI2VuZGlmCi0KKyAgICBSRUxFQVNFX0FTU0VSVChyZWludGVycHJldF9j YXN0PHZvaWQqPihzcGFuLT5zdGFydCA8PCBrUGFnZVNoaWZ0KSA9PSBwdHIpOwogICAgIFBPSVNP Tl9ERUFMTE9DQVRJT04ocHRyLCBzcGFuLT5sZW5ndGggPDwga1BhZ2VTaGlmdCk7CiAgICAgcGFn ZWhlYXAtPkRlbGV0ZShzcGFuKTsKICAgfQo=