114710 2013-04-16 15:43:55 -0700 [GTK] JSCore.gir.in has a few problems 2013-04-22 08:45:34 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson cgarcia commit-queue gustavo zan oldest_to_newest 876917 0 mrobinson 2013-04-16 15:43:55 -0700 There are a few issues with the JSCore.gir.in. It's essentially a stub file that enables introspection of APIs, but is mostly incomplete. JavaScriptCore isn't a GObject API, which suggests that using it will lead to memory errors. Instead it should likely be a "foreign" library defined like https://git.gnome.org/browse/gobject-introspection/tree/gir/cairo-1.0.gir.in. It references the libwebkitgtk library when it should really be referencing libjavascriptcoregtk. 878563 1 198897 mrobinson 2013-04-19 10:37:15 -0700 Created attachment 198897 Patch 878571 2 198897 mrobinson 2013-04-19 10:54:46 -0700 Comment on attachment 198897 Patch Clearing flags on attachment: 198897 Committed r148755: <http://trac.webkit.org/changeset/148755> 878572 3 mrobinson 2013-04-19 10:54:49 -0700 All reviewed patches have been landed. Closing bug. 878733 4 198897 cgarcia 2013-04-20 00:52:19 -0700 Comment on attachment 198897 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198897&action=review Nice cleanup! > Source/JavaScriptCore/GNUmakefile.am:211 > +CLEANFILES += JavaScriptCore-@WEBKITGTK_API_VERSION@.gir JavaScriptCore-@WEBKITGTK_API_VERSION@.typelib Now that gir_DATA and typelibs_DATA are common and global, I wonder if we could simply add CLEANFILES += $(gir_DATA) $(typelibs_DATA) to the main makefile and we don't need to do it for every GIR. > Source/WebKit/gtk/GNUmakefile.am:-356 > -EXTRA_DIST += $(top_builddir)/Source/WebKit/gtk/JSCore-@WEBKITGTK_API_VERSION@.gir > - This is no longer needed? Have you checked this patch doesn't break distcheck? 879179 5 mrobinson 2013-04-22 08:45:34 -0700 (In reply to comment #4) > (From update of attachment 198897 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=198897&action=review > > Nice cleanup! > > > Source/JavaScriptCore/GNUmakefile.am:211 > > +CLEANFILES += JavaScriptCore-@WEBKITGTK_API_VERSION@.gir JavaScriptCore-@WEBKITGTK_API_VERSION@.typelib > > Now that gir_DATA and typelibs_DATA are common and global, I wonder if we could simply add CLEANFILES += $(gir_DATA) $(typelibs_DATA) to the main makefile and we don't need to do it for every GIR. I wonder if we'll need to split the introspection bits of the main makefile up for that -- one before the includes and one after. > > Source/WebKit/gtk/GNUmakefile.am:-356 > > -EXTRA_DIST += $(top_builddir)/Source/WebKit/gtk/JSCore-@WEBKITGTK_API_VERSION@.gir > > - > > This is no longer needed? Have you checked this patch doesn't break distcheck? 'make dist' is broken at the moment, but I double-checked that Source/JavaScriptCore/JavaScriptCore.gir.in was in DIST_COMMON in the makefile. If AC_CONFIG_FILE doesn't automatically dist the source files, we'd need to put the other files used in AC_CONFIG_FILES in EXTRA_DIST as well. 198897 2013-04-19 10:37:15 -0700 2013-04-20 00:52:19 -0700 Patch bug-114710-20130419103644.patch text/plain 13267 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy ZDYwODE4MDRiMmQwYmVlZGI5ZDQwZTdlZDA1YWY2MzVlNGI5ZWI2Li5iM2MxYjE1YzBiMjUxYmZj Njk4NDdjMDNhNWM0Y2YxNGNmYTcyODllIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMy0wNC0xOSAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxp YS5jb20+CisKKyAgICAgICAgW0dUS10gSlNDb3JlLmdpci5pbiBoYXMgYSBmZXcgcHJvYmxlbXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDcxMAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogR05VbWFr ZWZpbGUuYW06IEFkZCB0aGUgZ29iamVjdCBpbnRyb3NwZWN0aW9uIHN0ZXBzIGZvciBKYXZhU2Ny aXB0Q29yZSBoZXJlLAorICAgICAgICBiZWNhdXNlIHRoZXkgYXJlIHNoYXJlZCBiZXR3ZWVuIFdl YktpdDEgYW5kIFdlYktpdDIuCisgICAgICAgICogSmF2YVNjcmlwdENvcmUuZ2lyLmluOiBBZGRl ZC4gTW92ZWQgZnJvbSB0aGUgV2ViS2l0MSBkaXJlY3RvcnkuIE5vdyB3cml0dGVuCisgICAgICAg IGFzIGZvcmVpZ24gaW50ZXJmYWNlcyBhbmQgcmVmZXJlbmNpbmcgdGhlIGphdmFzY3JpcHRjb3Jl Z3RrIGxpYnJhcnkuCisKIDIwMTMtMDQtMTUgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5v cmc+CiAKICAgICAgICAgV2luZG93cyBjbGVhbiBidWlsZCBmaXggYWZ0ZXIgcjE0ODQ3OS4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3Rr L0NoYW5nZUxvZwppbmRleCAyODlkNTEzZWNmZjE4Y2E0MzQyZDJlMzcxNjliMDJlZTI2MmEyMmM0 Li44OTE3ZmEwZmZhZjFkZTNkYTM0ODM5MzNhNzQ0ZmZiNmIyMzAzMWJkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMDQtMTkgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2Jp bnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEpTQ29yZS5naXIuaW4gaGFzIGEgZmV3 IHByb2JsZW1zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTQ3MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIEdOVW1ha2VmaWxlLmFtOiBVcGRhdGVkIHRvIHJlZmxlY3QgbmV3IG5hbWUgYW5kIGxvY2F0 aW9uIG9mIEphdmFTY3JpcHRDb3JlLXguMC5naXIuCisgICAgICAgICogSlNDb3JlLmdpci5pbjog UmVtb3ZlZC4KKwogMjAxMy0wNC0xNCAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+ CiAKICAgICAgICAgTW92ZSBDU1NPTSBjbGFzc2VzIHRvIHVzaW5nIE11dGFibGVTdHlsZVByb3Bl cnR5U2V0IG92ZXIgU3R5bGVQcm9wZXJ0eVNldC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA3MjU0MTA0NDcwNDNk NjMxYTQwZjhiMjFmZmNmYTY5MjBhZDk4MjNmLi5mNTkyZjI5ZmNhZjI0NGU4YTFjODUzZjlkNTFh NWI0YzkzOTdjNWJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMDQtMTkgIE1h cnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEpT Q29yZS5naXIuaW4gaGFzIGEgZmV3IHByb2JsZW1zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ3MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIEdOVW1ha2VmaWxlLmFtOiBVcGRhdGVkIHRvIHJlZmxl Y3QgbmV3IGxvY2F0aW9uIG9mIEphdmFTY3JpcHRDb3JlIGdpciBmaWxlLiBTaGFyZSB0aGUKKyAg ICAgICAgc2FtZSBhdXRvdG9vbHMgZGF0YSB0YXNrIGFzIHRoZSBXZWJLaXQxIGFuZCBKYXZhU2Ny aXB0Q29yZSBnaXIgaW5zdGFsbGF0aW9ucy4KKwogMjAxMy0wNC0xNiAgTWljaGHFgiBQYWt1xYJh IHZlbCBSdXRrYSAgPG0ucGFrdWxhQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdW1dLMl0g QWRkIGFuIEFQSSBmb3IgZ2V0dGluZyBjb250ZXh0IG1lbnUgaXRlbSdzIHBhcmVudCBtZW51CmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvR05VbWFrZWZpbGUuYW0gYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvR05VbWFrZWZpbGUuYW0KaW5kZXggOTZhMjNmMjg4NTIxY2Q3MmVhNGEz MGVmMjA4OTVmYzc2MjE2ZjU5NS4uMWM2OGI3NjIxMDQzYjc5NGZjMzNjYjU0YzlhNTgxMDVlZGY5 NWJlMSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0dOVW1ha2VmaWxlLmFtCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9HTlVtYWtlZmlsZS5hbQpAQCAtMjAwLDMgKzIwMCwx MyBAQCBDTEVBTkZJTEVTICs9IFwKIAogRElTVENMRUFORklMRVMgKz0gXAogCSQodG9wX2J1aWxk ZGlyKS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvamF2YXNjcmlwdGNvcmVndGstQFdFQktJVEdUS19B UElfVkVSU0lPTkAucGMKKworaWYgRU5BQkxFX0lOVFJPU1BFQ1RJT04KKyMgVGhlIEdJUiBmaWxl IGlzIGdlbmVyYXRlZCB2aWEgYXV0b2NvbmYsIGFzIHdlIGRvbid0IG5lZWQgdG8gcnVuIHRoZSBz Y2FubmVyIGFnYWluc3Qgbm9uLUdPYmplY3QgbGlicmFyaWVzLgorSmF2YVNjcmlwdENvcmUtQFdF QktJVEdUS19BUElfVkVSU0lPTkAudHlwZWxpYjogSmF2YVNjcmlwdENvcmUtQFdFQktJVEdUS19B UElfVkVSU0lPTkAuZ2lyICQoR19JUl9DT01QSUxFUikKKwkkKEFNX1ZfR0VOKSQoR19JUl9DT01Q SUxFUikgLS1pbmNsdWRlZGlyICQoV2ViS2l0KSAtLWluY2x1ZGVkaXIgJCh0b3BfYnVpbGRkaXIp ICQ8IC1vICRACisKK2dpcl9EQVRBICs9IEphdmFTY3JpcHRDb3JlLUBXRUJLSVRHVEtfQVBJX1ZF UlNJT05ALmdpcgordHlwZWxpYnNfREFUQSArPSBKYXZhU2NyaXB0Q29yZS1AV0VCS0lUR1RLX0FQ SV9WRVJTSU9OQC50eXBlbGliCitDTEVBTkZJTEVTICs9IEphdmFTY3JpcHRDb3JlLUBXRUJLSVRH VEtfQVBJX1ZFUlNJT05ALmdpciBKYXZhU2NyaXB0Q29yZS1AV0VCS0lUR1RLX0FQSV9WRVJTSU9O QC50eXBlbGliCitlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFT Y3JpcHRDb3JlLmdpci5pbiBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5n aXIuaW4KbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uNmY4ZGNjMTI4ZGNlMjljOTllNDY0YThjY2ZlYzAyNjUzMzM5ZTg4 OAotLS0gL2Rldi9udWxsCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29y ZS5naXIuaW4KQEAgLTAsMCArMSwxMiBAQAorPD94bWwgdmVyc2lvbj0iMS4wIj8+Cis8cmVwb3Np dG9yeSB2ZXJzaW9uPSIxLjIiCisgICAgICAgICAgICB4bWxucz0iaHR0cDovL3d3dy5ndGsub3Jn L2ludHJvc3BlY3Rpb24vY29yZS8xLjAiCisgICAgICAgICAgICB4bWxuczpjPSJodHRwOi8vd3d3 Lmd0ay5vcmcvaW50cm9zcGVjdGlvbi9jLzEuMCI+CisgIDxuYW1lc3BhY2UgbmFtZT0iSmF2YVNj cmlwdENvcmUiIHZlcnNpb249IkBXRUJLSVRHVEtfQVBJX1ZFUlNJT05AIiAKKyAgICAgICAgICAg ICBzaGFyZWQtbGlicmFyeT0iamF2YXNjcmlwdGNvcmVndGstQFdFQktJVEdUS19BUElfVkVSU0lP TkAiCisgICAgICAgICAgICAgYzppZGVudGlmaWVyLXByZWZpeGVzPSJKUyIKKyAgICAgICAgICAg ICBjOnN5bWJvbC1wcmVmaXhlcz0iSlMiPgorICAgIDxyZWNvcmQgbmFtZT0iR2xvYmFsQ29udGV4 dCIgYzp0eXBlPSJKU0dsb2JhbENvbnRleHRSZWYiIGZvcmVpZ249IjEiLz4KKyAgICA8cmVjb3Jk IG5hbWU9IlZhbHVlIiBjOnR5cGU9IkpTVmFsdWVSZWYiIGZvcmVpZ249IjEiLz4KKyAgPC9uYW1l c3BhY2U+Cis8L3JlcG9zaXRvcnk+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9HTlVt YWtlZmlsZS5hbSBiL1NvdXJjZS9XZWJLaXQvZ3RrL0dOVW1ha2VmaWxlLmFtCmluZGV4IGI2NDIy OTRkOWQyMjgxNzEwN2Y4ZTgyYjE3ZjFiYWFlNTIzMTU2MGMuLmUwY2ZmZmU2ZTIyZjRjYTI1NTRj ZTA4N2JhNDVhMThiNWIwMDJlNTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL0dOVW1h a2VmaWxlLmFtCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0dOVW1ha2VmaWxlLmFtCkBAIC0yOTMs MTQgKzI5Myw3IEBAIGlmIEVOQUJMRV9XRUJLSVQxCiBwa2djb25maWdfREFUQSArPSBTb3VyY2Uv V2ViS2l0L2d0ay9AV0VCS0lUR1RLX1BDX05BTUVALUBXRUJLSVRHVEtfQVBJX1ZFUlNJT05ALnBj CiAKIGlmIEVOQUJMRV9JTlRST1NQRUNUSU9OCi0KLUpTQ29yZS1AV0VCS0lUR1RLX0FQSV9WRVJT SU9OQC5naXI6ICQodG9wX2J1aWxkZGlyKS9Tb3VyY2UvV2ViS2l0L2d0ay9KU0NvcmUtQFdFQktJ VEdUS19BUElfVkVSU0lPTkAuZ2lyCi0JJChBTV9WX0dFTiljcCAkKHRvcF9idWlsZGRpcikvU291 cmNlL1dlYktpdC9ndGsvSlNDb3JlLUBXRUJLSVRHVEtfQVBJX1ZFUlNJT05ALmdpciAkKHRvcF9i dWlsZGRpcikvCi0KLUpTQ09SRV9HSVJTT1VSQ0VTICs9IEpTQ29yZS1AV0VCS0lUR1RLX0FQSV9W RVJTSU9OQC5naXIKLVdFQktJVF9HSVJTT1VSQ0VTICs9IFdlYktpdC1AV0VCS0lUR1RLX0FQSV9W RVJTSU9OQC5naXIKLQotJChXRUJLSVRfR0lSU09VUkNFUyk6ICQoR19JUl9TQ0FOTkVSKSAkKEpT Q09SRV9HSVJTT1VSQ0VTKSBsaWJ3ZWJraXRndGstQFdFQktJVEdUS19BUElfTUFKT1JfVkVSU0lP TkAuQFdFQktJVEdUS19BUElfTUlOT1JfVkVSU0lPTkAubGEKK1dlYktpdC1AV0VCS0lUR1RLX0FQ SV9WRVJTSU9OQC5naXI6ICQoR19JUl9TQ0FOTkVSKSBKYXZhU2NyaXB0Q29yZS1AV0VCS0lUR1RL X0FQSV9WRVJTSU9OQC5naXIgbGlid2Via2l0Z3RrLUBXRUJLSVRHVEtfQVBJX01BSk9SX1ZFUlNJ T05ALkBXRUJLSVRHVEtfQVBJX01JTk9SX1ZFUlNJT05ALmxhCiAJJChBTV9WX0dFTikkKEdfSVJf U0NBTk5FUikgLXYgLS13YXJuLWFsbCBcCiAJICAgICAtLXN5bWJvbC1wcmVmaXg9d2Via2l0IFwK IAkgICAgIC0taWRlbnRpZmllci1wcmVmaXg9V2ViS2l0IFwKQEAgLTMwOCw3ICszMDEsNyBAQCAk KFdFQktJVF9HSVJTT1VSQ0VTKTogJChHX0lSX1NDQU5ORVIpICQoSlNDT1JFX0dJUlNPVVJDRVMp IGxpYndlYmtpdGd0ay1AV0VCS0lURwogCSAgICAgLS1uc3ZlcnNpb249QFdFQktJVEdUS19BUElf VkVSU0lPTkAgXAogCSAgICAgLS1pbmNsdWRlPUdPYmplY3QtMi4wIFwKIAkgICAgIC0taW5jbHVk ZT1HdGstQEdUS19BUElfVkVSU0lPTkAgXAotCSAgICAgLS1pbmNsdWRlPUpTQ29yZS1AV0VCS0lU R1RLX0FQSV9WRVJTSU9OQCBcCisJICAgICAtLWluY2x1ZGU9SmF2YVNjcmlwdENvcmUtQFdFQktJ VEdUS19BUElfVkVSU0lPTkAgXAogCSAgICAgLS1pbmNsdWRlPVNvdXAtMi40IFwKIAkgICAgIC0t bGlicmFyeT13ZWJraXRndGstQFdFQktJVEdUS19BUElfVkVSU0lPTkAgXAogCSAgICAgLS1saWJy YXJ5PWphdmFzY3JpcHRjb3JlZ3RrLUBXRUJLSVRHVEtfQVBJX1ZFUlNJT05AIFwKQEAgLTMzNSwy NSArMzI4LDE1IEBAICQoV0VCS0lUX0dJUlNPVVJDRVMpOiAkKEdfSVJfU0NBTk5FUikgJChKU0NP UkVfR0lSU09VUkNFUykgbGlid2Via2l0Z3RrLUBXRUJLSVRHCiAJICAgICAkKHdlYmtpdGd0a19n ZG9tX2J1aWx0X2hfYXBpKSBcCiAJICAgICAkKFdlYktpdCkvd2Via2l0LyouY3BwCiAKLWdpcmRp ciA9ICQoZGF0YWRpcikvZ2lyLTEuMAotZ2lyX0RBVEEgPSAkKFdFQktJVF9HSVJTT1VSQ0VTKSAk KEpTQ09SRV9HSVJTT1VSQ0VTKQotCi10eXBlbGlic2RpciArPSAkKGxpYmRpcikvZ2lyZXBvc2l0 b3J5LTEuMAotdHlwZWxpYnNfREFUQSArPSAkKEpTQ09SRV9HSVJTT1VSQ0VTOi5naXI9LnR5cGVs aWIpICQoV0VCS0lUX0dJUlNPVVJDRVM6Lmdpcj0udHlwZWxpYikKLQogV2ViS2l0LUBXRUJLSVRH VEtfQVBJX1ZFUlNJT05ALnR5cGVsaWI6IFdlYktpdC1AV0VCS0lUR1RLX0FQSV9WRVJTSU9OQC5n aXIgJChHX0lSX0NPTVBJTEVSKQogCSQoQU1fVl9HRU4pJChHX0lSX0NPTVBJTEVSKSAtLWluY2x1 ZGVkaXIgJChXZWJLaXQpIC0taW5jbHVkZWRpciAkKHRvcF9idWlsZGRpcikgJDwgLW8gJEAKIAot SlNDb3JlLUBXRUJLSVRHVEtfQVBJX1ZFUlNJT05ALnR5cGVsaWI6IEpTQ29yZS1AV0VCS0lUR1RL X0FQSV9WRVJTSU9OQC5naXIgJChHX0lSX0NPTVBJTEVSKQotCSQoQU1fVl9HRU4pJChHX0lSX0NP TVBJTEVSKSAtLWluY2x1ZGVkaXIgJChXZWJLaXQpIC0taW5jbHVkZWRpciAkKHRvcF9idWlsZGRp cikgJDwgLW8gJEAKLQotQ0xFQU5GSUxFUyArPSAkKEpTQ09SRV9HSVJTT1VSQ0VTKSAkKFdFQktJ VF9HSVJTT1VSQ0VTKSAkKHR5cGVsaWJzX0RBVEEpCi0KK2dpcl9EQVRBICs9IFdlYktpdC1AV0VC S0lUR1RLX0FQSV9WRVJTSU9OQC5naXIKK3R5cGVsaWJzX0RBVEEgKz0gV2ViS2l0LUBXRUJLSVRH VEtfQVBJX1ZFUlNJT05ALnR5cGVsaWIKK0NMRUFORklMRVMgKz0gV2ViS2l0LUBXRUJLSVRHVEtf QVBJX1ZFUlNJT05ALmdpciBXZWJLaXQtQFdFQktJVEdUS19BUElfVkVSU0lPTkAudHlwZWxpYgog ZW5kaWYKIGVuZGlmCiAKLUVYVFJBX0RJU1QgKz0gJCh0b3BfYnVpbGRkaXIpL1NvdXJjZS9XZWJL aXQvZ3RrL0pTQ29yZS1AV0VCS0lUR1RLX0FQSV9WRVJTSU9OQC5naXIKLQogV0VCS0lUX01BUlNI QUxfTElTVCA9ICQoV2ViS2l0KS93ZWJraXRtYXJzaGFsLmxpc3QKICQoR0VOU09VUkNFU19XRUJL SVQpL3dlYmtpdG1hcnNoYWwuY3BwOiBzdGFtcC13ZWJraXRtYXJzaGFsLmNwcAogCUB0cnVlCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9KU0NvcmUuZ2lyLmluIGIvU291cmNlL1dlYktp dC9ndGsvSlNDb3JlLmdpci5pbgpkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggZTE0Mzk4 MjcwY2NlYThkMjJlMzY0Yjc3NzFiYjZlNDAzNTJiM2FkYy4uMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9KU0NvcmUuZ2lyLmlu CisrKyAvZGV2L251bGwKQEAgLTEsMjAgKzAsMCBAQAotPD94bWwgdmVyc2lvbj0iMS4wIj8+Ci08 cmVwb3NpdG9yeSB2ZXJzaW9uPSIxLjIiCi0gICAgICAgICAgICB4bWxucz0iaHR0cDovL3d3dy5n dGsub3JnL2ludHJvc3BlY3Rpb24vY29yZS8xLjAiCi0gICAgICAgICAgICB4bWxuczpjPSJodHRw Oi8vd3d3Lmd0ay5vcmcvaW50cm9zcGVjdGlvbi9jLzEuMCI+Ci0gIDxuYW1lc3BhY2UgbmFtZT0i SlNDb3JlIiB2ZXJzaW9uPSJAV0VCS0lUR1RLX0FQSV9WRVJTSU9OQCIgc2hhcmVkLWxpYnJhcnk9 IndlYmtpdGd0ay1AV0VCS0lUR1RLX0FQSV9WRVJTSU9OQCI+Ci0gICAgPGFsaWFzIG5hbWU9Ikds b2JhbENvbnRleHRSZWYiIHRhcmdldD0ibm9uZSI+Ci0gICAgICA8dHlwZSBuYW1lPSJKU0dsb2Jh bENvbnRleHRSZWYiIGM6dHlwZT0iSlNHbG9iYWxDb250ZXh0UmVmIi8+Ci0gICAgPC9hbGlhcz4K LSAgICA8YWxpYXMgbmFtZT0iT2JqZWN0UmVmIiB0YXJnZXQ9Im5vbmUiPgotICAgICAgPHR5cGUg bmFtZT0iSlNPYmplY3RSZWYiIGM6dHlwZT0iSlNPYmplY3RSZWYiLz4KLSAgICA8L2FsaWFzPgot ICAgIDxmdW5jdGlvbiBuYW1lPSJFdmFsdWF0ZVNjcmlwdCIgYzppZGVudGlmaWVyPSJKU0V2YWx1 YXRlU2NyaXB0Ij4KLSAgICAgIDxyZXR1cm4tdmFsdWUgdHJhbnNmZXItb3duZXJzaGlwPSJub25l Ij4KLSAgICAgICAgPHR5cGUgbmFtZT0ibm9uZSIgYzp0eXBlPSJ2b2lkIi8+Ci0gICAgICA8L3Jl dHVybi12YWx1ZT4KLSAgICAgIDxwYXJhbWV0ZXJzPgotICAgICAgPC9wYXJhbWV0ZXJzPgotICAg IDwvZnVuY3Rpb24+Ci0gIDwvbmFtZXNwYWNlPgotPC9yZXBvc2l0b3J5PgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvR05VbWFrZWZpbGUuYW0gYi9Tb3VyY2UvV2ViS2l0Mi9HTlVtYWtlZmls ZS5hbQppbmRleCA2ZmE2ZjliOTgzYTUzZjBhMWRlODc3ODg1NGRlMDVjNjkxZDU5NTFlLi5jMzUx ODI3NmRkMmI4NDc3NTk5ODk5MDc0ZTk3ZGE4Mzk2NTAwZWYyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9HTlVtYWtlZmlsZS5hbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9HTlVtYWtlZmlsZS5h bQpAQCAtMjY4LDYgKzI2OCw3IEBAIFdlYktpdDItQFdFQktJVEdUS19BUElfVkVSU0lPTkAuZ2ly OiAkKEdfSVJfU0NBTk5FUikgbGlid2Via2l0Mmd0ay1AV0VCS0lUR1RLX0FQCiAJICAgICAtLW5z dmVyc2lvbj1AV0VCS0lUR1RLX0FQSV9WRVJTSU9OQCBcCiAJICAgICAtLWluY2x1ZGU9R09iamVj dC0yLjAgXAogCSAgICAgLS1pbmNsdWRlPUd0ay0zLjAgXAorCSAgICAgLS1pbmNsdWRlPUphdmFT Y3JpcHRDb3JlLUBXRUJLSVRHVEtfQVBJX1ZFUlNJT05AIFwKIAkgICAgIC0taW5jbHVkZT1Tb3Vw LTIuNCBcCiAJICAgICAtLWxpYnJhcnk9d2Via2l0Mmd0ay1AV0VCS0lUR1RLX0FQSV9WRVJTSU9O QCBcCiAJICAgICAtLWxpYnJhcnk9amF2YXNjcmlwdGNvcmVndGstQFdFQktJVEdUS19BUElfVkVS U0lPTkAgXApAQCAtMjk3LDE1ICsyOTgsMTIgQEAgV2ViS2l0Mi1AV0VCS0lUR1RLX0FQSV9WRVJT SU9OQC5naXI6ICQoR19JUl9TQ0FOTkVSKSBsaWJ3ZWJraXQyZ3RrLUBXRUJLSVRHVEtfQVAKIAkg ICAgICQod2Via2l0Z3RrX2dkb21fYnVpbHRfaF9hcGkpIFwKIAkgICAgICQoV2ViS2l0MikvVUlQ cm9jZXNzL0FQSS9ndGsvKi5jcHAKIAotZ2lyMmRpciA9ICQoZGF0YWRpcikvZ2lyLTEuMAotZ2ly Ml9EQVRBID0gV2ViS2l0Mi1AV0VCS0lUR1RLX0FQSV9WRVJTSU9OQC5naXIKLQotdHlwZWxpYnMy ZGlyID0gJChsaWJkaXIpL2dpcmVwb3NpdG9yeS0xLjAKLXR5cGVsaWJzMl9EQVRBID0gV2ViS2l0 Mi1AV0VCS0lUR1RLX0FQSV9WRVJTSU9OQC50eXBlbGliCi0KIFdlYktpdDItQFdFQktJVEdUS19B UElfVkVSU0lPTkAudHlwZWxpYjogV2ViS2l0Mi1AV0VCS0lUR1RLX0FQSV9WRVJTSU9OQC5naXIg JChHX0lSX0NPTVBJTEVSKQogCSQoQU1fVl9HRU4pJChHX0lSX0NPTVBJTEVSKSAtLWluY2x1ZGVk aXIgJChXZWJLaXQyKSAtLWluY2x1ZGVkaXIgJCh0b3BfYnVpbGRkaXIpICQ8IC1vICRACiAKK2dp cl9EQVRBICs9IFdlYktpdDItQFdFQktJVEdUS19BUElfVkVSU0lPTkAuZ2lyCit0eXBlbGlic19E QVRBICs9IFdlYktpdDItQFdFQktJVEdUS19BUElfVkVSU0lPTkAudHlwZWxpYgorCiBDTEVBTkZJ TEVTICs9IFdlYktpdDItQFdFQktJVEdUS19BUElfVkVSU0lPTkAuZ2lyIFdlYktpdDItQFdFQktJ VEdUS19BUElfVkVSU0lPTkAudHlwZWxpYgogCiBlbmRpZgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9n IGIvQ2hhbmdlTG9nCmluZGV4IDM4NTUwZmFmZWIxZDI5NDgxZDY0YzBjYTMyNjE1ZjQ2OTE3NTgx OTUuLmNmZmQyNTU1ZTdkYzY5NWNhMWY1NDQ5NmY2NzRmYTViODIyZDZiNzEgMTAwNjQ0Ci0tLSBh L0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0wNC0xOSAg TWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10g SlNDb3JlLmdpci5pbiBoYXMgYSBmZXcgcHJvYmxlbXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDcxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogR05VbWFrZWZpbGUuYW06IE1vdmUgY29tbW9uIEdJ UiBpbml0aWFsaXphdGlvbiBoZXJlIGZyb20gV2ViS2l0MS4KKyAgICAgICAgKiBjb25maWd1cmUu YWM6IFVwZGF0ZWQgdG8gcmVmbGVjdCBuZXcgSlNDIGdpciBmaWxlIGxvY2F0aW9uLgorCiAyMDEz LTA0LTE2ICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgogCiAgICAg ICAgIFtFRkxdIEJ1bXAgbGlic291cCBkZXBlbmRlbmN5IHRvIDIuNDIuMApkaWZmIC0tZ2l0IGEv R05VbWFrZWZpbGUuYW0gYi9HTlVtYWtlZmlsZS5hbQppbmRleCBhMDc1YTllNGM4OWYyMWNkMTU2 MTk0NzZkZWEwZmM3MzZiNGE5YmI2Li5hMWQwMTkwMTA5OWJmYjFlZTg2Y2NmZjRiMWQ3NTQyMmNi MmM3NDU4IDEwMDY0NAotLS0gYS9HTlVtYWtlZmlsZS5hbQorKysgYi9HTlVtYWtlZmlsZS5hbQpA QCAtMTA4LDEwICsxMDgsNiBAQCBtaW5pYnJvd3Nlcl9idWlsdF9zb3VyY2VzIDo9CiBnbG9iYWxf Y3BwZmxhZ3MgOj0KIGdsb2JhbF9jZmxhZ3MgOj0KIGdsb2JhbF9jeHhmbGFncyA6PQotSlNDT1JF X0dJUlNPVVJDRVMgOj0KLVdFQktJVF9HSVJTT1VSQ0VTIDo9Ci10eXBlbGlic2RpciA6PQotdHlw ZWxpYnNfREFUQSA6PQogRVhUUkFfRElTVCA6PQogQlVJTFRfU09VUkNFUyA6PQogQ0xFQU5GSUxF UyA6PQpAQCAtMTIwLDYgKzExNiwxMyBAQCBESVNUQ0xFQU5GSUxFUyA6PQogTUFJTlRBSU5FUkNM RUFORklMRVMgOj0KIHBrZ2NvbmZpZ19EQVRBIDo9CiAKK2lmIEVOQUJMRV9JTlRST1NQRUNUSU9O CitnaXJfREFUQSA6PQordHlwZWxpYnNfREFUQSA6PQorZ2lyZGlyIDo9ICQoZGF0YWRpcikvZ2ly LTEuMAordHlwZWxpYnNkaXIgOj0gJChsaWJkaXIpL2dpcmVwb3NpdG9yeS0xLjAKK2VuZGlmCisK ICMgV2UgZG8gbm90IGNhcmUgYXQgYWxsIGFib3V0IHRoaXMgaW1wbGljaXQgYnVpbHQtaW4gbWFr ZSBydWxlcywKICMgZGlzYWJsZSB0aGVtIHRvIHNhdmUgc29tZSBidWlsZCB0aW1lCiAlOiAlLmMK ZGlmZiAtLWdpdCBhL2NvbmZpZ3VyZS5hYyBiL2NvbmZpZ3VyZS5hYwppbmRleCBkYzFkZWI5NDdh ZGYxNzA3MjgxNWNhNTAyMzFiNzBmMDcyNzI4N2MyLi45YWU3NWZlMWNhZDhkYjdiYTkyMGM3NzQ4 MWE2ZjFiYTcxMzMzYThkIDEwMDY0NAotLS0gYS9jb25maWd1cmUuYWMKKysrIGIvY29uZmlndXJl LmFjCkBAIC0zOCwyNSArMzgsMjEgQEAgbTRfaW5jbHVkZShbU291cmNlL2F1dG90b29scy9TZXR1 cEF1dG9tYWtlLm00XSkKICMgUHJvY2Vzc2luZyBvZiBjb25maWd1cmF0aW9uIGZpbGVzCiAjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIwogCi1BQ19DT05GSUdfRklMRVMoW0dOVW1ha2VmaWxl IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9wby9QT1RGSUxFU10pCi1BQ19DT05GSUdfRklM RVMoCi0gICAgW1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qYXZhc2NyaXB0Y29yZWd0ay0ke1dFQktJ VEdUS19BUElfVkVSU0lPTn0ucGM6U291cmNlL0phdmFTY3JpcHRDb3JlL2phdmFzY3JpcHRjb3Jl Z3RrLnBjLmluCi0gICAgICAgIFNvdXJjZS9XZWJLaXQvZ3RrL0pTQ29yZS0ke1dFQktJVEdUS19B UElfVkVSU0lPTn0uZ2lyOlNvdXJjZS9XZWJLaXQvZ3RrL0pTQ29yZS5naXIuaW5dLAotICAgIFtX RUJLSVRHVEtfQVBJX1ZFUlNJT049JFdFQktJVEdUS19BUElfVkVSU0lPTixXRUJLSVRHVEtfUENf TkFNRT0kV0VCS0lUR1RLX1BDX05BTUVdKQorQUNfQ09ORklHX0ZJTEVTKFsKKyAgICBHTlVtYWtl ZmlsZSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvcG8vUE9URklMRVMKKyAgICBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvamF2YXNjcmlwdGNvcmVndGstJHtXRUJLSVRHVEtfQVBJX1ZFUlNJT059 LnBjOlNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qYXZhc2NyaXB0Y29yZWd0ay5wYy5pbgorICAgIEph dmFTY3JpcHRDb3JlLSR7V0VCS0lUR1RLX0FQSV9WRVJTSU9OfS5naXI6U291cmNlL0phdmFTY3Jp cHRDb3JlL0phdmFTY3JpcHRDb3JlLmdpci5pbl0pCiAKIGlmIHRlc3QgIiRlbmFibGVfd2Via2l0 MSIgPSAieWVzIjsgdGhlbgotICAgIEFDX0NPTkZJR19GSUxFUyhbU291cmNlL1dlYktpdC9ndGsv d2Via2l0L3dlYmtpdHZlcnNpb24uaF0pCi0KLSAgICBBQ19DT05GSUdfRklMRVMoW1NvdXJjZS9X ZWJLaXQvZ3RrLyR7V0VCS0lUR1RLX1BDX05BTUV9LSR7V0VCS0lUR1RLX0FQSV9WRVJTSU9OfS5w YzpTb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQucGMuaW5dLAotICAgICAgICBbV0VCS0lUR1RLX0FQ SV9WRVJTSU9OPSRXRUJLSVRHVEtfQVBJX1ZFUlNJT04sV0VCS0lUR1RLX1BDX05BTUU9JFdFQktJ VEdUS19QQ19OQU1FXSkKKyAgICBBQ19DT05GSUdfRklMRVMoWworICAgICAgICBTb3VyY2UvV2Vi S2l0L2d0ay93ZWJraXQvd2Via2l0dmVyc2lvbi5oCisgICAgICAgIFNvdXJjZS9XZWJLaXQvZ3Rr LyR7V0VCS0lUR1RLX1BDX05BTUV9LSR7V0VCS0lUR1RLX0FQSV9WRVJTSU9OfS5wYzpTb3VyY2Uv V2ViS2l0L2d0ay93ZWJraXQucGMuaW5dKQogZmkKIAogaWYgdGVzdCAiJGVuYWJsZV93ZWJraXQy IiA9ICJ5ZXMiOyB0aGVuCi0gICAgQUNfQ09ORklHX0ZJTEVTKAotICAgICAgICBbRGVyaXZlZFNv dXJjZXMvV2ViS2l0Mi93ZWJraXQyZ3RrL3dlYmtpdDIvV2ViS2l0VmVyc2lvbi5oOlNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFZlcnNpb24uaC5pbl0pCi0KLSAgICBBQ19D T05GSUdfRklMRVMoW1NvdXJjZS9XZWJLaXQyL3dlYmtpdDJndGstJHtXRUJLSVRHVEtfQVBJX1ZF UlNJT059LnBjOlNvdXJjZS9XZWJLaXQyL3dlYmtpdDJndGsucGMuaW5dLAotICAgICAgICBbV0VC S0lUR1RLX0FQSV9WRVJTSU9OPSRXRUJLSVRHVEtfQVBJX1ZFUlNJT04sV0VCS0lUR1RLX1BDX05B TUU9JFdFQktJVEdUS19QQ19OQU1FXSkKKyAgICBBQ19DT05GSUdfRklMRVMoWworICAgICAgICBE ZXJpdmVkU291cmNlcy9XZWJLaXQyL3dlYmtpdDJndGsvd2Via2l0Mi9XZWJLaXRWZXJzaW9uLmg6 U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0VmVyc2lvbi5oLmluCisgICAg ICAgIFNvdXJjZS9XZWJLaXQyL3dlYmtpdDJndGstJHtXRUJLSVRHVEtfQVBJX1ZFUlNJT059LnBj OlNvdXJjZS9XZWJLaXQyL3dlYmtpdDJndGsucGMuaW5dKQogZmkKIAogbTRfaW5jbHVkZShbU291 cmNlL2F1dG90b29scy9QcmludEJ1aWxkQ29uZmlndXJhdGlvbi5tNF0pCg==