114697 2013-04-16 13:15:12 -0700 PlugIns that resize in user gestures should be immune to snapshotting 2013-04-16 15:00:56 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino commit-queue esprehn+autocc webkit-bug-importer oldest_to_newest 876733 0 dino 2013-04-16 13:15:12 -0700 https://bugs.webkit.org/show_bug.cgi?id=102157 introduced detecting if a plugin resizes above the snapshotting threshold. But plugins that do this in response to user gestures should not snapshot. 876742 1 webkit-bug-importer 2013-04-16 13:15:42 -0700 <rdar://problem/13666258> 876854 2 198426 dino 2013-04-16 13:59:16 -0700 Created attachment 198426 Patch 876855 3 198426 thorton 2013-04-16 14:00:44 -0700 Comment on attachment 198426 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198426&action=review > Source/WebCore/html/HTMLPlugInImageElement.cpp:556 > + if (!m_needsCheckForSizeChange || m_snapshotDecision != MaySnapshotWhenResized || wasRecentUserGesture(document())) the document was not a recent user gesture. perhaps had* or saw*? 876881 4 dino 2013-04-16 14:57:18 -0700 Changed to documentHadRecentUserGesture 876885 5 dino 2013-04-16 15:00:56 -0700 https://trac.webkit.org/r148547 198426 2013-04-16 13:59:16 -0700 2013-04-16 14:00:44 -0700 Patch click-resize.patch text/plain 3490 dino ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwYmNhOTkxLi41NDYwNjRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYg QEAKKzIwMTMtMDQtMTYgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAg IFBsdWdJbnMgdGhhdCByZXNpemUgaW4gdXNlciBnZXN0dXJlcyBzaG91bGQgYmUgaW1tdW5lIHRv IHNuYXBzaG90dGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTE0Njk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTm93IHRoYXQgd2Ugc25hcHNob3QgcGx1Z2lucyBpZiB0aGV5IHJlc2l6ZSBhYm92ZSB0 aGUgc25hcHNob3R0aW5nIHRocmVzaG9sZCwKKyAgICAgICAgd2UgbmVlZCB0byBtYWtlIHN1cmUg dGhhdCB3ZSBkb24ndCBkbyBpdCBpbiByZXNwb25zZSB0byBhIHVzZXIgZ2VzdHVyZQorICAgICAg ICBzdWNoIGFzIGEgY2xpY2suCisKKyAgICAgICAgRHVlIHRvIHRoZSBjb21wbGV4aXRpZXMgb2Yg cmVhbC13b3JsZCBjb250ZW50IGFuZCB0aGUgd2F5IHRoZXkgb2Z0ZW4gZG8KKyAgICAgICAgdGhp bmdzIHVzaW5nIHRpbWVvdXQsIEkgY29waWVkIHRoZSBjb2RlIGZyb20gdGhlIGdlbmVyaWMgdXNl ciBnZXN0dXJlCisgICAgICAgIHRpbWVvdXQsIHdoaWNoIGdpdmVzIGEgNSBzZWNvbmQgZ3JhY2Ug cGVyaW9kIGFmdGVyIGNsaWNrcy4KKworICAgICAgICAqIGh0bWwvSFRNTFBsdWdJbkltYWdlRWxl bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjp3YXNSZWNlbnRVc2VyR2VzdHVyZSk6IE5ldyBz dGF0aWMgZnVuY3Rpb24gdG8gc2hhcmUgdGhlIGNvZGUgZm9yCisgICAgICAgICAgICBjaGVja2lu ZyB0aGUgdGltZSBzaW5jZSB0aGUgbGFzdCBjbGljayAob3Igd2hhdGV2ZXIpLgorICAgICAgICAo V2ViQ29yZTo6SFRNTFBsdWdJbkltYWdlRWxlbWVudDo6Y2hlY2tTaXplQ2hhbmdlRm9yU25hcHNo b3R0aW5nKTogTWFrZSBzdXJlCisgICAgICAgICAgICB0byB0ZXN0IGZvciBhIHVzZXIgZ2VzdHVy ZS4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxQbHVnSW5JbWFnZUVsZW1lbnQ6OnN1YmZyYW1lTG9h ZGVyV2lsbENyZWF0ZVBsdWdJbik6IE1vdmUgdGhlCisgICAgICAgICAgICBjb2RlIGludG8gdGhl IG5ldyBmdW5jdGlvbi4KKwogMjAxMy0wNC0xNSAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5j b20+CiAKICAgICAgICAgUmVuYW1lIHJlc3RhcnRlZFBsdWdpbiB0byBpc1Jlc3RhcnRlZFBsdWdp bi4gVGhpcyB3YXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFBsdWdJbklt YWdlRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQbHVnSW5JbWFnZUVsZW1l bnQuY3BwCmluZGV4IDc1MzAwMTIuLjZlZmVhNDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTFBsdWdJbkltYWdlRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MUGx1Z0luSW1hZ2VFbGVtZW50LmNwcApAQCAtNTM4LDkgKzUzOCwyMiBAQCB2b2lkIEhU TUxQbHVnSW5JbWFnZUVsZW1lbnQ6OnNpbXVsYXRlZE1vdXNlQ2xpY2tUaW1lckZpcmVkKERlZmVy cmFibGVPbmVTaG90VGltZQogICAgIG1fcGVuZGluZ0NsaWNrRXZlbnRGcm9tU25hcHNob3QgPSBu dWxscHRyOwogfQogCitzdGF0aWMgYm9vbCB3YXNSZWNlbnRVc2VyR2VzdHVyZShEb2N1bWVudCog ZG9jdW1lbnQpCit7CisgICAgZG91YmxlIGxhc3RLbm93blVzZXJHZXN0dXJlVGltZXN0YW1wID0g ZG9jdW1lbnQtPmxhc3RIYW5kbGVkVXNlckdlc3R1cmVUaW1lc3RhbXAoKTsKKworICAgIGlmIChk b2N1bWVudC0+ZnJhbWUoKSAhPSBkb2N1bWVudC0+cGFnZSgpLT5tYWluRnJhbWUoKSAmJiBkb2N1 bWVudC0+cGFnZSgpLT5tYWluRnJhbWUoKSAmJiBkb2N1bWVudC0+cGFnZSgpLT5tYWluRnJhbWUo KS0+ZG9jdW1lbnQoKSkKKyAgICAgICAgbGFzdEtub3duVXNlckdlc3R1cmVUaW1lc3RhbXAgPSBz dGQ6Om1heChsYXN0S25vd25Vc2VyR2VzdHVyZVRpbWVzdGFtcCwgZG9jdW1lbnQtPnBhZ2UoKS0+ bWFpbkZyYW1lKCktPmRvY3VtZW50KCktPmxhc3RIYW5kbGVkVXNlckdlc3R1cmVUaW1lc3RhbXAo KSk7CisKKyAgICBpZiAoY3VycmVudFRpbWUoKSAtIGxhc3RLbm93blVzZXJHZXN0dXJlVGltZXN0 YW1wIDwgYXV0b3N0YXJ0U29vbkFmdGVyVXNlckdlc3R1cmVUaHJlc2hvbGQpCisgICAgICAgIHJl dHVybiB0cnVlOworCisgICAgcmV0dXJuIGZhbHNlOworfQorCiB2b2lkIEhUTUxQbHVnSW5JbWFn ZUVsZW1lbnQ6OmNoZWNrU2l6ZUNoYW5nZUZvclNuYXBzaG90dGluZygpCiB7Ci0gICAgaWYgKCFt X25lZWRzQ2hlY2tGb3JTaXplQ2hhbmdlIHx8IG1fc25hcHNob3REZWNpc2lvbiAhPSBNYXlTbmFw c2hvdFdoZW5SZXNpemVkKQorICAgIGlmICghbV9uZWVkc0NoZWNrRm9yU2l6ZUNoYW5nZSB8fCBt X3NuYXBzaG90RGVjaXNpb24gIT0gTWF5U25hcHNob3RXaGVuUmVzaXplZCB8fCB3YXNSZWNlbnRV c2VyR2VzdHVyZShkb2N1bWVudCgpKSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgbV9uZWVkc0No ZWNrRm9yU2l6ZUNoYW5nZSA9IGZhbHNlOwpAQCAtNjA5LDEwICs2MjIsNyBAQCB2b2lkIEhUTUxQ bHVnSW5JbWFnZUVsZW1lbnQ6OnN1YmZyYW1lTG9hZGVyV2lsbENyZWF0ZVBsdWdJbihjb25zdCBL VVJMJiB1cmwpCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBkb3VibGUgbGFzdEtub3du VXNlckdlc3R1cmVUaW1lc3RhbXAgPSBkb2N1bWVudCgpLT5sYXN0SGFuZGxlZFVzZXJHZXN0dXJl VGltZXN0YW1wKCk7Ci0gICAgaWYgKCFpbk1haW5GcmFtZSAmJiBkb2N1bWVudCgpLT5wYWdlKCkt Pm1haW5GcmFtZSgpICYmIGRvY3VtZW50KCktPnBhZ2UoKS0+bWFpbkZyYW1lKCktPmRvY3VtZW50 KCkpCi0gICAgICAgIGxhc3RLbm93blVzZXJHZXN0dXJlVGltZXN0YW1wID0gc3RkOjptYXgobGFz dEtub3duVXNlckdlc3R1cmVUaW1lc3RhbXAsIGRvY3VtZW50KCktPnBhZ2UoKS0+bWFpbkZyYW1l KCktPmRvY3VtZW50KCktPmxhc3RIYW5kbGVkVXNlckdlc3R1cmVUaW1lc3RhbXAoKSk7Ci0gICAg aWYgKGN1cnJlbnRUaW1lKCkgLSBsYXN0S25vd25Vc2VyR2VzdHVyZVRpbWVzdGFtcCA8IGF1dG9z dGFydFNvb25BZnRlclVzZXJHZXN0dXJlVGhyZXNob2xkKSB7CisgICAgaWYgKHdhc1JlY2VudFVz ZXJHZXN0dXJlKGRvY3VtZW50KCkpKSB7CiAgICAgICAgIExPRyhQbHVnaW5zLCAiJXAgUGx1Zy1p biB3YXMgY3JlYXRlZCBzaG9ydGx5IGFmdGVyIGEgdXNlciBnZXN0dXJlLCBzZXQgdG8gcGxheSIs IHRoaXMpOwogICAgICAgICBtX3NuYXBzaG90RGVjaXNpb24gPSBOZXZlclNuYXBzaG90OwogICAg ICAgICByZXR1cm47Cg==