114695 2013-04-16 12:46:53 -0700 Begin chipping away at ScriptState 2013-04-16 13:04:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 876719 0 andersca 2013-04-16 12:46:53 -0700 Begin chipping away at ScriptState 876720 1 198389 andersca 2013-04-16 12:48:10 -0700 Created attachment 198389 Patch 876724 2 198389 ggaren 2013-04-16 12:52:20 -0700 Comment on attachment 198389 Patch r=me 876730 3 andersca 2013-04-16 13:04:19 -0700 Committed r148537: <http://trac.webkit.org/changeset/148537> 198389 2013-04-16 12:48:10 -0700 2013-04-16 12:52:20 -0700 Patch bug-114695-20130416124743.patch text/plain 7233 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTdkMTliYmNjZDVkNTRh NmM5ODkwNmZlYzAwNDE2ZTUxYzQwNTkzNS4uNGMyZThjN2NlMThkMTBjNGVhMGQwZTkxZmU1YzU2 ZTFkYTk5MzVjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA0LTE2ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgQmVnaW4gY2hpcHBp bmcgYXdheSBhdCBTY3JpcHRTdGF0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTE0Njk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUmVtb3ZlIFNjcmlwdFN0YXRlUHJvdGVjdGVkUHRyIGFzIHdlbGwgYXMg ZXZhbEVuYWJsZWQgYW5kIHNldEV2YWxFbmFibGVkLgorCisgICAgICAgICogYmluZGluZ3MvanMv U2NyaXB0U3RhdGUuY3BwOgorICAgICAgICAqIGJpbmRpbmdzL2pzL1NjcmlwdFN0YXRlLmg6Cisg ICAgICAgICogaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0QmFzZS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpJbmplY3RlZFNjcmlwdEJhc2U6OmNhbGxGdW5jdGlvbldpdGhFdmFsRW5hYmxlZCk6Cisg ICAgICAgICogaW5zcGVjdG9yL1NjcmlwdEFyZ3VtZW50cy5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpTY3JpcHRBcmd1bWVudHM6OlNjcmlwdEFyZ3VtZW50cyk6CisgICAgICAgIChXZWJDb3JlOjpT Y3JpcHRBcmd1bWVudHM6Omdsb2JhbFN0YXRlKToKKyAgICAgICAgKiBpbnNwZWN0b3IvU2NyaXB0 QXJndW1lbnRzLmg6CisKIDIwMTMtMDQtMTYgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQu b3JnPgogCiAgICAgICAgIEZsb2F0IGF0IGV4YWN0IG11bHRpcGxlIG9mIGxpbmUtaGVpZ2h0IGFm ZmVjdHMgdG9vIG1hbnkgbGluZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL1NjcmlwdFN0YXRlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdFN0 YXRlLmNwcAppbmRleCA3Nzg4NGI5ZDljNTYxNTQxMThlNDUzNDhiOTc2NGU1MTRmMDFkYzFkLi4w ZjNjY2IzMzdmYzZhZTllYmYxZWI0MmRhNTBmNzRhNjM0NmNkMzZlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRTdGF0ZS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvU2NyaXB0U3RhdGUuY3BwCkBAIC00OCwyMiArNDgsNiBAQAogCiBuYW1l c3BhY2UgV2ViQ29yZSB7CiAKLVNjcmlwdFN0YXRlUHJvdGVjdGVkUHRyOjp+U2NyaXB0U3RhdGVQ cm90ZWN0ZWRQdHIoKQotewotfQotCi1TY3JpcHRTdGF0ZVByb3RlY3RlZFB0cjo6U2NyaXB0U3Rh dGVQcm90ZWN0ZWRQdHIoU2NyaXB0U3RhdGUqIHNjcmlwdFN0YXRlKQotICAgIDogbV9nbG9iYWxP YmplY3Qoc2NyaXB0U3RhdGUtPmdsb2JhbERhdGEoKSwgc2NyaXB0U3RhdGUtPmxleGljYWxHbG9i YWxPYmplY3QoKSkKLXsKLX0KLQotU2NyaXB0U3RhdGUqIFNjcmlwdFN0YXRlUHJvdGVjdGVkUHRy OjpnZXQoKSBjb25zdAotewotICAgIGlmIChtX2dsb2JhbE9iamVjdCkKLSAgICAgICAgcmV0dXJu IGNvbnN0X2Nhc3Q8SlNDOjpKU0dsb2JhbE9iamVjdCo+KG1fZ2xvYmFsT2JqZWN0LmdldCgpKS0+ Z2xvYmFsRXhlYygpOwotICAgIHJldHVybiAwOwotfQotCiBET01XaW5kb3cqIGRvbVdpbmRvd0Zy b21TY3JpcHRTdGF0ZShTY3JpcHRTdGF0ZSogc2NyaXB0U3RhdGUpCiB7CiAgICAgSlNDOjpKU0ds b2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0ID0gc2NyaXB0U3RhdGUtPmxleGljYWxHbG9iYWxPYmpl Y3QoKTsKQEAgLTgwLDE4ICs2NCw2IEBAIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIHNjcmlwdEV4 ZWN1dGlvbkNvbnRleHRGcm9tU2NyaXB0U3RhdGUoU2NyaXB0U3RhdGUqIHNjcmlwCiAgICAgcmV0 dXJuIEpTQzo6anNDYXN0PEpTRE9NR2xvYmFsT2JqZWN0Kj4oZ2xvYmFsT2JqZWN0KS0+c2NyaXB0 RXhlY3V0aW9uQ29udGV4dCgpOwogfQogCi1ib29sIGV2YWxFbmFibGVkKFNjcmlwdFN0YXRlKiBz Y3JpcHRTdGF0ZSkKLXsKLSAgICBKU0M6OkpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QgPSBz Y3JpcHRTdGF0ZS0+bGV4aWNhbEdsb2JhbE9iamVjdCgpOwotICAgIHJldHVybiBnbG9iYWxPYmpl Y3QtPmV2YWxFbmFibGVkKCk7Ci19Ci0KLXZvaWQgc2V0RXZhbEVuYWJsZWQoU2NyaXB0U3RhdGUq IHNjcmlwdFN0YXRlLCBib29sIGVuYWJsZWQpCi17Ci0gICAgSlNDOjpKU0dsb2JhbE9iamVjdCog Z2xvYmFsT2JqZWN0ID0gc2NyaXB0U3RhdGUtPmxleGljYWxHbG9iYWxPYmplY3QoKTsKLSAgICBy ZXR1cm4gZ2xvYmFsT2JqZWN0LT5zZXRFdmFsRW5hYmxlZChlbmFibGVkKTsKLX0KLQogU2NyaXB0 U3RhdGUqIG1haW5Xb3JsZFNjcmlwdFN0YXRlKEZyYW1lKiBmcmFtZSkKIHsKICAgICBpZiAoIWZy YW1lKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0U3RhdGUu aCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdFN0YXRlLmgKaW5kZXggNDVhY2Uy YmE0YzhkMDRmNTNlZGY3NWUxMWQ2NWEzNDQyYjA3ODM2ZC4uN2FlMTVkOWRmY2MwYjlkOTZhMGZm YzhmZDFhODIyYmFjMDA1YTgzOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvU2NyaXB0U3RhdGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRT dGF0ZS5oCkBAIC0zMiw5ICszMiw2IEBACiAjaWZuZGVmIFNjcmlwdFN0YXRlX2gKICNkZWZpbmUg U2NyaXB0U3RhdGVfaAogCi0jaW5jbHVkZSA8aGVhcC9TdHJvbmcuaD4KLSNpbmNsdWRlIDx3dGYv Tm9uY29weWFibGUuaD4KLQogbmFtZXNwYWNlIEpTQyB7CiBjbGFzcyBFeGVjU3RhdGU7CiBjbGFz cyBKU0dsb2JhbE9iamVjdDsKQEAgLTU1LDIyICs1Miw5IEBAIGNsYXNzIFdvcmtlckNvbnRleHQ7 CiAvLyBGb3Igbm93LCB0aGUgc2VwYXJhdGlvbiBpcyBwdXJlbHkgYnkgY29udmVudGlvbi4KIHR5 cGVkZWYgSlNDOjpFeGVjU3RhdGUgU2NyaXB0U3RhdGU7CiAKLWNsYXNzIFNjcmlwdFN0YXRlUHJv dGVjdGVkUHRyIHsKLSAgICBXVEZfTUFLRV9OT05DT1BZQUJMRShTY3JpcHRTdGF0ZVByb3RlY3Rl ZFB0cik7Ci1wdWJsaWM6Ci0gICAgZXhwbGljaXQgU2NyaXB0U3RhdGVQcm90ZWN0ZWRQdHIoU2Ny aXB0U3RhdGUqKTsKLSAgICB+U2NyaXB0U3RhdGVQcm90ZWN0ZWRQdHIoKTsKLSAgICBTY3JpcHRT dGF0ZSogZ2V0KCkgY29uc3Q7Ci1wcml2YXRlOgotICAgIEpTQzo6U3Ryb25nPEpTQzo6SlNHbG9i YWxPYmplY3Q+IG1fZ2xvYmFsT2JqZWN0OwotfTsKLQogRE9NV2luZG93KiBkb21XaW5kb3dGcm9t U2NyaXB0U3RhdGUoU2NyaXB0U3RhdGUqKTsKIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIHNjcmlw dEV4ZWN1dGlvbkNvbnRleHRGcm9tU2NyaXB0U3RhdGUoU2NyaXB0U3RhdGUqKTsKIAotYm9vbCBl dmFsRW5hYmxlZChTY3JpcHRTdGF0ZSopOwotdm9pZCBzZXRFdmFsRW5hYmxlZChTY3JpcHRTdGF0 ZSosIGJvb2wpOwotCiBTY3JpcHRTdGF0ZSogbWFpbldvcmxkU2NyaXB0U3RhdGUoRnJhbWUqKTsK IAogU2NyaXB0U3RhdGUqIHNjcmlwdFN0YXRlRnJvbU5vZGUoRE9NV3JhcHBlcldvcmxkKiwgTm9k ZSopOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0 QmFzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRCYXNlLmNw cAppbmRleCAwOWJjYWFjNWMxY2FjMzBjMGJjNTI1ZjI0M2Y3YTIxNGIxODRjMGMyLi5iYWJkNjA0 YmVlNzE2MTY3OWU0ZWU5ZDIxNTZjNzVmNDFhZWNhOTI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRCYXNlLmNwcApAQCAtMzcsNiArMzcsNyBAQAogI2lu Y2x1ZGUgIkluc3BlY3Rvckluc3RydW1lbnRhdGlvbi5oIgogI2luY2x1ZGUgIkluc3BlY3RvclZh bHVlcy5oIgogI2luY2x1ZGUgIlNjcmlwdEZ1bmN0aW9uQ2FsbC5oIgorI2luY2x1ZGUgPHJ1bnRp bWUvSlNHbG9iYWxPYmplY3QuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KIAog dXNpbmcgV2ViQ29yZTo6VHlwZUJ1aWxkZXI6OlJ1bnRpbWU6OlJlbW90ZU9iamVjdDsKQEAgLTgw LDE2ICs4MSwxNiBAQCBTY3JpcHRWYWx1ZSBJbmplY3RlZFNjcmlwdEJhc2U6OmNhbGxGdW5jdGlv bldpdGhFdmFsRW5hYmxlZChTY3JpcHRGdW5jdGlvbkNhbGwmCiAgICAgU2NyaXB0U3RhdGUqIHNj cmlwdFN0YXRlID0gbV9pbmplY3RlZFNjcmlwdE9iamVjdC5zY3JpcHRTdGF0ZSgpOwogICAgIGJv b2wgZXZhbElzRGlzYWJsZWQgPSBmYWxzZTsKICAgICBpZiAoc2NyaXB0U3RhdGUpIHsKLSAgICAg ICAgZXZhbElzRGlzYWJsZWQgPSAhZXZhbEVuYWJsZWQoc2NyaXB0U3RhdGUpOworICAgICAgICBl dmFsSXNEaXNhYmxlZCA9ICFzY3JpcHRTdGF0ZS0+bGV4aWNhbEdsb2JhbE9iamVjdCgpLT5ldmFs RW5hYmxlZCgpOwogICAgICAgICAvLyBUZW1wb3JhcmlseSBlbmFibGUgYWxsb3cgZXZhbHMgZm9y IGluc3BlY3Rvci4KICAgICAgICAgaWYgKGV2YWxJc0Rpc2FibGVkKQotICAgICAgICAgICAgc2V0 RXZhbEVuYWJsZWQoc2NyaXB0U3RhdGUsIHRydWUpOworICAgICAgICAgICAgc2NyaXB0U3RhdGUt PmxleGljYWxHbG9iYWxPYmplY3QoKS0+c2V0RXZhbEVuYWJsZWQodHJ1ZSk7CiAgICAgfQogCiAg ICAgU2NyaXB0VmFsdWUgcmVzdWx0VmFsdWUgPSBmdW5jdGlvbi5jYWxsKGhhZEV4Y2VwdGlvbik7 CiAKICAgICBpZiAoZXZhbElzRGlzYWJsZWQpCi0gICAgICAgIHNldEV2YWxFbmFibGVkKHNjcmlw dFN0YXRlLCBmYWxzZSk7CisgICAgICAgIHNjcmlwdFN0YXRlLT5sZXhpY2FsR2xvYmFsT2JqZWN0 KCktPnNldEV2YWxFbmFibGVkKGZhbHNlKTsKIAogICAgIEluc3BlY3Rvckluc3RydW1lbnRhdGlv bjo6ZGlkQ2FsbEZ1bmN0aW9uKGNvb2tpZSk7CiAgICAgcmV0dXJuIHJlc3VsdFZhbHVlOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL1NjcmlwdEFyZ3VtZW50cy5jcHAgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvU2NyaXB0QXJndW1lbnRzLmNwcAppbmRleCBiMGZlNTU0 ZWE3OGU1ZDBhNzY3MzdmYWQ4NWRmYjhhYzE4NTYwOThmLi5iYTJlZTA1YTE1YzRiYjBkNzU4MDE3 YzMwODk5NzUyMDJkOTZkMDI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv U2NyaXB0QXJndW1lbnRzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvU2NyaXB0 QXJndW1lbnRzLmNwcApAQCAtNDEsNyArNDEsNyBAQCBQYXNzUmVmUHRyPFNjcmlwdEFyZ3VtZW50 cz4gU2NyaXB0QXJndW1lbnRzOjpjcmVhdGUoU2NyaXB0U3RhdGUqIHNjcmlwdFN0YXRlLCBWZQog fQogCiBTY3JpcHRBcmd1bWVudHM6OlNjcmlwdEFyZ3VtZW50cyhTY3JpcHRTdGF0ZSogc2NyaXB0 U3RhdGUsIFZlY3RvcjxTY3JpcHRWYWx1ZT4mIGFyZ3VtZW50cykKLSAgICA6IG1fc2NyaXB0U3Rh dGUoc2NyaXB0U3RhdGUpCisgICAgOiBtX2dsb2JhbE9iamVjdChzY3JpcHRTdGF0ZS0+Z2xvYmFs RGF0YSgpLCBzY3JpcHRTdGF0ZS0+bGV4aWNhbEdsb2JhbE9iamVjdCgpKQogewogICAgIG1fYXJn dW1lbnRzLnN3YXAoYXJndW1lbnRzKTsKIH0KQEAgLTU4LDcgKzU4LDkgQEAgY29uc3QgU2NyaXB0 VmFsdWUgJlNjcmlwdEFyZ3VtZW50czo6YXJndW1lbnRBdChzaXplX3QgaW5kZXgpIGNvbnN0CiAK IFNjcmlwdFN0YXRlKiBTY3JpcHRBcmd1bWVudHM6Omdsb2JhbFN0YXRlKCkgY29uc3QKIHsKLSAg ICByZXR1cm4gbV9zY3JpcHRTdGF0ZS5nZXQoKTsKKyAgICBpZiAobV9nbG9iYWxPYmplY3QpCisg ICAgICAgIHJldHVybiBjb25zdF9jYXN0PEpTQzo6SlNHbG9iYWxPYmplY3QqPihtX2dsb2JhbE9i amVjdC5nZXQoKSktPmdsb2JhbEV4ZWMoKTsKKyAgICByZXR1cm4gMDsKIH0KIAogYm9vbCBTY3Jp cHRBcmd1bWVudHM6OmdldEZpcnN0QXJndW1lbnRBc1N0cmluZyhTdHJpbmcmIHJlc3VsdCwgYm9v bCBjaGVja0Zvck51bGxPclVuZGVmaW5lZCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9TY3JpcHRBcmd1bWVudHMuaCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9TY3Jp cHRBcmd1bWVudHMuaAppbmRleCA3NmMwZmU3MWNkNWM3Yzc4NzRlZWQxZmE3NWFjYjViMjdiNDYy MzBiLi43ODkyYmMxYTI4NDljYTdmMGMwNDcyM2VjYTNlOWQzM2Y4M2YwNmM1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvU2NyaXB0QXJndW1lbnRzLmgKKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL1NjcmlwdEFyZ3VtZW50cy5oCkBAIC0zMSwxNCArMzEsMjAgQEAK ICNpZm5kZWYgU2NyaXB0QXJndW1lbnRzX2gKICNkZWZpbmUgU2NyaXB0QXJndW1lbnRzX2gKIAot I2luY2x1ZGUgIlNjcmlwdFN0YXRlLmgiCisjaW5jbHVkZSA8aGVhcC9TdHJvbmcuaD4KICNpbmNs dWRlIDx3dGYvRm9yd2FyZC5oPgogI2luY2x1ZGUgPHd0Zi9SZWZDb3VudGVkLmg+CiAjaW5jbHVk ZSA8d3RmL1ZlY3Rvci5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgogCituYW1l c3BhY2UgSlNDIHsKK2NsYXNzIEV4ZWNTdGF0ZTsKK2NsYXNzIEpTR2xvYmFsT2JqZWN0OworfQor CiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKK3R5cGVkZWYgSlNDOjpFeGVjU3RhdGUgU2NyaXB0U3Rh dGU7CiBjbGFzcyBTY3JpcHRWYWx1ZTsKIAogY2xhc3MgU2NyaXB0QXJndW1lbnRzIDogcHVibGlj IFJlZkNvdW50ZWQ8U2NyaXB0QXJndW1lbnRzPiB7CkBAIC01OCw3ICs2NCw3IEBAIHB1YmxpYzoK IHByaXZhdGU6CiAgICAgU2NyaXB0QXJndW1lbnRzKFNjcmlwdFN0YXRlKiwgVmVjdG9yPFNjcmlw dFZhbHVlPiYgYXJndW1lbnRzKTsKIAotICAgIFNjcmlwdFN0YXRlUHJvdGVjdGVkUHRyIG1fc2Ny aXB0U3RhdGU7CisgICAgSlNDOjpTdHJvbmc8SlNDOjpKU0dsb2JhbE9iamVjdD4gbV9nbG9iYWxP YmplY3Q7CiAgICAgVmVjdG9yPFNjcmlwdFZhbHVlPiBtX2FyZ3VtZW50czsKIH07CiAK