<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>114694</bug_id>
          
          <creation_ts>2013-04-16 12:24:08 -0700</creation_ts>
          <short_desc>[Windows, WinCairo] Remove Include Settings for Pthreads from WTF</short_desc>
          <delta_ts>2013-04-17 11:57:02 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>114563</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Brent Fulgham">bfulgham</assigned_to>
          <cc>commit-queue</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>876715</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-04-16 12:24:08 -0700</bug_when>
    <thetext>Now that WTF is clean of pthread use under Windows, remove the project settings and include paths for pthreads.

This change will allow JavaScriptCoreExportGenerator (VS2010) and WebKitExportGenerator (VS2005 and VS2010) to build and run without needing pthreads.

It will also allow builds under VS2010 to run cleanly on the build bots, since we will no longer have to deal with the Windows SxS error related to the pthreads.dll shipped as part of the Apple &quot;Common Files&quot; distribution.  This had prevented us from using VS2010 builds on the build bots.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>877414</commentid>
    <comment_count>1</comment_count>
      <attachid>198591</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-04-17 11:55:22 -0700</bug_when>
    <thetext>Created attachment 198591
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>877415</commentid>
    <comment_count>2</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-04-17 11:57:02 -0700</bug_when>
    <thetext>Committed r148623: &lt;http://trac.webkit.org/changeset/148623&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>198591</attachid>
            <date>2013-04-17 11:55:22 -0700</date>
            <delta_ts>2013-04-17 11:56:23 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-114694-20130417115454.patch</filename>
            <type>text/plain</type>
            <size>3569</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh
bmdlTG9nCShyZXZpc2lvbiAxNDg2MjIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu
ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA0LTE3ICBCcmVudCBGdWxnaGFtICA8YmZ1
bGdoYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBbV2luZG93cywgV2luQ2Fpcm9dIFJlbW92ZSBJ
bmNsdWRlIFNldHRpbmdzIGZvciBQdGhyZWFkcyBmcm9tIFdURgorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0Njk0CisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXVEYudmNwcm9qL1dURkNvbW1vbi52c3By
b3BzOiBSZW1vdmUgcHRocmVhZCBzZWFyY2ggcGF0aC4KKyAgICAgICAgKiBXVEYudmN4cHJvai9X
VEZDb21tb24ucHJvcHM6IFJlbW92ZSBwdGhyZWFkIHNlYXJjaCBwYXRoLgorICAgICAgICAqIHd0
Zi9GYXN0TWFsbG9jLmNwcDogR3VhcmQgcHRocmVhZC5oIGluY2x1ZGUgZm9yIG5vbi1wdGhyZWFk
CisgICAgICAgIGJ1aWxkcy4KKwogMjAxMy0wNC0xNiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBw
bGUuY29tPgogCiAgICAgICAgIEhhcmRlbiBGYXN0TWFsbG9jIGFnYWluc3QgcGFydGlhbCBwb2lu
dGVyIG92ZXJmbG93cwpJbmRleDogU291cmNlL1dURi9XVEYudmNwcm9qL1dURkNvbW1vbi52c3By
b3BzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvV1RGLnZjcHJvai9XVEZDb21tb24udnNwcm9w
cwkocmV2aXNpb24gMTQ4NjE5KQorKysgU291cmNlL1dURi9XVEYudmNwcm9qL1dURkNvbW1vbi52
c3Byb3BzCSh3b3JraW5nIGNvcHkpCkBAIC03LDcgKzcsNyBAQAogCT4KIAk8VG9vbAogCQlOYW1l
PSJWQ0NMQ29tcGlsZXJUb29sIgotCQlBZGRpdGlvbmFsSW5jbHVkZURpcmVjdG9yaWVzPSIuLi87
Li4vd3RmLzsuLi93dGYvdGhyZWFkcy87Li4vd3RmL3VuaWNvZGUvOyZxdW90OyQoQ29uZmlndXJh
dGlvbkJ1aWxkRGlyKVxpbmNsdWRlXHByaXZhdGUmcXVvdDs7JnF1b3Q7JChXZWJLaXRMaWJyYXJp
ZXNEaXIpXGluY2x1ZGUmcXVvdDs7JnF1b3Q7JChDb25maWd1cmF0aW9uQnVpbGREaXIpXGluY2x1
ZGVcSmF2YVNjcmlwdENvcmUmcXVvdDs7JnF1b3Q7JChXZWJLaXRMaWJyYXJpZXNEaXIpXGluY2x1
ZGVccHRocmVhZHMmcXVvdDsiCisJCUFkZGl0aW9uYWxJbmNsdWRlRGlyZWN0b3JpZXM9Ii4uLzsu
Li93dGYvOy4uL3d0Zi90aHJlYWRzLzsuLi93dGYvdW5pY29kZS87JnF1b3Q7JChDb25maWd1cmF0
aW9uQnVpbGREaXIpXGluY2x1ZGVccHJpdmF0ZSZxdW90OzsmcXVvdDskKFdlYktpdExpYnJhcmll
c0RpcilcaW5jbHVkZSZxdW90OzsmcXVvdDskKENvbmZpZ3VyYXRpb25CdWlsZERpcilcaW5jbHVk
ZVxKYXZhU2NyaXB0Q29yZSZxdW90OyIKIAkJUHJlcHJvY2Vzc29yRGVmaW5pdGlvbnM9Il9fU1RE
X0MiCiAJCVByb2dyYW1EYXRhQmFzZUZpbGVOYW1lPSIkKE91dERpcilcJChUYXJnZXROYW1lKS52
YzgwLnBkYiIKIAkJRm9yY2VkSW5jbHVkZUZpbGVzPSJJQ1VWZXJzaW9uLmgiCkluZGV4OiBTb3Vy
Y2UvV1RGL1dURi52Y3hwcm9qL1dURkNvbW1vbi5wcm9wcwo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
V1RGL1dURi52Y3hwcm9qL1dURkNvbW1vbi5wcm9wcwkocmV2aXNpb24gMTQ4NjE5KQorKysgU291
cmNlL1dURi9XVEYudmN4cHJvai9XVEZDb21tb24ucHJvcHMJKHdvcmtpbmcgY29weSkKQEAgLTcs
NyArNyw3IEBACiAgIDxJdGVtR3JvdXAgLz4NCiAgIDxJdGVtRGVmaW5pdGlvbkdyb3VwPg0KICAg
ICA8Q2xDb21waWxlPg0KLSAgICAgIDxBZGRpdGlvbmFsSW5jbHVkZURpcmVjdG9yaWVzPi4uLzsu
Li93dGYvOy4uL3d0Zi90aHJlYWRzLzsuLi93dGYvdW5pY29kZS87JChDb25maWd1cmF0aW9uQnVp
bGREaXIpXGluY2x1ZGVccHJpdmF0ZTskKENvbmZpZ3VyYXRpb25CdWlsZERpcilcaW5jbHVkZVxK
YXZhU2NyaXB0Q29yZTskKFdlYktpdF9MaWJyYXJpZXMpXGluY2x1ZGVccHRocmVhZHM7JChXZWJL
aXRfTGlicmFyaWVzKVxpbmNsdWRlXHByaXZhdGU7JChXZWJLaXRfTGlicmFyaWVzKVxpbmNsdWRl
OyUoQWRkaXRpb25hbEluY2x1ZGVEaXJlY3Rvcmllcyk8L0FkZGl0aW9uYWxJbmNsdWRlRGlyZWN0
b3JpZXM+DQorICAgICAgPEFkZGl0aW9uYWxJbmNsdWRlRGlyZWN0b3JpZXM+Li4vOy4uL3d0Zi87
Li4vd3RmL3RocmVhZHMvOy4uL3d0Zi91bmljb2RlLzskKENvbmZpZ3VyYXRpb25CdWlsZERpcilc
aW5jbHVkZVxwcml2YXRlOyQoQ29uZmlndXJhdGlvbkJ1aWxkRGlyKVxpbmNsdWRlXEphdmFTY3Jp
cHRDb3JlOyQoV2ViS2l0X0xpYnJhcmllcylcaW5jbHVkZVxwcml2YXRlOyQoV2ViS2l0X0xpYnJh
cmllcylcaW5jbHVkZTslKEFkZGl0aW9uYWxJbmNsdWRlRGlyZWN0b3JpZXMpPC9BZGRpdGlvbmFs
SW5jbHVkZURpcmVjdG9yaWVzPg0KICAgICAgIDxQcmVwcm9jZXNzb3JEZWZpbml0aW9ucz5fQ1JU
X1NFQ1VSRV9OT19XQVJOSU5HUztfX1NURF9DO19MSUI7JShQcmVwcm9jZXNzb3JEZWZpbml0aW9u
cyk8L1ByZXByb2Nlc3NvckRlZmluaXRpb25zPg0KICAgICAgIDxGb3JjZWRJbmNsdWRlRmlsZXM+
SUNVVmVyc2lvbi5oOyUoRm9yY2VkSW5jbHVkZUZpbGVzKTwvRm9yY2VkSW5jbHVkZUZpbGVzPg0K
ICAgICAgIDxEaXNhYmxlU3BlY2lmaWNXYXJuaW5ncz4lKERpc2FibGVTcGVjaWZpY1dhcm5pbmdz
KTwvRGlzYWJsZVNwZWNpZmljV2FybmluZ3M+DQpAQCAtMjUsNCArMjUsNCBAQAogICAgICAgPE91
dHB1dEZpbGU+JChPdXREaXIpXCQoVGFyZ2V0TmFtZSkuYnNjPC9PdXRwdXRGaWxlPg0KICAgICA8
L0JzY21ha2U+DQogICA8L0l0ZW1EZWZpbml0aW9uR3JvdXA+DQotPC9Qcm9qZWN0PgpcIE5vIG5l
d2xpbmUgYXQgZW5kIG9mIGZpbGUKKzwvUHJvamVjdD4NCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9G
YXN0TWFsbG9jLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9GYXN0TWFsbG9jLmNw
cAkocmV2aXNpb24gMTQ4NjE5KQorKysgU291cmNlL1dURi93dGYvRmFzdE1hbGxvYy5jcHAJKHdv
cmtpbmcgY29weSkKQEAgLTQzMCw3ICs0MzAsOSBAQCBleHRlcm4gIkMiIFdURl9FWFBPUlRfUFJJ
VkFURSBjb25zdCBpbnQKICNpbmNsdWRlICJUQ1N5c3RlbUFsbG9jLmgiCiAjaW5jbHVkZSAiVGhy
ZWFkU3BlY2lmaWMuaCIKICNpbmNsdWRlIDxhbGdvcml0aG0+CisjaWYgVVNFKFBUSFJFQURTKQog
I2luY2x1ZGUgPHB0aHJlYWQuaD4KKyNlbmRpZgogI2luY2x1ZGUgPHN0ZGFyZy5oPgogI2luY2x1
ZGUgPHN0ZGRlZi5oPgogI2luY2x1ZGUgPHN0ZGludC5oPgo=
</data>
<flag name="review"
          id="220277"
          type_id="1"
          status="+"
          setter="rniwa"
    />
    <flag name="commit-queue"
          id="220278"
          type_id="3"
          status="+"
          setter="rniwa"
    />
          </attachment>
      

    </bug>

</bugzilla>