114687 2013-04-16 09:33:52 -0700 AX: VoiceOver says everything that isn't a link is a "clickable" in Safari reader? 2013-04-17 17:36:10 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach aboxhall apinheiro commit-queue dmazzoni jdiggs oldest_to_newest 876579 0 cfleizach 2013-04-16 09:33:52 -0700 VoiceOver is saying everything in Safari reader is clickable. That's because the AXPress action is exposed on all static text elements That's happening because on the <body> tag there's an on click handler I think the best course of action is not to expose AXPress for static text elements if the on click handler is on the body. 876580 1 198337 cfleizach 2013-04-16 09:40:50 -0700 Created attachment 198337 patch 877336 2 198337 thorton 2013-04-17 09:24:34 -0700 Comment on attachment 198337 patch View in context: https://bugs.webkit.org/attachment.cgi?id=198337&action=review > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:966 > + // It can cause false positives where every piece of text is labeled as accepting press actions when this comment looks cut off. 877343 3 198337 thorton 2013-04-17 09:32:27 -0700 Comment on attachment 198337 patch But other than that it seems fine. 877583 4 cfleizach 2013-04-17 17:36:10 -0700 Thanks. Fixed the comment http://trac.webkit.org/changeset/148652 198337 2013-04-16 09:40:50 -0700 2013-04-17 09:32:27 -0700 patch patch text/plain 7511 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU5vZGVPYmpl Y3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNz aWJpbGl0eU5vZGVPYmplY3QuY3BwCShyZXZpc2lvbiAxNDgyODEpCisrKyBTb3VyY2UvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlOb2RlT2JqZWN0LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtOTYyLDcgKzk2MiwxMiBAQAogCiAgICAgLy8gRklYTUU6IERvIHRoZSBjb250aW51YXRp b24gc2VhcmNoIGxpa2UgYW5jaG9yRWxlbWVudCBkb2VzCiAgICAgZm9yIChFbGVtZW50KiBlbGVt ZW50ID0gdG9FbGVtZW50KG5vZGUpOyBlbGVtZW50OyBlbGVtZW50ID0gZWxlbWVudC0+cGFyZW50 RWxlbWVudCgpKSB7Ci0gICAgICAgIGlmIChlbGVtZW50LT5nZXRBdHRyaWJ1dGVFdmVudExpc3Rl bmVyKGV2ZW50TmFtZXMoKS5jbGlja0V2ZW50KSB8fCBlbGVtZW50LT5nZXRBdHRyaWJ1dGVFdmVu dExpc3RlbmVyKGV2ZW50TmFtZXMoKS5tb3VzZWRvd25FdmVudCkgfHwgZWxlbWVudC0+Z2V0QXR0 cmlidXRlRXZlbnRMaXN0ZW5lcihldmVudE5hbWVzKCkubW91c2V1cEV2ZW50KSkKKyAgICAgICAg Ly8gSWYgd2UndmUgcmVhY2hlZCB0aGUgYm9keSBhbmQgdGhpcyBpcyBub3QgYSBjb250cm9sIGVs ZW1lbnQsIGRvIG5vdCBleHBvc2UgcHJlc3MgYWN0aW9uIGZvciB0aGlzIGVsZW1lbnQuCisgICAg ICAgIC8vIEl0IGNhbiBjYXVzZSBmYWxzZSBwb3NpdGl2ZXMgd2hlcmUgZXZlcnkgcGllY2Ugb2Yg dGV4dCBpcyBsYWJlbGVkIGFzIGFjY2VwdGluZyBwcmVzcyBhY3Rpb25zIHdoZW4KKyAgICAgICAg aWYgKGVsZW1lbnQtPmhhc1RhZ05hbWUoYm9keVRhZykgJiYgaXNTdGF0aWNUZXh0KCkpCisgICAg ICAgICAgICBicmVhazsKKyAgICAgICAgCisgICAgICAgIGlmIChlbGVtZW50LT5oYXNFdmVudExp c3RlbmVycyhldmVudE5hbWVzKCkuY2xpY2tFdmVudCkgfHwgZWxlbWVudC0+aGFzRXZlbnRMaXN0 ZW5lcnMoZXZlbnROYW1lcygpLm1vdXNlZG93bkV2ZW50KSB8fCBlbGVtZW50LT5oYXNFdmVudExp c3RlbmVycyhldmVudE5hbWVzKCkubW91c2V1cEV2ZW50KSkKICAgICAgICAgICAgIHJldHVybiBl bGVtZW50OwogICAgIH0KIApJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nl c3NpYmlsaXR5T2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwCShyZXZpc2lvbiAxNDgyODEpCisrKyBTb3Vy Y2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0yMDksNyArMjA5LDcgQEAKICAgICAgICAgICAgICYmIGF4T2JqZWN0LT5yb2xl VmFsdWUoKSA9PSBjcml0ZXJpYS0+c3RhcnRPYmplY3QtPnJvbGVWYWx1ZSgpOwogICAgICAgICAK ICAgICBjYXNlIFN0YXRpY1RleHRTZWFyY2hLZXk6Ci0gICAgICAgIHJldHVybiBheE9iamVjdC0+ aGFzU3RhdGljVGV4dCgpOworICAgICAgICByZXR1cm4gYXhPYmplY3QtPmlzU3RhdGljVGV4dCgp OwogICAgICAgICAKICAgICBjYXNlIFN0eWxlQ2hhbmdlU2VhcmNoS2V5OgogICAgICAgICByZXR1 cm4gY3JpdGVyaWEtPnN0YXJ0T2JqZWN0CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuaAkocmV2aXNpb24gMTQ4MjgxKQorKysg U291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmgJKHdvcmtp bmcgY29weSkKQEAgLTQ3OSw3ICs0NzksNyBAQAogICAgIHZpcnR1YWwgYm9vbCBoYXNTYW1lRm9u dChSZW5kZXJPYmplY3QqKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQogICAgIHZpcnR1YWwgYm9v bCBoYXNTYW1lRm9udENvbG9yKFJlbmRlck9iamVjdCopIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9 CiAgICAgdmlydHVhbCBib29sIGhhc1NhbWVTdHlsZShSZW5kZXJPYmplY3QqKSBjb25zdCB7IHJl dHVybiBmYWxzZTsgfQotICAgIGJvb2wgaGFzU3RhdGljVGV4dCgpIGNvbnN0IHsgcmV0dXJuIHJv bGVWYWx1ZSgpID09IFN0YXRpY1RleHRSb2xlOyB9CisgICAgYm9vbCBpc1N0YXRpY1RleHQoKSBj b25zdCB7IHJldHVybiByb2xlVmFsdWUoKSA9PSBTdGF0aWNUZXh0Um9sZTsgfQogICAgIHZpcnR1 YWwgYm9vbCBoYXNVbmRlcmxpbmUoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQogICAgIGJvb2wg aGFzSGlnaGxpZ2h0aW5nKCkgY29uc3Q7CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0ODUxNikKKysr IExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisy MDEzLTA0LTE2ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAg ICAgQVg6IFZvaWNlT3ZlciBzYXlzIGV2ZXJ5dGhpbmcgdGhhdCBpc24ndCBhIGxpbmsgaXMgYSAi Y2xpY2thYmxlIiBpbiBTYWZhcmkgcmVhZGVyPworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0Njg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9wcmVzcy1h Y3Rpb24tbm90LWV4cG9zZWQtd2hlbi1ib2R5LWlzLWNsaWNrLWhhbmRsZXItZXhwZWN0ZWQudHh0 OiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9wcmVzcy1hY3Rp b24tbm90LWV4cG9zZWQtd2hlbi1ib2R5LWlzLWNsaWNrLWhhbmRsZXIuaHRtbDogQWRkZWQuCisK IDIwMTMtMDQtMTYgIFBhbiBEZW5nICA8cGFuLmRlbmdAaW50ZWwuY29tPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IFtOZXR3b3JrXSBDb3ZlciB0aGUgdHlwZSBvZiBwcmVmbGlnaHQgeGhyLgpJ bmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvcHJlc3MtYWN0aW9u LW5vdC1leHBvc2VkLXdoZW4tYm9keS1pcy1jbGljay1oYW5kbGVyLWV4cGVjdGVkLnR4dAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9wcmVzcy1h Y3Rpb24tbm90LWV4cG9zZWQtd2hlbi1ib2R5LWlzLWNsaWNrLWhhbmRsZXItZXhwZWN0ZWQudHh0 CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkv cHJlc3MtYWN0aW9uLW5vdC1leHBvc2VkLXdoZW4tYm9keS1pcy1jbGljay1oYW5kbGVyLWV4cGVj dGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDIxIEBACisKK1RoaXMgdGVzdHMgdGhh dCBpZiB0aGUgYm9keSBvciBodG1sIHRhZ3MgaGF2ZSBjbGljayBoYW5kbGVycywgdGhlbiBub24t Y29udHJvbCBlbGVtZW50cyBkbyBub3QgYXV0b21hdGljYWxseSBoYXZlIHRoZSBwcmVzcyBhY3Rp b24gb24gdGhlbS4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNT IiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgdGV4dDEu cm9sZSBpcyAnQVhSb2xlOiBBWFN0YXRpY1RleHQnCitQQVNTIHRleHQyLnJvbGUgaXMgJ0FYUm9s ZTogQVhTdGF0aWNUZXh0JworV2hlbiBhIGNsaWNrIGhhbmRsZXIgaXMgb24gdGhlIEhUTUwgdGFn LCBBWFByZXNzIHNob3VsZCBub3QgYmUgc3VwcG9ydGVkIG9uIHN0YXRpYyB0ZXh0IGNoaWxkcmVu IGVsZW1lbnRzIGF1dG9tYXRpY2FsbHkuCitQQVNTIHRleHQxLmlzUHJlc3NBY3Rpb25TdXBwb3J0 ZWQoKSBpcyBmYWxzZQorUEFTUyB0ZXh0Mi5pc1ByZXNzQWN0aW9uU3VwcG9ydGVkKCkgaXMgZmFs c2UKK1doZW4gYSBjbGljayBoYW5kbGVyIGlzIG9uIHRoZSBCT0RZIHRhZywgQVhQcmVzcyBzaG91 bGQgbm90IGJlIHN1cHBvcnRlZCBvbiBzdGF0aWMgdGV4dCBjaGlsZHJlbiBlbGVtZW50cyBhdXRv bWF0aWNhbGx5LgorUEFTUyB0ZXh0MS5pc1ByZXNzQWN0aW9uU3VwcG9ydGVkKCkgaXMgZmFsc2UK K1BBU1MgdGV4dDIuaXNQcmVzc0FjdGlvblN1cHBvcnRlZCgpIGlzIGZhbHNlCitXaGVuIGEgY2xp Y2sgaGFuZGxlciBpcyBvbiBhIHBhcmVudCB0YWcsIEFYUHJlc3Mgc2hvdWxkIGJlIHN1cHBvcnRl ZCBvbiBzdGF0aWMgdGV4dCBjaGlsZHJlbiBlbGVtZW50cyBhdXRvbWF0aWNhbGx5LgorUEFTUyB0 ZXh0MS5pc1ByZXNzQWN0aW9uU3VwcG9ydGVkKCkgaXMgdHJ1ZQorUEFTUyB0ZXh0Mi5pc1ByZXNz QWN0aW9uU3VwcG9ydGVkKCkgaXMgdHJ1ZQorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1 ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nl c3NpYmlsaXR5L3ByZXNzLWFjdGlvbi1ub3QtZXhwb3NlZC13aGVuLWJvZHktaXMtY2xpY2staGFu ZGxlci5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3Np YmlsaXR5L3ByZXNzLWFjdGlvbi1ub3QtZXhwb3NlZC13aGVuLWJvZHktaXMtY2xpY2staGFuZGxl ci5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2li aWxpdHkvcHJlc3MtYWN0aW9uLW5vdC1leHBvc2VkLXdoZW4tYm9keS1pcy1jbGljay1oYW5kbGVy Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw2MCBAQAorPCFET0NUWVBFIEhUTUwgUFVC TElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWwgaWQ9Imh0bWwiPgorPGhlYWQ+Cis8 c2NyaXB0IHNyYz0iLi4vLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwv c2NyaXB0PgorPC9oZWFkPgorPGJvZHkgaWQ9ImJvZHkiPgorCis8ZGl2IGlkPSJncm91cDEiIHJv bGU9Imdyb3VwIj4KK3RleHQxCis8YnI+Cis8ZGl2IHJvbGU9InRleHQiIGlkPSJ0ZXh0MiI+dGV4 dDI8L2Rpdj4KKworPC9kaXY+CisKKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0i Y29uc29sZSI+PC9kaXY+CisKKzxzY3JpcHQ+CisKKyAgICBkZXNjcmlwdGlvbigiVGhpcyB0ZXN0 cyB0aGF0IGlmIHRoZSBib2R5IG9yIGh0bWwgdGFncyBoYXZlIGNsaWNrIGhhbmRsZXJzLCB0aGVu IG5vbi1jb250cm9sIGVsZW1lbnRzIGRvIG5vdCBhdXRvbWF0aWNhbGx5IGhhdmUgdGhlIHByZXNz IGFjdGlvbiBvbiB0aGVtLiIpOworCisgICAgaWYgKHdpbmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJv bGxlcikgeworCisgICAgICAgICAgZnVuY3Rpb24gbGlzdGVuZXIoKSB7IH0KKworICAgICAgICAg IHZhciBncm91cCA9IGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmFjY2Vzc2libGVFbGVtZW50QnlJ ZCgiZ3JvdXAxIik7CisgICAgICAgICAgdmFyIHRleHQxID0gZ3JvdXAuY2hpbGRBdEluZGV4KDAp LmNoaWxkQXRJbmRleCgwKTsKKyAgICAgICAgICB2YXIgdGV4dDIgPSBhY2Nlc3NpYmlsaXR5Q29u dHJvbGxlci5hY2Nlc3NpYmxlRWxlbWVudEJ5SWQoInRleHQyIik7CisKKyAgICAgICAgICBzaG91 bGRCZSgidGV4dDEucm9sZSIsICInQVhSb2xlOiBBWFN0YXRpY1RleHQnIik7CisgICAgICAgICAg c2hvdWxkQmUoInRleHQyLnJvbGUiLCAiJ0FYUm9sZTogQVhTdGF0aWNUZXh0JyIpOworCisgICAg ICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImh0bWwiKS5hZGRFdmVudExpc3RlbmVyKCdj bGljaycsIGxpc3RlbmVyLCBmYWxzZSk7CisKKyAgICAgICAgICBkZWJ1ZygiV2hlbiBhIGNsaWNr IGhhbmRsZXIgaXMgb24gdGhlIEhUTUwgdGFnLCBBWFByZXNzIHNob3VsZCBub3QgYmUgc3VwcG9y dGVkIG9uIHN0YXRpYyB0ZXh0IGNoaWxkcmVuIGVsZW1lbnRzIGF1dG9tYXRpY2FsbHkuIik7Cisg ICAgICAgICAgc2hvdWxkQmVGYWxzZSgidGV4dDEuaXNQcmVzc0FjdGlvblN1cHBvcnRlZCgpIik7 CisgICAgICAgICAgc2hvdWxkQmVGYWxzZSgidGV4dDIuaXNQcmVzc0FjdGlvblN1cHBvcnRlZCgp Iik7CisKKyAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiaHRtbCIpLnJlbW92ZUV2 ZW50TGlzdGVuZXIoJ2NsaWNrJywgbGlzdGVuZXIsIGZhbHNlKTsKKyAgICAgICAgICBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgiYm9keSIpLmFkZEV2ZW50TGlzdGVuZXIoJ2NsaWNrJywgbGlzdGVu ZXIsIGZhbHNlKTsKKworICAgICAgICAgIGRlYnVnKCJXaGVuIGEgY2xpY2sgaGFuZGxlciBpcyBv biB0aGUgQk9EWSB0YWcsIEFYUHJlc3Mgc2hvdWxkIG5vdCBiZSBzdXBwb3J0ZWQgb24gc3RhdGlj IHRleHQgY2hpbGRyZW4gZWxlbWVudHMgYXV0b21hdGljYWxseS4iKTsKKyAgICAgICAgICBzaG91 bGRCZUZhbHNlKCJ0ZXh0MS5pc1ByZXNzQWN0aW9uU3VwcG9ydGVkKCkiKTsKKyAgICAgICAgICBz aG91bGRCZUZhbHNlKCJ0ZXh0Mi5pc1ByZXNzQWN0aW9uU3VwcG9ydGVkKCkiKTsKKworICAgICAg ICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJib2R5IikucmVtb3ZlRXZlbnRMaXN0ZW5lcign Y2xpY2snLCBsaXN0ZW5lciwgZmFsc2UpOworICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJncm91cDEiKS5hZGRFdmVudExpc3RlbmVyKCdjbGljaycsIGxpc3RlbmVyLCBmYWxzZSk7 CisKKyAgICAgICAgICBkZWJ1ZygiV2hlbiBhIGNsaWNrIGhhbmRsZXIgaXMgb24gYSBwYXJlbnQg dGFnLCBBWFByZXNzIHNob3VsZCBiZSBzdXBwb3J0ZWQgb24gc3RhdGljIHRleHQgY2hpbGRyZW4g ZWxlbWVudHMgYXV0b21hdGljYWxseS4iKTsKKyAgICAgICAgICBzaG91bGRCZVRydWUoInRleHQx LmlzUHJlc3NBY3Rpb25TdXBwb3J0ZWQoKSIpOworICAgICAgICAgIHNob3VsZEJlVHJ1ZSgidGV4 dDIuaXNQcmVzc0FjdGlvblN1cHBvcnRlZCgpIik7CisKKyAgICAgICAgICBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgiZ3JvdXAxIikuc3R5bGUudmlzaWJpbGl0eSA9ICJoaWRkZW4iOworICAgIH0K KworPC9zY3JpcHQ+CisKKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9q cy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=