114681 2013-04-16 05:59:29 -0700 [refactor] Moved ScriptedAnimationController clearance code to common function 2013-04-17 11:15:37 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Enhancement --- 1 bruno.abinader bruno.abinader commit-queue dbates esprehn+autocc jamesr rego+ews xan.lopez oldest_to_newest 876524 0 bruno.abinader 2013-04-16 05:59:29 -0700 Avoided duplicated code by moving ScriptedAnimationController clearance code to an inline function to be used by both Document::dispose() and Document::detach(). 876525 1 198320 bruno.abinader 2013-04-16 06:02:35 -0700 Created attachment 198320 Patch 876530 2 198320 eflews.bot 2013-04-16 06:10:12 -0700 Comment on attachment 198320 Patch Attachment 198320 did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/171013 876538 3 198327 bruno.abinader 2013-04-16 06:39:16 -0700 Created attachment 198327 Patch Moved implementation code out of header as ScriptedAnimationController is forward declared in Document.cpp source. 877392 4 198327 commit-queue 2013-04-17 11:15:34 -0700 Comment on attachment 198327 Patch Clearing flags on attachment: 198327 Committed r148618: <http://trac.webkit.org/changeset/148618> 877393 5 commit-queue 2013-04-17 11:15:37 -0700 All reviewed patches have been landed. Closing bug. 198320 2013-04-16 06:02:35 -0700 2013-04-16 06:11:24 -0700 Patch bug-114681-20130416090207.patch text/plain 3686 bruno.abinader U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTU5NzY4MmIyOGE2ODg2 MjFhNjgzZGMyNzM0NDFjNGZiNmMwNGFkMC4uNDMxOTIwMmJjMDYyMjMzZDIwZGVmZmQ2M2VjZDQ1 YTA1MWRmODk5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTA0LTE2ICBCcnVu byBkZSBPbGl2ZWlyYSBBYmluYWRlciAgPGJydW5vLmFiaW5hZGVyQGJhc3lza29tLmNvbT4KKwor ICAgICAgICBbcmVmYWN0b3JdIE1vdmVkIFNjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlciBjb21t b24gY29kZSB0byBpbmxpbmUgZnVuY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExNDY4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEF2b2lkZWQgZHVwbGljYXRlZCBjb2RlIGJ5IG1vdmluZyBTY3Jp cHRlZEFuaW1hdGlvbkNvbnRyb2xsZXIgY2xlYXJhbmNlCisgICAgICAgIGNvZGUgdG8gYW4gaW5s aW5lIGZ1bmN0aW9uIHRvIGJlIHVzZWQgYnkgYm90aCBEb2N1bWVudDo6ZGlzcG9zZSgpIGFuZAor ICAgICAgICBEb2N1bWVudDo6ZGV0YWNoKCkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBi ZWhhdmlvciBjaGFuZ2VzLgorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkRvY3VtZW50OjpkaXNwb3NlKToKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50 OjpkZXRhY2gpOgorICAgICAgICAqIGRvbS9Eb2N1bWVudC5oOgorICAgICAgICAoRG9jdW1lbnQp OgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6Y2xlYXJT Y3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXIpOiBBZGRlZC4KKwogMjAxMy0wNC0xNSAgQnJ1bm8g ZGUgT2xpdmVpcmEgQWJpbmFkZXIgIDxicnVuby5hYmluYWRlckBiYXN5c2tvbS5jb20+CiAKICAg ICAgICAgT3B0aW1pemUgY29tcHV0YXRpb24gb2YgdmlzdWFsIG92ZXJmbG93IHdoZW4gb3BhY2l0 eSBjaGFuZ2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIv U291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAppbmRleCA2NGNiNWYwYWQyYzM5MThiZTBi OWI4MjBhYTM5NTg4NTM2OGYzYzY4Li4wODhmMDIxN2M4YWY3ODc3YWZlODk3NTY5MTA3MzY3MzY3 MTA2ZjM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTY5NSwxMCArNjk1LDcgQEAgdm9p ZCBEb2N1bWVudDo6ZGlzcG9zZSgpCiAgICAgbV9jc3NDYW52YXNFbGVtZW50cy5jbGVhcigpOwog CiAjaWYgRU5BQkxFKFJFUVVFU1RfQU5JTUFUSU9OX0ZSQU1FKQotICAgIC8vIEZJWE1FOiBjb25z aWRlciB1c2luZyBBY3RpdmVET01PYmplY3QuCi0gICAgaWYgKG1fc2NyaXB0ZWRBbmltYXRpb25D b250cm9sbGVyKQotICAgICAgICBtX3NjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlci0+Y2xlYXJE b2N1bWVudFBvaW50ZXIoKTsKLSAgICBtX3NjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlci5jbGVh cigpOworICAgIGNsZWFyU2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyKCk7CiAjZW5kaWYKIH0K IApAQCAtMjExNywxMCArMjExNCw3IEBAIHZvaWQgRG9jdW1lbnQ6OmRldGFjaCgpCiAjZW5kaWYK IAogI2lmIEVOQUJMRShSRVFVRVNUX0FOSU1BVElPTl9GUkFNRSkKLSAgICAvLyBGSVhNRTogY29u c2lkZXIgdXNpbmcgQWN0aXZlRE9NT2JqZWN0LgotICAgIGlmIChtX3NjcmlwdGVkQW5pbWF0aW9u Q29udHJvbGxlcikKLSAgICAgICAgbV9zY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXItPmNsZWFy RG9jdW1lbnRQb2ludGVyKCk7Ci0gICAgbV9zY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXIuY2xl YXIoKTsKKyAgICBjbGVhclNjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlcigpOwogI2VuZGlmCiAK ICAgICBSZW5kZXJPYmplY3QqIHJlbmRlciA9IHJlbmRlcmVyKCk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5o CmluZGV4IDMwNjc0NzQ3YzY3YjBhYjkwYTQ5ZWJjYjEzZjUzMzQzNjk5MDk1NTYuLmZjMGM4MDFj NzM3ODE2MTE1MjJjNTc5ZjNkMTdjZjIyNDljOWE5ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2RvbS9Eb2N1bWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCkBA IC0xMjkwLDYgKzEyOTAsMTEgQEAgcHJpdmF0ZToKICAgICB2b2lkIGFkZERvY3VtZW50VG9GdWxs U2NyZWVuQ2hhbmdlRXZlbnRRdWV1ZShEb2N1bWVudCopOwogI2VuZGlmCiAKKyNpZiBFTkFCTEUo UkVRVUVTVF9BTklNQVRJT05fRlJBTUUpCisgICAgdm9pZCBjbGVhclNjcmlwdGVkQW5pbWF0aW9u Q29udHJvbGxlcigpOworICAgIFJlZlB0cjxTY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXI+IG1f c2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyOworI2VuZGlmCisKICAgICB2b2lkIHNldFZpc3Vh bFVwZGF0ZXNBbGxvd2VkKFJlYWR5U3RhdGUpOwogICAgIHZvaWQgc2V0VmlzdWFsVXBkYXRlc0Fs bG93ZWQoYm9vbCk7CiAgICAgdm9pZCB2aXN1YWxVcGRhdGVzU3VwcHJlc3Npb25UaW1lckZpcmVk KFRpbWVyPERvY3VtZW50PiopOwpAQCAtMTU0MiwxMCArMTU0Nyw2IEBAIHByaXZhdGU6CiAKICAg ICBkb3VibGUgbV9sYXN0SGFuZGxlZFVzZXJHZXN0dXJlVGltZXN0YW1wOwogCi0jaWYgRU5BQkxF KFJFUVVFU1RfQU5JTUFUSU9OX0ZSQU1FKQotICAgIFJlZlB0cjxTY3JpcHRlZEFuaW1hdGlvbkNv bnRyb2xsZXI+IG1fc2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyOwotI2VuZGlmCi0KICAgICBU aW1lcjxEb2N1bWVudD4gbV9wZW5kaW5nVGFza3NUaW1lcjsKICAgICBWZWN0b3I8T3duUHRyPFRh c2s+ID4gbV9wZW5kaW5nVGFza3M7CiAKQEAgLTE2MTUsNiArMTYxNiwxNiBAQCBpbmxpbmUgY29u c3QgRG9jdW1lbnQqIERvY3VtZW50Ojp0ZW1wbGF0ZURvY3VtZW50KCkgY29uc3QKIH0KICNlbmRp ZgogCisjaWYgRU5BQkxFKFJFUVVFU1RfQU5JTUFUSU9OX0ZSQU1FKQoraW5saW5lIHZvaWQgRG9j dW1lbnQ6OmNsZWFyU2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyKCkKK3sKKyAgICAvLyBGSVhN RTogY29uc2lkZXIgdXNpbmcgQWN0aXZlRE9NT2JqZWN0LgorICAgIGlmIChtX3NjcmlwdGVkQW5p bWF0aW9uQ29udHJvbGxlcikKKyAgICAgICAgbV9zY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXIt PmNsZWFyRG9jdW1lbnRQb2ludGVyKCk7CisgICAgbV9zY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xs ZXIuY2xlYXIoKTsKK30KKyNlbmRpZgorCiBpbmxpbmUgRG9jdW1lbnQqIHRvRG9jdW1lbnQoU2Ny aXB0RXhlY3V0aW9uQ29udGV4dCogc2NyaXB0RXhlY3V0aW9uQ29udGV4dCkKIHsKICAgICBBU1NF UlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTighc2NyaXB0RXhlY3V0aW9uQ29udGV4dCB8fCBz Y3JpcHRFeGVjdXRpb25Db250ZXh0LT5pc0RvY3VtZW50KCkpOwo= 198327 2013-04-16 06:39:16 -0700 2013-04-17 11:15:34 -0700 Patch bug-114681-20130416093848.patch text/plain 3112 bruno.abinader U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTU5NzY4MmIyOGE2ODg2 MjFhNjgzZGMyNzM0NDFjNGZiNmMwNGFkMC4uZDgzMjkwN2Q1NWI5NTBiNGQ4MDg3MTQ3MmIyYmRl N2U1MTE1YWM4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTA0LTE2ICBCcnVu byBkZSBPbGl2ZWlyYSBBYmluYWRlciAgPGJydW5vLmFiaW5hZGVyQGJhc3lza29tLmNvbT4KKwor ICAgICAgICBbcmVmYWN0b3JdIE1vdmVkIFNjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlciBjb21t b24gY29kZSB0byBpbmxpbmUgZnVuY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExNDY4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEF2b2lkZWQgZHVwbGljYXRlZCBjb2RlIGJ5IG1vdmluZyBTY3Jp cHRlZEFuaW1hdGlvbkNvbnRyb2xsZXIgY2xlYXJhbmNlCisgICAgICAgIGNvZGUgdG8gYSBjb21t b24gZnVuY3Rpb24gdXNlZCBieSBib3RoIERvY3VtZW50OjpkaXNwb3NlKCkgYW5kCisgICAgICAg IERvY3VtZW50OjpkZXRhY2goKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9y IGNoYW5nZXMuCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RG9jdW1lbnQ6OmRpc3Bvc2UpOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OmRldGFj aCk6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6Y2xlYXJTY3JpcHRlZEFuaW1hdGlvbkNv bnRyb2xsZXIpOiBBZGRlZC4KKyAgICAgICAgKiBkb20vRG9jdW1lbnQuaDoKKyAgICAgICAgKERv Y3VtZW50KToKKwogMjAxMy0wNC0xNSAgQnJ1bm8gZGUgT2xpdmVpcmEgQWJpbmFkZXIgIDxicnVu by5hYmluYWRlckBiYXN5c2tvbS5jb20+CiAKICAgICAgICAgT3B0aW1pemUgY29tcHV0YXRpb24g b2YgdmlzdWFsIG92ZXJmbG93IHdoZW4gb3BhY2l0eSBjaGFuZ2VzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50 LmNwcAppbmRleCA2NGNiNWYwYWQyYzM5MThiZTBiOWI4MjBhYTM5NTg4NTM2OGYzYzY4Li4wMGE3 YTViZGUxZWYxMjBjZDAyYTAwZGVlYTg5ZTFjNjJiMGRiN2RjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVu dC5jcHAKQEAgLTY5NSwxMCArNjk1LDcgQEAgdm9pZCBEb2N1bWVudDo6ZGlzcG9zZSgpCiAgICAg bV9jc3NDYW52YXNFbGVtZW50cy5jbGVhcigpOwogCiAjaWYgRU5BQkxFKFJFUVVFU1RfQU5JTUFU SU9OX0ZSQU1FKQotICAgIC8vIEZJWE1FOiBjb25zaWRlciB1c2luZyBBY3RpdmVET01PYmplY3Qu Ci0gICAgaWYgKG1fc2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyKQotICAgICAgICBtX3Njcmlw dGVkQW5pbWF0aW9uQ29udHJvbGxlci0+Y2xlYXJEb2N1bWVudFBvaW50ZXIoKTsKLSAgICBtX3Nj cmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlci5jbGVhcigpOworICAgIGNsZWFyU2NyaXB0ZWRBbmlt YXRpb25Db250cm9sbGVyKCk7CiAjZW5kaWYKIH0KIApAQCAtMjExNywxMCArMjExNCw3IEBAIHZv aWQgRG9jdW1lbnQ6OmRldGFjaCgpCiAjZW5kaWYKIAogI2lmIEVOQUJMRShSRVFVRVNUX0FOSU1B VElPTl9GUkFNRSkKLSAgICAvLyBGSVhNRTogY29uc2lkZXIgdXNpbmcgQWN0aXZlRE9NT2JqZWN0 LgotICAgIGlmIChtX3NjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlcikKLSAgICAgICAgbV9zY3Jp cHRlZEFuaW1hdGlvbkNvbnRyb2xsZXItPmNsZWFyRG9jdW1lbnRQb2ludGVyKCk7Ci0gICAgbV9z Y3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXIuY2xlYXIoKTsKKyAgICBjbGVhclNjcmlwdGVkQW5p bWF0aW9uQ29udHJvbGxlcigpOwogI2VuZGlmCiAKICAgICBSZW5kZXJPYmplY3QqIHJlbmRlciA9 IHJlbmRlcmVyKCk7CkBAIC01NjI3LDYgKzU2MjEsMTQgQEAgdm9pZCBEb2N1bWVudDo6c2Vydmlj ZVNjcmlwdGVkQW5pbWF0aW9ucyhkb3VibGUgbW9ub3RvbmljQW5pbWF0aW9uU3RhcnRUaW1lKQog ICAgICAgICByZXR1cm47CiAgICAgbV9zY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXItPnNlcnZp Y2VTY3JpcHRlZEFuaW1hdGlvbnMobW9ub3RvbmljQW5pbWF0aW9uU3RhcnRUaW1lKTsKIH0KKwor dm9pZCBEb2N1bWVudDo6Y2xlYXJTY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXIoKQoreworICAg IC8vIEZJWE1FOiBjb25zaWRlciB1c2luZyBBY3RpdmVET01PYmplY3QuCisgICAgaWYgKG1fc2Ny aXB0ZWRBbmltYXRpb25Db250cm9sbGVyKQorICAgICAgICBtX3NjcmlwdGVkQW5pbWF0aW9uQ29u dHJvbGxlci0+Y2xlYXJEb2N1bWVudFBvaW50ZXIoKTsKKyAgICBtX3NjcmlwdGVkQW5pbWF0aW9u Q29udHJvbGxlci5jbGVhcigpOworfQogI2VuZGlmCiAKICNpZiBFTkFCTEUoVE9VQ0hfRVZFTlRT KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmggYi9Tb3VyY2UvV2Vi Q29yZS9kb20vRG9jdW1lbnQuaAppbmRleCAzMDY3NDc0N2M2N2IwYWI5MGE0OWViY2IxM2Y1MzM0 MzY5OTA5NTU2Li5kMjUxYTc4YTJiZTY1M2UzNDVjMTBmYTk1ODQ0MzEzMWM0YjQ5ZTgwIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9kb20vRG9jdW1lbnQuaApAQCAtMTU0Myw2ICsxNTQzLDcgQEAgcHJpdmF0ZToKICAgICBkb3Vi bGUgbV9sYXN0SGFuZGxlZFVzZXJHZXN0dXJlVGltZXN0YW1wOwogCiAjaWYgRU5BQkxFKFJFUVVF U1RfQU5JTUFUSU9OX0ZSQU1FKQorICAgIHZvaWQgY2xlYXJTY3JpcHRlZEFuaW1hdGlvbkNvbnRy b2xsZXIoKTsKICAgICBSZWZQdHI8U2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyPiBtX3Njcmlw dGVkQW5pbWF0aW9uQ29udHJvbGxlcjsKICNlbmRpZgogCg==