114674 2013-04-16 02:27:55 -0700 [BlackBerry] LayerTexture: check if the graphics context is NULL 2013-04-16 09:14:47 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 berto webkit-unassigned cgarcia commit-queue mifenton rwlbuis tonikitoo xan.lopez oldest_to_newest 876419 0 berto 2013-04-16 02:27:55 -0700 lockBufferDrawable() can return a null pointer, so it should be checked first. 876421 1 198280 berto 2013-04-16 02:31:00 -0700 Created attachment 198280 Patch 876514 2 198280 rwlbuis 2013-04-16 04:50:48 -0700 Comment on attachment 198280 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198280&action=review > Source/WebCore/platform/graphics/blackberry/LayerTexture.cpp:-70 > - gc->addFillRect(BlackBerry::Platform::FloatRect(0, 0, 1, 1)); Why was this never a problem before? Did the semantics of lockBufferDrawable change? > Source/WebCore/platform/graphics/blackberry/LayerTexture.cpp:69 > + if (gc) { It is WebKit style to put the temp var declaration in the if. 876562 3 198333 berto 2013-04-16 08:44:43 -0700 Created attachment 198333 Patch (In reply to comment #2) > > Source/WebCore/platform/graphics/blackberry/LayerTexture.cpp:-70 > > - gc->addFillRect(BlackBerry::Platform::FloatRect(0, 0, 1, 1)); > Why was this never a problem before? Did the semantics of > lockBufferDrawable change? They didn't, it can actually return a null pointer. I don't think it's the case here anyway but see also bug 114005. > > Source/WebCore/platform/graphics/blackberry/LayerTexture.cpp:69 > > + if (gc) { > It is WebKit style to put the temp var declaration in the if. Ok, fixed. 876563 4 198333 rwlbuis 2013-04-16 08:46:53 -0700 Comment on attachment 198333 Patch LGTM. 876567 5 198333 commit-queue 2013-04-16 09:14:45 -0700 Comment on attachment 198333 Patch Clearing flags on attachment: 198333 Committed r148516: <http://trac.webkit.org/changeset/148516> 876568 6 commit-queue 2013-04-16 09:14:47 -0700 All reviewed patches have been landed. Closing bug. 198280 2013-04-16 02:31:00 -0700 2013-04-16 08:44:43 -0700 Patch 114674.diff text/plain 1544 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5NjcxZWM2Li4yYjJlMTNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMDQtMTYgIEFudGhvbnkgU2NpYW4gIDxhc2NpYW5AYmxhY2tiZXJyeS5jb20+CisK KyAgICAgICAgW0JsYWNrQmVycnldIExheWVyVGV4dHVyZTogY2hlY2sgaWYgdGhlIGdyYXBoaWNz IGNvbnRleHQgaXMgTlVMTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTE0Njc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgSW50ZXJuYWwgUFI6IDI1NjUyMgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvYmxhY2tiZXJyeS9MYXllclRleHR1cmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJU ZXh0dXJlOjpzZXRDb250ZW50c1RvQ29sb3IpOgorCiAyMDEzLTA0LTE1ICBBbGJlcnRvIEdhcmNp YSAgPGFnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gVXBzdHJlYW0g dGhlIGlucHV0IHBvcHVwcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvYmxhY2tiZXJyeS9MYXllclRleHR1cmUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9MYXllclRleHR1cmUuY3BwCmluZGV4IDE2NDhkOGYuLjM0 NjZlYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNr YmVycnkvTGF5ZXJUZXh0dXJlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9ibGFja2JlcnJ5L0xheWVyVGV4dHVyZS5jcHAKQEAgLTY2LDggKzY2LDEwIEBAIHZvaWQg TGF5ZXJUZXh0dXJlOjpzZXRDb250ZW50c1RvQ29sb3IoY29uc3QgQ29sb3ImIGNvbG9yKQogCiAg ICAgbV9idWZmZXIgPSBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6R3JhcGhpY3M6OmNyZWF0ZUJ1ZmZl cihJbnRTaXplKDEsIDEpLCBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6R3JhcGhpY3M6OkJhY2tlZFdo ZW5OZWNlc3NhcnkpOwogICAgIEJsYWNrQmVycnk6OlBsYXRmb3JtOjpHcmFwaGljczo6UGxhdGZv cm1HcmFwaGljc0NvbnRleHQqIGdjID0gbG9ja0J1ZmZlckRyYXdhYmxlKG1fYnVmZmVyKTsKLSAg ICBnYy0+c2V0RmlsbENvbG9yKHJnYmEpOwotICAgIGdjLT5hZGRGaWxsUmVjdChCbGFja0JlcnJ5 OjpQbGF0Zm9ybTo6RmxvYXRSZWN0KDAsIDAsIDEsIDEpKTsKKyAgICBpZiAoZ2MpIHsKKyAgICAg ICAgZ2MtPnNldEZpbGxDb2xvcihyZ2JhKTsKKyAgICAgICAgZ2MtPmFkZEZpbGxSZWN0KEJsYWNr QmVycnk6OlBsYXRmb3JtOjpGbG9hdFJlY3QoMCwgMCwgMSwgMSkpOworICAgIH0KICAgICByZWxl YXNlQnVmZmVyRHJhd2FibGUobV9idWZmZXIpOwogCiAgICAgSW50U2l6ZSBvbGRTaXplID0gbV9z aXplOwo= 198333 2013-04-16 08:44:43 -0700 2013-04-16 09:14:44 -0700 Patch 114674.diff text/plain 1698 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmZDVlOTAyLi5iNjNjYzA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMDQtMTYgIEFudGhvbnkgU2NpYW4gIDxhc2NpYW5AYmxhY2tiZXJyeS5jb20+CisK KyAgICAgICAgW0JsYWNrQmVycnldIExheWVyVGV4dHVyZTogY2hlY2sgaWYgdGhlIGdyYXBoaWNz IGNvbnRleHQgaXMgTlVMTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTE0Njc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgSW50ZXJuYWwgUFI6IDI1NjUyMgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvYmxhY2tiZXJyeS9MYXllclRleHR1cmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJU ZXh0dXJlOjpzZXRDb250ZW50c1RvQ29sb3IpOgorCiAyMDEzLTA0LTE1ICBBbGJlcnRvIEdhcmNp YSAgPGFnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gVXBzdHJlYW0g dGhlIGlucHV0IHBvcHVwcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvYmxhY2tiZXJyeS9MYXllclRleHR1cmUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9MYXllclRleHR1cmUuY3BwCmluZGV4IDE2NDhkOGYuLmRi M2M5ZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNr YmVycnkvTGF5ZXJUZXh0dXJlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9ibGFja2JlcnJ5L0xheWVyVGV4dHVyZS5jcHAKQEAgLTY1LDkgKzY1LDEwIEBAIHZvaWQg TGF5ZXJUZXh0dXJlOjpzZXRDb250ZW50c1RvQ29sb3IoY29uc3QgQ29sb3ImIGNvbG9yKQogICAg ICAgICBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6R3JhcGhpY3M6OmRlc3Ryb3lCdWZmZXIobV9idWZm ZXIpOwogCiAgICAgbV9idWZmZXIgPSBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6R3JhcGhpY3M6OmNy ZWF0ZUJ1ZmZlcihJbnRTaXplKDEsIDEpLCBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6R3JhcGhpY3M6 OkJhY2tlZFdoZW5OZWNlc3NhcnkpOwotICAgIEJsYWNrQmVycnk6OlBsYXRmb3JtOjpHcmFwaGlj czo6UGxhdGZvcm1HcmFwaGljc0NvbnRleHQqIGdjID0gbG9ja0J1ZmZlckRyYXdhYmxlKG1fYnVm ZmVyKTsKLSAgICBnYy0+c2V0RmlsbENvbG9yKHJnYmEpOwotICAgIGdjLT5hZGRGaWxsUmVjdChC bGFja0JlcnJ5OjpQbGF0Zm9ybTo6RmxvYXRSZWN0KDAsIDAsIDEsIDEpKTsKKyAgICBpZiAoQmxh Y2tCZXJyeTo6UGxhdGZvcm06OkdyYXBoaWNzOjpQbGF0Zm9ybUdyYXBoaWNzQ29udGV4dCogZ2Mg PSBsb2NrQnVmZmVyRHJhd2FibGUobV9idWZmZXIpKSB7CisgICAgICAgIGdjLT5zZXRGaWxsQ29s b3IocmdiYSk7CisgICAgICAgIGdjLT5hZGRGaWxsUmVjdChCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6 RmxvYXRSZWN0KDAsIDAsIDEsIDEpKTsKKyAgICB9CiAgICAgcmVsZWFzZUJ1ZmZlckRyYXdhYmxl KG1fYnVmZmVyKTsKIAogICAgIEludFNpemUgb2xkU2l6ZSA9IG1fc2l6ZTsK