114662 2013-04-15 21:03:27 -0700 REGRESSION(r146025): WebKit applications can't apply underline or strike through 2013-04-16 11:24:15 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P1 Major --- 1 rniwa rniwa abarth darin eric mjs oldest_to_newest 876260 0 rniwa 2013-04-15 21:03:27 -0700 After http://trac.webkit.org/changeset/146025, OS X Application that embed WebKit cannot apply text decorations via font panel. 876261 1 198230 rniwa 2013-04-15 21:05:57 -0700 Created attachment 198230 Fixes the bug 876621 2 rniwa 2013-04-16 11:12:56 -0700 <rdar://problem/13528389> 876623 3 198230 enrica 2013-04-16 11:15:16 -0700 Comment on attachment 198230 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=198230&action=review Looks good. > Source/WebKit/mac/ChangeLog:8 > + Use -webkit- prefixes to apply underline. There should be no further compat. issue since compatibility > Source/WebKit/mac/ChangeLog:11 > + Unforutnately, we can't test this code like any other font panel bug. typo: Unfortunately 876634 4 rniwa 2013-04-16 11:24:15 -0700 Committed r148525: <http://trac.webkit.org/changeset/148525> 198230 2013-04-15 21:05:57 -0700 2013-04-16 11:15:15 -0700 Fixes the bug bug-114662-20130415210531.patch text/plain 3931 rniwa SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0ODQ5MCkKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA0LTE1 ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04o cjE0NjAyNSk6IFdlYktpdCBhcHBsaWNhdGlvbnMgY2FuJ3QgYXBwbHkgdW5kZXJsaW5lIG9yIHN0 cmlrZSB0aHJvdWdoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTQ2NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBVc2UgLXdlYmtpdC0gcHJlZml4ZXMgdG8gYXBwbHkgdW5kZXJsaW5lLiBUaGVyZSBzaG91 bGQgYmUgbm8gZnVydGhlciBjb21wYXQuIGlzc3VlIHNpbmNlCisgICAgICAgIC1raHRtbC0gd2Fz IHVzZWQgb25seSBpbnRlcm5hbGx5IHRvIHBhc3MgdGhlIGluZm9ybWF0aW9uIGRvd24gdG8gV2Vi Q29yZS4KKworICAgICAgICBVbmZvcnV0bmF0ZWx5LCB3ZSBjYW4ndCB0ZXN0IHRoaXMgY29kZSBs aWtlIGFueSBvdGhlciBmb250IHBhbmVsIGJ1Zy4KKworICAgICAgICBJbiB0aGUgbG9uZyBydW4s IHdlIG5lZWQgdG8gYWRkIHNvbWUgYWJzdHJhY3Rpb24gbGF5ZXIgYXJvdW5kIGZvbnQgcGFuZWwg dG8gbWFrZSB0aGlzIHRlc3RhYmxlCisgICAgICAgIG9yIGVsc2Ugd2UnbGwga2VlcCByZWdyZXNz aW5nIHRoaXMgZmVhdHVyZS4KKworICAgICAgICAqIFdlYlZpZXcvV2ViSFRNTFZpZXcubW06Cisg ICAgICAgICgtW1dlYkhUTUxWaWV3IF9zdHlsZUZyb21Gb250QXR0cmlidXRlczpdKToKKyAgICAg ICAgKC1bV2ViSFRNTFZpZXcgX3N0eWxlRm9yQXR0cmlidXRlQ2hhbmdlOl0pOgorCiAyMDEzLTA0 LTE1ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgcGx1 Z2lucy9nZXQtdXJsLWJlZm9yZXVubG9hZC1kZXN0cm95cy1wbHVnaW4uaHRtbCBjcmFzaGVzIGlu IFdlYktpdDEKSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcubW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJIVE1MVmlldy5tbQko cmV2aXNpb24gMTQ4NDg4KQorKysgU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJIVE1MVmll dy5tbQkod29ya2luZyBjb3B5KQpAQCAtNDMzNiwxMSArNDMzNiwxMSBAQCAtIChET01DU1NTdHls ZURlY2xhcmF0aW9uICopX3N0eWxlRnJvbUZvCiAgICAgaW50IHVuZGVybGluZUludCA9IFtbZGlj dGlvbmFyeSBvYmplY3RGb3JLZXk6TlNVbmRlcmxpbmVTdHlsZUF0dHJpYnV0ZU5hbWVdIGludFZh bHVlXTsKICAgICAvLyBGSVhNRTogVW5kZXJsaW5lIHdpbnMgaGVyZSBpZiB3ZSBoYXZlIGJvdGgg KHNlZSBidWcgMzc5MDQ0MykuCiAgICAgaWYgKHN0cmlrZXRocm91Z2hJbnQgPT0gTlNVbmRlcmxp bmVTdHlsZU5vbmUgJiYgdW5kZXJsaW5lSW50ID09IE5TVW5kZXJsaW5lU3R5bGVOb25lKQotICAg ICAgICBbc3R5bGUgc2V0UHJvcGVydHk6QCIta2h0bWwtdGV4dC1kZWNvcmF0aW9ucy1pbi1lZmZl Y3QiIHZhbHVlOkAibm9uZSIgcHJpb3JpdHk6QCIiXTsKKyAgICAgICAgW3N0eWxlIHNldFByb3Bl cnR5OkAiLXdlYmtpdC10ZXh0LWRlY29yYXRpb25zLWluLWVmZmVjdCIgdmFsdWU6QCJub25lIiBw cmlvcml0eTpAIiJdOwogICAgIGVsc2UgaWYgKHVuZGVybGluZUludCA9PSBOU1VuZGVybGluZVN0 eWxlTm9uZSkKLSAgICAgICAgW3N0eWxlIHNldFByb3BlcnR5OkAiLWtodG1sLXRleHQtZGVjb3Jh dGlvbnMtaW4tZWZmZWN0IiB2YWx1ZTpAImxpbmUtdGhyb3VnaCIgcHJpb3JpdHk6QCIiXTsKKyAg ICAgICAgW3N0eWxlIHNldFByb3BlcnR5OkAiLXdlYmtpdC10ZXh0LWRlY29yYXRpb25zLWluLWVm ZmVjdCIgdmFsdWU6QCJsaW5lLXRocm91Z2giIHByaW9yaXR5OkAiIl07CiAgICAgZWxzZQotICAg ICAgICBbc3R5bGUgc2V0UHJvcGVydHk6QCIta2h0bWwtdGV4dC1kZWNvcmF0aW9ucy1pbi1lZmZl Y3QiIHZhbHVlOkAidW5kZXJsaW5lIiBwcmlvcml0eTpAIiJdOworICAgICAgICBbc3R5bGUgc2V0 UHJvcGVydHk6QCItd2Via2l0LXRleHQtZGVjb3JhdGlvbnMtaW4tZWZmZWN0IiB2YWx1ZTpAInVu ZGVybGluZSIgcHJpb3JpdHk6QCIiXTsKIAogICAgIHJldHVybiBzdHlsZTsKIH0KQEAgLTQ1ODgs MTAgKzQ1ODgsMTAgQEAgLSAoRE9NQ1NTU3R5bGVEZWNsYXJhdGlvbiAqKV9zdHlsZUZvckF0dAog ICAgIGludCBzYiA9IFtbYiBvYmplY3RGb3JLZXk6TlNTdHJpa2V0aHJvdWdoU3R5bGVBdHRyaWJ1 dGVOYW1lXSBpbnRWYWx1ZV07CiAgICAgaWYgKHNhID09IHNiKSB7CiAgICAgICAgIGlmIChzYSA9 PSBOU1VuZGVybGluZVN0eWxlTm9uZSkKLSAgICAgICAgICAgIFtzdHlsZSBzZXRQcm9wZXJ0eTpA Ii1raHRtbC10ZXh0LWRlY29yYXRpb25zLWluLWVmZmVjdCIgdmFsdWU6QCJub25lIiBwcmlvcml0 eTpAIiJdOyAKKyAgICAgICAgICAgIFtzdHlsZSBzZXRQcm9wZXJ0eTpAIi13ZWJraXQtdGV4dC1k ZWNvcmF0aW9ucy1pbi1lZmZlY3QiIHZhbHVlOkAibm9uZSIgcHJpb3JpdHk6QCIiXTsKICAgICAg ICAgICAgIC8vIHdlIHJlYWxseSBtZWFuICJubyBsaW5lLXRocm91Z2giIHJhdGhlciB0aGFuICJu b25lIgogICAgICAgICBlbHNlCi0gICAgICAgICAgICBbc3R5bGUgc2V0UHJvcGVydHk6QCIta2h0 bWwtdGV4dC1kZWNvcmF0aW9ucy1pbi1lZmZlY3QiIHZhbHVlOkAibGluZS10aHJvdWdoIiBwcmlv cml0eTpAIiJdOworICAgICAgICAgICAgW3N0eWxlIHNldFByb3BlcnR5OkAiLXdlYmtpdC10ZXh0 LWRlY29yYXRpb25zLWluLWVmZmVjdCIgdmFsdWU6QCJsaW5lLXRocm91Z2giIHByaW9yaXR5OkAi Il07CiAgICAgICAgICAgICAvLyB3ZSByZWFsbHkgbWVhbiAiYWRkIGxpbmUtdGhyb3VnaCIgcmF0 aGVyIHRoYW4gImxpbmUtdGhyb3VnaCIKICAgICB9CiAKQEAgLTQ2MTAsMTAgKzQ2MTAsMTAgQEAg LSAoRE9NQ1NTU3R5bGVEZWNsYXJhdGlvbiAqKV9zdHlsZUZvckF0dAogICAgIGludCB1YiA9IFtb YiBvYmplY3RGb3JLZXk6TlNVbmRlcmxpbmVTdHlsZUF0dHJpYnV0ZU5hbWVdIGludFZhbHVlXTsK ICAgICBpZiAodWEgPT0gdWIpIHsKICAgICAgICAgaWYgKHVhID09IE5TVW5kZXJsaW5lU3R5bGVO b25lKQotICAgICAgICAgICAgW3N0eWxlIHNldFByb3BlcnR5OkAiLWtodG1sLXRleHQtZGVjb3Jh dGlvbnMtaW4tZWZmZWN0IiB2YWx1ZTpAIm5vbmUiIHByaW9yaXR5OkAiIl07CisgICAgICAgICAg ICBbc3R5bGUgc2V0UHJvcGVydHk6QCItd2Via2l0LXRleHQtZGVjb3JhdGlvbnMtaW4tZWZmZWN0 IiB2YWx1ZTpAIm5vbmUiIHByaW9yaXR5OkAiIl07CiAgICAgICAgICAgICAvLyB3ZSByZWFsbHkg bWVhbiAibm8gdW5kZXJsaW5lIiByYXRoZXIgdGhhbiAibm9uZSIKICAgICAgICAgZWxzZQotICAg ICAgICAgICAgW3N0eWxlIHNldFByb3BlcnR5OkAiLWtodG1sLXRleHQtZGVjb3JhdGlvbnMtaW4t ZWZmZWN0IiB2YWx1ZTpAInVuZGVybGluZSIgcHJpb3JpdHk6QCIiXTsKKyAgICAgICAgICAgIFtz dHlsZSBzZXRQcm9wZXJ0eTpAIi13ZWJraXQtdGV4dC1kZWNvcmF0aW9ucy1pbi1lZmZlY3QiIHZh bHVlOkAidW5kZXJsaW5lIiBwcmlvcml0eTpAIiJdOwogICAgICAgICAgICAgLy8gd2UgcmVhbGx5 IG1lYW4gImFkZCB1bmRlcmxpbmUiIHJhdGhlciB0aGFuICJ1bmRlcmxpbmUiCiAgICAgfQogCg==