114654 2013-04-15 18:56:38 -0700 [GStreamer] Eclipse warnings in MediaPlayerPrivateGStreamer 2013-05-29 20:28:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 0 b.long webkit-unassigned b.long commit-queue eric.carlson gustavo jer.noble menard mrobinson pnormand zan oldest_to_newest 876209 0 b.long 2013-04-15 18:56:38 -0700 [GStreamer] Eclipse warnings in MediaPlayerPrivateGStreamer 876211 1 198216 b.long 2013-04-15 18:58:47 -0700 Created attachment 198216 Patch 876213 2 b.long 2013-04-15 19:03:39 -0700 Minor issues obviously, but Eclipse is annoying about them. * We're not initializing all of the members in GStreamerMediaPlayerPrivate and GStreamerMediaPlayerPrivateBase * isinf() isn't in std:: since we're not importing it with #import <cmath>. I'm trying to figure out how it actually is being imported (I assume gstreamer or glib, but I'm not sure). 876220 3 198220 b.long 2013-04-15 19:33:22 -0700 Created attachment 198220 Patch 876223 4 b.long 2013-04-15 19:37:18 -0700 Actually, I think the problem is that isinf() is only in std:: in C++11 (according to http://en.cppreference.com/w/cpp/header/cmath). That can be fixed in Eclipse by explicitly setting __GXX_EXPERIMENTAL_CXX0X__. I'm not sure there's any reason to force that though. 876358 5 pnormand 2013-04-15 23:44:14 -0700 CCing Zan, who, I think, recently did some work related with isinf. 876360 6 pnormand 2013-04-15 23:48:26 -0700 Patch looks excepted for the isinf part, I think. We are adding C++11 support so I guess it would make sense for you to bend Eclipse to that decision :) 876366 7 zan 2013-04-16 00:18:48 -0700 (In reply to comment #2) > * isinf() isn't in std:: since we're not importing it with #import <cmath>. I'm trying to figure out how it actually is being imported (I assume gstreamer or glib, but I'm not sure). If including the <math.h> header isn't putting the isinf method inside std::, the <wtf/MathExtras.h> header (in Source/WTF/wtf/) should handle the OS-specific setup to do so and should then be included where necessary. To clarify, are we talking about the Eclipse IDE? What compiler is used? What version of it? 876560 8 b.long 2013-04-16 08:39:55 -0700 (In reply to comment #7) > If including the <math.h> header isn't putting the isinf method inside std::, the <wtf/MathExtras.h> header (in Source/WTF/wtf/) should handle the OS-specific setup to do so and should then be included where necessary. I could make it define these when --std=c++11 isn't set if that would be useful. > To clarify, are we talking about the Eclipse IDE? What compiler is used? What version of it? This is in the Eclipse IDE. Builds work fine (presumably --std=c++11 is set?), it's just annoying that Eclipse highlights every usage of std::isinf() as an error. It sounds like it's probably better to just document how to get Eclipse working with QtWebKit and WebKitGtk instead of changing this? 876834 9 b.long 2013-04-16 13:29:46 -0700 Do you want the patch with just initializing GStreamerMediaPlayerPrivate members? 877047 10 pnormand 2013-04-16 23:41:38 -0700 Yes. 877162 11 b.long 2013-04-17 07:33:08 -0700 Oops didn't mean to do that. 877164 12 198509 b.long 2013-04-17 07:43:50 -0700 Created attachment 198509 Patch 877174 13 198509 pnormand 2013-04-17 07:55:58 -0700 Comment on attachment 198509 Patch Cool, thanks Brendan! 877247 14 commit-queue 2013-04-17 08:29:46 -0700 The commit-queue encountered the following flaky tests while processing attachment 198509: media/track/track-mode.html bug 114361 (author: annacc@chromium.org) media/video-layer-crash.html bug 114744 (authors: annacc@chromium.org, eric.carlson@apple.com, jamesr@chromium.org, and vrk@chromium.org) transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org) transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com) transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org) transitions/multiple-shadow-transitions.html bug 114187 (author: simon.fraser@apple.com) transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com) transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com) transitions/negative-delay.html bug 114190 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org) transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com) transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com) transitions/flex-transitions.html bug 114195 (author: tony@chromium.org) transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org) transitions/multiple-mask-transitions.html bug 114197 (author: simon.fraser@apple.com) transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com) transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com) transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org) transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com) transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org and simon.fraser@apple.com) transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org) transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org) transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com) http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org) fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org) platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org) The commit-queue is continuing to process your patch. 877331 15 198509 commit-queue 2013-04-17 09:14:58 -0700 Comment on attachment 198509 Patch Rejecting attachment 198509 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 198509, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ects to file Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp.rej patching file Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp Hunk #1 FAILED at 108. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Philippe Normand']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/31627 877346 16 b.long 2013-04-17 09:34:49 -0700 I'm confused. The commit-queue message says the patch didn't apply, but the git repos say otherwise (https://github.com/WebKit/webkit/commit/c74d372a14a8fc3184b3a61398e13d1f8cb3fa18). Do I need to do anything with this? 877389 17 pnormand 2013-04-17 11:13:30 -0700 Landed in http://trac.webkit.org/changeset/148611 879056 18 zan 2013-04-22 03:32:31 -0700 Reviving the discussion here in hope of resolving this problem. (In reply to comment #8) > (In reply to comment #7) > > If including the <math.h> header isn't putting the isinf method inside std::, the <wtf/MathExtras.h> header (in Source/WTF/wtf/) should handle the OS-specific setup to do so and should then be included where necessary. > > I could make it define these when --std=c++11 isn't set if that would be useful. > Let's keep this as a backup plan. It makes sense though I'm not at the moment 100% sure it's the right approach. Also, FWIW, the MediaPlayerPrivateGStreamer source code is at the moment not compiled with std=c++11. > > To clarify, are we talking about the Eclipse IDE? What compiler is used? What version of it? > > This is in the Eclipse IDE. Builds work fine (presumably --std=c++11 is set?), it's just annoying that Eclipse highlights every usage of std::isinf() as an error. > Again, -std=c++11 is not used when compiling WebCore. If I'm understanding right, the build _does_ work but it's the Eclipse static code analysis that's marking the std::isinf as an error? Could you try including various headers in the MediaPlayerPrivateGStreamer.cpp file and reporting the outcome regarding the std::isinf being marked as an error? The three headers I'd like you to try are - <math.h> (what's normally included in WebCore nowadays when stdlib's math functions are required), - <cmath> (what I hope someday will replace the inclusions from the previous line), - <wtf/MathExtras.h> (the helper header that also sets up missing math functions for various compiler configurations, also includes <cmath>). > It sounds like it's probably better to just document how to get Eclipse working with QtWebKit and WebKitGtk instead of changing this? Hrm, I'd prioritize getting to the source of the problem, though I'm admittedly not affected by it. 882747 19 b.long 2013-04-29 13:45:50 -0700 (In reply to comment #18) > If I'm understanding right, the build _does_ work but it's the Eclipse static code analysis that's marking the std::isinf as an error? Yes, the build works. I even went to the trouble to make it build inside of Eclipse to see if it would pick up the settings automatically, but it didn't help (as suggested here: https://code.google.com/p/chromium/wiki/LinuxEclipseDev). I actually get errors (reported in Eclipse's editor but not the build) on std::isinf (but not ::isinf) and roundf One guess could be related to my relatively old Ubuntu version (12.04), but I assume if it was a GCC problem, it wouldn't compile. > - <math.h> (what's normally included in WebCore nowadays when stdlib's math functions are required), > - <cmath> (what I hope someday will replace the inclusions from the previous line), > - <wtf/MathExtras.h> (the helper header that also sets up missing math functions for various compiler configurations, also includes <cmath>). I get the same results for all three: * roundf not resolved * std::isinf(float): Invalid arguments ' Candidates are: __gnu_cxx::__enable_if<&0[std::__is_arithmetic<#0>::__value],int>::__type isinf(#0) ' 895318 20 b.long 2013-05-29 20:28:36 -0700 It works on my home computer (Fedora 18). Since this only happens on a really old distro (Ubuntu 12.04), I doubt this is really worth spending any time on. 198216 2013-04-15 18:58:47 -0700 2013-04-15 19:33:15 -0700 Patch bug-114654-20130415195820.patch text/plain 4155 b.long U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NDg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjE2MTY0Mzg0NTRiNWQ3 N2QwYjA2MGJiNWI4ZDUzZTVjMGVkNTE1Mi4uMGQyOWYxNmJkMzQ0YmVlNmRjMTZiZjEwOTI3MDE1 MTlmOGZmMmMxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA0LTE1ICBCcmVu ZGFuIExvbmcgIDxiLmxvbmdAY2FibGVsYWJzLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBF Y2xpcHNlIHdhcm5pbmdzIGluIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0NjU0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChub3Ro aW5nIGFkZGVkKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIpOgorICAgICAg ICBJbml0aWFsaXplIG1fdm9sdW1lQW5kTXV0ZUluaXRpYWxpemVkCisgICAgICAgIChXZWJDb3Jl OjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OmJ1ZmZlcmVkKToKKyAgICAgICAgaXNpbmYo KSB3YXMgaW5jbHVkZWQgYnkgR1N0cmVhbWVyLCBzbyBpdCdzIG5vdCBpbiBzdGQ6OgorICAgICAg ICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjptYXhUaW1lU2Vla2FibGUp OiBTYW1lLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXll clByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVy UHJpdmF0ZUdTdHJlYW1lckJhc2U6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UpOgor ICAgICAgICBJbml0aWFsaXplIHNpZ25hbCBoYW5kbGVycyB0byAwLgorCiAyMDEzLTA0LTE1ICBK YW1lcyBDcmFpZyAgPGphbWVzQGNvb2tpZWNyb29rLmNvbT4KIAogICAgICAgICBXZWJLaXQgc2hv dWxkIG5vdCBleHBvc2UgQVhTdWJyb2xlOkFYRGVzY3JpcHRpb25MaXN0IG9uIE1vdW50YWluIExp b24gYXMgaXQgY2F1c2VzIGEgcmVncmVzc2lvbiBpbiBWb2ljZU92ZXIgYmVoYXZpb3IKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKaW5kZXggZjdjYTFh M2NhNTAwNmY5MTIyMGM5ZjdiNmNjMDcxNzQzNjMxMzJkMS4uNDdhYWRkOTJhMmZjYjhkMWEyNWQ0 YTIwOTJmZWY3M2YwMGI5NmUxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lci5jcHAKQEAgLTIxMSw2ICsyMTEsNyBAQCBNZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXI6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcihNZWRpYVBsYXllciogcGxheWVy KQogICAgICwgbV9kZWxheWluZ0xvYWQoZmFsc2UpCiAgICAgLCBtX21lZGlhRHVyYXRpb25Lbm93 bih0cnVlKQogICAgICwgbV9tYXhUaW1lTG9hZGVkQXRMYXN0RGlkTG9hZGluZ1Byb2dyZXNzKDAp CisgICAgLCBtX3ZvbHVtZUFuZE11dGVJbml0aWFsaXplZChmYWxzZSkKICAgICAsIG1faGFzVmlk ZW8oZmFsc2UpCiAgICAgLCBtX2hhc0F1ZGlvKGZhbHNlKQogICAgICwgbV9hdWRpb1RpbWVySGFu ZGxlcigwKQpAQCAtNjM3LDcgKzYzOCw3IEBAIFBhc3NSZWZQdHI8VGltZVJhbmdlcz4gTWVkaWFQ bGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpidWZmZXJlZCgpIGNvbnN0CiAKICNpZiBHU1RfQ0hFQ0tf VkVSU0lPTigwLCAxMCwgMzEpCiAgICAgZmxvYXQgbWVkaWFEdXJhdGlvbihkdXJhdGlvbigpKTsK LSAgICBpZiAoIW1lZGlhRHVyYXRpb24gfHwgc3RkOjppc2luZihtZWRpYUR1cmF0aW9uKSkKKyAg ICBpZiAoIW1lZGlhRHVyYXRpb24gfHwgOjppc2luZihtZWRpYUR1cmF0aW9uKSkKICAgICAgICAg cmV0dXJuIHRpbWVSYW5nZXMucmVsZWFzZSgpOwogCiAgICAgR3N0UXVlcnkqIHF1ZXJ5ID0gZ3N0 X3F1ZXJ5X25ld19idWZmZXJpbmcoR1NUX0ZPUk1BVF9QRVJDRU5UKTsKQEAgLTg5Miw3ICs4OTMs NyBAQCBmbG9hdCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6Om1heFRpbWVTZWVrYWJsZSgp IGNvbnN0CiAKICAgICBMT0dfTUVESUFfTUVTU0FHRSgibWF4VGltZVNlZWthYmxlIik7CiAgICAg Ly8gaW5maW5pdGUgZHVyYXRpb24gbWVhbnMgbGl2ZSBzdHJlYW0KLSAgICBpZiAoc3RkOjppc2lu ZihkdXJhdGlvbigpKSkKKyAgICBpZiAoOjppc2luZihkdXJhdGlvbigpKSkKICAgICAgICAgcmV0 dXJuIDAuMGY7CiAKICAgICByZXR1cm4gZHVyYXRpb24oKTsKQEAgLTEzNjcsMTUgKzEzNjgsMTUg QEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OmNhY2hlRHVyYXRpb24oKQogICAg ICAgICAvLyBEb24ndCBzZXQgbV9tZWRpYUR1cmF0aW9uS25vd24geWV0IGlmIHRoZSBwaXBlbGlu ZSBpcyBub3QKICAgICAgICAgLy8gcGF1c2VkLiBUaGlzIGFsbG93cyBkdXJhdGlvbigpIHF1ZXJ5 IHRvIGZhaWwgYXQgbGVhc3Qgb25jZQogICAgICAgICAvLyBiZWZvcmUgcGxheWJhY2sgc3RhcnRz IGFuZCBkdXJhdGlvbiBiZWNvbWVzIGtub3duLgotICAgICAgICBpZiAoIXN0ZDo6aXNpbmYobmV3 RHVyYXRpb24pKQorICAgICAgICBpZiAoITo6aXNpbmYobmV3RHVyYXRpb24pKQogICAgICAgICAg ICAgbV9tZWRpYUR1cmF0aW9uID0gbmV3RHVyYXRpb247CiAgICAgfSBlbHNlIHsKLSAgICAgICAg bV9tZWRpYUR1cmF0aW9uS25vd24gPSAhc3RkOjppc2luZihuZXdEdXJhdGlvbik7CisgICAgICAg IG1fbWVkaWFEdXJhdGlvbktub3duID0gITo6aXNpbmYobmV3RHVyYXRpb24pOwogICAgICAgICBp ZiAobV9tZWRpYUR1cmF0aW9uS25vd24pCiAgICAgICAgICAgICBtX21lZGlhRHVyYXRpb24gPSBu ZXdEdXJhdGlvbjsKICAgICB9CiAKLSAgICBpZiAoIXN0ZDo6aXNpbmYobmV3RHVyYXRpb24pKQor ICAgIGlmICghOjppc2luZihuZXdEdXJhdGlvbikpCiAgICAgICAgIG1fbWVkaWFEdXJhdGlvbiA9 IG5ld0R1cmF0aW9uOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyQmFzZS5jcHAKaW5kZXggNTYwMjAzMGE3MWIyMGU5MTcwZDk5NWZhMTIyZTM0 ZWI3YWI5Y2YxYi4uMGNjMjgxMGNhNDU2NjIxYTFjMzczZjEyYTYxYTNkMTdmOTAwMDdjMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNw cApAQCAtMTA4LDYgKzEwOCw5IEBAIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6Ok1l ZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UoTWVkaWFQbGF5ZXIqIHBsCiAgICAgLCBtX2J1 ZmZlcigwKQogICAgICwgbV92b2x1bWVUaW1lckhhbmRsZXIoMCkKICAgICAsIG1fbXV0ZVRpbWVy SGFuZGxlcigwKQorICAgICwgbV9yZXBhaW50SGFuZGxlcigwKQorICAgICwgbV92b2x1bWVTaWdu YWxIYW5kbGVyKDApCisgICAgLCBtX211dGVTaWduYWxIYW5kbGVyKDApCiB7CiB9CiAK 198220 2013-04-15 19:33:22 -0700 2013-04-17 07:43:46 -0700 Patch bug-114654-20130415203256.patch text/plain 4133 b.long U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NDg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjE2MTY0Mzg0NTRiNWQ3 N2QwYjA2MGJiNWI4ZDUzZTVjMGVkNTE1Mi4uYzc1YTNhMmE5Y2Q1Yjc3NzI2YzRjYzY3ZTYxNTI2 OGIzMDU4OWFjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA0LTE1ICBCcmVu ZGFuIExvbmcgIDxiLmxvbmdAY2FibGVsYWJzLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBF Y2xpcHNlIHdhcm5pbmdzIGluIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0NjU0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChub3Ro aW5nIGFkZGVkKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIpOgorICAgICAg ICBJbml0aWFsaXplIG1fdm9sdW1lQW5kTXV0ZUluaXRpYWxpemVkCisgICAgICAgIChXZWJDb3Jl OjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OmJ1ZmZlcmVkKToKKyAgICAgICAgaXNpbmYo KSBpcyBvbmx5IGluIHN0ZDo6IGluIEMrKzExCisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXll clByaXZhdGVHU3RyZWFtZXI6Om1heFRpbWVTZWVrYWJsZSk6IFNhbWUuCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2Uu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6 TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZSk6CisgICAgICAgIEluaXRpYWxpemUgc2ln bmFsIGhhbmRsZXJzIHRvIDAuCisKIDIwMTMtMDQtMTUgIEphbWVzIENyYWlnICA8amFtZXNAY29v a2llY3Jvb2suY29tPgogCiAgICAgICAgIFdlYktpdCBzaG91bGQgbm90IGV4cG9zZSBBWFN1YnJv bGU6QVhEZXNjcmlwdGlvbkxpc3Qgb24gTW91bnRhaW4gTGlvbiBhcyBpdCBjYXVzZXMgYSByZWdy ZXNzaW9uIGluIFZvaWNlT3ZlciBiZWhhdmlvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAppbmRleCBmN2NhMWEzY2E1MDA2ZjkxMjIwYzlmN2I2Y2Mw NzE3NDM2MzEzMmQxLi40N2FhZGQ5MmEyZmNiOGQxYTI1ZDRhMjA5MmZlZjczZjAwYjk2ZTFkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVk aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcApAQCAt MjExLDYgKzIxMSw3IEBAIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6TWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyKE1lZGlhUGxheWVyKiBwbGF5ZXIpCiAgICAgLCBtX2RlbGF5aW5nTG9h ZChmYWxzZSkKICAgICAsIG1fbWVkaWFEdXJhdGlvbktub3duKHRydWUpCiAgICAgLCBtX21heFRp bWVMb2FkZWRBdExhc3REaWRMb2FkaW5nUHJvZ3Jlc3MoMCkKKyAgICAsIG1fdm9sdW1lQW5kTXV0 ZUluaXRpYWxpemVkKGZhbHNlKQogICAgICwgbV9oYXNWaWRlbyhmYWxzZSkKICAgICAsIG1faGFz QXVkaW8oZmFsc2UpCiAgICAgLCBtX2F1ZGlvVGltZXJIYW5kbGVyKDApCkBAIC02MzcsNyArNjM4 LDcgQEAgUGFzc1JlZlB0cjxUaW1lUmFuZ2VzPiBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6 OmJ1ZmZlcmVkKCkgY29uc3QKIAogI2lmIEdTVF9DSEVDS19WRVJTSU9OKDAsIDEwLCAzMSkKICAg ICBmbG9hdCBtZWRpYUR1cmF0aW9uKGR1cmF0aW9uKCkpOwotICAgIGlmICghbWVkaWFEdXJhdGlv biB8fCBzdGQ6OmlzaW5mKG1lZGlhRHVyYXRpb24pKQorICAgIGlmICghbWVkaWFEdXJhdGlvbiB8 fCA6OmlzaW5mKG1lZGlhRHVyYXRpb24pKQogICAgICAgICByZXR1cm4gdGltZVJhbmdlcy5yZWxl YXNlKCk7CiAKICAgICBHc3RRdWVyeSogcXVlcnkgPSBnc3RfcXVlcnlfbmV3X2J1ZmZlcmluZyhH U1RfRk9STUFUX1BFUkNFTlQpOwpAQCAtODkyLDcgKzg5Myw3IEBAIGZsb2F0IE1lZGlhUGxheWVy UHJpdmF0ZUdTdHJlYW1lcjo6bWF4VGltZVNlZWthYmxlKCkgY29uc3QKIAogICAgIExPR19NRURJ QV9NRVNTQUdFKCJtYXhUaW1lU2Vla2FibGUiKTsKICAgICAvLyBpbmZpbml0ZSBkdXJhdGlvbiBt ZWFucyBsaXZlIHN0cmVhbQotICAgIGlmIChzdGQ6OmlzaW5mKGR1cmF0aW9uKCkpKQorICAgIGlm ICg6OmlzaW5mKGR1cmF0aW9uKCkpKQogICAgICAgICByZXR1cm4gMC4wZjsKIAogICAgIHJldHVy biBkdXJhdGlvbigpOwpAQCAtMTM2NywxNSArMTM2OCwxNSBAQCB2b2lkIE1lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lcjo6Y2FjaGVEdXJhdGlvbigpCiAgICAgICAgIC8vIERvbid0IHNldCBtX21l ZGlhRHVyYXRpb25Lbm93biB5ZXQgaWYgdGhlIHBpcGVsaW5lIGlzIG5vdAogICAgICAgICAvLyBw YXVzZWQuIFRoaXMgYWxsb3dzIGR1cmF0aW9uKCkgcXVlcnkgdG8gZmFpbCBhdCBsZWFzdCBvbmNl CiAgICAgICAgIC8vIGJlZm9yZSBwbGF5YmFjayBzdGFydHMgYW5kIGR1cmF0aW9uIGJlY29tZXMg a25vd24uCi0gICAgICAgIGlmICghc3RkOjppc2luZihuZXdEdXJhdGlvbikpCisgICAgICAgIGlm ICghOjppc2luZihuZXdEdXJhdGlvbikpCiAgICAgICAgICAgICBtX21lZGlhRHVyYXRpb24gPSBu ZXdEdXJhdGlvbjsKICAgICB9IGVsc2UgewotICAgICAgICBtX21lZGlhRHVyYXRpb25Lbm93biA9 ICFzdGQ6OmlzaW5mKG5ld0R1cmF0aW9uKTsKKyAgICAgICAgbV9tZWRpYUR1cmF0aW9uS25vd24g PSAhOjppc2luZihuZXdEdXJhdGlvbik7CiAgICAgICAgIGlmIChtX21lZGlhRHVyYXRpb25Lbm93 bikKICAgICAgICAgICAgIG1fbWVkaWFEdXJhdGlvbiA9IG5ld0R1cmF0aW9uOwogICAgIH0KIAot ICAgIGlmICghc3RkOjppc2luZihuZXdEdXJhdGlvbikpCisgICAgaWYgKCE6OmlzaW5mKG5ld0R1 cmF0aW9uKSkKICAgICAgICAgbV9tZWRpYUR1cmF0aW9uID0gbmV3RHVyYXRpb247CiB9CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcApp bmRleCA1NjAyMDMwYTcxYjIwZTkxNzBkOTk1ZmExMjJlMzRlYjdhYjljZjFiLi4wY2MyODEwY2E0 NTY2MjFhMWMzNzNmMTJhNjFhM2QxN2Y5MDAwN2MyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy QmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCkBAIC0xMDgsNiArMTA4LDkgQEAg TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyQmFzZShNZWRpYVBsYXllciogcGwKICAgICAsIG1fYnVmZmVyKDApCiAgICAgLCBtX3ZvbHVt ZVRpbWVySGFuZGxlcigwKQogICAgICwgbV9tdXRlVGltZXJIYW5kbGVyKDApCisgICAgLCBtX3Jl cGFpbnRIYW5kbGVyKDApCisgICAgLCBtX3ZvbHVtZVNpZ25hbEhhbmRsZXIoMCkKKyAgICAsIG1f bXV0ZVNpZ25hbEhhbmRsZXIoMCkKIHsKIH0KIAo= 198509 2013-04-17 07:43:50 -0700 2013-04-17 11:13:46 -0700 Patch bug-114654-20130417084322.patch text/plain 2518 b.long U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODUwYTM5Nzk4YjFhMjY5 M2UxMjkzMmU4N2Q1NWY3MzU2ZTJlMmViNi4uYzY3YmZlNDViMzdjMmEzMTk5MjY5ZjllZWU0YzVl ODYxZTdjMTY2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA0LTE3ICBCcmVu ZGFuIExvbmcgIDxiLmxvbmdAY2FibGVsYWJzLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBF Y2xpcHNlIHdhcm5pbmdzIGluIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0NjU0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChub3Ro aW5nIGFkZGVkKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIpOgorICAgICAg ICBJbml0aWFsaXplIG1fdm9sdW1lQW5kTXV0ZUluaXRpYWxpemVkCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6TWVk aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZSk6CisgICAgICAgIEluaXRpYWxpemUgc2lnbmFs IGhhbmRsZXJzIHRvIDAuCisKIDIwMTMtMDQtMTcgIEFuZHJlaSBCdWN1ciAgPGFidWN1ckBhZG9i ZS5jb20+CiAKICAgICAgICAgW0NTUyBSZWdpb25zXSBSZW1vdmUgbV9mbG93VGhyZWFkIGZyb20g Tm9kZVJlbmRlcmluZ0NvbnRleHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0 ZUdTdHJlYW1lci5jcHAKaW5kZXggZjdjYTFhM2NhNTAwNmY5MTIyMGM5ZjdiNmNjMDcxNzQzNjMx MzJkMS4uZTYzOTk2YjRjM2ZiNzk2NWRmMzllYjk3NjBkZTcwOGRiNjRkYTEwNCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVy UHJpdmF0ZUdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKQEAgLTIxMSw2ICsy MTEsNyBAQCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6Ok1lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lcihNZWRpYVBsYXllciogcGxheWVyKQogICAgICwgbV9kZWxheWluZ0xvYWQoZmFsc2Up CiAgICAgLCBtX21lZGlhRHVyYXRpb25Lbm93bih0cnVlKQogICAgICwgbV9tYXhUaW1lTG9hZGVk QXRMYXN0RGlkTG9hZGluZ1Byb2dyZXNzKDApCisgICAgLCBtX3ZvbHVtZUFuZE11dGVJbml0aWFs aXplZChmYWxzZSkKICAgICAsIG1faGFzVmlkZW8oZmFsc2UpCiAgICAgLCBtX2hhc0F1ZGlvKGZh bHNlKQogICAgICwgbV9hdWRpb1RpbWVySGFuZGxlcigwKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJl YW1lckJhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCmluZGV4IDU2MDIwMzBhNzFiMjBl OTE3MGQ5OTVmYTEyMmUzNGViN2FiOWNmMWIuLjBjYzI4MTBjYTQ1NjYyMWExYzM3M2YxMmE2MWEz ZDE3ZjkwMDA3YzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRl R1N0cmVhbWVyQmFzZS5jcHAKQEAgLTEwOCw2ICsxMDgsOSBAQCBNZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXJCYXNlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlKE1lZGlhUGxheWVy KiBwbAogICAgICwgbV9idWZmZXIoMCkKICAgICAsIG1fdm9sdW1lVGltZXJIYW5kbGVyKDApCiAg ICAgLCBtX211dGVUaW1lckhhbmRsZXIoMCkKKyAgICAsIG1fcmVwYWludEhhbmRsZXIoMCkKKyAg ICAsIG1fdm9sdW1lU2lnbmFsSGFuZGxlcigwKQorICAgICwgbV9tdXRlU2lnbmFsSGFuZGxlcigw KQogewogfQogCg==