<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>114650</bug_id>
          
          <creation_ts>2013-04-15 17:25:16 -0700</creation_ts>
          <short_desc>WebKit should not decode or support PDF favicons</short_desc>
          <delta_ts>2013-04-19 12:44:59 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Images</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tim Horton">thorton</reporter>
          <assigned_to name="Tim Horton">thorton</assigned_to>
          <cc>ap</cc>
    
    <cc>commit-queue</cc>
    
    <cc>japhet</cc>
    
    <cc>mitz</cc>
    
    <cc>sam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>876171</commentid>
    <comment_count>0</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2013-04-15 17:25:16 -0700</bug_when>
    <thetext>No other browser I can find supports this anyway. *We* don&apos;t even successfully display the image, but we try to.

&lt;rdar://problem/10133914&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>876176</commentid>
    <comment_count>1</comment_count>
      <attachid>198207</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2013-04-15 17:38:40 -0700</bug_when>
    <thetext>Created attachment 198207
patch

Not sure if this is a reasonable place to bail if we find PDF data, but... maybe?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>876177</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-04-15 17:39:54 -0700</bug_when>
    <thetext>Attachment 198207 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/WebCore/ChangeLog&apos;, u&apos;Source/WebCore/loader/icon/IconLoader.cpp&apos;]&quot; exit_code: 1
Source/WebCore/loader/icon/IconLoader.cpp:100:  Omit int when using unsigned  [runtime/unsigned] [1]
Source/WebCore/loader/icon/IconLoader.cpp:104:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>876178</commentid>
    <comment_count>3</comment_count>
      <attachid>198208</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2013-04-15 17:42:14 -0700</bug_when>
    <thetext>Created attachment 198208
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>876180</commentid>
    <comment_count>4</comment_count>
      <attachid>198209</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2013-04-15 17:42:50 -0700</bug_when>
    <thetext>Created attachment 198209
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>876181</commentid>
    <comment_count>5</comment_count>
      <attachid>198210</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2013-04-15 17:45:26 -0700</bug_when>
    <thetext>Created attachment 198210
patch

oh boy</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>878201</commentid>
    <comment_count>6</comment_count>
      <attachid>198210</attachid>
    <who name="">mitz</who>
    <bug_when>2013-04-18 20:40:28 -0700</bug_when>
    <thetext>Comment on attachment 198210
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198210&amp;action=review

&gt; Source/WebCore/loader/icon/IconLoader.cpp:100
&gt; +    static const char* pdfMagicNumber = &quot;%PDF&quot;;
&gt; +    static unsigned pdfMagicNumberLength = strlen(pdfMagicNumber);

I would have done this with a uint32_t constant (and gotten it wrong on big endian) or a char array that I could sizeof() instead of using strlen().</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>878615</commentid>
    <comment_count>7</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2013-04-19 12:44:59 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/148758</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>198207</attachid>
            <date>2013-04-15 17:38:40 -0700</date>
            <delta_ts>2013-04-15 17:42:14 -0700</delta_ts>
            <desc>patch</desc>
            <filename>pdf-magic-favicon.diff</filename>
            <type>text/plain</type>
            <size>2006</size>
            <attacher name="Tim Horton">thorton</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCAyNjYyNmVhLi4yOTA4MmFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg
QEAKKzIwMTMtMDQtMTUgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK
KyAgICAgICAgV2ViS2l0IHNob3VsZCBub3QgZGVjb2RlIG9yIHN1cHBvcnQgUERGIGZhdmljb25z
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ2NTAK
KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEwMTMzOTE0PgorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERyb3AgdGhlIGltYWdlIGRhdGEgb24gdGhlIGZs
b29yIGlmIGl0IGJlZ2lucyB3aXRoIHRoZSBQREYgbWFnaWMgbnVtYmVyLgorICAgICAgICBObyBv
dGhlciBicm93c2VyIEkgY2FuIGZpbmQgb24gT1MgWCBzdXBwb3J0cyBQREYgZmF2aWNvbnMgKGJ5
IGV4cGVyaW1lbnRhdGlvbiksCisgICAgICAgIGFuZCB3ZSBkbyBub3QgcHJvcGVybHkgZGlzcGxh
eSB0aGVtLgorCisgICAgICAgICogbG9hZGVyL2ljb24vSWNvbkxvYWRlci5jcHA6CisgICAgICAg
IChXZWJDb3JlOjpJY29uTG9hZGVyOjpub3RpZnlGaW5pc2hlZCk6CisKIDIwMTMtMDQtMTUgIEln
b3IgT2xpdmVpcmEgIDxpZ29yLm9Ac2lzYS5zYW1zdW5nLmNvbT4KIAogICAgICAgICBDYWxsIGRp
cmVjdGx5IFJlbmRlckJsb2NrOjpkZWxldGVMaW5lQm94VHJlZQpkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYkNvcmUvbG9hZGVyL2ljb24vSWNvbkxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2Fk
ZXIvaWNvbi9JY29uTG9hZGVyLmNwcAppbmRleCBkNzQyM2U2Li5kZTQxOWFjIDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvaWNvbi9JY29uTG9hZGVyLmNwcAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9sb2FkZXIvaWNvbi9JY29uTG9hZGVyLmNwcApAQCAtOTYsNiArOTYsMTcgQEAgdm9p
ZCBJY29uTG9hZGVyOjpub3RpZnlGaW5pc2hlZChDYWNoZWRSZXNvdXJjZSogcmVzb3VyY2UpCiAg
ICAgaWYgKHN0YXR1cyAmJiAoc3RhdHVzIDwgMjAwIHx8IHN0YXR1cyA+IDI5OSkpCiAgICAgICAg
IGRhdGEgPSAwOwogCisgICAgc3RhdGljIGNvbnN0IGNoYXIqIHBkZk1hZ2ljTnVtYmVyID0gIiVQ
REYiOworICAgIHN0YXRpYyB1bnNpZ25lZCBpbnQgcGRmTWFnaWNOdW1iZXJMZW5ndGggPSBzdHJs
ZW4ocGRmTWFnaWNOdW1iZXIpIC0gMTsKKyAgICBpZiAoZGF0YSAmJiBkYXRhLT5zaXplKCkgPj0g
cGRmTWFnaWNOdW1iZXJMZW5ndGgpIHsKKyAgICAgICAgY29uc3QgY2hhciogcmF3RGF0YSA9IGRh
dGEtPmRhdGEoKTsKKworICAgICAgICBpZiAobWVtY21wKHJhd0RhdGEsIHBkZk1hZ2ljTnVtYmVy
LCBwZGZNYWdpY051bWJlckxlbmd0aCkgPT0gMCkgeworICAgICAgICAgICAgTE9HKEljb25EYXRh
YmFzZSwgIkljb25Mb2FkZXI6OmZpbmlzaExvYWRpbmcoKSAtIElnbm9yaW5nIGljb24gYXQgJXMg
YmVjYXVzZSBpdCBhcHBlYXJzIHRvIGJlIGEgUERGIiwgcmVzb3VyY2UtPnVybCgpLnN0cmluZygp
LmFzY2lpKCkuZGF0YSgpKTsKKyAgICAgICAgICAgIGRhdGEgPSAwOworICAgICAgICB9CisgICAg
fQorCiAgICAgTE9HKEljb25EYXRhYmFzZSwgIkljb25Mb2FkZXI6OmZpbmlzaExvYWRpbmcoKSAt
IENvbW1pdHRpbmcgaWNvblVSTCAlcyB0byBkYXRhYmFzZSIsIHJlc291cmNlLT51cmwoKS5zdHJp
bmcoKS5hc2NpaSgpLmRhdGEoKSk7CiAgICAgbV9mcmFtZS0+bG9hZGVyKCktPmljb24oKS0+Y29t
bWl0VG9EYXRhYmFzZShyZXNvdXJjZS0+dXJsKCkpOwogICAgIC8vIFNldHRpbmcgdGhlIGljb24g
ZGF0YSBvbmx5IGFmdGVyIGNvbW1pdHRpbmcgdG8gdGhlIGRhdGFiYXNlIGVuc3VyZXMgdGhhdCB0
aGUgZGF0YSBpcwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>198208</attachid>
            <date>2013-04-15 17:42:14 -0700</date>
            <delta_ts>2013-04-15 17:42:50 -0700</delta_ts>
            <desc>patch</desc>
            <filename>pdf-magic-favicon.diff</filename>
            <type>text/plain</type>
            <size>1998</size>
            <attacher name="Tim Horton">thorton</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCAyNjYyNmVhLi4yOTA4MmFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg
QEAKKzIwMTMtMDQtMTUgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK
KyAgICAgICAgV2ViS2l0IHNob3VsZCBub3QgZGVjb2RlIG9yIHN1cHBvcnQgUERGIGZhdmljb25z
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ2NTAK
KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEwMTMzOTE0PgorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERyb3AgdGhlIGltYWdlIGRhdGEgb24gdGhlIGZs
b29yIGlmIGl0IGJlZ2lucyB3aXRoIHRoZSBQREYgbWFnaWMgbnVtYmVyLgorICAgICAgICBObyBv
dGhlciBicm93c2VyIEkgY2FuIGZpbmQgb24gT1MgWCBzdXBwb3J0cyBQREYgZmF2aWNvbnMgKGJ5
IGV4cGVyaW1lbnRhdGlvbiksCisgICAgICAgIGFuZCB3ZSBkbyBub3QgcHJvcGVybHkgZGlzcGxh
eSB0aGVtLgorCisgICAgICAgICogbG9hZGVyL2ljb24vSWNvbkxvYWRlci5jcHA6CisgICAgICAg
IChXZWJDb3JlOjpJY29uTG9hZGVyOjpub3RpZnlGaW5pc2hlZCk6CisKIDIwMTMtMDQtMTUgIEln
b3IgT2xpdmVpcmEgIDxpZ29yLm9Ac2lzYS5zYW1zdW5nLmNvbT4KIAogICAgICAgICBDYWxsIGRp
cmVjdGx5IFJlbmRlckJsb2NrOjpkZWxldGVMaW5lQm94VHJlZQpkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYkNvcmUvbG9hZGVyL2ljb24vSWNvbkxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2Fk
ZXIvaWNvbi9JY29uTG9hZGVyLmNwcAppbmRleCBkNzQyM2U2Li41OTA4YmJmIDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvaWNvbi9JY29uTG9hZGVyLmNwcAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9sb2FkZXIvaWNvbi9JY29uTG9hZGVyLmNwcApAQCAtOTYsNiArOTYsMTcgQEAgdm9p
ZCBJY29uTG9hZGVyOjpub3RpZnlGaW5pc2hlZChDYWNoZWRSZXNvdXJjZSogcmVzb3VyY2UpCiAg
ICAgaWYgKHN0YXR1cyAmJiAoc3RhdHVzIDwgMjAwIHx8IHN0YXR1cyA+IDI5OSkpCiAgICAgICAg
IGRhdGEgPSAwOwogCisgICAgc3RhdGljIGNvbnN0IGNoYXIqIHBkZk1hZ2ljTnVtYmVyID0gIiVQ
REYiOworICAgIHN0YXRpYyB1bnNpZ25lZCBpbnQgcGRmTWFnaWNOdW1iZXJMZW5ndGggPSBzdHJs
ZW4ocGRmTWFnaWNOdW1iZXIpOworICAgIGlmIChkYXRhICYmIGRhdGEtPnNpemUoKSA+PSBwZGZN
YWdpY051bWJlckxlbmd0aCkgeworICAgICAgICBjb25zdCBjaGFyKiByYXdEYXRhID0gZGF0YS0+
ZGF0YSgpOworCisgICAgICAgIGlmICghbWVtY21wKHJhd0RhdGEsIHBkZk1hZ2ljTnVtYmVyLCBw
ZGZNYWdpY051bWJlckxlbmd0aCkpIHsKKyAgICAgICAgICAgIExPRyhJY29uRGF0YWJhc2UsICJJ
Y29uTG9hZGVyOjpmaW5pc2hMb2FkaW5nKCkgLSBJZ25vcmluZyBpY29uIGF0ICVzIGJlY2F1c2Ug
aXQgYXBwZWFycyB0byBiZSBhIFBERiIsIHJlc291cmNlLT51cmwoKS5zdHJpbmcoKS5hc2NpaSgp
LmRhdGEoKSk7CisgICAgICAgICAgICBkYXRhID0gMDsKKyAgICAgICAgfQorICAgIH0KKwogICAg
IExPRyhJY29uRGF0YWJhc2UsICJJY29uTG9hZGVyOjpmaW5pc2hMb2FkaW5nKCkgLSBDb21taXR0
aW5nIGljb25VUkwgJXMgdG8gZGF0YWJhc2UiLCByZXNvdXJjZS0+dXJsKCkuc3RyaW5nKCkuYXNj
aWkoKS5kYXRhKCkpOwogICAgIG1fZnJhbWUtPmxvYWRlcigpLT5pY29uKCktPmNvbW1pdFRvRGF0
YWJhc2UocmVzb3VyY2UtPnVybCgpKTsKICAgICAvLyBTZXR0aW5nIHRoZSBpY29uIGRhdGEgb25s
eSBhZnRlciBjb21taXR0aW5nIHRvIHRoZSBkYXRhYmFzZSBlbnN1cmVzIHRoYXQgdGhlIGRhdGEg
aXMK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>198209</attachid>
            <date>2013-04-15 17:42:50 -0700</date>
            <delta_ts>2013-04-15 17:45:26 -0700</delta_ts>
            <desc>patch</desc>
            <filename>pdf-magic-favicon.diff</filename>
            <type>text/plain</type>
            <size>1994</size>
            <attacher name="Tim Horton">thorton</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCAyNjYyNmVhLi4yOTA4MmFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg
QEAKKzIwMTMtMDQtMTUgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK
KyAgICAgICAgV2ViS2l0IHNob3VsZCBub3QgZGVjb2RlIG9yIHN1cHBvcnQgUERGIGZhdmljb25z
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ2NTAK
KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEwMTMzOTE0PgorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERyb3AgdGhlIGltYWdlIGRhdGEgb24gdGhlIGZs
b29yIGlmIGl0IGJlZ2lucyB3aXRoIHRoZSBQREYgbWFnaWMgbnVtYmVyLgorICAgICAgICBObyBv
dGhlciBicm93c2VyIEkgY2FuIGZpbmQgb24gT1MgWCBzdXBwb3J0cyBQREYgZmF2aWNvbnMgKGJ5
IGV4cGVyaW1lbnRhdGlvbiksCisgICAgICAgIGFuZCB3ZSBkbyBub3QgcHJvcGVybHkgZGlzcGxh
eSB0aGVtLgorCisgICAgICAgICogbG9hZGVyL2ljb24vSWNvbkxvYWRlci5jcHA6CisgICAgICAg
IChXZWJDb3JlOjpJY29uTG9hZGVyOjpub3RpZnlGaW5pc2hlZCk6CisKIDIwMTMtMDQtMTUgIEln
b3IgT2xpdmVpcmEgIDxpZ29yLm9Ac2lzYS5zYW1zdW5nLmNvbT4KIAogICAgICAgICBDYWxsIGRp
cmVjdGx5IFJlbmRlckJsb2NrOjpkZWxldGVMaW5lQm94VHJlZQpkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYkNvcmUvbG9hZGVyL2ljb24vSWNvbkxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2Fk
ZXIvaWNvbi9JY29uTG9hZGVyLmNwcAppbmRleCBkNzQyM2U2Li4zNTliOWZmIDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvaWNvbi9JY29uTG9hZGVyLmNwcAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9sb2FkZXIvaWNvbi9JY29uTG9hZGVyLmNwcApAQCAtOTYsNiArOTYsMTcgQEAgdm9p
ZCBJY29uTG9hZGVyOjpub3RpZnlGaW5pc2hlZChDYWNoZWRSZXNvdXJjZSogcmVzb3VyY2UpCiAg
ICAgaWYgKHN0YXR1cyAmJiAoc3RhdHVzIDwgMjAwIHx8IHN0YXR1cyA+IDI5OSkpCiAgICAgICAg
IGRhdGEgPSAwOwogCisgICAgc3RhdGljIGNvbnN0IGNoYXIqIHBkZk1hZ2ljTnVtYmVyID0gIiVQ
REYiOworICAgIHN0YXRpYyB1bnNpZ25lZCBwZGZNYWdpY051bWJlckxlbmd0aCA9IHN0cmxlbihw
ZGZNYWdpY051bWJlcik7CisgICAgaWYgKGRhdGEgJiYgZGF0YS0+c2l6ZSgpID49IHBkZk1hZ2lj
TnVtYmVyTGVuZ3RoKSB7CisgICAgICAgIGNvbnN0IGNoYXIqIHJhd0RhdGEgPSBkYXRhLT5kYXRh
KCk7CisKKyAgICAgICAgaWYgKCFtZW1jbXAocmF3RGF0YSwgcGRmTWFnaWNOdW1iZXIsIHBkZk1h
Z2ljTnVtYmVyTGVuZ3RoKSkgeworICAgICAgICAgICAgTE9HKEljb25EYXRhYmFzZSwgIkljb25M
b2FkZXI6OmZpbmlzaExvYWRpbmcoKSAtIElnbm9yaW5nIGljb24gYXQgJXMgYmVjYXVzZSBpdCBh
cHBlYXJzIHRvIGJlIGEgUERGIiwgcmVzb3VyY2UtPnVybCgpLnN0cmluZygpLmFzY2lpKCkuZGF0
YSgpKTsKKyAgICAgICAgICAgIGRhdGEgPSAwOworICAgICAgICB9CisgICAgfQorCiAgICAgTE9H
KEljb25EYXRhYmFzZSwgIkljb25Mb2FkZXI6OmZpbmlzaExvYWRpbmcoKSAtIENvbW1pdHRpbmcg
aWNvblVSTCAlcyB0byBkYXRhYmFzZSIsIHJlc291cmNlLT51cmwoKS5zdHJpbmcoKS5hc2NpaSgp
LmRhdGEoKSk7CiAgICAgbV9mcmFtZS0+bG9hZGVyKCktPmljb24oKS0+Y29tbWl0VG9EYXRhYmFz
ZShyZXNvdXJjZS0+dXJsKCkpOwogICAgIC8vIFNldHRpbmcgdGhlIGljb24gZGF0YSBvbmx5IGFm
dGVyIGNvbW1pdHRpbmcgdG8gdGhlIGRhdGFiYXNlIGVuc3VyZXMgdGhhdCB0aGUgZGF0YSBpcwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>198210</attachid>
            <date>2013-04-15 17:45:26 -0700</date>
            <delta_ts>2013-04-18 20:40:28 -0700</delta_ts>
            <desc>patch</desc>
            <filename>pdf-magic-favicon.diff</filename>
            <type>text/plain</type>
            <size>1920</size>
            <attacher name="Tim Horton">thorton</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCAyNjYyNmVhLi4yOTA4MmFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg
QEAKKzIwMTMtMDQtMTUgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK
KyAgICAgICAgV2ViS2l0IHNob3VsZCBub3QgZGVjb2RlIG9yIHN1cHBvcnQgUERGIGZhdmljb25z
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ2NTAK
KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEwMTMzOTE0PgorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERyb3AgdGhlIGltYWdlIGRhdGEgb24gdGhlIGZs
b29yIGlmIGl0IGJlZ2lucyB3aXRoIHRoZSBQREYgbWFnaWMgbnVtYmVyLgorICAgICAgICBObyBv
dGhlciBicm93c2VyIEkgY2FuIGZpbmQgb24gT1MgWCBzdXBwb3J0cyBQREYgZmF2aWNvbnMgKGJ5
IGV4cGVyaW1lbnRhdGlvbiksCisgICAgICAgIGFuZCB3ZSBkbyBub3QgcHJvcGVybHkgZGlzcGxh
eSB0aGVtLgorCisgICAgICAgICogbG9hZGVyL2ljb24vSWNvbkxvYWRlci5jcHA6CisgICAgICAg
IChXZWJDb3JlOjpJY29uTG9hZGVyOjpub3RpZnlGaW5pc2hlZCk6CisKIDIwMTMtMDQtMTUgIEln
b3IgT2xpdmVpcmEgIDxpZ29yLm9Ac2lzYS5zYW1zdW5nLmNvbT4KIAogICAgICAgICBDYWxsIGRp
cmVjdGx5IFJlbmRlckJsb2NrOjpkZWxldGVMaW5lQm94VHJlZQpkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYkNvcmUvbG9hZGVyL2ljb24vSWNvbkxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2Fk
ZXIvaWNvbi9JY29uTG9hZGVyLmNwcAppbmRleCBkNzQyM2U2Li5hMDRjMTc5IDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvaWNvbi9JY29uTG9hZGVyLmNwcAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9sb2FkZXIvaWNvbi9JY29uTG9hZGVyLmNwcApAQCAtOTYsNiArOTYsMTMgQEAgdm9p
ZCBJY29uTG9hZGVyOjpub3RpZnlGaW5pc2hlZChDYWNoZWRSZXNvdXJjZSogcmVzb3VyY2UpCiAg
ICAgaWYgKHN0YXR1cyAmJiAoc3RhdHVzIDwgMjAwIHx8IHN0YXR1cyA+IDI5OSkpCiAgICAgICAg
IGRhdGEgPSAwOwogCisgICAgc3RhdGljIGNvbnN0IGNoYXIqIHBkZk1hZ2ljTnVtYmVyID0gIiVQ
REYiOworICAgIHN0YXRpYyB1bnNpZ25lZCBwZGZNYWdpY051bWJlckxlbmd0aCA9IHN0cmxlbihw
ZGZNYWdpY051bWJlcik7CisgICAgaWYgKGRhdGEgJiYgZGF0YS0+c2l6ZSgpID49IHBkZk1hZ2lj
TnVtYmVyTGVuZ3RoICYmICFtZW1jbXAoZGF0YS0+ZGF0YSgpLCBwZGZNYWdpY051bWJlciwgcGRm
TWFnaWNOdW1iZXJMZW5ndGgpKSB7CisgICAgICAgIExPRyhJY29uRGF0YWJhc2UsICJJY29uTG9h
ZGVyOjpmaW5pc2hMb2FkaW5nKCkgLSBJZ25vcmluZyBpY29uIGF0ICVzIGJlY2F1c2UgaXQgYXBw
ZWFycyB0byBiZSBhIFBERiIsIHJlc291cmNlLT51cmwoKS5zdHJpbmcoKS5hc2NpaSgpLmRhdGEo
KSk7CisgICAgICAgIGRhdGEgPSAwOworICAgIH0KKwogICAgIExPRyhJY29uRGF0YWJhc2UsICJJ
Y29uTG9hZGVyOjpmaW5pc2hMb2FkaW5nKCkgLSBDb21taXR0aW5nIGljb25VUkwgJXMgdG8gZGF0
YWJhc2UiLCByZXNvdXJjZS0+dXJsKCkuc3RyaW5nKCkuYXNjaWkoKS5kYXRhKCkpOwogICAgIG1f
ZnJhbWUtPmxvYWRlcigpLT5pY29uKCktPmNvbW1pdFRvRGF0YWJhc2UocmVzb3VyY2UtPnVybCgp
KTsKICAgICAvLyBTZXR0aW5nIHRoZSBpY29uIGRhdGEgb25seSBhZnRlciBjb21taXR0aW5nIHRv
IHRoZSBkYXRhYmFzZSBlbnN1cmVzIHRoYXQgdGhlIGRhdGEgaXMK
</data>
<flag name="review"
          id="220016"
          type_id="1"
          status="+"
          setter="mitz"
    />
          </attachment>
      

    </bug>

</bugzilla>