114649 2013-04-15 16:38:55 -0700 Build fix: removing contextMenuProxy left over 2013-04-27 10:54:06 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other All RESOLVED DUPLICATE 114647 P2 Normal --- 0 savagobr webkit-unassigned commit-queue gyuyoung.kim lucas.de.marchi rakuco oldest_to_newest 876132 0 savagobr 2013-04-15 16:38:55 -0700 Current trunk build is broken: //------------------------------------------------------------------------------------------------ [ 85%] In file included from /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/WebPageProxy.h:32:0, from /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/DefaultUndoController.h:26, from /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/efl/WebView.h:31, from /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/EwkView.h:32, from /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/EwkView.cpp:22: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/DrawingAreaProxy.h:71:18: warning: unused parameter ‘timeout’ [-Wunused-parameter] /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/EwkView.cpp: In member function ‘void EwkView::showContextMenu(WKPoint, WKArrayRef)’: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/EwkView.cpp:812:8: error: ‘contextMenuProxy’ was not declared in this scope make[2]: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/UIProcess/API/efl/EwkView.cpp.o] Error 1 //------------------------------------------------------------------------------------------------ This regression probably was introduced with http://trac.webkit.org/changeset/148434, and wasn't noticed since ASSERTs are not compiled in Release mode. 876136 1 198202 savagobr 2013-04-15 16:42:22 -0700 Created attachment 198202 Remove faulty ASSERT 876143 2 savagobr 2013-04-15 16:50:21 -0700 Already fixed in #114647. *** This bug has been marked as a duplicate of bug 114647 *** 198202 2013-04-15 16:42:22 -0700 2013-04-27 10:54:06 -0700 Remove faulty ASSERT 0001-Fix.patch text/plain 1587 savagobr RnJvbSBiNTJlNGU5YmQwMDhkZTM4NmY5YTkwYzM0NDMwODhmNmM5ZThmODliIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVuaWxzb24gQ2F2YWxjYW50aSA8Y2F2YWxjYW50aWlAZ21h aWwuY29tPgpEYXRlOiBNb24sIDE1IEFwciAyMDEzIDE5OjQwOjQ4IC0wNDAwClN1YmplY3Q6IFtQ QVRDSF0gRml4LgoKU2lnbmVkLW9mZi1ieTogQWRlbmlsc29uIENhdmFsY2FudGkgPGNhdmFsY2Fu dGlpQGdtYWlsLmNvbT4KLS0tCiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgICAgICB8ICAgMTIgKysrKysrKysrKysrCiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC9Fd2tWaWV3LmNwcCB8ICAgIDIgLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9u cygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjkyZGY0My4uYjViYTdkNSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA0LTE1ICBBZGVuaWxzb24gQ2F2YWxjYW50 aSAgPGNhdmFsY2FudGlpQGdtYWlsLmNvbT4KKworICAgICAgICBCdWlsZCBmaXg6IHJlbW92aW5n IGNvbnRleHRNZW51UHJveHkgbGVmdCBvdmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ2NDkKKworICAgICAgICBSZW1vdmUgdW5uZWVkZWQgQVNT RVJUIChmaXggY29tcGlsYXRpb24gaW4gRGVidWcgbW9kZSkuCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3 LmNwcDoKKyAgICAgICAgKEV3a1ZpZXc6OnNob3dDb250ZXh0TWVudSk6CisKIDIwMTMtMDQtMTUg IEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgQWZ0ZXIgc3dpdGNo aW5nIHRvIGFub3RoZXIgc3BhY2UgYW5kIGJhY2ssIHZpZGVvIHJhY2VzIHRvIGNhdGNoIHVwIHdp dGggYXVkaW8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3 a1ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAK aW5kZXggMzE1YjJiOS4uZTkxNzE4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9lZmwvRXdrVmlldy5jcHAKQEAgLTgwOSw4ICs4MDksNiBAQCB2b2lkIEV3a1ZpZXc6OnNob3dD b250ZXh0TWVudShXS1BvaW50IHBvc2l0aW9uLCBXS0FycmF5UmVmIGl0ZW1zKQogICAgIEV3a19W aWV3X1NtYXJ0X0RhdGEqIHNkID0gc21hcnREYXRhKCk7CiAgICAgQVNTRVJUKHNkLT5hcGkpOwog Ci0gICAgQVNTRVJUKGNvbnRleHRNZW51UHJveHkpOwotCiAgICAgaWYgKCFzZC0+YXBpLT5jb250 ZXh0X21lbnVfc2hvdykKICAgICAgICAgcmV0dXJuOwogCi0tIAoxLjcuMTAuNAoK