114633 2013-04-15 13:24:14 -0700 [BlackBerry] Crash from null m_webSettings in WebPagePrivate 2013-04-15 14:05:45 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 lquinn lquinn commit-queue mifenton rwlbuis tonikitoo oldest_to_newest 876027 0 lquinn 2013-04-15 13:24:14 -0700 We've had a few reports of crashes from a null m_webSettings in WebPagePrivate. As a speculative fix suggested by George Staikos, we should move the initialization of m_webSettings to the top of the init() method. 876030 1 198177 lquinn 2013-04-15 13:33:04 -0700 Created attachment 198177 Patch 876031 2 198177 rwlbuis 2013-04-15 13:36:48 -0700 Comment on attachment 198177 Patch Can't hurt. 876054 3 198177 commit-queue 2013-04-15 14:05:43 -0700 Comment on attachment 198177 Patch Clearing flags on attachment: 198177 Committed r148466: <http://trac.webkit.org/changeset/148466> 876055 4 commit-queue 2013-04-15 14:05:45 -0700 All reviewed patches have been landed. Closing bug. 198177 2013-04-15 13:33:04 -0700 2013-04-15 14:05:43 -0700 Patch bug-114633-20130415162908.patch text/plain 2099 lquinn U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NDYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAxZTVjZDBjYTVkNWExNWIxNDBkZTBjZTBhODBjNmU3Y2Y3NGE4MWIyLi44NDY1MDcxZTZj YTg5NjYwYjIxY2E0YjVjYjFiZmJiZjEyMGNiNWY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMy0wNC0xNSAgTGlhbSBRdWlubiAgPGxxdWlubkBi bGFja2JlcnJ5LmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gQ3Jhc2ggZnJvbSBudWxsIG1f d2ViU2V0dGluZ3MgaW4gV2ViUGFnZVByaXZhdGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDYzMworICAgICAgICBSSU0gUFIgMzAzNzQ1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIEludGVybmFsbHkgcmV2 aWV3ZWQgYnkgTGVvIFlhbmcuCisKKyAgICAgICAgU3BlY3VsYXRpdmUgZml4IHN1Z2dlc3RlZCBi eSBHZW9yZ2UgU3RhaWtvcy0taW5pdGlhbGl6ZSBtX3dlYlNldHRpbmdzIGZpcnN0IHRoaW5nIGlu IHRoZSBpbml0KCkgbWV0aG9kLgorCisgICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgorICAgICAg ICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6aW5pdCk6CisKIDIwMTMtMDQt MTUgIEFuZHkgQ2hlbiAgPGFuZGNoZW5AYmxhY2tiZXJyeS5jb20+CiAKICAgICAgICAgW0JsYWNr QmVycnldIEZvcndhcmQgdXNlckdlc3R1cmUgd2hlbiBjcmVhdGluZyBhIG5ldyB3aW5kb3cKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IDNkOWU2ZTZjMTg5NmM3 NGE5N2Q4NzZhZjNkMTNmMWM4ZDU4OTJlNjIuLjFhOWEzODNjNWRkMjc1N2Q4NDkzMjU3YjBkNjQx YTQyNmEwOWFjMmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2Vi UGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApA QCAtNTEwLDYgKzUxMCw5IEBAIFBhZ2UqIFdlYlBhZ2VQcml2YXRlOjpjb3JlKGNvbnN0IFdlYlBh Z2UqIHdlYlBhZ2UpCiAKIHZvaWQgV2ViUGFnZVByaXZhdGU6OmluaXQoY29uc3QgQmxhY2tCZXJy eTo6UGxhdGZvcm06OlN0cmluZyYgcGFnZUdyb3VwTmFtZSkKIHsKKyAgICBtX3dlYlNldHRpbmdz ID0gV2ViU2V0dGluZ3M6OmNyZWF0ZUZyb21TdGFuZGFyZFNldHRpbmdzKCk7CisgICAgbV93ZWJT ZXR0aW5ncy0+c2V0VXNlckFnZW50U3RyaW5nKGRlZmF1bHRVc2VyQWdlbnQoKSk7CisKICAgICBD aHJvbWVDbGllbnRCbGFja0JlcnJ5KiBjaHJvbWVDbGllbnQgPSBuZXcgQ2hyb21lQ2xpZW50Qmxh Y2tCZXJyeSh0aGlzKTsKICNpZiBFTkFCTEUoQ09OVEVYVF9NRU5VUykKICAgICBDb250ZXh0TWVu dUNsaWVudEJsYWNrQmVycnkqIGNvbnRleHRNZW51Q2xpZW50ID0gMDsKQEAgLTU3OSw4ICs1ODIs NiBAQCB2b2lkIFdlYlBhZ2VQcml2YXRlOjppbml0KGNvbnN0IEJsYWNrQmVycnk6OlBsYXRmb3Jt OjpTdHJpbmcmIHBhZ2VHcm91cE5hbWUpCiAgICAgV2ViQ29yZTo6cHJvdmlkZU5ldHdvcmtJbmZv VG8obV9wYWdlLCBuZXcgV2ViQ29yZTo6TmV0d29ya0luZm9DbGllbnRCbGFja0JlcnJ5KHRoaXMp KTsKICNlbmRpZgogCi0gICAgbV93ZWJTZXR0aW5ncyA9IFdlYlNldHRpbmdzOjpjcmVhdGVGcm9t U3RhbmRhcmRTZXR0aW5ncygpOwotICAgIG1fd2ViU2V0dGluZ3MtPnNldFVzZXJBZ2VudFN0cmlu ZyhkZWZhdWx0VXNlckFnZW50KCkpOwogICAgIG1fcGFnZS0+c2V0RGV2aWNlU2NhbGVGYWN0b3Io bV93ZWJTZXR0aW5ncy0+ZGV2aWNlUGl4ZWxSYXRpbygpKTsKIAogICAgIG1fcGFnZS0+YWRkTGF5 b3V0TWlsZXN0b25lcyhEaWRGaXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlvdXQpOwo=