114628 2013-04-15 10:10:53 -0700 aria-valuetext is not exposed on OS X. 2013-04-16 10:51:18 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jcraig cfleizach aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig jdiggs thorton webkit-bug-importer oldest_to_newest 875883 0 jcraig 2013-04-15 10:10:53 -0700 WebKit has support for aria-valuetext, does not expose it on OS X. example test case https://dvcs.w3.org/hg/pfwg/raw-file/tip/ARIA/1.0/tests/test-files/host-language/input-range-valuetext.htm 875884 1 webkit-bug-importer 2013-04-15 10:11:29 -0700 <rdar://problem/13653594> 876187 2 cfleizach 2013-04-15 18:05:25 -0700 we return this as the AXValueDescription when appropriate (like sliders). where are you seeing this not work? 876589 3 198341 cfleizach 2013-04-16 10:08:57 -0700 Created attachment 198341 patch 876590 4 cfleizach 2013-04-16 10:09:20 -0700 Adding Tim to help with review 876602 5 198341 thorton 2013-04-16 10:29:21 -0700 Comment on attachment 198341 patch View in context: https://bugs.webkit.org/attachment.cgi?id=198341&action=review > Source/WebCore/ChangeLog:9 > + aria-valuetext is only being exposed on ARIA controls. We should allow it > + to work on native controls as well. One additional sentence about why it wasn't being exposed before would be nice (it's easy to see why by looking at the patch more closely, but the ChangeLog is supposed to help you around that!) > Source/WebCore/ChangeLog:15 > + (WebCore): Please clean this up/remove extraneous lines/etc. > LayoutTests/platform/mac/accessibility/aria-valuetext-on-native-slider.html:17 > + there's extra space here 876612 6 cfleizach 2013-04-16 10:51:18 -0700 http://trac.webkit.org/changeset/148522 198341 2013-04-16 10:08:57 -0700 2013-04-16 10:29:41 -0700 patch patch text/plain 7264 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0ODUxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDEzLTA0LTE2ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IGFyaWEtdmFsdWV0 ZXh0IGlzIG5vdCBleHBvc2VkIG9uIE9TIFguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ2MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBhcmlhLXZhbHVldGV4dCBpcyBvbmx5IGJlaW5nIGV4cG9zZWQg b24gQVJJQSBjb250cm9scy4gV2Ugc2hvdWxkIGFsbG93IGl0CisgICAgICAgIHRvIHdvcmsgb24g bmF0aXZlIGNvbnRyb2xzIGFzIHdlbGwuCisKKyAgICAgICAgVGVzdDogcGxhdGZvcm0vbWFjL2Fj Y2Vzc2liaWxpdHkvYXJpYS12YWx1ZXRleHQtb24tbmF0aXZlLXNsaWRlci5odG1sCisKKyAgICAg ICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlOb2RlT2JqZWN0LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlOb2RlT2JqZWN0Ojp2YWx1ZURlc2NyaXB0aW9uKToKKyAg ICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eU5vZGVPYmpl Y3Q6OnZhbHVlRm9yUmFuZ2UpOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eU5vZGVP YmplY3Q6Om1heFZhbHVlRm9yUmFuZ2UpOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0 eU5vZGVPYmplY3Q6Om1pblZhbHVlRm9yUmFuZ2UpOgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkv QWNjZXNzaWJpbGl0eU5vZGVPYmplY3QuaDoKKyAgICAgICAgKEFjY2Vzc2liaWxpdHlOb2RlT2Jq ZWN0KToKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwOgor ICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5T2JqZWN0 Ojppc1JhbmdlQ29udHJvbCk6CisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5 T2JqZWN0Lmg6CisgICAgICAgIChBY2Nlc3NpYmlsaXR5T2JqZWN0KToKKwogMjAxMy0wNC0xNiAg QW50aG9ueSBTY2lhbiAgPGFzY2lhbkBibGFja2JlcnJ5LmNvbT4KIAogICAgICAgICBbQmxhY2tC ZXJyeV0gTGF5ZXJUZXh0dXJlOiBjaGVjayBpZiB0aGUgZ3JhcGhpY3MgY29udGV4dCBpcyBOVUxM CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3Qu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxp dHlPYmplY3QuaAkocmV2aXNpb24gMTQ4NDgwKQorKysgU291cmNlL1dlYkNvcmUvYWNjZXNzaWJp bGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTQ0OCw3ICs0NDgs OCBAQAogICAgIGJvb2wgaXNCbG9ja3F1b3RlKCkgY29uc3Q7CiAgICAgYm9vbCBpc0xhbmRtYXJr KCkgY29uc3Q7CiAgICAgYm9vbCBpc0NvbG9yV2VsbCgpIGNvbnN0IHsgcmV0dXJuIHJvbGVWYWx1 ZSgpID09IENvbG9yV2VsbFJvbGU7IH0KLSAgICAKKyAgICBib29sIGlzUmFuZ2VDb250cm9sKCkg Y29uc3Q7CisKICAgICB2aXJ0dWFsIGJvb2wgaXNDaGVja2VkKCkgY29uc3QgeyByZXR1cm4gZmFs c2U7IH0KICAgICB2aXJ0dWFsIGJvb2wgaXNFbmFibGVkKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7 IH0KICAgICB2aXJ0dWFsIGJvb2wgaXNTZWxlY3RlZCgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9 CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlOb2RlT2Jq ZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3Np YmlsaXR5Tm9kZU9iamVjdC5oCShyZXZpc2lvbiAxNDg0ODApCisrKyBTb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlOb2RlT2JqZWN0LmgJKHdvcmtpbmcgY29weSkKQEAg LTE3Miw3ICsxNzIsNiBAQAogICAgIHZpcnR1YWwgYm9vbCBpc0Rlc2NlbmRhbnRPZkJhcnJlblBh cmVudCgpIGNvbnN0OwogICAgIHZvaWQgYWx0ZXJTbGlkZXJWYWx1ZShib29sIGluY3JlYXNlKTsK ICAgICB2b2lkIGNoYW5nZVZhbHVlQnlTdGVwKGJvb2wgaW5jcmVhc2UpOwotICAgIGJvb2wgaXNB UklBUmFuZ2UoKSBjb25zdDsKICAgICAvLyBUaGlzIHJldHVybnMgdHJ1ZSBpZiBpdCdzIGZvY3Vz YWJsZSBidXQgaXQncyBub3QgY29udGVudCBlZGl0YWJsZSBhbmQgaXQncyBub3QgYSBjb250cm9s IG9yIEFSSUEgY29udHJvbC4KICAgICBib29sIGlzR2VuZXJpY0ZvY3VzYWJsZUVsZW1lbnQoKSBj b25zdDsKICAgICBIVE1MTGFiZWxFbGVtZW50KiBsYWJlbEZvckVsZW1lbnQoRWxlbWVudCopIGNv bnN0OwpJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2Jq ZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vz c2liaWxpdHlPYmplY3QuY3BwCShyZXZpc2lvbiAxNDg0ODApCisrKyBTb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01 MjgsNiArNTI4LDE5IEBACiAgICAgcmV0dXJuIGlzQVJJQUlucHV0KGFyaWFSb2xlKSB8fCBhcmlh Um9sZSA9PSBUZXh0QXJlYVJvbGUgfHwgYXJpYVJvbGUgPT0gQnV0dG9uUm9sZSAKICAgICB8fCBh cmlhUm9sZSA9PSBDb21ib0JveFJvbGUgfHwgYXJpYVJvbGUgPT0gU2xpZGVyUm9sZTsgCiB9Cisg ICAgCitib29sIEFjY2Vzc2liaWxpdHlPYmplY3Q6OmlzUmFuZ2VDb250cm9sKCkgY29uc3QKK3sK KyAgICBzd2l0Y2ggKHJvbGVWYWx1ZSgpKSB7CisgICAgY2FzZSBQcm9ncmVzc0luZGljYXRvclJv bGU6CisgICAgY2FzZSBTbGlkZXJSb2xlOgorICAgIGNhc2UgU2Nyb2xsQmFyUm9sZToKKyAgICBj YXNlIFNwaW5CdXR0b25Sb2xlOgorICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICBkZWZhdWx0Ogor ICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQorfQogCiBJbnRQb2ludCBBY2Nlc3NpYmlsaXR5 T2JqZWN0OjpjbGlja1BvaW50KCkKIHsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxp dHkvQWNjZXNzaWJpbGl0eU5vZGVPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU5vZGVPYmplY3QuY3BwCShyZXZpc2lvbiAx NDg0ODApCisrKyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlOb2Rl T2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzQyLDI1ICs3NDIsMTIgQEAKIAogU3RyaW5n IEFjY2Vzc2liaWxpdHlOb2RlT2JqZWN0Ojp2YWx1ZURlc2NyaXB0aW9uKCkgY29uc3QKIHsKLSAg ICBpZiAoIWlzQVJJQVJhbmdlKCkpCisgICAgaWYgKCFpc1JhbmdlQ29udHJvbCgpKQogICAgICAg ICByZXR1cm4gU3RyaW5nKCk7CiAKICAgICByZXR1cm4gZ2V0QXR0cmlidXRlKGFyaWFfdmFsdWV0 ZXh0QXR0cikuc3RyaW5nKCk7CiB9CiAKLWJvb2wgQWNjZXNzaWJpbGl0eU5vZGVPYmplY3Q6Omlz QVJJQVJhbmdlKCkgY29uc3QKLXsKLSAgICBzd2l0Y2ggKG1fYXJpYVJvbGUpIHsKLSAgICBjYXNl IFByb2dyZXNzSW5kaWNhdG9yUm9sZToKLSAgICBjYXNlIFNsaWRlclJvbGU6Ci0gICAgY2FzZSBT Y3JvbGxCYXJSb2xlOgotICAgIGNhc2UgU3BpbkJ1dHRvblJvbGU6Ci0gICAgICAgIHJldHVybiB0 cnVlOwotICAgIGRlZmF1bHQ6Ci0gICAgICAgIHJldHVybiBmYWxzZTsKLSAgICB9Ci19Ci0KIGZs b2F0IEFjY2Vzc2liaWxpdHlOb2RlT2JqZWN0Ojp2YWx1ZUZvclJhbmdlKCkgY29uc3QKIHsKICAg ICBpZiAobm9kZSgpICYmIG5vZGUoKS0+aGFzVGFnTmFtZShpbnB1dFRhZykpIHsKQEAgLTc2OSw3 ICs3NTYsNyBAQAogICAgICAgICAgICAgcmV0dXJuIGlucHV0LT52YWx1ZUFzTnVtYmVyKCk7CiAg ICAgfQogCi0gICAgaWYgKCFpc0FSSUFSYW5nZSgpKQorICAgIGlmICghaXNSYW5nZUNvbnRyb2wo KSkKICAgICAgICAgcmV0dXJuIDAuMGY7CiAKICAgICByZXR1cm4gZ2V0QXR0cmlidXRlKGFyaWFf dmFsdWVub3dBdHRyKS50b0Zsb2F0KCk7CkBAIC03ODMsNyArNzcwLDcgQEAKICAgICAgICAgICAg IHJldHVybiBpbnB1dC0+bWF4aW11bSgpOwogICAgIH0KIAotICAgIGlmICghaXNBUklBUmFuZ2Uo KSkKKyAgICBpZiAoIWlzUmFuZ2VDb250cm9sKCkpCiAgICAgICAgIHJldHVybiAwLjBmOwogCiAg ICAgcmV0dXJuIGdldEF0dHJpYnV0ZShhcmlhX3ZhbHVlbWF4QXR0cikudG9GbG9hdCgpOwpAQCAt Nzk3LDcgKzc4NCw3IEBACiAgICAgICAgICAgICByZXR1cm4gaW5wdXQtPm1pbmltdW0oKTsKICAg ICB9CiAKLSAgICBpZiAoIWlzQVJJQVJhbmdlKCkpCisgICAgaWYgKCFpc1JhbmdlQ29udHJvbCgp KQogICAgICAgICByZXR1cm4gMC4wZjsKIAogICAgIHJldHVybiBnZXRBdHRyaWJ1dGUoYXJpYV92 YWx1ZW1pbkF0dHIpLnRvRmxvYXQoKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0ODUxNykKKysrIExh eW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEz LTA0LTE2ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAg QVg6IGFyaWEtdmFsdWV0ZXh0IGlzIG5vdCBleHBvc2VkIG9uIE9TIFguCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ2MjgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9hY2Nlc3Np YmlsaXR5L2FyaWEtdmFsdWV0ZXh0LW9uLW5hdGl2ZS1zbGlkZXItZXhwZWN0ZWQudHh0OiBBZGRl ZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9hcmlhLXZhbHVldGV4dC1v bi1uYXRpdmUtc2xpZGVyLmh0bWw6IEFkZGVkLgorCiAyMDEzLTA0LTE2ICBQYW4gRGVuZyAgPHBh bi5kZW5nQGludGVsLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBbTmV0d29ya10gQ292 ZXIgdGhlIHR5cGUgb2YgcHJlZmxpZ2h0IHhoci4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3Jt L21hYy9hY2Nlc3NpYmlsaXR5L2FyaWEtdmFsdWV0ZXh0LW9uLW5hdGl2ZS1zbGlkZXItZXhwZWN0 ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmls aXR5L2FyaWEtdmFsdWV0ZXh0LW9uLW5hdGl2ZS1zbGlkZXItZXhwZWN0ZWQudHh0CShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS12YWx1 ZXRleHQtb24tbmF0aXZlLXNsaWRlci1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsMTEgQEAKKworVGhpcyB0ZXN0cyB0aGF0IGFyaWEtdmFsdWV0ZXh0IGNhbiBiZSB1c2VkIG9u IG5hdGl2ZSBlbGVtZW50cywgbGlrZSBpbnB1dD1yYW5nZQorCitPbiBzdWNjZXNzLCB5b3Ugd2ls bCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01Q TEVURSIuCisKKworUEFTUyByYW5nZS52YWx1ZURlc2NyaXB0aW9uIGlzICdoZWxsbycKK1BBU1Mg c3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9hcmlhLXZhbHVldGV4dC1vbi1uYXRp dmUtc2xpZGVyLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Fj Y2Vzc2liaWxpdHkvYXJpYS12YWx1ZXRleHQtb24tbmF0aXZlLXNsaWRlci5odG1sCShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS12YWx1 ZXRleHQtb24tbmF0aXZlLXNsaWRlci5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI2IEBA Cis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4K KzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3Qt cHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IGlkPSJib2R5Ij4KKworPGlucHV0IHR5 cGU9InJhbmdlIiBhcmlhLXZhbHVldGV4dD0iaGVsbG8iIGlkPSJyYW5nZSI+CisKKzxkaXYgaWQ9 ImNvbnNvbGUiPjwvZGl2PgorCis8c2NyaXB0PgorCisgICAgZGVzY3JpcHRpb24oIlRoaXMgdGVz dHMgdGhhdCBhcmlhLXZhbHVldGV4dCBjYW4gYmUgdXNlZCBvbiBuYXRpdmUgZWxlbWVudHMsIGxp a2UgaW5wdXQ9cmFuZ2UiKTsKKworICAgIGlmICh3aW5kb3cuYWNjZXNzaWJpbGl0eUNvbnRyb2xs ZXIpIHsKKworICAgICAgICAgIHZhciByYW5nZSA9IGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmFj Y2Vzc2libGVFbGVtZW50QnlJZCgicmFuZ2UiKTsKKyAgICAgICAgICBzaG91bGRCZSgicmFuZ2Uu dmFsdWVEZXNjcmlwdGlvbiIsICInaGVsbG8nIik7CisgICAgfQorCis8L3NjcmlwdD4KKworPHNj cmlwdCBzcmM9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9z Y3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==