114622 2013-04-15 06:46:14 -0700 [BlackBerry] Forward userGesture when creating a new window 2013-04-15 11:01:37 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 andchen webkit-unassigned commit-queue mifenton rwlbuis tonikitoo oldest_to_newest 875762 0 andchen 2013-04-15 06:46:14 -0700 This info is needed for client to decide whether the popup should be blocked. 875882 1 198132 andchen 2013-04-15 10:10:12 -0700 Created attachment 198132 Patch 875891 2 198132 rwlbuis 2013-04-15 10:32:53 -0700 Comment on attachment 198132 Patch LGTM. 875907 3 198132 commit-queue 2013-04-15 11:01:34 -0700 Comment on attachment 198132 Patch Clearing flags on attachment: 198132 Committed r148451: <http://trac.webkit.org/changeset/148451> 875908 4 commit-queue 2013-04-15 11:01:37 -0700 All reviewed patches have been landed. Closing bug. 198132 2013-04-15 10:10:12 -0700 2013-04-15 11:01:34 -0700 Patch bug-114622-20130415130946.patch text/plain 4281 andchen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NDM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA5OWRiNWI0YzllNWYxNDgxMjlmYWQyZGZlNzM2M2E4NzczMDNlMDhhLi40NmU4NzU2NzVj NmZkNDQxZGE3MjMwYWY1NjdkNzljZjE4M2QxMTI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMy0wNC0xNSAgQW5keSBDaGVuICA8YW5kY2hlbkBi bGFja2JlcnJ5LmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gRm9yd2FyZCB1c2VyR2VzdHVy ZSB3aGVuIGNyZWF0aW5nIGEgbmV3IHdpbmRvdworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0NjIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ2xpZW50IGNvdWxkIHVzZSB0aGlzIGluZm8gdG8gZGVjaWRl IHdoZXRoZXIgdGhlIHBvcHVwIHNob3VsZAorICAgICAgICBiZSBibG9ja2VkLgorICAgICAgICBQ UiAyOTE4OTgKKyAgICAgICAgUmV2aWV3ZWQgaW50ZXJuYWxseSBieSBNaWtlIEZlbnRvbgorCisg ICAgICAgICogQXBpL1dlYlBhZ2VDbGllbnQuaDoKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9D aHJvbWVDbGllbnRCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNocm9tZUNsaWVu dEJsYWNrQmVycnk6OmNyZWF0ZVdpbmRvdyk6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRnJh bWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9h ZGVyQ2xpZW50QmxhY2tCZXJyeTo6ZGlzcGF0Y2hDcmVhdGVQYWdlKToKKwogMjAxMy0wNC0xNSAg WGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEFT U0VSVCBpbiBTdHlsZVJlc29sdmVyOjplbnN1cmVTY29wZVJlc29sdmVyKCkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNsaWVudC5oIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlQ2xpZW50LmgKaW5kZXggZTk0YjFmNTJlMDU2MDYx NDI1NmI3ZDE2NDEyZjUyNDYzMDg4ZjNlOS4uYjViOWMxOGNlOGMxODQ5YWUxNGZkYzkyMDM0YzNh MzJiOWY0YjQyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQ YWdlQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlQ2xp ZW50LmgKQEAgLTE3MSw3ICsxNzEsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIG9wZW5Q b3B1cExpc3QoYm9vbCBtdWx0aXBsZSwgaW50IHNpemUsIGNvbnN0IFNjb3BlQXJyYXk8QmxhY2tC ZXJyeTo6UGxhdGZvcm06OlN0cmluZz4mIGxhYmVscywgY29uc3QgYm9vbCogZW5hYmxlZHMsIGNv bnN0IGludCogaXRlbVR5cGUsIGNvbnN0IGJvb2wqIHNlbGVjdGVkcykgPSAwOwogICAgIHZpcnR1 YWwgYm9vbCBjaG9vc2VGaWxlbmFtZXMoYm9vbCBhbGxvd011bHRpcGxlLCBjb25zdCBTaGFyZWRB cnJheTxCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6U3RyaW5nPiYgYWNjZXB0VHlwZXMsIGNvbnN0IFNo YXJlZEFycmF5PEJsYWNrQmVycnk6OlBsYXRmb3JtOjpTdHJpbmc+JiBpbml0aWFsRmlsZXMsIGNv bnN0IEJsYWNrQmVycnk6OlBsYXRmb3JtOjpTdHJpbmcmIGNhcHR1cmUsIFNoYXJlZEFycmF5PEJs YWNrQmVycnk6OlBsYXRmb3JtOjpTdHJpbmc+JiBjaG9zZW5GaWxlcykgPSAwOwogCi0gICAgdmly dHVhbCBXZWJQYWdlKiBjcmVhdGVXaW5kb3coaW50IHgsIGludCB5LCBpbnQgd2lkdGgsIGludCBo ZWlnaHQsIHVuc2lnbmVkIGZsYWdzLCBjb25zdCBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6U3RyaW5n JiB1cmwsIGNvbnN0IEJsYWNrQmVycnk6OlBsYXRmb3JtOjpTdHJpbmcmIHdpbmRvd05hbWUpID0g MDsKKyAgICB2aXJ0dWFsIFdlYlBhZ2UqIGNyZWF0ZVdpbmRvdyhpbnQgeCwgaW50IHksIGludCB3 aWR0aCwgaW50IGhlaWdodCwgdW5zaWduZWQgZmxhZ3MsIGNvbnN0IEJsYWNrQmVycnk6OlBsYXRm b3JtOjpTdHJpbmcmIHVybCwgY29uc3QgQmxhY2tCZXJyeTo6UGxhdGZvcm06OlN0cmluZyYgd2lu ZG93TmFtZSwgYm9vbCB1c2VyR2VzdHVyZSkgPSAwOwogCiAgICAgdmlydHVhbCB2b2lkIHNjaGVk dWxlQ2xvc2VXaW5kb3coKSA9IDA7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRCbGFja0JlcnJ5LmNw cAppbmRleCBlZDQxMTZhMWFiODBiZDJmMjZhNzkzM2EzNTBjYTQ1ODU3N2FlMDkyLi5kODFmZjI1 YjgxZjEwZjY3MzRjM2UwMTU0ZTdkYjAxNjg1MTljODc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50QmxhY2tCZXJyeS5jcHAK KysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVu dEJsYWNrQmVycnkuY3BwCkBAIC0yNjAsNyArMjYwLDcgQEAgUGFnZSogQ2hyb21lQ2xpZW50Qmxh Y2tCZXJyeTo6Y3JlYXRlV2luZG93KEZyYW1lKiBmcmFtZSwgY29uc3QgRnJhbWVMb2FkUmVxdWVz dCYKICAgICBpZiAoZmVhdHVyZXMuZGlhbG9nKQogICAgICAgICBmbGFncyB8PSBXZWJQYWdlQ2xp ZW50OjpGbGFnV2luZG93SXNEaWFsb2c7CiAKLSAgICBXZWJQYWdlKiB3ZWJQYWdlID0gbV93ZWJQ YWdlUHJpdmF0ZS0+bV9jbGllbnQtPmNyZWF0ZVdpbmRvdyh4LCB5LCB3aWR0aCwgaGVpZ2h0LCBm bGFncywgdXJsLnN0cmluZygpLCByZXF1ZXN0LmZyYW1lTmFtZSgpKTsKKyAgICBXZWJQYWdlKiB3 ZWJQYWdlID0gbV93ZWJQYWdlUHJpdmF0ZS0+bV9jbGllbnQtPmNyZWF0ZVdpbmRvdyh4LCB5LCB3 aWR0aCwgaGVpZ2h0LCBmbGFncywgdXJsLnN0cmluZygpLCByZXF1ZXN0LmZyYW1lTmFtZSgpLCBT Y3JpcHRDb250cm9sbGVyOjpwcm9jZXNzaW5nVXNlckdlc3R1cmUoKSk7CiAgICAgaWYgKCF3ZWJQ YWdlKQogICAgICAgICByZXR1cm4gMDsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAgYi9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRC bGFja0JlcnJ5LmNwcAppbmRleCAxZWYzZTE4YjE3M2IyYWM0MDg0OTQ1ODA5MmM5ZmFjNzBiOGNj YmZiLi5hYjUyMjk3N2UxZGM2NjFmMjhlZDY1N2NlM2JmMDlkZjQ4YWI5M2FhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGll bnRCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1 cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5LmNwcApAQCAtOTM2LDcgKzkzNiw3IEBA IGJvb2wgRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5OjpzaG91bGRTdG9wTG9hZGluZ0Zvckhp c3RvcnlJdGVtKEhpc3RvcnlJdGVtKikKIAogRnJhbWUqIEZyYW1lTG9hZGVyQ2xpZW50QmxhY2tC ZXJyeTo6ZGlzcGF0Y2hDcmVhdGVQYWdlKGNvbnN0IE5hdmlnYXRpb25BY3Rpb24mIG5hdmlnYXRp b24pCiB7Ci0gICAgV2ViUGFnZSogd2ViUGFnZSA9IG1fd2ViUGFnZVByaXZhdGUtPm1fY2xpZW50 LT5jcmVhdGVXaW5kb3coMCwgMCwgLTEsIC0xLCBXZWJQYWdlQ2xpZW50OjpGbGFnV2luZG93RGVm YXVsdCwgbmF2aWdhdGlvbi51cmwoKS5zdHJpbmcoKSwgQmxhY2tCZXJyeTo6UGxhdGZvcm06OlN0 cmluZzo6ZW1wdHlTdHJpbmcoKSk7CisgICAgV2ViUGFnZSogd2ViUGFnZSA9IG1fd2ViUGFnZVBy aXZhdGUtPm1fY2xpZW50LT5jcmVhdGVXaW5kb3coMCwgMCwgLTEsIC0xLCBXZWJQYWdlQ2xpZW50 OjpGbGFnV2luZG93RGVmYXVsdCwgbmF2aWdhdGlvbi51cmwoKS5zdHJpbmcoKSwgQmxhY2tCZXJy eTo6UGxhdGZvcm06OlN0cmluZzo6ZW1wdHlTdHJpbmcoKSwgU2NyaXB0Q29udHJvbGxlcjo6cHJv Y2Vzc2luZ1VzZXJHZXN0dXJlKCkpOwogICAgIGlmICghd2ViUGFnZSkKICAgICAgICAgcmV0dXJu IDA7CiAK