114620 2013-04-15 05:34:34 -0700 win_cmd_shell detection doesn't work under MSYS 2013-04-16 15:34:22 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 net147 webkit-unassigned abecsi commit-queue hausmann jturcotte vestbo oldest_to_newest 875726 0 net147 2013-04-15 05:34:34 -0700 Tools/qmake/mkspecs/features/default_pre.prf tries to detect if running under Windows cmd.exe. This detect works for cmd.exe and Cygwin shell but fails for MSYS. The detection simplified and improved to also detect MSYS properly: win32:isEmpty(QMAKE_SH): CONFIG += win_cmd_shell 875728 1 198116 net147 2013-04-15 05:38:17 -0700 Created attachment 198116 Patch 875730 2 198116 jturcotte 2013-04-15 05:46:44 -0700 Comment on attachment 198116 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198116&action=review > Tools/qmake/mkspecs/features/default_pre.prf:40 > +win32:isEmpty(QMAKE_SH): CONFIG += win_cmd_shell As far as I know you can have sh.exe in your PATH even in cmd.exe, which this would break. Maybe this changed but I've spent a lot of hours trying to tweak project files back and forth like this to make sure that QtWebKit could build in both MSYS and cmd.exe to the end concluding that it's just not worth it. Unless you want to commit to maintain this code yourself I would prefer that we stick to only supporting cmd.exe to have one well supported environment on Windows instead of two crappy ones. 875732 3 198117 net147 2013-04-15 05:59:36 -0700 Created attachment 198117 Patch 875734 4 commit-queue 2013-04-15 06:01:17 -0700 Attachment 198117 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/qmake/mkspecs/features/default_pre.prf']" exit_code: 1 Tools/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 875735 5 198118 net147 2013-04-15 06:02:19 -0700 Created attachment 198118 Patch 875736 6 net147 2013-04-15 06:05:10 -0700 (In reply to comment #2) > (From update of attachment 198116 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=198116&action=review > > > Tools/qmake/mkspecs/features/default_pre.prf:40 > > +win32:isEmpty(QMAKE_SH): CONFIG += win_cmd_shell > > As far as I know you can have sh.exe in your PATH even in cmd.exe, which this would break. If you have sh.exe in your PATH, mingw32-make will use sh.exe instead of cmd.exe anyway so the commands in the Makefile generated should be UNIX shell commands. 875743 7 198118 jturcotte 2013-04-15 06:16:29 -0700 Comment on attachment 198118 Patch I'm still not enthousiastic about supporting building in MSYS but this does make things more robust on both sides, so r=me :) 875776 8 198118 commit-queue 2013-04-15 07:00:52 -0700 Comment on attachment 198118 Patch Clearing flags on attachment: 198118 Committed r148435: <http://trac.webkit.org/changeset/148435> 875777 9 commit-queue 2013-04-15 07:00:56 -0700 All reviewed patches have been landed. Closing bug. 198116 2013-04-15 05:38:17 -0700 2013-04-15 05:59:31 -0700 Patch bug-114620-20130415224919.patch text/plain 1520 net147 U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4MzgxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTc0YWQ1MDdhMGY3NjA5NWIzMTJlYmE3ZTA0YTg3NzEz MGI3NzY5OS4uNTY1OTJlMjczMTQ2OTE3Yjc1NWNmMDAyMzk1ZDJiMmM2MmY0MmU1ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEzLTA0LTE1ICBKb25hdGhhbiBMaXUgIDxuZXQxNDdAZ21haWwuY29tPgorCisgICAg ICAgIEltcHJvdmUgV2luZG93cyBjbWQuZXhlIGRldGVjdGlvbgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0NjIwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGN1cnJlbnQgZGV0ZWN0aW9uIGNvZGUg aGFuZGxlcyBXaW5kb3dzIGNtZC5leGUgYW5kIEN5Z3dpbiBzaGVsbAorICAgICAgICBidXQgbm90 IGRvZXMgbm90IGhhbmRsZSBNU1lTIHNoZWxsIGNvcnJlY3RseS4gU2ltcGxpZnkgYW5kIGltcHJv dmUgdGhlCisgICAgICAgIGRldGVjdGlvbiBieSBjaGVja2luZyBRTUFLRV9TSCBpbnN0ZWFkLgor CisgICAgICAgICogcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9kZWZhdWx0X3ByZS5wcmY6CisKIDIw MTMtMDQtMTMgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQnVp bGQgZml4IGF0dGVtcHQgZm9yIHdlYmtpdGJvdC4gVW5pY29kaWZ5IGV2ZXJ5dGhpbmcuCmRpZmYg LS1naXQgYS9Ub29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2RlZmF1bHRfcHJlLnByZiBiL1Rv b2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZGVmYXVsdF9wcmUucHJmCmluZGV4IDViYWU3ZGNl MzRkNmFiZWI3YTIyNDQxMGUzNjlhMDg3NGVlYzNhZGUuLjJmZTExOWZhYWY0ZTQxNjE0NTAyYzFh YjNlZTc5ZGIyOTcyYWMyNTUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVy ZXMvZGVmYXVsdF9wcmUucHJmCisrKyBiL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZGVm YXVsdF9wcmUucHJmCkBAIC0zNywxMSArMzcsNyBAQCBlcXVhbHMoT1VUX1BXRCwgJCR7Uk9PVF9C VUlMRF9ESVJ9KSB7CiB9CiAKICMgVHJ5IHRvIGRldGVjdCBpZiB3ZSdyZSBydW5uaW5nIHVuZGVy IFdpbmRvd3MgY21kLmV4ZSBvciBub3QKLXdpbjMyKiB7Ci0gICAgcHdkID0gJCQoUFdEKSAjIE5v cm1hbGx5IGVtcHR5IGZvciBjbWQuZXhlCi0gICAgcHdkX3N0YXJ0c193aXRoX3NsYXNoID0gJCRm aW5kKHB3ZCwgXi8pCi0gICAgaXNFbXB0eShwd2Rfc3RhcnRzX3dpdGhfc2xhc2gpOiBDT05GSUcg Kz0gd2luX2NtZF9zaGVsbAotfQord2luMzI6aXNFbXB0eShRTUFLRV9TSCk6IENPTkZJRyArPSB3 aW5fY21kX3NoZWxsCiAKICMgRGVmYXVsdCBsb2NhdGlvbiBvZiBnZW5lcmF0ZWQgc291cmNlcwog R0VORVJBVEVEX1NPVVJDRVNfREVTVERJUiA9IGdlbmVyYXRlZAo= 198117 2013-04-15 05:59:36 -0700 2013-04-15 06:02:13 -0700 Patch bug-114620-20130415231038.patch text/plain 1582 net147 U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4MzgxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTc0YWQ1MDdhMGY3NjA5NWIzMTJlYmE3ZTA0YTg3NzEz MGI3NzY5OS4uMzhjZjVhZGY3YmNmNmZmMWVlMGEyOTllODhiZDg1NWM5MTUzNDNhZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEzLTA0LTE1ICBKb25hdGhhbiBMaXUgIDxuZXQxNDdAZ21haWwuY29tPgorCisgICAg ICAgIEltcHJvdmUgV2luZG93cyBjbWQuZXhlIGRldGVjdGlvbgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0NjIwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGN1cnJlbnQgZGV0ZWN0aW9uIGNvZGUg aGFuZGxlcyBXaW5kb3dzIGNtZC5leGUgYW5kIEN5Z3dpbiBzaGVsbAorICAgICAgICBidXQgbm90 IGRvZXMgbm90IGhhbmRsZSBNU1lTIHNoZWxsIGNvcnJlY3RseS4gU2ltcGxpZnkgYW5kIGltcHJv dmUgdGhlCisgICAgICAgIGRldGVjdGlvbiBieSBjaGVja2luZyBNSU5HV19JTl9TSEVMTCBpbnN0 ZWFkIGFzIHVzZWQgaW4gb3RoZXIgcGxhY2VzCisJKGUuZy4gcXRfZnVuY3Rpb25zLnByZikuCisK KyAgICAgICAgKiBxbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2RlZmF1bHRfcHJlLnByZjoKKwogMjAx My0wNC0xMyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBCdWls ZCBmaXggYXR0ZW1wdCBmb3Igd2Via2l0Ym90LiBVbmljb2RpZnkgZXZlcnl0aGluZy4KZGlmZiAt LWdpdCBhL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZGVmYXVsdF9wcmUucHJmIGIvVG9v bHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9kZWZhdWx0X3ByZS5wcmYKaW5kZXggNWJhZTdkY2Uz NGQ2YWJlYjdhMjI0NDEwZTM2OWEwODc0ZWVjM2FkZS4uNGM5MzZmNTMwNjk5YTYxYWE3MTM3M2Jj MGE1NmY5ZmRlZWFmMDcyOSAxMDA2NDQKLS0tIGEvVG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJl cy9kZWZhdWx0X3ByZS5wcmYKKysrIGIvVG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9kZWZh dWx0X3ByZS5wcmYKQEAgLTM3LDExICszNyw3IEBAIGVxdWFscyhPVVRfUFdELCAkJHtST09UX0JV SUxEX0RJUn0pIHsKIH0KIAogIyBUcnkgdG8gZGV0ZWN0IGlmIHdlJ3JlIHJ1bm5pbmcgdW5kZXIg V2luZG93cyBjbWQuZXhlIG9yIG5vdAotd2luMzIqIHsKLSAgICBwd2QgPSAkJChQV0QpICMgTm9y bWFsbHkgZW1wdHkgZm9yIGNtZC5leGUKLSAgICBwd2Rfc3RhcnRzX3dpdGhfc2xhc2ggPSAkJGZp bmQocHdkLCBeLykKLSAgICBpc0VtcHR5KHB3ZF9zdGFydHNfd2l0aF9zbGFzaCk6IENPTkZJRyAr PSB3aW5fY21kX3NoZWxsCi19Cit3aW4zMjppc0VtcHR5KE1JTkdXX0lOX1NIRUxMKTogQ09ORklH ICs9IHdpbl9jbWRfc2hlbGwKIAogIyBEZWZhdWx0IGxvY2F0aW9uIG9mIGdlbmVyYXRlZCBzb3Vy Y2VzCiBHRU5FUkFURURfU09VUkNFU19ERVNURElSID0gZ2VuZXJhdGVkCg== 198118 2013-04-15 06:02:19 -0700 2013-04-15 07:00:52 -0700 Patch bug-114620-20130415231321.patch text/plain 1589 net147 U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4MzgxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTc0YWQ1MDdhMGY3NjA5NWIzMTJlYmE3ZTA0YTg3NzEz MGI3NzY5OS4uNGNkMjMxNTIzNTdjODQ1OTY0MjRiOTdlMjkwZjE5OTFmN2RhYjg4ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEzLTA0LTE1ICBKb25hdGhhbiBMaXUgIDxuZXQxNDdAZ21haWwuY29tPgorCisgICAg ICAgIEltcHJvdmUgV2luZG93cyBjbWQuZXhlIGRldGVjdGlvbgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0NjIwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGN1cnJlbnQgZGV0ZWN0aW9uIGNvZGUg aGFuZGxlcyBXaW5kb3dzIGNtZC5leGUgYW5kIEN5Z3dpbiBzaGVsbAorICAgICAgICBidXQgbm90 IGRvZXMgbm90IGhhbmRsZSBNU1lTIHNoZWxsIGNvcnJlY3RseS4gU2ltcGxpZnkgYW5kIGltcHJv dmUgdGhlCisgICAgICAgIGRldGVjdGlvbiBieSBjaGVja2luZyBNSU5HV19JTl9TSEVMTCBpbnN0 ZWFkIGFzIHVzZWQgaW4gb3RoZXIgcGxhY2VzCisgICAgICAgIChlLmcuIHF0X2Z1bmN0aW9ucy5w cmYpLgorCisgICAgICAgICogcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9kZWZhdWx0X3ByZS5wcmY6 CisKIDIwMTMtMDQtMTMgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgQnVpbGQgZml4IGF0dGVtcHQgZm9yIHdlYmtpdGJvdC4gVW5pY29kaWZ5IGV2ZXJ5dGhpbmcu CmRpZmYgLS1naXQgYS9Ub29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2RlZmF1bHRfcHJlLnBy ZiBiL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZGVmYXVsdF9wcmUucHJmCmluZGV4IDVi YWU3ZGNlMzRkNmFiZWI3YTIyNDQxMGUzNjlhMDg3NGVlYzNhZGUuLjRjOTM2ZjUzMDY5OWE2MWFh NzEzNzNiYzBhNTZmOWZkZWVhZjA3MjkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL3FtYWtlL21rc3BlY3Mv ZmVhdHVyZXMvZGVmYXVsdF9wcmUucHJmCisrKyBiL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVy ZXMvZGVmYXVsdF9wcmUucHJmCkBAIC0zNywxMSArMzcsNyBAQCBlcXVhbHMoT1VUX1BXRCwgJCR7 Uk9PVF9CVUlMRF9ESVJ9KSB7CiB9CiAKICMgVHJ5IHRvIGRldGVjdCBpZiB3ZSdyZSBydW5uaW5n IHVuZGVyIFdpbmRvd3MgY21kLmV4ZSBvciBub3QKLXdpbjMyKiB7Ci0gICAgcHdkID0gJCQoUFdE KSAjIE5vcm1hbGx5IGVtcHR5IGZvciBjbWQuZXhlCi0gICAgcHdkX3N0YXJ0c193aXRoX3NsYXNo ID0gJCRmaW5kKHB3ZCwgXi8pCi0gICAgaXNFbXB0eShwd2Rfc3RhcnRzX3dpdGhfc2xhc2gpOiBD T05GSUcgKz0gd2luX2NtZF9zaGVsbAotfQord2luMzI6aXNFbXB0eShNSU5HV19JTl9TSEVMTCk6 IENPTkZJRyArPSB3aW5fY21kX3NoZWxsCiAKICMgRGVmYXVsdCBsb2NhdGlvbiBvZiBnZW5lcmF0 ZWQgc291cmNlcwogR0VORVJBVEVEX1NPVVJDRVNfREVTVERJUiA9IGdlbmVyYXRlZAo=